Re: [PATCH v3 5/5] mips/kvm: Fix ABI by moving manipulation of CP0 registers to KVM_{G,S}ET_MSRS

2013-05-21 Thread David Daney
On 05/21/2013 09:28 AM, Gleb Natapov wrote: On Tue, May 21, 2013 at 09:21:06AM -0700, David Daney wrote: On 05/21/2013 08:37 AM, Gleb Natapov wrote: On Mon, May 20, 2013 at 02:01:26PM -0700, David Daney wrote: From: David Daney Because not all 256 CP0 registers are ever implemented, we need

Re: [PATCH v3 5/5] mips/kvm: Fix ABI by moving manipulation of CP0 registers to KVM_{G,S}ET_MSRS

2013-05-21 Thread Gleb Natapov
On Tue, May 21, 2013 at 09:21:06AM -0700, David Daney wrote: > On 05/21/2013 08:37 AM, Gleb Natapov wrote: > >On Mon, May 20, 2013 at 02:01:26PM -0700, David Daney wrote: > >>From: David Daney > >> > >>Because not all 256 CP0 registers are ever implemented, we need a > >>different method of manipu

Re: [PATCH v3 5/5] mips/kvm: Fix ABI by moving manipulation of CP0 registers to KVM_{G,S}ET_MSRS

2013-05-21 Thread David Daney
On 05/21/2013 08:37 AM, Gleb Natapov wrote: On Mon, May 20, 2013 at 02:01:26PM -0700, David Daney wrote: From: David Daney Because not all 256 CP0 registers are ever implemented, we need a different method of manipulating them. Use the KVM_GET_MSRS/KVM_SET_MSRS mechanism as x86 does for its M

Re: [PATCH v3 5/5] mips/kvm: Fix ABI by moving manipulation of CP0 registers to KVM_{G,S}ET_MSRS

2013-05-21 Thread Gleb Natapov
On Mon, May 20, 2013 at 02:01:26PM -0700, David Daney wrote: > From: David Daney > > Because not all 256 CP0 registers are ever implemented, we need a > different method of manipulating them. Use the > KVM_GET_MSRS/KVM_SET_MSRS mechanism as x86 does for its MSRs. > Have you looked at KVM_(GET|S

[PATCH v3 5/5] mips/kvm: Fix ABI by moving manipulation of CP0 registers to KVM_{G,S}ET_MSRS

2013-05-20 Thread David Daney
From: David Daney Because not all 256 CP0 registers are ever implemented, we need a different method of manipulating them. Use the KVM_GET_MSRS/KVM_SET_MSRS mechanism as x86 does for its MSRs. Code related to implementing KVM_GET_MSRS/KVM_SET_MSRS is consolidated in to kvm_trap_emul.c, now unus