Re: [PATCH v4: kvm 1/4] Code motion. Separate timer intialization into an indepedent function.

2009-09-30 Thread Zachary Amsden
On 09/30/2009 06:11 AM, Avi Kivity wrote: On 09/30/2009 06:06 PM, Zachary Amsden wrote: On 09/30/2009 05:56 AM, Avi Kivity wrote: On 09/30/2009 05:51 PM, Zachary Amsden wrote: If the API allows us to query the tsc frequency, it would simply return the same values in all cases, which we'd igno

Re: [PATCH v4: kvm 1/4] Code motion. Separate timer intialization into an indepedent function.

2009-09-30 Thread Avi Kivity
On 09/30/2009 06:06 PM, Zachary Amsden wrote: On 09/30/2009 05:56 AM, Avi Kivity wrote: On 09/30/2009 05:51 PM, Zachary Amsden wrote: If the API allows us to query the tsc frequency, it would simply return the same values in all cases, which we'd ignore. The API only allows querying the proc

Re: [PATCH v4: kvm 1/4] Code motion. Separate timer intialization into an indepedent function.

2009-09-30 Thread Zachary Amsden
On 09/30/2009 05:56 AM, Avi Kivity wrote: On 09/30/2009 05:51 PM, Zachary Amsden wrote: If the API allows us to query the tsc frequency, it would simply return the same values in all cases, which we'd ignore. The API only allows querying the processor frequency. In the constant_tsc case, th

Re: [PATCH v4: kvm 1/4] Code motion. Separate timer intialization into an indepedent function.

2009-09-30 Thread Avi Kivity
On 09/30/2009 05:51 PM, Zachary Amsden wrote: Is anything preventing us from unifying the constant_tsc and !same paths? We could just do a quick check in the notifier, see the tsc frequency hasn't changed, and return. Actually, yes. On constant_tsc processors, the processor frequency may s

Re: [PATCH v4: kvm 1/4] Code motion. Separate timer intialization into an indepedent function.

2009-09-30 Thread Zachary Amsden
On 09/29/2009 10:45 PM, Avi Kivity wrote: On 09/29/2009 11:38 PM, Zachary Amsden wrote: Signed-off-by: Zachary Amsden Looks good. Is anything preventing us from unifying the constant_tsc and !same paths? We could just do a quick check in the notifier, see the tsc frequency hasn't changed,

Re: [PATCH v4: kvm 1/4] Code motion. Separate timer intialization into an indepedent function.

2009-09-30 Thread Avi Kivity
On 09/29/2009 11:38 PM, Zachary Amsden wrote: Signed-off-by: Zachary Amsden Looks good. Is anything preventing us from unifying the constant_tsc and !same paths? We could just do a quick check in the notifier, see the tsc frequency hasn't changed, and return. -- Do not meddle in the

[PATCH v4: kvm 1/4] Code motion. Separate timer intialization into an indepedent function.

2009-09-29 Thread Zachary Amsden
Signed-off-by: Zachary Amsden --- arch/x86/kvm/x86.c | 23 +++ 1 files changed, 15 insertions(+), 8 deletions(-) diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index fedac9d..15d2ace 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -3116,9 +3116,22 @@ stati