Re: [PATCH v4] ARM/KVM: save and restore generic timer registers

2013-12-12 Thread Peter Maydell
On 12 December 2013 02:28, Christoffer Dall christoffer.d...@linaro.org wrote: diff --git a/Documentation/virtual/kvm/api.txt b/Documentation/virtual/kvm/api.txt index a30035d..9565e6a 100644 --- a/Documentation/virtual/kvm/api.txt +++ b/Documentation/virtual/kvm/api.txt @@ -1889,9 +1889,12

Re: [PATCH v4] ARM/KVM: save and restore generic timer registers

2013-12-12 Thread Andre Przywara
On 12/12/2013 10:23 AM, Peter Maydell wrote: On 12 December 2013 02:28, Christoffer Dall christoffer.d...@linaro.org wrote: diff --git a/Documentation/virtual/kvm/api.txt b/Documentation/virtual/kvm/api.txt index a30035d..9565e6a 100644 --- a/Documentation/virtual/kvm/api.txt +++

Re: [PATCH v4] ARM/KVM: save and restore generic timer registers

2013-12-12 Thread Peter Maydell
On 12 December 2013 09:32, Andre Przywara andre.przyw...@linaro.org wrote: On 12/12/2013 10:23 AM, Peter Maydell wrote: What does it mean to say that a system register for AArch64 is 32 bits given that MRS/MSR always operate on a 64 bit register? But ARMv8 ARM still defines these registers

Re: [PATCH v4] ARM/KVM: save and restore generic timer registers

2013-12-12 Thread Marc Zyngier
On 12/12/13 11:36, Peter Maydell wrote: On 12 December 2013 09:32, Andre Przywara andre.przyw...@linaro.org wrote: On 12/12/2013 10:23 AM, Peter Maydell wrote: What does it mean to say that a system register for AArch64 is 32 bits given that MRS/MSR always operate on a 64 bit register? But

Re: [PATCH v4] ARM/KVM: save and restore generic timer registers

2013-12-12 Thread Christoffer Dall
On Thu, Dec 12, 2013 at 05:15:36PM +, Marc Zyngier wrote: On 12/12/13 11:36, Peter Maydell wrote: On 12 December 2013 09:32, Andre Przywara andre.przyw...@linaro.org wrote: On 12/12/2013 10:23 AM, Peter Maydell wrote: What does it mean to say that a system register for AArch64 is 32

Re: [PATCH v4] ARM/KVM: save and restore generic timer registers

2013-12-11 Thread Christoffer Dall
On Tue, Dec 10, 2013 at 11:50:25AM +0100, Andre Przywara wrote: From: Andre Przywara andre.przyw...@calxeda.com For migration to work we need to save (and later restore) the state of each cores virtual generic timer. Since this is per VCPU, we can use the [gs]et_one_reg ioctl and export the

[PATCH v4] ARM/KVM: save and restore generic timer registers

2013-12-10 Thread Andre Przywara
From: Andre Przywara andre.przyw...@calxeda.com For migration to work we need to save (and later restore) the state of each cores virtual generic timer. Since this is per VCPU, we can use the [gs]et_one_reg ioctl and export the three needed registers (control, counter, compare value). Though they

Re: [PATCH v4] ARM/KVM: save and restore generic timer registers

2013-12-10 Thread Andre Przywara
On 12/10/2013 11:50 AM, Andre Przywara wrote: From: Andre Przywara andre.przyw...@calxeda.com Ooops, I managed to screw up the authorship :-( Can the committer please change this to: Andre Przywara andre.przyw...@linaro.org (as in the signed-off-by?) Thanks, Andre. For migration to work