Re: [PATCH v6 12/12] KVM: indicate readonly access fault

2012-09-12 Thread Marcelo Tosatti
On Tue, Sep 11, 2012 at 11:39:01AM -0300, Marcelo Tosatti wrote: On Tue, Sep 11, 2012 at 12:18:22PM +0300, Avi Kivity wrote: The same can happen with slot deletion, for example. Userspace (which performed the modification which can result in faults to

Re: [PATCH v6 12/12] KVM: indicate readonly access fault

2012-09-12 Thread Avi Kivity
On 09/11/2012 05:39 PM, Marcelo Tosatti wrote: On Tue, Sep 11, 2012 at 12:18:22PM +0300, Avi Kivity wrote: The same can happen with slot deletion, for example. Userspace (which performed the modification which can result in faults to non-existant/read-only/.../new-tag memslot), must

Re: [PATCH v6 12/12] KVM: indicate readonly access fault

2012-09-12 Thread Marcelo Tosatti
On Wed, Sep 12, 2012 at 06:34:33PM +0300, Avi Kivity wrote: On 09/11/2012 05:39 PM, Marcelo Tosatti wrote: On Tue, Sep 11, 2012 at 12:18:22PM +0300, Avi Kivity wrote: The same can happen with slot deletion, for example. Userspace (which performed the modification which can result in

Re: [PATCH v6 12/12] KVM: indicate readonly access fault

2012-09-12 Thread Avi Kivity
On 09/12/2012 06:44 PM, Marcelo Tosatti wrote: On Wed, Sep 12, 2012 at 06:34:33PM +0300, Avi Kivity wrote: On 09/11/2012 05:39 PM, Marcelo Tosatti wrote: On Tue, Sep 11, 2012 at 12:18:22PM +0300, Avi Kivity wrote: The same can happen with slot deletion, for example. Userspace (which

Re: [PATCH v6 12/12] KVM: indicate readonly access fault

2012-09-11 Thread Avi Kivity
: Introduce write_readonly_mem in mmio-exit-info to indicate this exit is caused by write access on readonly memslot Please document this in chapter 5 of apic.txt. Okay, please review this one. Subject: [PATCH v6 12/12] KVM: indicate readonly access fault Introduce

Re: [PATCH v6 12/12] KVM: indicate readonly access fault

2012-09-11 Thread Marcelo Tosatti
On Tue, Sep 11, 2012 at 12:18:22PM +0300, Avi Kivity wrote: The same can happen with slot deletion, for example. Userspace (which performed the modification which can result in faults to non-existant/read-only/.../new-tag memslot), must handle the faults properly or avoid the

Re: [PATCH v6 12/12] KVM: indicate readonly access fault

2012-09-10 Thread Marcelo Tosatti
to indicate this exit is caused by write access on readonly memslot Please document this in chapter 5 of apic.txt. Okay, please review this one. Subject: [PATCH v6 12/12] KVM: indicate readonly access fault Introduce write_readonly_mem in mmio-exit-info to indicate this exit

Re: [PATCH v6 12/12] KVM: indicate readonly access fault

2012-09-09 Thread Avi Kivity
is caused by write access on readonly memslot Please document this in chapter 5 of apic.txt. Okay, please review this one. Subject: [PATCH v6 12/12] KVM: indicate readonly access fault Introduce write_readonly_mem in mmio-exit-info to indicate this exit is caused by write access on readonly

Re: [PATCH v6 12/12] KVM: indicate readonly access fault

2012-09-07 Thread Xiao Guangrong
Please document this in chapter 5 of apic.txt. Okay, please review this one. Subject: [PATCH v6 12/12] KVM: indicate readonly access fault Introduce write_readonly_mem in mmio-exit-info to indicate this exit is caused by write access on readonly memslot I'm not sure whether

Re: [PATCH v6 12/12] KVM: indicate readonly access fault

2012-09-06 Thread Avi Kivity
of apic.txt. Okay, please review this one. Subject: [PATCH v6 12/12] KVM: indicate readonly access fault Introduce write_readonly_mem in mmio-exit-info to indicate this exit is caused by write access on readonly memslot I'm not sure whether this indication can be trusted by userspace

Re: [PATCH v6 12/12] KVM: indicate readonly access fault

2012-08-22 Thread Avi Kivity
On 08/21/2012 06:03 AM, Xiao Guangrong wrote: Introduce write_readonly_mem in mmio-exit-info to indicate this exit is caused by write access on readonly memslot Please document this in chapter 5 of apic.txt. -- error compiling committee.c: too many arguments to function -- To unsubscribe from

Re: [PATCH v6 12/12] KVM: indicate readonly access fault

2012-08-22 Thread Xiao Guangrong
: [PATCH v6 12/12] KVM: indicate readonly access fault Introduce write_readonly_mem in mmio-exit-info to indicate this exit is caused by write access on readonly memslot Signed-off-by: Xiao Guangrong xiaoguangr...@linux.vnet.ibm.com --- Documentation/virtual/kvm/api.txt |8 +++- arch/x86

[PATCH v6 12/12] KVM: indicate readonly access fault

2012-08-20 Thread Xiao Guangrong
Introduce write_readonly_mem in mmio-exit-info to indicate this exit is caused by write access on readonly memslot Signed-off-by: Xiao Guangrong xiaoguangr...@linux.vnet.ibm.com --- arch/x86/kvm/x86.c | 23 ++- include/linux/kvm.h |3 +++