Re: [PATCH v7 3/3] tcm_vhost: Add hotplug/hotunplug support

2013-04-22 Thread Asias He
On Tue, Apr 23, 2013 at 01:48:51PM +0930, Rusty Russell wrote: > Asias He writes: > > On Mon, Apr 22, 2013 at 04:17:04PM +0300, Michael S. Tsirkin wrote: > >> > > > > > > > +evt = kzalloc(sizeof(*evt), GFP_KERNEL); > >> > > > > > > > >> > > > > > > I think kzalloc not needed here, you init al

Re: [PATCH v7 3/3] tcm_vhost: Add hotplug/hotunplug support

2013-04-22 Thread Rusty Russell
Asias He writes: > On Mon, Apr 22, 2013 at 04:17:04PM +0300, Michael S. Tsirkin wrote: >> > > > > > > > + evt = kzalloc(sizeof(*evt), GFP_KERNEL); >> > > > > > > >> > > > > > > I think kzalloc not needed here, you init all fields. >> > > > > > >> > > > > > Not really! evt->event.lun[4-7] is

Re: [PATCH v7 3/3] tcm_vhost: Add hotplug/hotunplug support

2013-04-22 Thread Asias He
On Mon, Apr 22, 2013 at 04:17:04PM +0300, Michael S. Tsirkin wrote: > On Mon, Apr 22, 2013 at 05:20:24PM +0800, Asias He wrote: > > On Sat, Apr 20, 2013 at 10:01:31PM +0300, Michael S. Tsirkin wrote: > > > On Fri, Apr 19, 2013 at 10:34:10AM +0800, Asias He wrote: > > > > On Thu, Apr 18, 2013 at 11:

Re: [PATCH v7 3/3] tcm_vhost: Add hotplug/hotunplug support

2013-04-22 Thread Michael S. Tsirkin
On Mon, Apr 22, 2013 at 05:20:24PM +0800, Asias He wrote: > On Sat, Apr 20, 2013 at 10:01:31PM +0300, Michael S. Tsirkin wrote: > > On Fri, Apr 19, 2013 at 10:34:10AM +0800, Asias He wrote: > > > On Thu, Apr 18, 2013 at 11:21:54AM +0300, Michael S. Tsirkin wrote: > > > > On Thu, Apr 18, 2013 at 04:

Re: [PATCH v7 3/3] tcm_vhost: Add hotplug/hotunplug support

2013-04-22 Thread Asias He
On Sat, Apr 20, 2013 at 10:01:31PM +0300, Michael S. Tsirkin wrote: > On Fri, Apr 19, 2013 at 10:34:10AM +0800, Asias He wrote: > > On Thu, Apr 18, 2013 at 11:21:54AM +0300, Michael S. Tsirkin wrote: > > > On Thu, Apr 18, 2013 at 04:59:08PM +0800, Asias He wrote: > > > > On Thu, Apr 18, 2013 at 10:

Re: [PATCH v7 3/3] tcm_vhost: Add hotplug/hotunplug support

2013-04-20 Thread Michael S. Tsirkin
On Fri, Apr 19, 2013 at 10:34:10AM +0800, Asias He wrote: > On Thu, Apr 18, 2013 at 11:21:54AM +0300, Michael S. Tsirkin wrote: > > On Thu, Apr 18, 2013 at 04:59:08PM +0800, Asias He wrote: > > > On Thu, Apr 18, 2013 at 10:34:29AM +0300, Michael S. Tsirkin wrote: > > > > On Thu, Apr 18, 2013 at 09:

Re: [PATCH v7 3/3] tcm_vhost: Add hotplug/hotunplug support

2013-04-18 Thread Asias He
On Thu, Apr 18, 2013 at 11:21:54AM +0300, Michael S. Tsirkin wrote: > On Thu, Apr 18, 2013 at 04:59:08PM +0800, Asias He wrote: > > On Thu, Apr 18, 2013 at 10:34:29AM +0300, Michael S. Tsirkin wrote: > > > On Thu, Apr 18, 2013 at 09:05:54AM +0800, Asias He wrote: > > > > In commit 365a7150094 ([SCS

Re: [PATCH v7 3/3] tcm_vhost: Add hotplug/hotunplug support

2013-04-18 Thread Michael S. Tsirkin
On Thu, Apr 18, 2013 at 04:59:08PM +0800, Asias He wrote: > On Thu, Apr 18, 2013 at 10:34:29AM +0300, Michael S. Tsirkin wrote: > > On Thu, Apr 18, 2013 at 09:05:54AM +0800, Asias He wrote: > > > In commit 365a7150094 ([SCSI] virtio-scsi: hotplug support for > > > virtio-scsi), hotplug support is a

Re: [PATCH v7 3/3] tcm_vhost: Add hotplug/hotunplug support

2013-04-18 Thread Asias He
On Thu, Apr 18, 2013 at 10:34:29AM +0300, Michael S. Tsirkin wrote: > On Thu, Apr 18, 2013 at 09:05:54AM +0800, Asias He wrote: > > In commit 365a7150094 ([SCSI] virtio-scsi: hotplug support for > > virtio-scsi), hotplug support is added to virtio-scsi. > > > > This patch adds hotplug and hotunplu

Re: [PATCH v7 3/3] tcm_vhost: Add hotplug/hotunplug support

2013-04-18 Thread Michael S. Tsirkin
On Thu, Apr 18, 2013 at 09:05:54AM +0800, Asias He wrote: > In commit 365a7150094 ([SCSI] virtio-scsi: hotplug support for > virtio-scsi), hotplug support is added to virtio-scsi. > > This patch adds hotplug and hotunplug support to tcm_vhost. > > You can create or delete a LUN in targetcli to ho

[PATCH v7 3/3] tcm_vhost: Add hotplug/hotunplug support

2013-04-17 Thread Asias He
In commit 365a7150094 ([SCSI] virtio-scsi: hotplug support for virtio-scsi), hotplug support is added to virtio-scsi. This patch adds hotplug and hotunplug support to tcm_vhost. You can create or delete a LUN in targetcli to hotplug or hotunplug a LUN in guest. Changes in v7: - Add vhost_work_fl