Re: [PATCHv4 15/15] Pass boot device list to firmware.

On Mon, Nov 15, 2010 at 08:29:24PM +, Blue Swirl wrote: > 2010/11/15 Gleb Natapov : > > On Sun, Nov 14, 2010 at 10:50:13PM +, Blue Swirl wrote: > >> On Sun, Nov 14, 2010 at 3:39 PM, Gleb Natapov wrote: > >> > > >> > Signed-off-by: Gleb Natapov > >> > --- > >> >  hw/fw_cfg.c |   14 +++

Re: [PATCHv4 15/15] Pass boot device list to firmware.

On Tue, Nov 16, 2010 at 09:22:45AM +0200, Gleb Natapov wrote: > On Mon, Nov 15, 2010 at 09:52:19PM -0500, Kevin O'Connor wrote: > > I also have an ulterior motive here. If the boot order is exposed as > > a newline separated list via an entry in QEMU_CFG_FILE_DIR, then this > > becomes free for co

Re: [PATCHv4 15/15] Pass boot device list to firmware.

On Thu, Nov 18, 2010 at 03:12:02PM +0200, Michael S. Tsirkin wrote: > On Thu, Nov 18, 2010 at 02:37:08PM +0200, Gleb Natapov wrote: > > > So that's unavoidable if we think paths are correct. > > > But if we know they are wrong, we are better off > > > correcting them first IMO. > > > > > They are

Re: [PATCHv4 15/15] Pass boot device list to firmware.

On Thu, Nov 18, 2010 at 02:37:08PM +0200, Gleb Natapov wrote: > > So that's unavoidable if we think paths are correct. > > But if we know they are wrong, we are better off > > correcting them first IMO. > > > They are correct for x86. My patch set does not even tries to cover all > HW. If sparc wa

Re: [PATCHv4 15/15] Pass boot device list to firmware.

On Thu, Nov 18, 2010 at 02:23:20PM +0200, Michael S. Tsirkin wrote: > On Thu, Nov 18, 2010 at 02:16:05PM +0200, Gleb Natapov wrote: > > On Thu, Nov 18, 2010 at 01:52:30PM +0200, Michael S. Tsirkin wrote: > > > On Thu, Nov 18, 2010 at 01:45:04PM +0200, Gleb Natapov wrote: > > > > On Thu, Nov 18, 201

Re: [PATCHv4 15/15] Pass boot device list to firmware.

On Thu, Nov 18, 2010 at 02:16:05PM +0200, Gleb Natapov wrote: > On Thu, Nov 18, 2010 at 01:52:30PM +0200, Michael S. Tsirkin wrote: > > On Thu, Nov 18, 2010 at 01:45:04PM +0200, Gleb Natapov wrote: > > > On Thu, Nov 18, 2010 at 01:38:31PM +0200, Michael S. Tsirkin wrote: > > > > On Thu, Nov 18, 201

Re: [PATCHv4 15/15] Pass boot device list to firmware.

On Thu, Nov 18, 2010 at 01:52:30PM +0200, Michael S. Tsirkin wrote: > On Thu, Nov 18, 2010 at 01:45:04PM +0200, Gleb Natapov wrote: > > On Thu, Nov 18, 2010 at 01:38:31PM +0200, Michael S. Tsirkin wrote: > > > On Thu, Nov 18, 2010 at 12:18:27PM +0200, Gleb Natapov wrote: > > > > On Wed, Nov 17, 201

Re: [PATCHv4 15/15] Pass boot device list to firmware.

On Thu, Nov 18, 2010 at 01:45:04PM +0200, Gleb Natapov wrote: > On Thu, Nov 18, 2010 at 01:38:31PM +0200, Michael S. Tsirkin wrote: > > On Thu, Nov 18, 2010 at 12:18:27PM +0200, Gleb Natapov wrote: > > > On Wed, Nov 17, 2010 at 09:54:27PM +, Blue Swirl wrote: > > > > 2010/11/16 Gleb Natapov : >

Re: [PATCHv4 15/15] Pass boot device list to firmware.

On Thu, Nov 18, 2010 at 01:38:31PM +0200, Michael S. Tsirkin wrote: > On Thu, Nov 18, 2010 at 12:18:27PM +0200, Gleb Natapov wrote: > > On Wed, Nov 17, 2010 at 09:54:27PM +, Blue Swirl wrote: > > > 2010/11/16 Gleb Natapov : > > > > On Tue, Nov 16, 2010 at 06:30:19PM +, Blue Swirl wrote: > >

Re: [PATCHv4 15/15] Pass boot device list to firmware.

On Thu, Nov 18, 2010 at 12:18:27PM +0200, Gleb Natapov wrote: > On Wed, Nov 17, 2010 at 09:54:27PM +, Blue Swirl wrote: > > 2010/11/16 Gleb Natapov : > > > On Tue, Nov 16, 2010 at 06:30:19PM +, Blue Swirl wrote: > > >> >> Perhaps the FW path should use device class names if no name is > >

Re: [PATCHv4 15/15] Pass boot device list to firmware.

On Wed, Nov 17, 2010 at 09:54:27PM +, Blue Swirl wrote: > 2010/11/16 Gleb Natapov : > > On Tue, Nov 16, 2010 at 06:30:19PM +, Blue Swirl wrote: > >> >> Perhaps the FW path should use device class names if no name is > >> >> specified. > >> > What do you mean by "device class name". We can

Re: [PATCHv4 15/15] Pass boot device list to firmware.

2010/11/16 Gleb Natapov : > On Tue, Nov 16, 2010 at 06:30:19PM +, Blue Swirl wrote: >> >> Perhaps the FW path should use device class names if no name is specified. >> > What do you mean by "device class name". We can do something like this: >> > if (dev->child_bus.lh_first) >> >        return

Re: [PATCHv4 15/15] Pass boot device list to firmware.

On Tue, Nov 16, 2010 at 06:30:19PM +, Blue Swirl wrote: > >> Perhaps the FW path should use device class names if no name is specified. > > What do you mean by "device class name". We can do something like this: > > if (dev->child_bus.lh_first) > >        return dev->child_bus.lh_first->info->n

Re: [PATCHv4 15/15] Pass boot device list to firmware.

2010/11/16 Gleb Natapov : > On Mon, Nov 15, 2010 at 08:29:24PM +, Blue Swirl wrote: >> 2010/11/15 Gleb Natapov : >> > On Sun, Nov 14, 2010 at 10:50:13PM +, Blue Swirl wrote: >> >> On Sun, Nov 14, 2010 at 3:39 PM, Gleb Natapov wrote: >> >> > >> >> > Signed-off-by: Gleb Natapov >> >> > ---

Re: [PATCHv4 15/15] Pass boot device list to firmware.

On Tue, Nov 16, 2010 at 7:22 AM, Gleb Natapov wrote: > On Mon, Nov 15, 2010 at 09:52:19PM -0500, Kevin O'Connor wrote: >> On Mon, Nov 15, 2010 at 03:36:25PM +0200, Gleb Natapov wrote: >> > On Mon, Nov 15, 2010 at 08:26:35AM -0500, Kevin O'Connor wrote: >> > > On Mon, Nov 15, 2010 at 09:40:08AM +02

Re: [PATCHv4 15/15] Pass boot device list to firmware.

On Mon, Nov 15, 2010 at 09:52:19PM -0500, Kevin O'Connor wrote: > On Mon, Nov 15, 2010 at 03:36:25PM +0200, Gleb Natapov wrote: > > On Mon, Nov 15, 2010 at 08:26:35AM -0500, Kevin O'Connor wrote: > > > On Mon, Nov 15, 2010 at 09:40:08AM +0200, Gleb Natapov wrote: > > > > On Sun, Nov 14, 2010 at 10:

Re: [PATCHv4 15/15] Pass boot device list to firmware.

On Mon, Nov 15, 2010 at 03:36:25PM +0200, Gleb Natapov wrote: > On Mon, Nov 15, 2010 at 08:26:35AM -0500, Kevin O'Connor wrote: > > On Mon, Nov 15, 2010 at 09:40:08AM +0200, Gleb Natapov wrote: > > > On Sun, Nov 14, 2010 at 10:40:33PM -0500, Kevin O'Connor wrote: > > > > Why not just return a newli

Re: [PATCHv4 15/15] Pass boot device list to firmware.

2010/11/15 Gleb Natapov : > On Sun, Nov 14, 2010 at 10:50:13PM +, Blue Swirl wrote: >> On Sun, Nov 14, 2010 at 3:39 PM, Gleb Natapov wrote: >> > >> > Signed-off-by: Gleb Natapov >> > --- >> >  hw/fw_cfg.c |   14 ++ >> >  hw/fw_cfg.h |    4 +++- >> >  sysemu.h    |    1 + >> >  vl.

Re: [PATCHv4 15/15] Pass boot device list to firmware.

On Mon, Nov 15, 2010 at 03:36:25PM +0200, Gleb Natapov wrote: > Hmm BTW I do not see proper endianness > handling in FILE_DIR. > That's just me. Everything it OK there with endianness. -- Gleb. -- To unsubscribe from this list: send the line "unsu

Re: [PATCHv4 15/15] Pass boot device list to firmware.

On Mon, Nov 15, 2010 at 08:26:35AM -0500, Kevin O'Connor wrote: > On Mon, Nov 15, 2010 at 09:40:08AM +0200, Gleb Natapov wrote: > > On Sun, Nov 14, 2010 at 10:40:33PM -0500, Kevin O'Connor wrote: > > > Why not just return a newline separated list that is null terminated? > > > > > Doing it like th

Re: [PATCHv4 15/15] Pass boot device list to firmware.

On Mon, Nov 15, 2010 at 09:40:08AM +0200, Gleb Natapov wrote: > On Sun, Nov 14, 2010 at 10:40:33PM -0500, Kevin O'Connor wrote: > > Why not just return a newline separated list that is null terminated? > > > Doing it like this will needlessly complicate firmware side. How do you > know how much me

Re: [PATCHv4 15/15] Pass boot device list to firmware.

On Sun, Nov 14, 2010 at 10:50:13PM +, Blue Swirl wrote: > On Sun, Nov 14, 2010 at 3:39 PM, Gleb Natapov wrote: > > > > Signed-off-by: Gleb Natapov > > --- > >  hw/fw_cfg.c |   14 ++ > >  hw/fw_cfg.h |    4 +++- > >  sysemu.h    |    1 + > >  vl.c        |   51

Re: [PATCHv4 15/15] Pass boot device list to firmware.

On Mon, Nov 15, 2010 at 09:53:50AM +0200, Michael S. Tsirkin wrote: > On Mon, Nov 15, 2010 at 09:40:08AM +0200, Gleb Natapov wrote: > > On Sun, Nov 14, 2010 at 10:40:33PM -0500, Kevin O'Connor wrote: > > > On Sun, Nov 14, 2010 at 05:39:41PM +0200, Gleb Natapov wrote: > > > > +/* > > > > + * This fu

Re: [PATCHv4 15/15] Pass boot device list to firmware.

On Mon, Nov 15, 2010 at 09:40:08AM +0200, Gleb Natapov wrote: > On Sun, Nov 14, 2010 at 10:40:33PM -0500, Kevin O'Connor wrote: > > On Sun, Nov 14, 2010 at 05:39:41PM +0200, Gleb Natapov wrote: > > > +/* > > > + * This function returns device list as an array in a below format: > > > + * +-+---

Re: [PATCHv4 15/15] Pass boot device list to firmware.

On Sun, Nov 14, 2010 at 10:40:33PM -0500, Kevin O'Connor wrote: > On Sun, Nov 14, 2010 at 05:39:41PM +0200, Gleb Natapov wrote: > > +/* > > + * This function returns device list as an array in a below format: > > + * +-+-+---+-+---+-- > > + * | n | l1 | devp

Re: [PATCHv4 15/15] Pass boot device list to firmware.

On Sun, Nov 14, 2010 at 05:39:41PM +0200, Gleb Natapov wrote: > +/* > + * This function returns device list as an array in a below format: > + * +-+-+---+-+---+-- > + * | n | l1 | devpath1| l2 | devpath2 | ... > + * +-+-+---+---

Re: [PATCHv4 15/15] Pass boot device list to firmware.

On Sun, Nov 14, 2010 at 3:39 PM, Gleb Natapov wrote: > > Signed-off-by: Gleb Natapov > --- >  hw/fw_cfg.c |   14 ++ >  hw/fw_cfg.h |    4 +++- >  sysemu.h    |    1 + >  vl.c        |   51 +++ >  4 files changed, 69 insertions(+), 1 dele

Re: [PATCHv4 15/15] Pass boot device list to firmware.

On Sun, Nov 14, 2010 at 09:13:03PM +, Blue Swirl wrote: > On Sun, Nov 14, 2010 at 8:54 PM, Michael S. Tsirkin wrote: > > On Sun, Nov 14, 2010 at 08:49:59PM +, Blue Swirl wrote: > >> On Sun, Nov 14, 2010 at 3:39 PM, Gleb Natapov wrote: > >> > > >> > Signed-off-by: Gleb Natapov > >> > ---

Re: [PATCHv4 15/15] Pass boot device list to firmware.

On Sun, Nov 14, 2010 at 8:54 PM, Michael S. Tsirkin wrote: > On Sun, Nov 14, 2010 at 08:49:59PM +, Blue Swirl wrote: >> On Sun, Nov 14, 2010 at 3:39 PM, Gleb Natapov wrote: >> > >> > Signed-off-by: Gleb Natapov >> > --- >> >  hw/fw_cfg.c |   14 ++ >> >  hw/fw_cfg.h |    4 +++- >>

Re: [PATCHv4 15/15] Pass boot device list to firmware.

On Sun, Nov 14, 2010 at 08:52:37PM +0200, Gleb Natapov wrote: > > > + > > > +len = strlen(bootpath); > > > +list = qemu_realloc(list, total + len + 1); > > > +list[total++] = len; > > > +memcpy(&list[total], bootpath, len); > > > +total += len; > > > +

Re: [PATCHv4 15/15] Pass boot device list to firmware.

On Sun, Nov 14, 2010 at 08:52:37PM +0200, Gleb Natapov wrote: > On Sun, Nov 14, 2010 at 08:41:37PM +0200, Michael S. Tsirkin wrote: > > On Sun, Nov 14, 2010 at 05:39:41PM +0200, Gleb Natapov wrote: > > > > > > Signed-off-by: Gleb Natapov > > > --- > > > hw/fw_cfg.c | 14 ++ > > > h

Re: [PATCHv4 15/15] Pass boot device list to firmware.

On Sun, Nov 14, 2010 at 08:49:59PM +, Blue Swirl wrote: > On Sun, Nov 14, 2010 at 3:39 PM, Gleb Natapov wrote: > > > > Signed-off-by: Gleb Natapov > > --- > >  hw/fw_cfg.c |   14 ++ > >  hw/fw_cfg.h |    4 +++- > >  sysemu.h    |    1 + > >  vl.c        |   51

Re: [PATCHv4 15/15] Pass boot device list to firmware.

On Sun, Nov 14, 2010 at 3:39 PM, Gleb Natapov wrote: > > Signed-off-by: Gleb Natapov > --- >  hw/fw_cfg.c |   14 ++ >  hw/fw_cfg.h |    4 +++- >  sysemu.h    |    1 + >  vl.c        |   51 +++ >  4 files changed, 69 insertions(+), 1 dele

Re: [PATCHv4 15/15] Pass boot device list to firmware.

On Sun, Nov 14, 2010 at 08:41:37PM +0200, Michael S. Tsirkin wrote: > On Sun, Nov 14, 2010 at 05:39:41PM +0200, Gleb Natapov wrote: > > > > Signed-off-by: Gleb Natapov > > --- > > hw/fw_cfg.c | 14 ++ > > hw/fw_cfg.h |4 +++- > > sysemu.h|1 + > > vl.c| 51 +++

Re: [PATCHv4 15/15] Pass boot device list to firmware.

On Sun, Nov 14, 2010 at 05:39:41PM +0200, Gleb Natapov wrote: > > Signed-off-by: Gleb Natapov > --- > hw/fw_cfg.c | 14 ++ > hw/fw_cfg.h |4 +++- > sysemu.h|1 + > vl.c| 51 +++ > 4 files changed, 69 insertions(+

[PATCHv4 15/15] Pass boot device list to firmware.

Signed-off-by: Gleb Natapov --- hw/fw_cfg.c | 14 ++ hw/fw_cfg.h |4 +++- sysemu.h|1 + vl.c| 51 +++ 4 files changed, 69 insertions(+), 1 deletions(-) diff --git a/hw/fw_cfg.c b/hw/fw_cfg.c index 7b9434f..f6a67