Re: [Qemu-devel] [PATCH] kvm: align ram_size to page boundary

2012-07-06 Thread Michael Tokarev
On 17.06.2012 17:14, Avi Kivity wrote: > On 06/17/2012 04:06 PM, Blue Swirl wrote: > >>> strtosz() is much too general. We could do it in vl.c without trouble. >>> However, it takes away our ability to emulate a "640k should be enough >>> for everyone" machine. >> >> Then how about current max o

Re: [Qemu-devel] [PATCH] kvm: align ram_size to page boundary

2012-06-17 Thread Avi Kivity
On 06/17/2012 04:06 PM, Blue Swirl wrote: >> strtosz() is much too general. We could do it in vl.c without trouble. >> However, it takes away our ability to emulate a "640k should be enough >> for everyone" machine. > > Then how about current max of target page sizes: 8k? No machine should > wa

Re: [Qemu-devel] [PATCH] kvm: align ram_size to page boundary

2012-06-17 Thread Blue Swirl
On Sun, Jun 17, 2012 at 12:54 PM, Avi Kivity wrote: > On 06/17/2012 03:43 PM, Blue Swirl wrote: >> On Sun, Jun 17, 2012 at 11:51 AM, Avi Kivity wrote: >>> On 06/17/2012 02:47 PM, Jan Kiszka wrote: >> >> I think this should rather go into generic code. > > To be honest, I put this

Re: [Qemu-devel] [PATCH] kvm: align ram_size to page boundary

2012-06-17 Thread Avi Kivity
On 06/17/2012 03:43 PM, Blue Swirl wrote: > On Sun, Jun 17, 2012 at 11:51 AM, Avi Kivity wrote: >> On 06/17/2012 02:47 PM, Jan Kiszka wrote: > > I think this should rather go into generic code. To be honest, I put this in kvm-specific code because vl.c doesn't have TARGET_PA

Re: [Qemu-devel] [PATCH] kvm: align ram_size to page boundary

2012-06-17 Thread Peter Maydell
On 17 June 2012 13:43, Blue Swirl wrote: > The boards should make sure that the amount of RAM is feasible with > the board memory slots. It's not possible to put 256kb SIMMs to a slot > that expects 1GB DIMMs. We can allow some flexibility there though, > I'm not sure if the current chipsets would

Re: [Qemu-devel] [PATCH] kvm: align ram_size to page boundary

2012-06-17 Thread Blue Swirl
On Sun, Jun 17, 2012 at 11:51 AM, Avi Kivity wrote: > On 06/17/2012 02:47 PM, Jan Kiszka wrote: I think this should rather go into generic code. >>> >>> To be honest, I put this in kvm-specific code because vl.c doesn't have >>> TARGET_PAGE_ALIGN.  Maybe we should have machine->page_size