Re: [Qemu-devel] [PATCH 11/23] memory: add ioeventfd support

2011-07-26 Thread Avi Kivity
On 07/25/2011 10:08 PM, Anthony Liguori wrote: +static void as_memory_ioeventfd_add(AddressSpace *as, MemoryRegionIoeventfd *fd) +{ +int r; + +if (!fd->match_data || fd->addr.size != 4) { +abort(); +} + +r = kvm_set_ioeventfd_mmio_long(fd->fd, fd->addr.start, fd->data,

Re: [Qemu-devel] [PATCH 11/23] memory: add ioeventfd support

2011-07-25 Thread Anthony Liguori
On 07/25/2011 09:02 AM, Avi Kivity wrote: As with the rest of the memory API, the caller associates an eventfd with an address, and the memory API takes care of registering or unregistering when the address is made visible or invisible to the guest. Signed-off-by: Avi Kivity --- memory.c | 23

Re: [Qemu-devel] [PATCH 11/23] memory: add ioeventfd support

2011-07-25 Thread Avi Kivity
On 07/25/2011 06:38 PM, malc wrote: On Mon, 25 Jul 2011, Avi Kivity wrote: > On 07/25/2011 06:22 PM, malc wrote: > > > > >+} > > > > >+if (a.fd > > > >+return true; > > > > >+} else { > > if (a.fd>b.

Re: [Qemu-devel] [PATCH 11/23] memory: add ioeventfd support

2011-07-25 Thread malc
On Mon, 25 Jul 2011, Avi Kivity wrote: > On 07/25/2011 06:22 PM, malc wrote: > > > > > +} > > > > > +if (a.fd< b.fd) { > > > > > +return true; > > > > > +} else { > > if (a.fd> b.fd) { > > > > > +return false; > > > > >

Re: [Qemu-devel] [PATCH 11/23] memory: add ioeventfd support

2011-07-25 Thread Avi Kivity
On 07/25/2011 06:22 PM, malc wrote: > > > +} > > > +if (a.fd< b.fd) { > > > +return true; > > > +} else { if (a.fd> b.fd) { > > > +return false; > > > +} } CODING_STYLE permits braceless else if.

Re: [Qemu-devel] [PATCH 11/23] memory: add ioeventfd support

2011-07-25 Thread malc
On Mon, 25 Jul 2011, Avi Kivity wrote: > On 07/25/2011 06:16 PM, malc wrote: > > On Mon, 25 Jul 2011, Avi Kivity wrote: > > > > > As with the rest of the memory API, the caller associates an eventfd > > > with an address, and the memory API takes care of registering or > > > unregistering when

Re: [Qemu-devel] [PATCH 11/23] memory: add ioeventfd support

2011-07-25 Thread Avi Kivity
On 07/25/2011 06:16 PM, malc wrote: On Mon, 25 Jul 2011, Avi Kivity wrote: > As with the rest of the memory API, the caller associates an eventfd > with an address, and the memory API takes care of registering or > unregistering when the address is made visible or invisible to the > guest. >

Re: [Qemu-devel] [PATCH 11/23] memory: add ioeventfd support

2011-07-25 Thread malc
On Mon, 25 Jul 2011, Avi Kivity wrote: > As with the rest of the memory API, the caller associates an eventfd > with an address, and the memory API takes care of registering or > unregistering when the address is made visible or invisible to the > guest. > > Signed-off-by: Avi Kivity [..snip..]