Re: [Qemu-devel] [PATCH 3/10] Add bdrv_flush_all()

2008-09-12 Thread Blue Swirl
On 9/9/08, Anthony Liguori <[EMAIL PROTECTED]> wrote: > This patch adds a bdrv_flush_all() function. It's necessary to ensure that > all > IO operations have been flushed to disk before completely a live migration. > > N.B. we don't actually use this now. We really should flush the block > dr

Re: [Qemu-devel] [PATCH 3/10] Add bdrv_flush_all()

2008-09-10 Thread Paul Brook
> I'm actually liking bdrv_flush_all() less and less. If there are any > outstanding IO requests, it will increase the down time associated with > live migration. I think we definitely need to add a live save handler > that waits until there are no outstanding IO requests to converge. I'm > conc

Re: [Qemu-devel] [PATCH 3/10] Add bdrv_flush_all()

2008-09-10 Thread Avi Kivity
Anthony Liguori wrote: I'm actually liking bdrv_flush_all() less and less. If there are any outstanding IO requests, it will increase the down time associated with live migration. I think we definitely need to add a live save handler that waits until there are no outstanding IO requests to

Re: [Qemu-devel] [PATCH 3/10] Add bdrv_flush_all()

2008-09-10 Thread Glauber Costa
On Wed, Sep 10, 2008 at 12:19 PM, Anthony Liguori <[EMAIL PROTECTED]> wrote: > Glauber Costa wrote: >> >> On Wed, Sep 10, 2008 at 10:26 AM, Chris Lalancette <[EMAIL PROTECTED]> >> wrote: >> >>> >>> Anthony Liguori wrote: >>> This patch adds a bdrv_flush_all() function. It's necessary to

Re: [Qemu-devel] [PATCH 3/10] Add bdrv_flush_all()

2008-09-10 Thread Anthony Liguori
Glauber Costa wrote: On Wed, Sep 10, 2008 at 10:26 AM, Chris Lalancette <[EMAIL PROTECTED]> wrote: Anthony Liguori wrote: This patch adds a bdrv_flush_all() function. It's necessary to ensure that all IO operations have been flushed to disk before completely a live migration. N.B. we

Re: [Qemu-devel] [PATCH 3/10] Add bdrv_flush_all()

2008-09-10 Thread Glauber Costa
On Wed, Sep 10, 2008 at 10:26 AM, Chris Lalancette <[EMAIL PROTECTED]> wrote: > Anthony Liguori wrote: >> This patch adds a bdrv_flush_all() function. It's necessary to ensure that >> all >> IO operations have been flushed to disk before completely a live migration. >> >> N.B. we don't actually u

Re: [Qemu-devel] [PATCH 3/10] Add bdrv_flush_all()

2008-09-10 Thread Chris Lalancette
Anthony Liguori wrote: > This patch adds a bdrv_flush_all() function. It's necessary to ensure that > all > IO operations have been flushed to disk before completely a live migration. > > N.B. we don't actually use this now. We really should flush the block drivers > using an live savevm callba