Re: [Qemu-devel] [PATCHv2-RFC 2/2] pci: add standard bridge device

2012-02-17 Thread Gerd Hoffmann
Hi, > +/* If we don't specify the name, the bus will be addressed as .0, > where > + * id is the parent id. But it seems more natural to address the bus > using > + * the parent device name. */ > +if (dev->qdev.id && *dev->qdev.id) { > +br->bus_name = dev->qdev.id; > +

Re: [Qemu-devel] [PATCHv2-RFC 2/2] pci: add standard bridge device

2012-02-17 Thread Gerd Hoffmann
On 02/13/12 10:16, Michael S. Tsirkin wrote: > This adds support for a standard pci to pci bridge, > enabling support for more than 32 PCI devices in the system. > Device hotplug is supported by means of SHPC controller. > For guests with an SHPC driver, this allows robust hotplug > and even hotplu

Re: [Qemu-devel] [PATCHv2-RFC 2/2] pci: add standard bridge device

2012-02-19 Thread Michael S. Tsirkin
On Fri, Feb 17, 2012 at 02:25:56PM +0100, Gerd Hoffmann wrote: > Hi, > > > +/* If we don't specify the name, the bus will be addressed as .0, > > where > > + * id is the parent id. But it seems more natural to address the bus > > using > > + * the parent device name. */ > > +i

Re: [Qemu-devel] [PATCHv2-RFC 2/2] pci: add standard bridge device

2012-02-19 Thread Michael S. Tsirkin
On Sun, Feb 19, 2012 at 04:57:07PM +0200, Michael S. Tsirkin wrote: > On Fri, Feb 17, 2012 at 02:25:56PM +0100, Gerd Hoffmann wrote: > > Hi, > > > > > +/* If we don't specify the name, the bus will be addressed as > > > .0, where > > > + * id is the parent id. But it seems more natural

Re: [Qemu-devel] [PATCHv2-RFC 2/2] pci: add standard bridge device

2012-02-20 Thread Michael S. Tsirkin
On Fri, Feb 17, 2012 at 02:33:42PM +0100, Gerd Hoffmann wrote: > On 02/13/12 10:16, Michael S. Tsirkin wrote: > > This adds support for a standard pci to pci bridge, > > enabling support for more than 32 PCI devices in the system. > > Device hotplug is supported by means of SHPC controller. > > For

Re: [Qemu-devel] [PATCHv2-RFC 2/2] pci: add standard bridge device

2012-02-21 Thread Gerd Hoffmann
Hi, >> This seems to not support 64bit prefetchable memory windows, at least >> linux doesn't think it does, lspci looks like this: >> >> 00:10.0 PCI bridge: Red Hat, Inc. Device 0001 (prog-if 00 [Normal decode]) [ ... ] >> Memory behind bridge: f600-f60f >> Prefetchable