Re: [RFC] KVM: x86: emulate movdqa

2012-01-09 Thread Avi Kivity
On 01/09/2012 10:52 AM, Takuya Yoshikawa wrote: > Avi Kivity wrote: > > > > Can you think of a case where we need to perform alignment checking in > > > the emulator? > > > > The case that x86/svm.c is checking for is a security issue. > > > > Guests don't normally turn eflags.AC on, so I don't

Re: [RFC] KVM: x86: emulate movdqa

2012-01-09 Thread Takuya Yoshikawa
Avi Kivity wrote: > > Can you think of a case where we need to perform alignment checking in > > the emulator? > > The case that x86/svm.c is checking for is a security issue. > > Guests don't normally turn eflags.AC on, so I don't expect issues > there. I also don't see issues with SSE alignm

Re: [RFC] KVM: x86: emulate movdqa

2012-01-08 Thread Avi Kivity
On 01/08/2012 06:21 PM, Stefan Hajnoczi wrote: > On Sun, Jan 8, 2012 at 10:32 AM, Avi Kivity wrote: > > On 01/07/2012 12:26 PM, Stefan Hajnoczi wrote: > >> > >> movdqa %xmm0,(%rdi) > >> > >> This patch adds movdqa to the emulator but does not implement #GP when > >> the memory operand is unaligned

Re: [RFC] KVM: x86: emulate movdqa

2012-01-08 Thread Gleb Natapov
On Sun, Jan 08, 2012 at 04:21:56PM +, Stefan Hajnoczi wrote: > On Sun, Jan 8, 2012 at 10:32 AM, Avi Kivity wrote: > > On 01/07/2012 12:26 PM, Stefan Hajnoczi wrote: > >> > >> movdqa %xmm0,(%rdi) > >> > >> This patch adds movdqa to the emulator but does not implement #GP when > >> the memory op

Re: [RFC] KVM: x86: emulate movdqa

2012-01-08 Thread Stefan Hajnoczi
On Sun, Jan 8, 2012 at 10:32 AM, Avi Kivity wrote: > On 01/07/2012 12:26 PM, Stefan Hajnoczi wrote: >> >> movdqa %xmm0,(%rdi) >> >> This patch adds movdqa to the emulator but does not implement #GP when >> the memory operand is unaligned to 16 bytes.  I'm not sure whether >> alignment checking can

Re: [RFC] KVM: x86: emulate movdqa

2012-01-08 Thread Avi Kivity
On 01/07/2012 12:26 PM, Stefan Hajnoczi wrote: > An Ubuntu 9.10 Karmic Koala guest is unable to boot or install due to > missing movdqa emulation: > > kvm_exit: reason EXCEPTION_NMI rip 0x7fef3e025a7b info 7fef3e799000 8b0e > kvm_page_fault: address 7fef3e799000 error_code f > kvm_emulate_insn:

[RFC] KVM: x86: emulate movdqa

2012-01-07 Thread Stefan Hajnoczi
An Ubuntu 9.10 Karmic Koala guest is unable to boot or install due to missing movdqa emulation: kvm_exit: reason EXCEPTION_NMI rip 0x7fef3e025a7b info 7fef3e799000 8b0e kvm_page_fault: address 7fef3e799000 error_code f kvm_emulate_insn: 0:7fef3e025a7b: 66 0f 7f 07 (prot64) movdqa %xmm0,(%rdi)