RE: [RFC] kvm irq assignment

2008-06-15 Thread Xu, Anthony
From: Alexander Graf [mailto:[EMAIL PROTECTED] Sent: 2008年6月13日 22:31 To: Xu, Anthony Cc: Avi Kivity; Marcelo Tosatti; Jes Sorensen; kvm@vger.kernel.org; [EMAIL PROTECTED] Subject: Re: [RFC] kvm irq assignment On Jun 12, 2008, at 11:38 PM, Xu, Anthony

RE: [RFC] kvm irq assignment

2008-06-15 Thread Xu, Anthony
Avi Kivity wrote: Xu, Anthony wrote: Hi Avi and all This is the revised one, All PCI devices send interrupt to both PIC and IOAPIC, a). When PIC is enabled and IOAPIC is disabled, all redirect entries in IOAPIC are masked. B) When PIC is disabled and IPAPIC is enabled, link entry bit7

RE: [RFC] kvm irq assignment

2008-06-15 Thread Xu, Anthony
I think you should avoid any changes to pci.c. Perhaps create a new ioapic_and_pic_map / ioapic_and_pic_set pair of functions and change pc.c to use that instead of piix_set_irq. I'll consider how to do this But pci.c includes below code section, which implements irq_num mapping through

RE: [RFC] kvm irq assignment

2008-06-15 Thread Xu, Anthony
: Alexander Graf [mailto:[EMAIL PROTECTED] Sent: 2008年6月13日 22:31 To: Xu, Anthony Cc: Avi Kivity; Marcelo Tosatti; Jes Sorensen; kvm@vger.kernel.org; [EMAIL PROTECTED] Subject: Re: [RFC] kvm irq assignment On Jun 12, 2008, at 11:38 PM, Xu, Anthony wrote: Hi Avi and all

Re: [RFC] kvm irq assignment

2008-06-14 Thread Marcelo Tosatti
Hi Anthony, On Fri, Jun 13, 2008 at 02:38:08PM +0800, Xu, Anthony wrote: Hi Avi and all This is the revised one, All PCI devices send interrupt to both PIC and IOAPIC, a). When PIC is enabled and IOAPIC is disabled, all redirect entries in IOAPIC are masked. B) When PIC is disabled

RE: [RFC] kvm irq assignment

2008-06-13 Thread Xu, Anthony
Hi Avi and all This is the revised one, All PCI devices send interrupt to both PIC and IOAPIC, a). When PIC is enabled and IOAPIC is disabled, all redirect entries in IOAPIC are masked. B) When PIC is disabled and IPAPIC is enabled, link entry bit7 is set, means this link entry is disable.

[RFC] kvm irq assignment

2008-06-12 Thread Xu, Anthony
Hi all, Thanks for your comments. I made this new patch based on your comments 1. use bimodal _PRT, to take advantage of IOAPIC pin 16~23 the mapping is simple, slot - (slot7)+16 IOAPIC pin, someone may provide good mapping ? 2. use ISA-bridge configure space 0x64 byte as a

Re: [RFC] kvm irq assignment

2008-06-12 Thread Avi Kivity
Xu, Anthony wrote: Hi all, Thanks for your comments. I made this new patch based on your comments 1. use bimodal _PRT, to take advantage of IOAPIC pin 16~23 the mapping is simple, slot - (slot7)+16 IOAPIC pin, someone may provide good mapping ? I think it's fine. If we find a