Re: [RFC 0/5] Introduce VM Sockets virtio transport

2013-06-28 Thread Asias He
On Thu, Jun 27, 2013 at 01:23:24PM +0300, Michael S. Tsirkin wrote: On Thu, Jun 27, 2013 at 03:59:59PM +0800, Asias He wrote: Hello guys, In commit d021c344051af91 (VSOCK: Introduce VM Sockets), VMware added VM Sockets support. VM Sockets allows communication between virtual machines

Re: [RFC 0/5] Introduce VM Sockets virtio transport

2013-06-28 Thread Asias He
On Thu, Jun 27, 2013 at 03:03:01PM -0400, Sasha Levin wrote: Hi Asias, Looks nice! Some comments inline below (I've removed anything that mst already commented on). Thanks. On 06/27/2013 03:59 AM, Asias He wrote: Hello guys, In commit d021c344051af91 (VSOCK: Introduce VM Sockets),

Re: [RFC 0/5] Introduce VM Sockets virtio transport

2013-06-27 Thread Michael S. Tsirkin
On Thu, Jun 27, 2013 at 03:59:59PM +0800, Asias He wrote: Hello guys, In commit d021c344051af91 (VSOCK: Introduce VM Sockets), VMware added VM Sockets support. VM Sockets allows communication between virtual machines and the hypervisor. VM Sockets is able to use different hyervisor neutral

Re: [RFC 0/5] Introduce VM Sockets virtio transport

2013-06-27 Thread Sasha Levin
Hi Asias, Looks nice! Some comments inline below (I've removed anything that mst already commented on). On 06/27/2013 03:59 AM, Asias He wrote: Hello guys, In commit d021c344051af91 (VSOCK: Introduce VM Sockets), VMware added VM Sockets support. VM Sockets allows communication between virtual

Re: [RFC 0/5] Introduce VM Sockets virtio transport

2013-06-27 Thread Andy King
Hi Michael, __u32 guest_cid; Given that cid is like an IP address, 32 bit seems too limiting. I would go for a 64 bit one or maybe even 128 bit, so that e.g. GUIDs can be used there. That's likely based on what vSockets uses, which is in turn based on what the VMCI device

Re: [RFC 0/5] Introduce VM Sockets virtio transport

2013-06-27 Thread Asias He
On Thu, Jun 27, 2013 at 07:25:40PM -0700, Andy King wrote: Hi Michael, __u32 guest_cid; Given that cid is like an IP address, 32 bit seems too limiting. I would go for a 64 bit one or maybe even 128 bit, so that e.g. GUIDs can be used there. That's likely based on what