Re: [RFC PATCH 0/3] directed yield for Pause Loop Exiting

2010-12-14 Thread Balbir Singh
* Rik van Riel [2010-12-13 12:02:51]: > On 12/11/2010 08:57 AM, Balbir Singh wrote: > > >If the vpcu holding the lock runs more and capped, the timeslice > >transfer is a heuristic that will not help. > > That indicates you really need the cap to be per guest, and > not per VCPU. > Yes, I pers

Re: [RFC PATCH 0/3] directed yield for Pause Loop Exiting

2010-12-13 Thread Rik van Riel
On 12/11/2010 08:57 AM, Balbir Singh wrote: If the vpcu holding the lock runs more and capped, the timeslice transfer is a heuristic that will not help. That indicates you really need the cap to be per guest, and not per VCPU. Having one VCPU spin on a lock (and achieve nothing), because the

Re: [RFC PATCH 0/3] directed yield for Pause Loop Exiting

2010-12-13 Thread Avi Kivity
On 12/13/2010 02:39 PM, Balbir Singh wrote: * Avi Kivity [2010-12-13 13:57:37]: > On 12/11/2010 03:57 PM, Balbir Singh wrote: > >* Avi Kivity [2010-12-11 09:31:24]: > > > >> On 12/10/2010 07:03 AM, Balbir Singh wrote: > >> >> > >> >>Scheduler people, please flame me with anyth

Re: [RFC PATCH 0/3] directed yield for Pause Loop Exiting

2010-12-13 Thread Balbir Singh
* Avi Kivity [2010-12-13 13:57:37]: > On 12/11/2010 03:57 PM, Balbir Singh wrote: > >* Avi Kivity [2010-12-11 09:31:24]: > > > >> On 12/10/2010 07:03 AM, Balbir Singh wrote: > >> >> > >> >> Scheduler people, please flame me with anything I may have done > >> >> wrong, so I can do it righ

Re: [RFC PATCH 0/3] directed yield for Pause Loop Exiting

2010-12-13 Thread Avi Kivity
On 12/11/2010 03:57 PM, Balbir Singh wrote: * Avi Kivity [2010-12-11 09:31:24]: > On 12/10/2010 07:03 AM, Balbir Singh wrote: > >> > >> Scheduler people, please flame me with anything I may have done > >> wrong, so I can do it right for a next version :) > >> > > > >This is a good pr

Re: [RFC PATCH 0/3] directed yield for Pause Loop Exiting

2010-12-13 Thread Balbir Singh
* Avi Kivity [2010-12-11 09:31:24]: > On 12/10/2010 07:03 AM, Balbir Singh wrote: > >> > >> Scheduler people, please flame me with anything I may have done > >> wrong, so I can do it right for a next version :) > >> > > > >This is a good problem statement, there are other things to consider > >

Re: [RFC PATCH 0/3] directed yield for Pause Loop Exiting

2010-12-10 Thread Avi Kivity
On 12/10/2010 07:03 AM, Balbir Singh wrote: > > Scheduler people, please flame me with anything I may have done > wrong, so I can do it right for a next version :) > This is a good problem statement, there are other things to consider as well 1. If a hard limit feature is enabled underneath,

Re: [RFC PATCH 0/3] directed yield for Pause Loop Exiting

2010-12-10 Thread Rik van Riel
On 12/10/2010 12:03 AM, Balbir Singh wrote: This is a good problem statement, there are other things to consider as well 1. If a hard limit feature is enabled underneath, donating the timeslice would probably not make too much sense in that case The idea is to get the VCPU that is holding the

Re: [RFC PATCH 0/3] directed yield for Pause Loop Exiting

2010-12-09 Thread Balbir Singh
* Rik van Riel [2010-12-02 14:41:29]: > When running SMP virtual machines, it is possible for one VCPU to be > spinning on a spinlock, while the VCPU that holds the spinlock is not > currently running, because the host scheduler preempted it to run > something else. > > Both Intel and AMD CPUs h

Re: [RFC PATCH 0/3] directed yield for Pause Loop Exiting

2010-12-05 Thread Avi Kivity
On 12/03/2010 12:41 AM, Chris Wright wrote: * Rik van Riel (r...@redhat.com) wrote: > When running SMP virtual machines, it is possible for one VCPU to be > spinning on a spinlock, while the VCPU that holds the spinlock is not > currently running, because the host scheduler preempted it to run

Re: [RFC PATCH 0/3] directed yield for Pause Loop Exiting

2010-12-02 Thread Chris Wright
* Rik van Riel (r...@redhat.com) wrote: > When running SMP virtual machines, it is possible for one VCPU to be > spinning on a spinlock, while the VCPU that holds the spinlock is not > currently running, because the host scheduler preempted it to run > something else. > > Both Intel and AMD CPUs h

[RFC PATCH 0/3] directed yield for Pause Loop Exiting

2010-12-02 Thread Rik van Riel
When running SMP virtual machines, it is possible for one VCPU to be spinning on a spinlock, while the VCPU that holds the spinlock is not currently running, because the host scheduler preempted it to run something else. Both Intel and AMD CPUs have a feature that detects when a virtual CPU is spi