Re: [RFC PATCH v2 1/6] kvm: add device control API

2013-04-04 Thread Gleb Natapov
On Wed, Apr 03, 2013 at 07:39:52PM +0200, Alexander Graf wrote: > > On 03.04.2013, at 19:37, Scott Wood wrote: > > > On 04/03/2013 08:22:37 AM, Alexander Graf wrote: > >> On 03.04.2013, at 04:17, Paul Mackerras wrote: > >> > On Tue, Apr 02, 2013 at 08:19:56PM -0500, Scott Wood wrote: > >> >> On 0

Re: [RFC PATCH v2 1/6] kvm: add device control API

2013-04-03 Thread Scott Wood
On 04/02/2013 09:17:58 PM, Paul Mackerras wrote: On Tue, Apr 02, 2013 at 08:19:56PM -0500, Scott Wood wrote: > On 04/02/2013 08:02:39 PM, Paul Mackerras wrote: > >On Mon, Apr 01, 2013 at 05:47:48PM -0500, Scott Wood wrote: > >> +4.79 KVM_CREATE_DEVICE > >> + > >> +Capability: KVM_CAP_DEVICE_CTRL

Re: [RFC PATCH v2 1/6] kvm: add device control API

2013-04-03 Thread Alexander Graf
On 03.04.2013, at 19:37, Scott Wood wrote: > On 04/03/2013 08:22:37 AM, Alexander Graf wrote: >> On 03.04.2013, at 04:17, Paul Mackerras wrote: >> > On Tue, Apr 02, 2013 at 08:19:56PM -0500, Scott Wood wrote: >> >> On 04/02/2013 08:02:39 PM, Paul Mackerras wrote: >> >>> On Mon, Apr 01, 2013 at 05

Re: [RFC PATCH v2 1/6] kvm: add device control API

2013-04-03 Thread Scott Wood
On 04/03/2013 08:22:37 AM, Alexander Graf wrote: On 03.04.2013, at 04:17, Paul Mackerras wrote: > On Tue, Apr 02, 2013 at 08:19:56PM -0500, Scott Wood wrote: >> On 04/02/2013 08:02:39 PM, Paul Mackerras wrote: >>> On Mon, Apr 01, 2013 at 05:47:48PM -0500, Scott Wood wrote: +4.79 KVM_CREATE

Re: [RFC PATCH v2 1/6] kvm: add device control API

2013-04-03 Thread Alexander Graf
On 03.04.2013, at 04:17, Paul Mackerras wrote: > On Tue, Apr 02, 2013 at 08:19:56PM -0500, Scott Wood wrote: >> On 04/02/2013 08:02:39 PM, Paul Mackerras wrote: >>> On Mon, Apr 01, 2013 at 05:47:48PM -0500, Scott Wood wrote: +4.79 KVM_CREATE_DEVICE + +Capability: KVM_CAP_DEVICE_CTR

Re: [RFC PATCH v2 1/6] kvm: add device control API

2013-04-02 Thread Paul Mackerras
On Tue, Apr 02, 2013 at 08:19:56PM -0500, Scott Wood wrote: > On 04/02/2013 08:02:39 PM, Paul Mackerras wrote: > >On Mon, Apr 01, 2013 at 05:47:48PM -0500, Scott Wood wrote: > >> +4.79 KVM_CREATE_DEVICE > >> + > >> +Capability: KVM_CAP_DEVICE_CTRL > > > >I notice this patch doesn't add this capabil

Re: [RFC PATCH v2 1/6] kvm: add device control API

2013-04-02 Thread tiejun.chen
On 04/03/2013 09:34 AM, Scott Wood wrote: On 04/02/2013 08:28:01 PM, tiejun.chen wrote: On 04/03/2013 01:30 AM, Scott Wood wrote: On 04/02/2013 01:59:57 AM, tiejun.chen wrote: On 04/02/2013 06:47 AM, Scott Wood wrote: diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index ff71541..ed033

Re: [RFC PATCH v2 1/6] kvm: add device control API

2013-04-02 Thread tiejun.chen
On 04/03/2013 01:30 AM, Scott Wood wrote: On 04/02/2013 01:59:57 AM, tiejun.chen wrote: On 04/02/2013 06:47 AM, Scott Wood wrote: diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index ff71541..ed033c0 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c @@ -2158,6 +2158,17 @@ out:

Re: [RFC PATCH v2 1/6] kvm: add device control API

2013-04-02 Thread Scott Wood
On 04/02/2013 08:02:39 PM, Paul Mackerras wrote: On Mon, Apr 01, 2013 at 05:47:48PM -0500, Scott Wood wrote: > Currently, devices that are emulated inside KVM are configured in a > hardcoded manner based on an assumption that any given architecture > only has one way to do it. If there's any nee

Re: [RFC PATCH v2 1/6] kvm: add device control API

2013-04-02 Thread Paul Mackerras
On Mon, Apr 01, 2013 at 05:47:48PM -0500, Scott Wood wrote: > Currently, devices that are emulated inside KVM are configured in a > hardcoded manner based on an assumption that any given architecture > only has one way to do it. If there's any need to access device state, > it is done through infl

Re: [RFC PATCH v2 1/6] kvm: add device control API

2013-04-02 Thread tiejun.chen
On 04/02/2013 06:47 AM, Scott Wood wrote: Currently, devices that are emulated inside KVM are configured in a hardcoded manner based on an assumption that any given architecture only has one way to do it. If there's any need to access device state, it is done through inflexible one-purpose-only

[RFC PATCH v2 1/6] kvm: add device control API

2013-04-01 Thread Scott Wood
Currently, devices that are emulated inside KVM are configured in a hardcoded manner based on an assumption that any given architecture only has one way to do it. If there's any need to access device state, it is done through inflexible one-purpose-only IOCTLs (e.g. KVM_GET/SET_LAPIC). Defining n