Re: [patch] stop passing in global variable as argument to cmos_init()

2008-09-27 Thread Avi Kivity
Jes Sorensen wrote: Hi, Looking through the ia64 code I came across this little gem. At some point someone added a new argument to hw/pc.c:cmos_init() named 'smp_cpus', and then passed in the global variable 'smp_cpus' as the argument. This propagated through to the ia64 code as well. I checke

[patch] stop passing in global variable as argument to cmos_init()

2008-09-26 Thread Jes Sorensen
Hi, Looking through the ia64 code I came across this little gem. At some point someone added a new argument to hw/pc.c:cmos_init() named 'smp_cpus', and then passed in the global variable 'smp_cpus' as the argument. This propagated through to the ia64 code as well. I checked, this isn't present