Re: [patch 02/16] x86: pvclock: make sure rdtsc doesnt speculate out of region

2012-11-01 Thread Gleb Natapov
On Thu, Nov 01, 2012 at 08:21:51PM -0200, Marcelo Tosatti wrote: > On Fri, Nov 02, 2012 at 12:13:54AM +0200, Gleb Natapov wrote: > > On Thu, Nov 01, 2012 at 06:56:11PM -0200, Marcelo Tosatti wrote: > > > On Thu, Nov 01, 2012 at 05:49:51PM +0400, Glauber Costa wrote: > > > > On 11/01/2012 03:48 PM,

Re: [patch 02/16] x86: pvclock: make sure rdtsc doesnt speculate out of region

2012-11-01 Thread Marcelo Tosatti
On Fri, Nov 02, 2012 at 12:13:54AM +0200, Gleb Natapov wrote: > On Thu, Nov 01, 2012 at 06:56:11PM -0200, Marcelo Tosatti wrote: > > On Thu, Nov 01, 2012 at 05:49:51PM +0400, Glauber Costa wrote: > > > On 11/01/2012 03:48 PM, Gleb Natapov wrote: > > > > On Wed, Oct 31, 2012 at 08:46:58PM -0200, Mar

Re: [patch 02/16] x86: pvclock: make sure rdtsc doesnt speculate out of region

2012-11-01 Thread Gleb Natapov
On Thu, Nov 01, 2012 at 06:56:11PM -0200, Marcelo Tosatti wrote: > On Thu, Nov 01, 2012 at 05:49:51PM +0400, Glauber Costa wrote: > > On 11/01/2012 03:48 PM, Gleb Natapov wrote: > > > On Wed, Oct 31, 2012 at 08:46:58PM -0200, Marcelo Tosatti wrote: > > >> Originally from Jeremy Fitzhardinge. > > >>

Re: [patch 02/16] x86: pvclock: make sure rdtsc doesnt speculate out of region

2012-11-01 Thread Marcelo Tosatti
On Thu, Nov 01, 2012 at 05:49:51PM +0400, Glauber Costa wrote: > On 11/01/2012 03:48 PM, Gleb Natapov wrote: > > On Wed, Oct 31, 2012 at 08:46:58PM -0200, Marcelo Tosatti wrote: > >> Originally from Jeremy Fitzhardinge. > >> > >> pvclock_get_time_values, which contains the memory barriers > >> will

Re: [patch 02/16] x86: pvclock: make sure rdtsc doesnt speculate out of region

2012-11-01 Thread Gleb Natapov
On Thu, Nov 01, 2012 at 05:49:51PM +0400, Glauber Costa wrote: > On 11/01/2012 03:48 PM, Gleb Natapov wrote: > > On Wed, Oct 31, 2012 at 08:46:58PM -0200, Marcelo Tosatti wrote: > >> Originally from Jeremy Fitzhardinge. > >> > >> pvclock_get_time_values, which contains the memory barriers > >> will

Re: [patch 02/16] x86: pvclock: make sure rdtsc doesnt speculate out of region

2012-11-01 Thread Glauber Costa
On 11/01/2012 03:48 PM, Gleb Natapov wrote: > On Wed, Oct 31, 2012 at 08:46:58PM -0200, Marcelo Tosatti wrote: >> Originally from Jeremy Fitzhardinge. >> >> pvclock_get_time_values, which contains the memory barriers >> will be removed by next patch. >> >> Signed-off-by: Marcelo Tosatti >> >> Inde

Re: [patch 02/16] x86: pvclock: make sure rdtsc doesnt speculate out of region

2012-11-01 Thread Gleb Natapov
On Wed, Oct 31, 2012 at 08:46:58PM -0200, Marcelo Tosatti wrote: > Originally from Jeremy Fitzhardinge. > > pvclock_get_time_values, which contains the memory barriers > will be removed by next patch. > > Signed-off-by: Marcelo Tosatti > > Index: vsyscall/arch/x86/kernel/pvclock.c > ===

[patch 02/16] x86: pvclock: make sure rdtsc doesnt speculate out of region

2012-10-31 Thread Marcelo Tosatti
Originally from Jeremy Fitzhardinge. pvclock_get_time_values, which contains the memory barriers will be removed by next patch. Signed-off-by: Marcelo Tosatti Index: vsyscall/arch/x86/kernel/pvclock.c === --- vsyscall.orig/arch/x86