Re: [patch 3/3] KVM: PIT: fix injection logic and count

2008-08-12 Thread David S. Ahern
Hi Marcelo: I am seeing erroneous accounting data in RHEL3 guests which I believe I have traced to this patch. The easiest way to see this is to run 'mpstat 1': intr/s is in the 50's (e.g., for a nearly idle guest with negligible disk/network). This is wrong. At a minimum it should be 100 -- 100 t

Re: [patch 3/3] KVM: PIT: fix injection logic and count

2008-07-29 Thread Marcelo Tosatti
On Tue, Jul 29, 2008 at 03:55:26PM +0300, Avi Kivity wrote: > Sometimes the guest leaves the timer enabled but the output pin masked, > (e.g. it doesn't use the timer bug doesn't bother to turn it off > properly). This results in extraneous interrupts, causing unnecessary > vmexits and incre

Re: [patch 3/3] KVM: PIT: fix injection logic and count

2008-07-29 Thread Marcelo Tosatti
Hi Sheng, On Mon, Jul 28, 2008 at 01:56:59PM +0800, Yang, Sheng wrote: > Hi Marcelo > > Thanks for your work! It finally reslove my problem on failing to ack > some injected interrupts. :) > > On Sunday 27 July 2008 04:01:01 Marcelo Tosatti wrote: > > The PIT injection logic is problematic unde

Re: [patch 3/3] KVM: PIT: fix injection logic and count

2008-07-29 Thread Avi Kivity
Marcelo Tosatti wrote: The PIT injection logic is problematic under the following cases: 1) If there is a higher priority vector to be delivered by the time kvm_pit_timer_intr_post is invoked ps->inject_pending won't be set. This opens the possibility for missing many PIT event injections (say

Re: [patch 3/3] KVM: PIT: fix injection logic and count

2008-07-27 Thread Yang, Sheng
Hi Marcelo Thanks for your work! It finally reslove my problem on failing to ack some injected interrupts. :) On Sunday 27 July 2008 04:01:01 Marcelo Tosatti wrote: > The PIT injection logic is problematic under the following cases: > > 1) If there is a higher priority vector to be delivered by

[patch 3/3] KVM: PIT: fix injection logic and count

2008-07-26 Thread Marcelo Tosatti
The PIT injection logic is problematic under the following cases: 1) If there is a higher priority vector to be delivered by the time kvm_pit_timer_intr_post is invoked ps->inject_pending won't be set. This opens the possibility for missing many PIT event injections (say if guest executes hlt at