Re: [patch 3/3] KVM: move postcommit flush to x86, as mmio sptes are x86 specific

2012-08-28 Thread Marcelo Tosatti
On Mon, Aug 27, 2012 at 04:04:44PM +0800, Xiao Guangrong wrote: > On 08/25/2012 02:54 AM, Marcelo Tosatti wrote: > > Other arches do not need this. > > > > Signed-off-by: Marcelo Tosatti > > > > Index: kvm/arch/x86/kvm/x86.c > > ===

Re: [patch 3/3] KVM: move postcommit flush to x86, as mmio sptes are x86 specific

2012-08-28 Thread Marcelo Tosatti
On Tue, Aug 28, 2012 at 09:30:24AM +0900, Takuya Yoshikawa wrote: > On Mon, 27 Aug 2012 16:06:01 -0300 > Marcelo Tosatti wrote: > > > > Any explanation why (old.base_gfn != new.base_gfn) case can be > > > omitted? > > > > (old.base_gfn != new.base_gfn) check covers the cases > > > > 1. old.base

Re: [patch 3/3] KVM: move postcommit flush to x86, as mmio sptes are x86 specific

2012-08-27 Thread Takuya Yoshikawa
On Mon, 27 Aug 2012 16:06:01 -0300 Marcelo Tosatti wrote: > > Any explanation why (old.base_gfn != new.base_gfn) case can be > > omitted? > > (old.base_gfn != new.base_gfn) check covers the cases > > 1. old.base_gfn = 0, new.base_gfn = !0 (slot creation) > > and > > x != 0, y != 0, x != y. >

Re: [patch 3/3] KVM: move postcommit flush to x86, as mmio sptes are x86 specific

2012-08-27 Thread Marcelo Tosatti
On Mon, Aug 27, 2012 at 11:41:08PM +0900, Takuya Yoshikawa wrote: > On Fri, 24 Aug 2012 15:54:59 -0300 > Marcelo Tosatti wrote: > > > Other arches do not need this. > > > > Signed-off-by: Marcelo Tosatti > > > > Index: kvm/arch/x86/kvm/x86.c > >

Re: [patch 3/3] KVM: move postcommit flush to x86, as mmio sptes are x86 specific

2012-08-27 Thread Takuya Yoshikawa
On Fri, 24 Aug 2012 15:54:59 -0300 Marcelo Tosatti wrote: > Other arches do not need this. > > Signed-off-by: Marcelo Tosatti > > Index: kvm/arch/x86/kvm/x86.c > === > --- kvm.orig/arch/x86/kvm/x86.c > +++ kvm/arch/x86/kvm/x86.c >

Re: [patch 3/3] KVM: move postcommit flush to x86, as mmio sptes are x86 specific

2012-08-27 Thread Xiao Guangrong
On 08/25/2012 02:54 AM, Marcelo Tosatti wrote: > Other arches do not need this. > > Signed-off-by: Marcelo Tosatti > > Index: kvm/arch/x86/kvm/x86.c > === > --- kvm.orig/arch/x86/kvm/x86.c > +++ kvm/arch/x86/kvm/x86.c > @@ -6455,6 +

[patch 3/3] KVM: move postcommit flush to x86, as mmio sptes are x86 specific

2012-08-24 Thread Marcelo Tosatti
Other arches do not need this. Signed-off-by: Marcelo Tosatti Index: kvm/arch/x86/kvm/x86.c === --- kvm.orig/arch/x86/kvm/x86.c +++ kvm/arch/x86/kvm/x86.c @@ -6455,6 +6455,14 @@ void kvm_arch_commit_memory_region(struc