RE: Alt SeaBIOS SSDT cpu hotplug

2010-08-05 Thread Liu, Jinsong
Kevin O'Connor wrote: On Tue, Aug 03, 2010 at 05:00:49PM +0800, Liu, Jinsong wrote: I just test your new patch with Windows 2008 DataCenter at my platform, it works OK! We can hot-add new cpus and they appear at Device Manager. (BTW, yesterday I test your new patch with linux 2.6.32 hvm, it

RE: Alt SeaBIOS SSDT cpu hotplug

2010-08-03 Thread Liu, Jinsong
; You, Yongkang Subject: Re: Alt SeaBIOS SSDT cpu hotplug On Mon, Aug 02, 2010 at 07:13:34PM +0300, Avi Kivity wrote: On 08/02/2010 06:55 PM, Kevin O'Connor wrote: On Mon, Aug 02, 2010 at 10:12:31AM +0200, Alexander Graf wrote: On 02.08.2010, at 07:49, Kevin O'Connor wrote: On Mon, Aug 02

Re: Alt SeaBIOS SSDT cpu hotplug

2010-08-03 Thread Kevin O'Connor
On Tue, Aug 03, 2010 at 05:00:49PM +0800, Liu, Jinsong wrote: I just test your new patch with Windows 2008 DataCenter at my platform, it works OK! We can hot-add new cpus and they appear at Device Manager. (BTW, yesterday I test your new patch with linux 2.6.32 hvm, it works fine, we can

Re: Alt SeaBIOS SSDT cpu hotplug

2010-08-02 Thread Alexander Graf
On 02.08.2010, at 07:49, Kevin O'Connor wrote: On Mon, Aug 02, 2010 at 10:41:39AM +0800, Liu, Jinsong wrote: Kevin, This patch still has issue, It can boot Windows 2008 DataCenter, however, when run cpu_set cpu online command, windows 2008 Datacenter system shutdown at once. Thanks for

Re: Alt SeaBIOS SSDT cpu hotplug

2010-08-02 Thread Kevin O'Connor
On Mon, Aug 02, 2010 at 10:12:31AM +0200, Alexander Graf wrote: On 02.08.2010, at 07:49, Kevin O'Connor wrote: On Mon, Aug 02, 2010 at 10:41:39AM +0800, Liu, Jinsong wrote: It seems the Windows acpi interpreter is significantly different from the Linux one. The only guess I have is that

Re: Alt SeaBIOS SSDT cpu hotplug

2010-08-02 Thread Alexander Graf
On 02.08.2010, at 17:55, Kevin O'Connor wrote: On Mon, Aug 02, 2010 at 10:12:31AM +0200, Alexander Graf wrote: On 02.08.2010, at 07:49, Kevin O'Connor wrote: On Mon, Aug 02, 2010 at 10:41:39AM +0800, Liu, Jinsong wrote: It seems the Windows acpi interpreter is significantly different from

Re: Alt SeaBIOS SSDT cpu hotplug

2010-08-02 Thread Alexander Graf
On 02.08.2010, at 18:13, Avi Kivity wrote: On 08/02/2010 06:55 PM, Kevin O'Connor wrote: On Mon, Aug 02, 2010 at 10:12:31AM +0200, Alexander Graf wrote: On 02.08.2010, at 07:49, Kevin O'Connor wrote: On Mon, Aug 02, 2010 at 10:41:39AM +0800, Liu, Jinsong wrote: It seems the Windows acpi

Re: Alt SeaBIOS SSDT cpu hotplug

2010-08-02 Thread Avi Kivity
On 08/02/2010 06:55 PM, Kevin O'Connor wrote: On Mon, Aug 02, 2010 at 10:12:31AM +0200, Alexander Graf wrote: On 02.08.2010, at 07:49, Kevin O'Connor wrote: On Mon, Aug 02, 2010 at 10:41:39AM +0800, Liu, Jinsong wrote: It seems the Windows acpi interpreter is significantly different from the

RE: Alt SeaBIOS SSDT cpu hotplug

2010-08-02 Thread Zheng, Shaohui
SSDT cpu hotplug On Mon, Aug 02, 2010 at 07:13:34PM +0300, Avi Kivity wrote: On 08/02/2010 06:55 PM, Kevin O'Connor wrote: On Mon, Aug 02, 2010 at 10:12:31AM +0200, Alexander Graf wrote: On 02.08.2010, at 07:49, Kevin O'Connor wrote: On Mon, Aug 02, 2010 at 10:41:39AM +0800, Liu, Jinsong

RE: Alt SeaBIOS SSDT cpu hotplug

2010-08-01 Thread Liu, Jinsong
Kevin, This patch still has issue, It can boot Windows 2008 DataCenter, however, when run cpu_set cpu online command, windows 2008 Datacenter system shutdown at once. Thanks, Jinsong Sorry about that. It looks like I messed up the SSDT ScopeOp length. New patch attached below. I've

Re: Alt SeaBIOS SSDT cpu hotplug

2010-08-01 Thread Kevin O'Connor
On Mon, Aug 02, 2010 at 10:41:39AM +0800, Liu, Jinsong wrote: Kevin, This patch still has issue, It can boot Windows 2008 DataCenter, however, when run cpu_set cpu online command, windows 2008 Datacenter system shutdown at once. Thanks for testing. I've inspected the generated DSDT and

RE: Alt SeaBIOS SSDT cpu hotplug

2010-07-30 Thread Liu, Jinsong
Liu, Jinsong wrote: Kevin O'Connor wrote: On Sat, Jul 10, 2010 at 12:41:18AM +0800, Liu, Jinsong wrote: Kevin O'Connor wrote: On Thu, Jul 08, 2010 at 09:19:13PM +0800, Liu, Jinsong wrote: Avi Kivity wrote: Very nice. I thought about doing this but abandoned it as unmaintainable. Using

Re: Alt SeaBIOS SSDT cpu hotplug

2010-07-30 Thread Kevin O'Connor
On Sat, Jul 31, 2010 at 01:22:59AM +0800, Liu, Jinsong wrote: Liu, Jinsong wrote: Kevin O'Connor wrote: On Sat, Jul 10, 2010 at 12:41:18AM +0800, Liu, Jinsong wrote: Kevin O'Connor wrote: I've tested this under linux - there were a few bugs in the previous patch. I also had to replace

Re: Alt SeaBIOS SSDT cpu hotplug

2010-07-24 Thread Kevin O'Connor
On Sat, Jul 10, 2010 at 12:41:18AM +0800, Liu, Jinsong wrote: Kevin O'Connor wrote: On Thu, Jul 08, 2010 at 09:19:13PM +0800, Liu, Jinsong wrote: Avi Kivity wrote: Very nice. I thought about doing this but abandoned it as unmaintainable. Using external functions and the ID variable,

RE: Alt SeaBIOS SSDT cpu hotplug

2010-07-24 Thread Liu, Jinsong
Kevin O'Connor wrote: On Sat, Jul 10, 2010 at 12:41:18AM +0800, Liu, Jinsong wrote: Kevin O'Connor wrote: On Thu, Jul 08, 2010 at 09:19:13PM +0800, Liu, Jinsong wrote: Avi Kivity wrote: Very nice. I thought about doing this but abandoned it as unmaintainable. Using external functions and

Re: Alt SeaBIOS SSDT cpu hotplug

2010-07-11 Thread Kevin O'Connor
On Sat, Jul 10, 2010 at 12:41:18AM +0800, Liu, Jinsong wrote: Kevin O'Connor wrote: I've tested this under linux - there were a few bugs in the previous patch. I also had to replace the dynamically created CPUS array with a dynamically created NTFY method - which is a bit more complicated.

Re: Alt SeaBIOS SSDT cpu hotplug

2010-07-09 Thread Gleb Natapov
On Thu, Jul 08, 2010 at 08:45:06PM -0400, Kevin O'Connor wrote: On Thu, Jul 08, 2010 at 03:54:10PM +0300, Gleb Natapov wrote: On Wed, Jul 07, 2010 at 07:26:07PM -0400, Kevin O'Connor wrote: On Wed, Jul 07, 2010 at 01:22:49PM +0300, Gleb Natapov wrote: On Wed, Jul 07, 2010 at 12:57:05AM

RE: Alt SeaBIOS SSDT cpu hotplug

2010-07-09 Thread Liu, Jinsong
Kevin O'Connor wrote: On Thu, Jul 08, 2010 at 09:19:13PM +0800, Liu, Jinsong wrote: Avi Kivity wrote: Very nice. I thought about doing this but abandoned it as unmaintainable. Using external functions and the ID variable, however, reduces the mess to tolerable proportions, and gains us a

Re: Alt SeaBIOS SSDT cpu hotplug

2010-07-08 Thread Gleb Natapov
On Wed, Jul 07, 2010 at 07:26:07PM -0400, Kevin O'Connor wrote: On Wed, Jul 07, 2010 at 01:22:49PM +0300, Gleb Natapov wrote: On Wed, Jul 07, 2010 at 12:57:05AM -0400, Kevin O'Connor wrote: The CPUS package stores references to the Processor objects, and the CPON package stores the state

RE: Alt SeaBIOS SSDT cpu hotplug

2010-07-08 Thread Liu, Jinsong
Avi Kivity wrote: On 07/07/2010 07:57 AM, Kevin O'Connor wrote: Hi, I've been playing with the cpu hotplug SSDT changes. Attached is a proposal for an alternative method of adding ACPI support. The idea is to continue to build a dynamic SSDT based on CountCPUs and MaxCountCPUs. The

Re: Alt SeaBIOS SSDT cpu hotplug

2010-07-08 Thread Kevin O'Connor
On Thu, Jul 08, 2010 at 03:54:10PM +0300, Gleb Natapov wrote: On Wed, Jul 07, 2010 at 07:26:07PM -0400, Kevin O'Connor wrote: On Wed, Jul 07, 2010 at 01:22:49PM +0300, Gleb Natapov wrote: On Wed, Jul 07, 2010 at 12:57:05AM -0400, Kevin O'Connor wrote: The CPUS package stores references

Re: Alt SeaBIOS SSDT cpu hotplug

2010-07-08 Thread Kevin O'Connor
On Thu, Jul 08, 2010 at 09:19:13PM +0800, Liu, Jinsong wrote: Avi Kivity wrote: Very nice. I thought about doing this but abandoned it as unmaintainable. Using external functions and the ID variable, however, reduces the mess to tolerable proportions, and gains us a lot of flexibility.

Re: Alt SeaBIOS SSDT cpu hotplug

2010-07-07 Thread Avi Kivity
On 07/07/2010 07:57 AM, Kevin O'Connor wrote: Hi, I've been playing with the cpu hotplug SSDT changes. Attached is a proposal for an alternative method of adding ACPI support. The idea is to continue to build a dynamic SSDT based on CountCPUs and MaxCountCPUs. The dynamic SSDT entries just

Re: Alt SeaBIOS SSDT cpu hotplug

2010-07-07 Thread Gleb Natapov
On Wed, Jul 07, 2010 at 12:57:05AM -0400, Kevin O'Connor wrote: Hi, I've been playing with the cpu hotplug SSDT changes. Attached is a proposal for an alternative method of adding ACPI support. The idea is to continue to build a dynamic SSDT based on CountCPUs and MaxCountCPUs. The

Re: Alt SeaBIOS SSDT cpu hotplug

2010-07-07 Thread Kevin O'Connor
On Wed, Jul 07, 2010 at 01:22:49PM +0300, Gleb Natapov wrote: On Wed, Jul 07, 2010 at 12:57:05AM -0400, Kevin O'Connor wrote: The CPUS package stores references to the Processor objects, and the CPON package stores the state of which cpus are active. With this info, hopefully there is no

Alt SeaBIOS SSDT cpu hotplug

2010-07-06 Thread Kevin O'Connor
Hi, I've been playing with the cpu hotplug SSDT changes. Attached is a proposal for an alternative method of adding ACPI support. The idea is to continue to build a dynamic SSDT based on CountCPUs and MaxCountCPUs. The dynamic SSDT entries just call methods in the main DSDT. This is