Re: CPU hotplug add seems broken

2010-01-11 Thread Ryota Ozaki
2010/1/10 Gleb Natapov g...@redhat.com: On Sun, Jan 10, 2010 at 05:33:02PM +0900, Ryota Ozaki wrote: [...] I see. Anyway I think we need some workaround to avoid segfault. Disabling cpu_set command for qemu-kvm-0.12 is good enough workaround. Agree. I'll send a patch. but ACPI code that

Re: CPU hotplug add seems broken

2010-01-11 Thread Gleb Natapov
On Mon, Jan 11, 2010 at 06:24:32PM +0900, Ryota Ozaki wrote: 2010/1/10 Gleb Natapov g...@redhat.com: On Sun, Jan 10, 2010 at 05:33:02PM +0900, Ryota Ozaki wrote: [...] I see. Anyway I think we need some workaround to avoid segfault. Disabling cpu_set command for qemu-kvm-0.12 is good

Re: CPU hotplug add seems broken

2010-01-11 Thread Ryota Ozaki
On Mon, Jan 11, 2010 at 6:32 PM, Gleb Natapov g...@redhat.com wrote: On Mon, Jan 11, 2010 at 06:24:32PM +0900, Ryota Ozaki wrote: 2010/1/10 Gleb Natapov g...@redhat.com: [...] May I ask what do you need it for? Oh sorry, actually I have not so strong desire on cpu hotplug but I have on

Re: CPU hotplug add seems broken

2010-01-11 Thread Avi Kivity
On 01/11/2010 11:24 AM, Ryota Ozaki wrote: The problem is that there is no standard way to hotplug CPUs in a PC. Linux implements the way UNISYS happen to do it, but no other system do it like that. Windows implements it differently and in the way that conflicts with Linux, so you can't have

Re: CPU hotplug add seems broken

2010-01-11 Thread Gleb Natapov
On Mon, Jan 11, 2010 at 12:23:05PM +0200, Avi Kivity wrote: On 01/11/2010 11:24 AM, Ryota Ozaki wrote: The problem is that there is no standard way to hotplug CPUs in a PC. Linux implements the way UNISYS happen to do it, but no other system do it like that. Windows implements it

Re: CPU hotplug add seems broken

2010-01-11 Thread Avi Kivity
On 01/11/2010 12:24 PM, Gleb Natapov wrote: IMO we should stick with the unisys-derived implementation, port it to SeaBIOS, and write a Windows driver for it. It has the advantage of having support in Linux, and of being somewhat tested. That cool, but SVVP complains. What's the

Re: CPU hotplug add seems broken

2010-01-11 Thread Ryota Ozaki
On Mon, Jan 11, 2010 at 7:23 PM, Avi Kivity a...@redhat.com wrote: On 01/11/2010 11:24 AM, Ryota Ozaki wrote: The problem is that there is no standard way to hotplug CPUs in a PC. Linux implements the way UNISYS happen to do it, but no other system do it like that. Windows implements it

Re: CPU hotplug add seems broken

2010-01-11 Thread Gleb Natapov
On Mon, Jan 11, 2010 at 12:25:52PM +0200, Avi Kivity wrote: On 01/11/2010 12:24 PM, Gleb Natapov wrote: IMO we should stick with the unisys-derived implementation, port it to SeaBIOS, and write a Windows driver for it. It has the advantage of having support in Linux, and of being somewhat

Re: CPU hotplug add seems broken

2010-01-11 Thread Avi Kivity
On 01/11/2010 12:42 PM, Gleb Natapov wrote: That cool, but SVVP complains. What's the complaint? Maybe we can fix it instead of rewriting things. https://bugzilla.redhat.com/show_bug.cgi?id=49584://bugzilla.redhat.com/show_bug.cgi?id=495844 Hope it accessible to everyone but

Re: CPU hotplug add seems broken

2010-01-11 Thread Gleb Natapov
On Mon, Jan 11, 2010 at 12:50:05PM +0200, Avi Kivity wrote: On 01/11/2010 12:42 PM, Gleb Natapov wrote: That cool, but SVVP complains. What's the complaint? Maybe we can fix it instead of rewriting things.

Re: CPU hotplug add seems broken

2010-01-11 Thread Avi Kivity
On 01/11/2010 12:53 PM, Gleb Natapov wrote: Anyway all those solution do not guaranty that we will be able to do cpu hotplug on Windows since we don't yet know what Windows expects. I'm sure we'll be able to eventually. Eventually yes, but can you say now that it will not

Re: CPU hotplug add seems broken

2010-01-11 Thread Gleb Natapov
On Mon, Jan 11, 2010 at 12:58:24PM +0200, Avi Kivity wrote: On 01/11/2010 12:53 PM, Gleb Natapov wrote: Anyway all those solution do not guaranty that we will be able to do cpu hotplug on Windows since we don't yet know what Windows expects. I'm sure we'll be able to eventually.

Re: CPU hotplug add seems broken

2010-01-11 Thread Avi Kivity
On 01/11/2010 01:03 PM, Gleb Natapov wrote: No, but I'm not really worried about that. So you want to introduce something that we know upset Windows without looking into alternatives. I don't want to drop support for existing guests unless I have to. And as far as I remember

Re: CPU hotplug add seems broken

2010-01-11 Thread Gleb Natapov
On Mon, Jan 11, 2010 at 01:06:24PM +0200, Avi Kivity wrote: On 01/11/2010 01:03 PM, Gleb Natapov wrote: No, but I'm not really worried about that. So you want to introduce something that we know upset Windows without looking into alternatives. I don't want to drop support for existing

Re: CPU hotplug add seems broken

2010-01-11 Thread Anthony Liguori
On 01/11/2010 04:50 AM, Avi Kivity wrote: On 01/11/2010 12:42 PM, Gleb Natapov wrote: That cool, but SVVP complains. What's the complaint? Maybe we can fix it instead of rewriting things. https://bugzilla.redhat.com/show_bug.cgi?id=49584://bugzilla.redhat.com/show_bug.cgi?id=495844 Hope

Re: CPU hotplug add seems broken

2010-01-11 Thread Avi Kivity
On 01/11/2010 03:57 PM, Anthony Liguori wrote: win2k8 supports CPU hotplug with VMware. I'd suggest someone fire up VMware and dump the ACPI tables to try and see how they're doing it. Otherwise, if someone has a physical machine that is known to do CPU hotplug with win2k8, an acpi dump

Re: CPU hotplug add seems broken

2010-01-10 Thread Gleb Natapov
On Sun, Jan 10, 2010 at 05:33:02PM +0900, Ryota Ozaki wrote: On Sun, Jan 10, 2010 at 3:39 PM, Gleb Natapov g...@redhat.com wrote: On Sat, Jan 09, 2010 at 04:30:11PM -0300, Daniel Bareiro wrote: On Friday, 08 January 2010 19:35:04 +0900, Ryota Ozaki wrote: Hi all, Hi, Ryota.

Re: CPU hotplug add seems broken

2010-01-09 Thread Daniel Bareiro
On Friday, 08 January 2010 19:35:04 +0900, Ryota Ozaki wrote: Hi all, Hi, Ryota. I've tried CPU hotplug with latest qemu-kvm.git code, and got segmentation fault. I'm also having this problem but with Linux 2.6.32.2 + qemu-kvm-0.12.1.1 in the host: Jan 9 16:11:11 ubuntu kernel:

Re: CPU hotplug add seems broken

2010-01-09 Thread Gleb Natapov
On Sat, Jan 09, 2010 at 04:30:11PM -0300, Daniel Bareiro wrote: On Friday, 08 January 2010 19:35:04 +0900, Ryota Ozaki wrote: Hi all, Hi, Ryota. I've tried CPU hotplug with latest qemu-kvm.git code, and got segmentation fault. I'm also having this problem but with Linux 2.6.32.2

CPU hotplug add seems broken

2010-01-08 Thread Ryota Ozaki
Hi all, I've tried CPU hotplug with latest qemu-kvm.git code, and got segmentation fault. Call trace of the qemu-system-x86_64 is like this: (gdb) where #0 0x003cec80c280 in pthread_kill () from /lib64/libpthread.so.0 #1 0x0042fd72 in on_vcpu (env=0x2b24080, func=0x42ffd7