Re: KVM: VMX: remove GUEST_CR3 write from vmx_vcpu_run

2009-10-22 Thread Avi Kivity
On 10/22/2009 09:35 AM, Sheng Yang wrote: On Tuesday 20 October 2009 20:37:20 Marcelo Tosatti wrote: GUEST_CR3 is updated via kvm_set_cr3 whenever CR3 value changes. The description is not that accuracy... If CR3 value change in guest when EPT enabled, no VM Exit would happen, then no

Re: KVM: VMX: remove GUEST_CR3 write from vmx_vcpu_run

2009-10-22 Thread Sheng Yang
On Tuesday 20 October 2009 20:37:20 Marcelo Tosatti wrote: > GUEST_CR3 is updated via kvm_set_cr3 whenever CR3 value > changes. The description is not that accuracy... If CR3 value change in guest when EPT enabled, no VM Exit would happen, then no kvm_set_cr3... -- regards Yang, Sheng > > Sign

Re: KVM: VMX: remove GUEST_CR3 write from vmx_vcpu_run

2009-10-22 Thread Avi Kivity
On 10/20/2009 04:59 PM, Marcelo Tosatti wrote: Nice. Any reason why ept_load_pdptrs() couldn't go the same way? Its already protected by VCPU_EXREG_PDPTR caching, so it does not buy much. The advantage would symmetry to cr3. Yes, the PDPTRs fulfil exactly the same role as cr

Re: KVM: VMX: remove GUEST_CR3 write from vmx_vcpu_run

2009-10-20 Thread Marcelo Tosatti
On Tue, Oct 20, 2009 at 10:14:52PM +0900, Avi Kivity wrote: > On 10/20/2009 09:37 PM, Marcelo Tosatti wrote: >> GUEST_CR3 is updated via kvm_set_cr3 whenever CR3 value >> changes. >> >> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c >> index 364263a..325075f 100644 >> --- a/arch/x86/kvm/vmx.c

Re: KVM: VMX: remove GUEST_CR3 write from vmx_vcpu_run

2009-10-20 Thread Avi Kivity
On 10/20/2009 09:37 PM, Marcelo Tosatti wrote: GUEST_CR3 is updated via kvm_set_cr3 whenever CR3 value changes. diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c index 364263a..325075f 100644 --- a/arch/x86/kvm/vmx.c +++ b/arch/x86/kvm/vmx.c @@ -3638,10 +3638,9 @@ static void vmx_vcpu_run(str

KVM: VMX: remove GUEST_CR3 write from vmx_vcpu_run

2009-10-20 Thread Marcelo Tosatti
GUEST_CR3 is updated via kvm_set_cr3 whenever CR3 value changes. Signed-off-by: Marcelo Tosatti diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c index 364263a..325075f 100644 --- a/arch/x86/kvm/vmx.c +++ b/arch/x86/kvm/vmx.c @@ -3638,10 +3638,9 @@ static void vmx_vcpu_run(struct kvm_vcpu *v