RE: [PATCH] KVM: arm64: Decode basic HYP fault information

2015-08-31 Thread Pavel Fedin
Hello! > Fundamentally what's changed is that you now run more custom code in C > code. Yes, but it doesn't do anything super-dupper, just decodes some values into a human-readable form. and i forgot this note... >> - >> -.align 3 >> -2: .quad HYP_PAGE_OFFSET >> -.quad PAGE_OF

Re: [PATCH] KVM: arm64: Decode basic HYP fault information

2015-08-31 Thread Christoffer Dall
On Mon, Aug 31, 2015 at 09:33:40AM +0300, Pavel Fedin wrote: > Hello! > > > my overall concern with this patch is that it adds complexity to an > > already really bad situation, and potentially increases the likelihood > > of not seeing any debug info at all. > > Why? In this case we currently

RE: [PATCH] KVM: arm64: Decode basic HYP fault information

2015-08-30 Thread Pavel Fedin
Hello! > my overall concern with this patch is that it adds complexity to an > already really bad situation, and potentially increases the likelihood > of not seeing any debug info at all. Why? In this case we currently already drop into C code. I do the same, with some more useful printout. W

Re: [PATCH] KVM: arm64: Decode basic HYP fault information

2015-08-30 Thread Christoffer Dall
On Tue, Aug 11, 2015 at 10:34:07AM +0300, Pavel Fedin wrote: > Print exception vector name, exception class and PC translated to EL1 virtual > address. Significantly aids debugging HYP crashes without special means like > JTAG. my overall concern with this patch is that it adds complexity to an al