RE: [PATCH] KVM: ia64: define kvm_lapic_enabled() to fix a compile error

2010-09-29 Thread Zhang, Xiantao
Avi Kivity wrote: On 09/27/2010 12:01 PM, Zhang, Xiantao wrote: Maybe we should make ia64 kvm depend on CONFIG_BROKEN. It has been experimental for quite a while. I don't think the kvm/ia64 is broken in the upstream Linux, and it should work according to our last try. When was

Re: [PATCH] KVM: ia64: define kvm_lapic_enabled() to fix a compile error

2010-09-28 Thread Avi Kivity
On 09/27/2010 12:01 PM, Zhang, Xiantao wrote: Maybe we should make ia64 kvm depend on CONFIG_BROKEN. It has been experimental for quite a while. I don't think the kvm/ia64 is broken in the upstream Linux, and it should work according to our last try. When was that? The big issue

Re: [PATCH] KVM: ia64: define kvm_lapic_enabled() to fix a compile error

2010-09-27 Thread Takuya Yoshikawa
(2010/09/02 17:57), Avi Kivity wrote: On 09/02/2010 11:55 AM, Takuya Yoshikawa wrote: The following patch commit 57ce1659316f4ca298919649f9b1b55862ac3826 KVM: x86: In DM_LOWEST, only deliver interrupts to vcpus with enabled LAPIC's ignored the fact that kvm_irq_delivery_to_apic() was also

Re: [PATCH] KVM: ia64: define kvm_lapic_enabled() to fix a compile error

2010-09-27 Thread Avi Kivity
On 09/27/2010 08:51 AM, Takuya Yoshikawa wrote: (2010/09/02 17:57), Avi Kivity wrote: On 09/02/2010 11:55 AM, Takuya Yoshikawa wrote: The following patch commit 57ce1659316f4ca298919649f9b1b55862ac3826 KVM: x86: In DM_LOWEST, only deliver interrupts to vcpus with enabled LAPIC's ignored

Re: [PATCH] KVM: ia64: define kvm_lapic_enabled() to fix a compile error

2010-09-27 Thread Alexander Graf
On 27.09.2010, at 11:49, Avi Kivity wrote: On 09/27/2010 08:51 AM, Takuya Yoshikawa wrote: (2010/09/02 17:57), Avi Kivity wrote: On 09/02/2010 11:55 AM, Takuya Yoshikawa wrote: The following patch commit 57ce1659316f4ca298919649f9b1b55862ac3826 KVM: x86: In DM_LOWEST, only deliver

RE: [PATCH] KVM: ia64: define kvm_lapic_enabled() to fix a compile error

2010-09-27 Thread Zhang, Xiantao
Avi Kivity wrote: On 09/27/2010 08:51 AM, Takuya Yoshikawa wrote: (2010/09/02 17:57), Avi Kivity wrote: On 09/02/2010 11:55 AM, Takuya Yoshikawa wrote: The following patch commit 57ce1659316f4ca298919649f9b1b55862ac3826 KVM: x86: In DM_LOWEST, only deliver interrupts to vcpus with

Re: [PATCH] KVM: ia64: define kvm_lapic_enabled() to fix a compile error

2010-09-27 Thread Takuya Yoshikawa
Hi, Isn't this a candidate for 2.6.36? Though ia64 kvm is in experimental stage and may not be working now, compile errors may be bad for other people who just want to compile ia64 linux. Maybe we should make ia64 kvm depend on CONFIG_BROKEN. It has been experimental for quite a while. I

Re: [PATCH] KVM: ia64: define kvm_lapic_enabled() to fix a compile error

2010-09-02 Thread Avi Kivity
On 09/02/2010 11:55 AM, Takuya Yoshikawa wrote: The following patch commit 57ce1659316f4ca298919649f9b1b55862ac3826 KVM: x86: In DM_LOWEST, only deliver interrupts to vcpus with enabled LAPIC's ignored the fact that kvm_irq_delivery_to_apic() was also used by ia64. We define