Re: [PATCH 2/2] Detect vGIC presence at runtime

2015-07-09 Thread Christoffer Dall
On Tue, Jul 07, 2015 at 02:11:01PM +0300, Pavel Fedin wrote: Allows to use KVM on hardware without vGIC. Interrupt controller has to be emulated in userspace in this case. Signed-off-by: Pavel Fedin p.fe...@samsung.com --- arch/arm/kvm/arm.c | 19 ++- 1 file changed, 18

RE: [PATCH 2/2] Detect vGIC presence at runtime

2015-07-09 Thread Pavel Fedin
Hello! why not report ENXIO as an error? If probing the vgic fails due to being unable to request the irq or something similar, then surely your system has and error and this should be reported. It is reported by probe function itself. -ENODEV here means there's no GIC at all. -ENXIO

Re: [PATCH 2/2] Detect vGIC presence at runtime

2015-07-09 Thread Christoffer Dall
On Thu, Jul 09, 2015 at 03:50:49PM +0300, Pavel Fedin wrote: Hello! why not report ENXIO as an error? If probing the vgic fails due to being unable to request the irq or something similar, then surely your system has and error and this should be reported. It is reported by probe

RE: [PATCH 2/2] Detect vGIC presence at runtime

2015-07-09 Thread Pavel Fedin
center Russia -Original Message- From: Christoffer Dall [mailto:christoffer.d...@linaro.org] Sent: Thursday, July 09, 2015 4:25 PM To: Pavel Fedin Cc: kvm...@lists.cs.columbia.edu; kvm@vger.kernel.org; 'Marc Zyngier' Subject: Re: [PATCH 2/2] Detect vGIC presence at runtime On Thu