RE: [PATCH 2/3] KVM: nVMX: Fix fail to get nested ack intr's vector during nested vmexit

2014-07-17 Thread Zhang, Yang Z
Paolo Bonzini wrote on 2014-07-17: Il 17/07/2014 06:56, Wanpeng Li ha scritto: nested_exit_intr_ack_set(vcpu)) { int irq = kvm_cpu_get_interrupt(vcpu); + +if (irq 0 kvm_apic_vid_enabled(vcpu-kvm)) +irq = kvm_get_apic_interrupt(vcpu);

Re: [PATCH 2/3] KVM: nVMX: Fix fail to get nested ack intr's vector during nested vmexit

2014-07-17 Thread Paolo Bonzini
Il 17/07/2014 06:56, Wanpeng Li ha scritto: nested_exit_intr_ack_set(vcpu)) { int irq = kvm_cpu_get_interrupt(vcpu); + + if (irq 0 kvm_apic_vid_enabled(vcpu-kvm)) + irq = kvm_get_apic_interrupt(vcpu); There's something weird in

Re: [PATCH 2/3] KVM: nVMX: Fix fail to get nested ack intr's vector during nested vmexit

2014-07-17 Thread Wanpeng Li
On Thu, Jul 17, 2014 at 09:13:56AM +, Zhang, Yang Z wrote: Paolo Bonzini wrote on 2014-07-17: Il 17/07/2014 06:56, Wanpeng Li ha scritto: nested_exit_intr_ack_set(vcpu)) { int irq = kvm_cpu_get_interrupt(vcpu); + + if (irq 0 kvm_apic_vid_enabled(vcpu-kvm))

Re: [PATCH 2/3] KVM: nVMX: Fix fail to get nested ack intr's vector during nested vmexit

2014-07-17 Thread Wanpeng Li
On Thu, Jul 17, 2014 at 09:13:56AM +, Zhang, Yang Z wrote: Paolo Bonzini wrote on 2014-07-17: Il 17/07/2014 06:56, Wanpeng Li ha scritto: nested_exit_intr_ack_set(vcpu)) { int irq = kvm_cpu_get_interrupt(vcpu); + + if (irq 0 kvm_apic_vid_enabled(vcpu-kvm))

Re: [PATCH 2/3] KVM: nVMX: Fix fail to get nested ack intr's vector during nested vmexit

2014-07-17 Thread Paolo Bonzini
Il 17/07/2014 12:01, Wanpeng Li ha scritto: That is my original proposal solution of this bug. However, what I concern after more think is since kvm_lapic_find_highest_irr will not clear irr, if the intr will be injected by kvm_86_ops-hwapic_irr_update(vcpu, kvm_lapic_find_highest_irr(vcpu))

RE: [PATCH 2/3] KVM: nVMX: Fix fail to get nested ack intr's vector during nested vmexit

2014-07-16 Thread Zhang, Yang Z
Wanpeng Li wrote on 2014-07-17: WARNING: CPU: 9 PID: 7251 at arch/x86/kvm/vmx.c:8719 nested_vmx_vmexit+0xa4/0x233 [kvm_intel]() Modules linked in: tun nfsv3 nfs_acl auth_rpcgss oid_registry nfsv4 dns_resolver nfs fscache lockd sunrpc pci_stub netconsole kvm_intel kvm bridge stp llc autofs4