Re: [PATCH v2 5/8] KVM: nVMX: Fix guest CR3 read-back on VM-exit

2013-08-07 Thread Gleb Natapov
On Tue, Aug 06, 2013 at 05:57:02PM +0200, Jan Kiszka wrote: On 2013-08-06 17:53, Gleb Natapov wrote: On Tue, Aug 06, 2013 at 05:48:54PM +0200, Jan Kiszka wrote: On 2013-08-06 17:04, Zhang, Yang Z wrote: Gleb Natapov wrote on 2013-08-06: On Tue, Aug 06, 2013 at 02:12:51PM +, Zhang,

Re: [PATCH v2 5/8] KVM: nVMX: Fix guest CR3 read-back on VM-exit

2013-08-07 Thread Jan Kiszka
On 2013-08-07 14:39, Gleb Natapov wrote: On Tue, Aug 06, 2013 at 05:57:02PM +0200, Jan Kiszka wrote: On 2013-08-06 17:53, Gleb Natapov wrote: On Tue, Aug 06, 2013 at 05:48:54PM +0200, Jan Kiszka wrote: On 2013-08-06 17:04, Zhang, Yang Z wrote: Gleb Natapov wrote on 2013-08-06: On Tue, Aug

Re: [PATCH v2 5/8] KVM: nVMX: Fix guest CR3 read-back on VM-exit

2013-08-07 Thread Paolo Bonzini
On 08/07/2013 02:46 PM, Jan Kiszka wrote: On 2013-08-07 14:39, Gleb Natapov wrote: On Tue, Aug 06, 2013 at 05:57:02PM +0200, Jan Kiszka wrote: On 2013-08-06 17:53, Gleb Natapov wrote: On Tue, Aug 06, 2013 at 05:48:54PM +0200, Jan Kiszka wrote: On 2013-08-06 17:04, Zhang, Yang Z wrote: Gleb

Re: [PATCH v2 5/8] KVM: nVMX: Fix guest CR3 read-back on VM-exit

2013-08-07 Thread Gleb Natapov
On Wed, Aug 07, 2013 at 03:32:37PM +0200, Paolo Bonzini wrote: diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c index 44494ed..60a3644 100644 --- a/arch/x86/kvm/vmx.c +++ b/arch/x86/kvm/vmx.c @@ -3375,8 +3375,10 @@ static void vmx_set_cr3(struct kvm_vcpu *vcpu, unsigned long cr3)

Re: [PATCH v2 5/8] KVM: nVMX: Fix guest CR3 read-back on VM-exit

2013-08-07 Thread Paolo Bonzini
On 08/07/2013 03:38 PM, Gleb Natapov wrote: On Wed, Aug 07, 2013 at 03:32:37PM +0200, Paolo Bonzini wrote: diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c index 44494ed..60a3644 100644 --- a/arch/x86/kvm/vmx.c +++ b/arch/x86/kvm/vmx.c @@ -3375,8 +3375,10 @@ static void vmx_set_cr3(struct

Re: [PATCH v2 5/8] KVM: nVMX: Fix guest CR3 read-back on VM-exit

2013-08-07 Thread Jan Kiszka
On 2013-08-07 15:54, Paolo Bonzini wrote: On 08/07/2013 03:38 PM, Gleb Natapov wrote: On Wed, Aug 07, 2013 at 03:32:37PM +0200, Paolo Bonzini wrote: diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c index 44494ed..60a3644 100644 --- a/arch/x86/kvm/vmx.c +++ b/arch/x86/kvm/vmx.c @@

Re: [PATCH v2 5/8] KVM: nVMX: Fix guest CR3 read-back on VM-exit

2013-08-06 Thread Gleb Natapov
On Tue, Aug 06, 2013 at 10:39:59AM +0200, Jan Kiszka wrote: From: Jan Kiszka jan.kis...@siemens.com If nested EPT is enabled, the L2 guest may change CR3 without any exits. We therefore have to read the current value from the VMCS when switching to L1. However, if paging wasn't enabled, L0

Re: [PATCH v2 5/8] KVM: nVMX: Fix guest CR3 read-back on VM-exit

2013-08-06 Thread Jan Kiszka
On 2013-08-06 12:12, Gleb Natapov wrote: On Tue, Aug 06, 2013 at 10:39:59AM +0200, Jan Kiszka wrote: From: Jan Kiszka jan.kis...@siemens.com If nested EPT is enabled, the L2 guest may change CR3 without any exits. We therefore have to read the current value from the VMCS when switching to

Re: [PATCH v2 5/8] KVM: nVMX: Fix guest CR3 read-back on VM-exit

2013-08-06 Thread Gleb Natapov
On Tue, Aug 06, 2013 at 12:25:55PM +0200, Jan Kiszka wrote: On 2013-08-06 12:12, Gleb Natapov wrote: On Tue, Aug 06, 2013 at 10:39:59AM +0200, Jan Kiszka wrote: From: Jan Kiszka jan.kis...@siemens.com If nested EPT is enabled, the L2 guest may change CR3 without any exits. We therefore

Re: [PATCH v2 5/8] KVM: nVMX: Fix guest CR3 read-back on VM-exit

2013-08-06 Thread Gleb Natapov
On Tue, Aug 06, 2013 at 01:31:03PM +0300, Gleb Natapov wrote: On Tue, Aug 06, 2013 at 12:25:55PM +0200, Jan Kiszka wrote: On 2013-08-06 12:12, Gleb Natapov wrote: On Tue, Aug 06, 2013 at 10:39:59AM +0200, Jan Kiszka wrote: From: Jan Kiszka jan.kis...@siemens.com If nested EPT is

RE: [PATCH v2 5/8] KVM: nVMX: Fix guest CR3 read-back on VM-exit

2013-08-06 Thread Zhang, Yang Z
Gleb Natapov wrote on 2013-08-06: On Tue, Aug 06, 2013 at 10:39:59AM +0200, Jan Kiszka wrote: From: Jan Kiszka jan.kis...@siemens.com If nested EPT is enabled, the L2 guest may change CR3 without any exits. We therefore have to read the current value from the VMCS when switching to L1.

Re: [PATCH v2 5/8] KVM: nVMX: Fix guest CR3 read-back on VM-exit

2013-08-06 Thread Gleb Natapov
On Tue, Aug 06, 2013 at 11:44:41AM +, Zhang, Yang Z wrote: Gleb Natapov wrote on 2013-08-06: On Tue, Aug 06, 2013 at 10:39:59AM +0200, Jan Kiszka wrote: From: Jan Kiszka jan.kis...@siemens.com If nested EPT is enabled, the L2 guest may change CR3 without any exits. We therefore

RE: [PATCH v2 5/8] KVM: nVMX: Fix guest CR3 read-back on VM-exit

2013-08-06 Thread Zhang, Yang Z
Gleb Natapov wrote on 2013-08-06: On Tue, Aug 06, 2013 at 11:44:41AM +, Zhang, Yang Z wrote: Gleb Natapov wrote on 2013-08-06: On Tue, Aug 06, 2013 at 10:39:59AM +0200, Jan Kiszka wrote: From: Jan Kiszka jan.kis...@siemens.com If nested EPT is enabled, the L2 guest may change CR3

Re: [PATCH v2 5/8] KVM: nVMX: Fix guest CR3 read-back on VM-exit

2013-08-06 Thread Gleb Natapov
On Tue, Aug 06, 2013 at 02:12:51PM +, Zhang, Yang Z wrote: Gleb Natapov wrote on 2013-08-06: On Tue, Aug 06, 2013 at 11:44:41AM +, Zhang, Yang Z wrote: Gleb Natapov wrote on 2013-08-06: On Tue, Aug 06, 2013 at 10:39:59AM +0200, Jan Kiszka wrote: From: Jan Kiszka

RE: [PATCH v2 5/8] KVM: nVMX: Fix guest CR3 read-back on VM-exit

2013-08-06 Thread Zhang, Yang Z
Gleb Natapov wrote on 2013-08-06: On Tue, Aug 06, 2013 at 02:12:51PM +, Zhang, Yang Z wrote: Gleb Natapov wrote on 2013-08-06: On Tue, Aug 06, 2013 at 11:44:41AM +, Zhang, Yang Z wrote: Gleb Natapov wrote on 2013-08-06: On Tue, Aug 06, 2013 at 10:39:59AM +0200, Jan Kiszka wrote:

Re: [PATCH v2 5/8] KVM: nVMX: Fix guest CR3 read-back on VM-exit

2013-08-06 Thread Jan Kiszka
On 2013-08-06 17:04, Zhang, Yang Z wrote: Gleb Natapov wrote on 2013-08-06: On Tue, Aug 06, 2013 at 02:12:51PM +, Zhang, Yang Z wrote: Gleb Natapov wrote on 2013-08-06: On Tue, Aug 06, 2013 at 11:44:41AM +, Zhang, Yang Z wrote: Gleb Natapov wrote on 2013-08-06: On Tue, Aug 06, 2013

Re: [PATCH v2 5/8] KVM: nVMX: Fix guest CR3 read-back on VM-exit

2013-08-06 Thread Gleb Natapov
On Tue, Aug 06, 2013 at 05:48:54PM +0200, Jan Kiszka wrote: On 2013-08-06 17:04, Zhang, Yang Z wrote: Gleb Natapov wrote on 2013-08-06: On Tue, Aug 06, 2013 at 02:12:51PM +, Zhang, Yang Z wrote: Gleb Natapov wrote on 2013-08-06: On Tue, Aug 06, 2013 at 11:44:41AM +, Zhang, Yang Z

Re: [PATCH v2 5/8] KVM: nVMX: Fix guest CR3 read-back on VM-exit

2013-08-06 Thread Jan Kiszka
On 2013-08-06 17:53, Gleb Natapov wrote: On Tue, Aug 06, 2013 at 05:48:54PM +0200, Jan Kiszka wrote: On 2013-08-06 17:04, Zhang, Yang Z wrote: Gleb Natapov wrote on 2013-08-06: On Tue, Aug 06, 2013 at 02:12:51PM +, Zhang, Yang Z wrote: Gleb Natapov wrote on 2013-08-06: On Tue, Aug 06,