Re: [PATCH v3] KVM: nVMX: nested TPR shadow/threshold emulation

2014-08-07 Thread Wanpeng Li
Hi Paolo, On Wed, Aug 06, 2014 at 06:38:06AM +, Zhang, Yang Z wrote: [...] + + if (exec_control CPU_BASED_TPR_SHADOW) { + if (vmx-nested.virtual_apic_page) + nested_release_page(vmx-nested.virtual_apic_page); + vmx-nested.virtual_apic_page = +

Re: [PATCH v3] KVM: nVMX: nested TPR shadow/threshold emulation

2014-08-07 Thread Paolo Bonzini
Il 06/08/2014 08:38, Zhang, Yang Z ha scritto: Paolo Bonzini wrote on 2014-08-05: Il 05/08/2014 09:56, Zhang, Yang Z ha scritto: Wanpeng Li wrote on 2014-08-04: This patch fix bug https://bugzilla.kernel.org/show_bug.cgi?id=61411 TPR shadow/threshold feature is important to speed up the

RE: [PATCH v3] KVM: nVMX: nested TPR shadow/threshold emulation

2014-08-06 Thread Zhang, Yang Z
Paolo Bonzini wrote on 2014-08-05: Il 05/08/2014 09:56, Zhang, Yang Z ha scritto: Wanpeng Li wrote on 2014-08-04: This patch fix bug https://bugzilla.kernel.org/show_bug.cgi?id=61411 TPR shadow/threshold feature is important to speed up the Windows guest. Besides, it is a must feature for

RE: [PATCH v3] KVM: nVMX: nested TPR shadow/threshold emulation

2014-08-05 Thread Zhang, Yang Z
Wanpeng Li wrote on 2014-08-04: This patch fix bug https://bugzilla.kernel.org/show_bug.cgi?id=61411 TPR shadow/threshold feature is important to speed up the Windows guest. Besides, it is a must feature for certain VMM. We map virtual APIC page address and TPR threshold from L1 VMCS. If

Re: [PATCH v3] KVM: nVMX: nested TPR shadow/threshold emulation

2014-08-05 Thread Paolo Bonzini
Il 05/08/2014 09:56, Zhang, Yang Z ha scritto: Wanpeng Li wrote on 2014-08-04: This patch fix bug https://bugzilla.kernel.org/show_bug.cgi?id=61411 TPR shadow/threshold feature is important to speed up the Windows guest. Besides, it is a must feature for certain VMM. We map virtual APIC

Re: [PATCH v3] KVM: nVMX: nested TPR shadow/threshold emulation

2014-08-04 Thread Paolo Bonzini
Il 04/08/2014 12:58, Wanpeng Li ha scritto: This patch fix bug https://bugzilla.kernel.org/show_bug.cgi?id=61411 TPR shadow/threshold feature is important to speed up the Windows guest. Besides, it is a must feature for certain VMM. We map virtual APIC page address and TPR threshold from