Re: [RFC PATCH v9 12/16] Add mp(mediate passthru) device.

2010-09-20 Thread xiaohui . xin
From: Xin Xiaohui --- Michael, I have move the ioctl to configure the locked memory to vhost and check the limit with mm->locked_vm. please have a look. Thanks Xiaohui drivers/vhost/mpassthru.c | 74 +-- drivers/vhost/net.c | 78 ++

Re: [RFC PATCH v9 12/16] Add mp(mediate passthru) device.

2010-09-20 Thread Michael S. Tsirkin
On Mon, Sep 20, 2010 at 04:08:48PM +0800, xiaohui@intel.com wrote: > From: Xin Xiaohui > > --- > Michael, > I have move the ioctl to configure the locked memory to vhost It's ok to move this to vhost but vhost does not know how much memory is needed by the backend. So I think we'll need anot

RE: [RFC PATCH v9 12/16] Add mp(mediate passthru) device.

2010-09-20 Thread Xin, Xiaohui
l.com >Subject: Re: [RFC PATCH v9 12/16] Add mp(mediate passthru) device. > >On Mon, Sep 20, 2010 at 04:08:48PM +0800, xiaohui@intel.com wrote: >> From: Xin Xiaohui >> >> --- >> Michael, >> I have move the ioctl to configure the locked memory to vhost > >

Re: [RFC PATCH v9 12/16] Add mp(mediate passthru) device.

2010-09-21 Thread Michael S. Tsirkin
rnel.org; > >mi...@elte.hu; da...@davemloft.net; herb...@gondor.hengli.com.au; > >jd...@linux.intel.com > >Subject: Re: [RFC PATCH v9 12/16] Add mp(mediate passthru) device. > > > >On Mon, Sep 20, 2010 at 04:08:48PM +0800, xiaohui@intel.com wrote: > >> From: Xin Xiaohui

RE: [RFC PATCH v9 12/16] Add mp(mediate passthru) device.

2010-09-22 Thread Xin, Xiaohui
hengli.com.au; >jd...@linux.intel.com >Subject: Re: [RFC PATCH v9 12/16] Add mp(mediate passthru) device. > >On Tue, Sep 21, 2010 at 09:39:31AM +0800, Xin, Xiaohui wrote: >> >From: Michael S. Tsirkin [mailto:m...@redhat.com] >> >Sent: Monday, September 20, 2010 7:37 PM >>

Re: [RFC PATCH v9 12/16] Add mp(mediate passthru) device.

2010-09-22 Thread Michael S. Tsirkin
gt; >linux-ker...@vger.kernel.org; > >mi...@elte.hu; da...@davemloft.net; herb...@gondor.hengli.com.au; > >jd...@linux.intel.com > >Subject: Re: [RFC PATCH v9 12/16] Add mp(mediate passthru) device. > > > >On Tue, Sep 21, 2010 at 09:39:31AM +0800, Xin, Xiaohui wrote:

RE: [RFC PATCH v9 12/16] Add mp(mediate passthru) device.

2010-09-23 Thread Xin, Xiaohui
hengli.com.au; >jd...@linux.intel.com >Subject: Re: [RFC PATCH v9 12/16] Add mp(mediate passthru) device. > >On Wed, Sep 22, 2010 at 07:41:36PM +0800, Xin, Xiaohui wrote: >> >-Original Message- >> >From: Michael S. Tsirkin [mailto:m...@redhat.com] >> >Sent:

Re: [RFC PATCH v9 12/16] Add mp(mediate passthru) device.

2010-09-26 Thread Michael S. Tsirkin
gt; >linux-ker...@vger.kernel.org; > >mi...@elte.hu; da...@davemloft.net; herb...@gondor.hengli.com.au; > >jd...@linux.intel.com > >Subject: Re: [RFC PATCH v9 12/16] Add mp(mediate passthru) device. > > > >On Wed, Sep 22, 2010 at 07:41:36PM +0800, Xin, Xiaohui wrot

RE: [RFC PATCH v9 12/16] Add mp(mediate passthru) device.

2010-09-26 Thread Xin, Xiaohui
PM >> >To: Xin, Xiaohui >> >Cc: net...@vger.kernel.org; kvm@vger.kernel.org; >> >linux-ker...@vger.kernel.org; >> >mi...@elte.hu; da...@davemloft.net; herb...@gondor.hengli.com.au; >> >jd...@linux.intel.com >> >Subject: Re: [RFC PATCH v9 1

Re: [RFC PATCH v9 12/16] Add mp(mediate passthru) device.

2010-09-06 Thread Michael S. Tsirkin
So - does this driver help reduce service demand signifiantly? Some comments from looking at the code: On Fri, Aug 06, 2010 at 05:23:41PM +0800, xiaohui@intel.com wrote: > +static struct page_info *alloc_page_info(struct page_ctor *ctor, > + struct kiocb *iocb, struct iovec *iov, >

RE: [RFC PATCH v9 12/16] Add mp(mediate passthru) device.

2010-09-10 Thread Xin, Xiaohui
Michael, Sorry to reply the mail late. >So - does this driver help reduce service demand signifiantly? I'm looking at the performance now. >Some comments from looking at the code: > >On Fri, Aug 06, 2010 at 05:23:41PM +0800, xiaohui@intel.com wrote: >> +static struct page_info *alloc_page_in

RE: [RFC PATCH v9 12/16] Add mp(mediate passthru) device.

2010-09-11 Thread Xin, Xiaohui
>>Playing with rlimit on data path, transparently to the application in this way >>looks strange to me, I suspect this has unexpected security implications. >>Further, applications may have other uses for locked memory >>besides mpassthru - you should not just take it because it's there. >> >>Can w

RE: [RFC PATCH v9 12/16] Add mp(mediate passthru) device.

2010-09-11 Thread Xin, Xiaohui
>>> + >>> + if (ctor->lock_pages + count > lock_limit && npages) { >>> + printk(KERN_INFO "exceed the locked memory rlimit."); >>> + return NULL; >>> + } >>> + >>> + info = kmem_cache_zalloc(ext_page_info_cache, GFP_KERNEL); >> >>You seem to fill in all memory, why zalloc?

Re: [RFC PATCH v9 12/16] Add mp(mediate passthru) device.

2010-09-12 Thread Michael S. Tsirkin
On Sat, Sep 11, 2010 at 03:41:14PM +0800, Xin, Xiaohui wrote: > >>Playing with rlimit on data path, transparently to the application in this > >>way > >>looks strange to me, I suspect this has unexpected security implications. > >>Further, applications may have other uses for locked memory > >>bes

RE: [RFC PATCH v9 12/16] Add mp(mediate passthru) device.

2010-09-14 Thread Xin, Xiaohui
l.com >Subject: Re: [RFC PATCH v9 12/16] Add mp(mediate passthru) device. > >On Sat, Sep 11, 2010 at 03:41:14PM +0800, Xin, Xiaohui wrote: >> >>Playing with rlimit on data path, transparently to the application in this >> >>way >> >>looks strange to me, I

Re: [RFC PATCH v9 12/16] Add mp(mediate passthru) device.

2010-09-15 Thread Michael S. Tsirkin
rnel.org; > >mi...@elte.hu; da...@davemloft.net; herb...@gondor.hengli.com.au; > >jd...@linux.intel.com > >Subject: Re: [RFC PATCH v9 12/16] Add mp(mediate passthru) device. > > > >On Sat, Sep 11, 2010 at 03:41:14PM +0800, Xin, Xiaohui wrote: > >> >>Playing wit

RE: [RFC PATCH v9 12/16] Add mp(mediate passthru) device.

2010-09-16 Thread Xin, Xiaohui
ui >> >Cc: net...@vger.kernel.org; kvm@vger.kernel.org; >> >linux-ker...@vger.kernel.org; >> >mi...@elte.hu; da...@davemloft.net; herb...@gondor.hengli.com.au; >> >jd...@linux.intel.com >> >Subject: Re: [RFC PATCH v9 12/16] Add mp(mediate passthru) device. >>