Zhang, Xiantao wrote:
--- qemu-kvm.orig/vl.c
+++ qemu-kvm/vl.c
@@ -4417,13 +4417,11 @@
}
if (cpu_can_run(env))
ret = qemu_cpu_exec(env);
-#ifndef CONFIG_GDBSTUB
^^^
Don't know why change #ifdef to #ifndef in upstream, and I remember it should be ifdef
Zhang, Xiantao wrote:
Jes Sorensen wrote:
Hi,
The latest changes to qemu-kvm breaks miserably if one tries to build
without CONFIG_GDBSTUB.
Jes
--- qemu-kvm.orig/vl.c
+++ qemu-kvm/vl.c
@@ -4417,13 +4417,11 @@
}
if (cpu_can_run(env))
ret =
Avi Kivity wrote:
Zhang, Xiantao wrote:
Jes Sorensen wrote:
Hi,
The latest changes to qemu-kvm breaks miserably if one tries to
build without CONFIG_GDBSTUB.
Jes
--- qemu-kvm.orig/vl.c
+++ qemu-kvm/vl.c
@@ -4417,13 +4417,11 @@
}
if (cpu_can_run(env))
Zhang, Xiantao wrote:
Avi Kivity wrote:
Zhang, Xiantao wrote:
Jes Sorensen wrote:
Hi,
The latest changes to qemu-kvm breaks miserably if one tries to
build without CONFIG_GDBSTUB.
Jes
--- qemu-kvm.orig/vl.c
+++ qemu-kvm/vl.c
@@ -4417,13 +4417,11 @@
}
Avi Kivity wrote:
Zhang, Xiantao wrote:
Jes Sorensen wrote:
Hi,
The latest changes to qemu-kvm breaks miserably if one tries to build
without CONFIG_GDBSTUB.
Jes
--- qemu-kvm.orig/vl.c
+++ qemu-kvm/vl.c
@@ -4417,13 +4417,11 @@
}
if (cpu_can_run(env))
Jan Kiszka wrote:
In upstream. Please fix it in upstream and qemu-kvm.git will get the
fix from there.
Given that CONFIG_GDBSTUB is always true upstream, I tend to say:
Finally drop it upstream and keep this (or a more arch-local) workaround
for missing ia64 gdbstub support downstream.
Avi Kivity wrote:
Jan Kiszka wrote:
In upstream. Please fix it in upstream and qemu-kvm.git will get the
fix from there.
Given that CONFIG_GDBSTUB is always true upstream, I tend to say:
Finally drop it upstream and keep this (or a more arch-local) workaround
for missing ia64 gdbstub
Jan Kiszka wrote:
I agree, unless
- we want to make gdbstub support configurable (don't see any
overwhelming reason for this, but maybe others do)
- we want to merge ia64 kvm support upstream, and don't want to impose
gdbstub support (though I'd recommend properly implementing gdbstub)
In any
Avi Kivity wrote:
Jan Kiszka wrote:
I agree, unless
- we want to make gdbstub support configurable (don't see any
overwhelming reason for this, but maybe others do)
- we want to merge ia64 kvm support upstream, and don't want to impose
gdbstub support (though I'd recommend properly
Avi Kivity wrote:
I agree, unless
- we want to make gdbstub support configurable (don't see any
overwhelming reason for this, but maybe others do)
- we want to merge ia64 kvm support upstream, and don't want to impose
gdbstub support (though I'd recommend properly implementing gdbstub)
In
Jes Sorensen wrote:
Avi Kivity wrote:
I agree, unless
- we want to make gdbstub support configurable (don't see any
overwhelming reason for this, but maybe others do)
- we want to merge ia64 kvm support upstream, and don't want to impose
gdbstub support (though I'd recommend properly
Jan Kiszka wrote:
As the original change this patch (correctly) fixes broke gdbstub
support in qemu-kvm for all archs + it is still a deviation from
upstream, please take the chance and go for ia64 stubs.
Jan,
There's far more to do in upstream than just gdbstubs for ia64 to be
usable :-(
Jes Sorensen wrote:
Jan Kiszka wrote:
As the original change this patch (correctly) fixes broke gdbstub
support in qemu-kvm for all archs + it is still a deviation from
upstream, please take the chance and go for ia64 stubs.
Jan,
There's far more to do in upstream than just gdbstubs for
Jan Kiszka wrote:
I'm not asking for full gdbstub support at this point, just for a build
workaround at arch-level (or in arch-specific blocks, in gdbstub.c e.g.)
instead of patching generic code with global risk of regressions.
Oh, I see.
I already submitted that to Avi, making
Jes Sorensen wrote:
Hi,
The latest changes to qemu-kvm breaks miserably if one tries to build
without CONFIG_GDBSTUB.
Jes
--- qemu-kvm.orig/vl.c
+++ qemu-kvm/vl.c
@@ -4417,13 +4417,11 @@
}
if (cpu_can_run(env))
ret = qemu_cpu_exec(env);
-#ifndef
15 matches
Mail list logo
