Re: [PATCH 00/11] KVM: x86: track guest page access

2015-12-01 Thread Xiao Guangrong
On 12/01/2015 06:17 PM, Paolo Bonzini wrote: On 30/11/2015 19:26, Xiao Guangrong wrote: This patchset introduces the feature which allows us to track page access in guest. Currently, only write access tracking is implemented in this version. Four APIs are introduces: -

Re: [PATCH v4 18/21] KVM: ARM64: Add PMU overflow interrupt routing

2015-12-01 Thread Marc Zyngier
On 01/12/15 16:26, Shannon Zhao wrote: > > > On 2015/12/1 23:41, Marc Zyngier wrote: >>> The reason is that when guest clear the overflow register, it will trap to kvm and call kvm_pmu_sync_hwstate() as you see above. At this moment, the overflow register is still overflowed(that is

Re: [Qemu-devel] [for-2.6 PATCH 1/3] target-i386: Define structs for layout of xsave area

2015-12-01 Thread Richard Henderson
On 11/30/2015 03:18 AM, Paolo Bonzini wrote: Because this is always little endian, I would write it as uint8_t[16][16]. Maybe. That isn't altogether handy for TCG, since we'll be wanting to bswap these buffers (probably in uint64_t chunks). r~ -- To unsubscribe from this list: send the

Re: [Qemu-devel] [for-2.6 PATCH 1/3] target-i386: Define structs for layout of xsave area

2015-12-01 Thread Eduardo Habkost
On Tue, Dec 01, 2015 at 09:09:47AM -0800, Richard Henderson wrote: > On 11/30/2015 03:18 AM, Paolo Bonzini wrote: > >Because this is always little endian, I would write it as uint8_t[16][16]. > > Maybe. That isn't altogether handy for TCG, since we'll be wanting to bswap > these buffers

Re: [Qemu-devel] [for-2.6 PATCH 1/3] target-i386: Define structs for layout of xsave area

2015-12-01 Thread Richard Henderson
On 12/01/2015 09:15 AM, Eduardo Habkost wrote: On Tue, Dec 01, 2015 at 09:09:47AM -0800, Richard Henderson wrote: On 11/30/2015 03:18 AM, Paolo Bonzini wrote: Because this is always little endian, I would write it as uint8_t[16][16]. Maybe. That isn't altogether handy for TCG, since we'll

Re: [Qemu-devel] [for-2.6 PATCH 1/3] target-i386: Define structs for layout of xsave area

2015-12-01 Thread Paolo Bonzini
On 01/12/2015 18:20, Richard Henderson wrote: >> >> X86XSaveArea will be used only when loading/saving state using >> xsave, not for executing regular instructions. > > ... like the regular instruction xsave? > > https://patchwork.ozlabs.org/patch/493318/ Right, but that's a helper anyway.

Re: [RFC PATCH V2 0/3] IXGBE/VFIO: Add live migration support for SRIOV NIC

2015-12-01 Thread Michael S. Tsirkin
On Tue, Dec 01, 2015 at 09:04:32AM -0800, Alexander Duyck wrote: > On Tue, Dec 1, 2015 at 7:28 AM, Michael S. Tsirkin wrote: > > On Tue, Dec 01, 2015 at 11:04:31PM +0800, Lan, Tianyu wrote: > >> > >> > >> On 12/1/2015 12:07 AM, Alexander Duyck wrote: > >> >They can only be

Re: [PATCH v2 00/21] arm64: KVM: world switch in C

2015-12-01 Thread Marc Zyngier
On 01/12/15 12:00, Christoffer Dall wrote: > On Tue, Dec 01, 2015 at 09:58:23AM +, Marc Zyngier wrote: >> On 30/11/15 20:33, Christoffer Dall wrote: >>> On Fri, Nov 27, 2015 at 06:49:54PM +, Marc Zyngier wrote: Once upon a time, the KVM/arm64 world switch was a nice, clean, lean

Re: KVM with PCI forwarding really slow after 4.1

2015-12-01 Thread Paolo Bonzini
On 01/12/2015 18:09, Michael Büsch wrote: > Hi, > > I use "-device pci-assign,host=00:1a.0" to forward a USB host chip > to a Win7 32 bit inside of qemu/kvm. That used to work pretty well, > but it broke horribly somewhere after 4.1. With recent kernels the > virtual machine boots, but is

Re: [PATCH net-next 3/3] vhost_net: basic polling support

2015-12-01 Thread Jason Wang
On 12/01/2015 10:43 PM, Michael S. Tsirkin wrote: > On Tue, Dec 01, 2015 at 01:17:49PM +0800, Jason Wang wrote: >> >> On 11/30/2015 06:44 PM, Michael S. Tsirkin wrote: >>> On Wed, Nov 25, 2015 at 03:11:29PM +0800, Jason Wang wrote: > This patch tries to poll for new added tx buffer or socket

Re: [PATCH v2 09/21] arm64: KVM: Implement guest entry

2015-12-01 Thread Marc Zyngier
On 01/12/15 15:29, Christoffer Dall wrote: > On Fri, Nov 27, 2015 at 06:50:03PM +, Marc Zyngier wrote: >> Contrary to the previous patch, the guest entry is fairly different >> from its assembly counterpart, mostly because it is only concerned >> with saving/restoring the GP registers, and

Re: [Qemu-devel] [for-2.6 PATCH 1/3] target-i386: Define structs for layout of xsave area

2015-12-01 Thread Eduardo Habkost
On Tue, Dec 01, 2015 at 06:27:17PM +0100, Paolo Bonzini wrote: > On 01/12/2015 18:20, Richard Henderson wrote: > >> > >> X86XSaveArea will be used only when loading/saving state using > >> xsave, not for executing regular instructions. > > > > ... like the regular instruction xsave? > > > >

Re: [PATCH v2 08/21] arm64: KVM: Implement debug save/restore

2015-12-01 Thread Marc Zyngier
On 01/12/15 15:41, Christoffer Dall wrote: > On Tue, Dec 01, 2015 at 03:01:16PM +, Marc Zyngier wrote: >> On 01/12/15 14:47, Christoffer Dall wrote: >>> On Tue, Dec 01, 2015 at 01:06:31PM +, Marc Zyngier wrote: On 01/12/15 12:56, Christoffer Dall wrote: > On Fri, Nov 27, 2015 at

Re: [RFC PATCH V2 0/3] IXGBE/VFIO: Add live migration support for SRIOV NIC

2015-12-01 Thread Alexander Duyck
On Tue, Dec 1, 2015 at 9:37 AM, Michael S. Tsirkin wrote: > On Tue, Dec 01, 2015 at 09:04:32AM -0800, Alexander Duyck wrote: >> On Tue, Dec 1, 2015 at 7:28 AM, Michael S. Tsirkin wrote: >> > There are several components to this: >> > - dma_map_* needs to

Re: [Qemu-devel] [for-2.6 PATCH 1/3] target-i386: Define structs for layout of xsave area

2015-12-01 Thread Richard Henderson
On 12/01/2015 10:34 AM, Eduardo Habkost wrote: BTW, if we are going to implement xsave in TCG, the X86CPU<->xsave translation logic in kvm_{get,put}_xsave() could be moved to generic code and reused by TCG instead of being reimplemented. That's not trivial. In particular, stq_p isn't what the

Re: [PATCH v2 10/21] arm64: KVM: Add patchable function selector

2015-12-01 Thread Marc Zyngier
On 01/12/15 15:39, Christoffer Dall wrote: > On Fri, Nov 27, 2015 at 06:50:04PM +, Marc Zyngier wrote: >> KVM so far relies on code patching, and is likely to use it more >> in the future. The main issue is that our alternative system works >> at the instruction level, while we'd like to have

Re: [PATCH v2 00/21] arm64: KVM: world switch in C

2015-12-01 Thread Christoffer Dall
On Tue, Dec 01, 2015 at 05:51:46PM +, Marc Zyngier wrote: > On 01/12/15 12:00, Christoffer Dall wrote: > > On Tue, Dec 01, 2015 at 09:58:23AM +, Marc Zyngier wrote: > >> On 30/11/15 20:33, Christoffer Dall wrote: > >>> On Fri, Nov 27, 2015 at 06:49:54PM +, Marc Zyngier wrote: >

Re: BUG ALERT: ARM32 KVM does not work in 4.4-rc3

2015-12-01 Thread Marc Zyngier
On 01/12/15 07:24, Pavel Fedin wrote: > Hello! > > My project involves ARM64, but from time to time i also test ARM32 > KVM. I have discovered that it stopped working in 4.4-rc3. The same > virtual machine works perfectly under current kvmarm/next, but gets > stuck at random point under 4.4-rc3

Re: best way to create a snapshot of a running vm ?

2015-12-01 Thread Stefan Hajnoczi
On Mon, Nov 30, 2015 at 04:34:14PM +0100, Lentes, Bernd wrote: > Stefan wrote: > > > > > Hi Bernd, > > qemu-img cannot be used on the disk image when the VM is running. > > Please use virsh, it communicates with the running QEMU process and > > ensures that the snapshot is crash-consistent. > >

Re: [PATCH v4 05/21] KVM: ARM64: Add reset and access handlers for PMSELR register

2015-12-01 Thread Marc Zyngier
On 01/12/15 01:51, Shannon Zhao wrote: > Hi Marc, > > On 2015/12/1 1:56, Marc Zyngier wrote: >> Same remark here as the one I made earlier. I'm pretty sure we don't >> call any CP15 reset because they are all shared with their 64bit >> counterparts. The same thing goes for the whole series. > Ok,

RE: BUG ALERT: ARM32 KVM does not work in 4.4-rc3

2015-12-01 Thread Pavel Fedin
Hello! > The same kernel is used both as a guest and a host with v4.4-rc3. > > So until you bisect it to an exact commit and configuration, I declare > the alert over. ;-) By this time i have also tried it on another machine, and there it also works. Looks like it's triggered only on some

Re: [PATCH v2 00/21] arm64: KVM: world switch in C

2015-12-01 Thread Marc Zyngier
On 30/11/15 20:33, Christoffer Dall wrote: > On Fri, Nov 27, 2015 at 06:49:54PM +, Marc Zyngier wrote: >> Once upon a time, the KVM/arm64 world switch was a nice, clean, lean >> and mean piece of hand-crafted assembly code. Over time, features have >> crept in, the code has become harder to

RE: BUG ALERT: ARM32 KVM does not work in 4.4-rc3

2015-12-01 Thread Pavel Fedin
Hello! > > My project involves ARM64, but from time to time i also test ARM32 > > KVM. I have discovered that it stopped working in 4.4-rc3. The same > > virtual machine works perfectly under current kvmarm/next, but gets > > stuck at random point under 4.4-rc3 from linux-stable. I'm not sure >

Re: [PATCH v1 0/7] KVM: Hyper-V SynIC timers

2015-12-01 Thread Wanpeng Li
2015-11-26 16:34 GMT+08:00 Andrey Smetanin : > > > On 11/26/2015 08:28 AM, Wanpeng Li wrote: >> >> 2015-11-25 23:20 GMT+08:00 Andrey Smetanin : >>> >>> Per Hyper-V specification (and as required by Hyper-V-aware guests), >>> SynIC provides 4

Re: [PATCH 00/11] KVM: x86: track guest page access

2015-12-01 Thread Paolo Bonzini
On 30/11/2015 19:26, Xiao Guangrong wrote: > This patchset introduces the feature which allows us to track page > access in guest. Currently, only write access tracking is implemented > in this version. > > Four APIs are introduces: > - kvm_page_track_add_page(kvm, gfn, mode), single guest page

Re: [PATCH v2 0/3] target-i386: Use C struct for xsave area layout, offsets & sizes

2015-12-01 Thread Paolo Bonzini
On 30/11/2015 18:34, Eduardo Habkost wrote: > target-i386/cpu.c:ext_save_area uses magic numbers for the xsave > area offets and sizes, and target-i386/kvm.c:kvm_{put,get}_xsave() > uses offset macros and bit manipulation to access the xsave area. > This series changes both to use C structs for

Re: [PATCH v1 0/7] KVM: Hyper-V SynIC timers

2015-12-01 Thread Denis V. Lunev
On 12/01/2015 01:12 PM, Wanpeng Li wrote: 2015-11-26 16:34 GMT+08:00 Andrey Smetanin : On 11/26/2015 08:28 AM, Wanpeng Li wrote: 2015-11-25 23:20 GMT+08:00 Andrey Smetanin : Per Hyper-V specification (and as required by Hyper-V-aware guests),

Re: [PATCH v2 0/3] target-i386: Use C struct for xsave area layout, offsets & sizes

2015-12-01 Thread Paolo Bonzini
On 30/11/2015 18:34, Eduardo Habkost wrote: > target-i386/cpu.c:ext_save_area uses magic numbers for the xsave > area offets and sizes, and target-i386/kvm.c:kvm_{put,get}_xsave() > uses offset macros and bit manipulation to access the xsave area. > This series changes both to use C structs for

Re: [PATCH v4 18/21] KVM: ARM64: Add PMU overflow interrupt routing

2015-12-01 Thread Shannon Zhao
On 2015/12/1 22:50, Marc Zyngier wrote: On 01/12/15 14:35, Shannon Zhao wrote: On 2015/12/1 2:22, Marc Zyngier wrote: On Fri, 30 Oct 2015 14:22:00 +0800 Shannon Zhao wrote: From: Shannon Zhao When calling

Re: [PATCH v2 0/3] target-i386: Use C struct for xsave area layout, offsets & sizes

2015-12-01 Thread Eduardo Habkost
On Tue, Dec 01, 2015 at 11:22:31AM +0100, Paolo Bonzini wrote: > On 30/11/2015 18:34, Eduardo Habkost wrote: > > target-i386/cpu.c:ext_save_area uses magic numbers for the xsave > > area offets and sizes, and target-i386/kvm.c:kvm_{put,get}_xsave() > > uses offset macros and bit manipulation to

Re: [PATCH v2 0/3] target-i386: Use C struct for xsave area layout, offsets & sizes

2015-12-01 Thread Paolo Bonzini
On 01/12/2015 16:25, Eduardo Habkost wrote: > > I think it's easier to use small guests (i.e. kvm-unit-tests) to test > > this code. > > I agree it's easier, but how likely it is to catch bugs in the > save/load code? If the code corrupts a register, we need to > trigger a save/load cycle at the

Re: [RFC PATCH V2 0/3] IXGBE/VFIO: Add live migration support for SRIOV NIC

2015-12-01 Thread Michael S. Tsirkin
On Tue, Dec 01, 2015 at 11:04:31PM +0800, Lan, Tianyu wrote: > > > On 12/1/2015 12:07 AM, Alexander Duyck wrote: > >They can only be corrected if the underlying assumptions are correct > >and they aren't. Your solution would have never worked correctly. > >The problem is you assume you can keep

Re: [PATCH v2 09/21] arm64: KVM: Implement guest entry

2015-12-01 Thread Christoffer Dall
On Fri, Nov 27, 2015 at 06:50:03PM +, Marc Zyngier wrote: > Contrary to the previous patch, the guest entry is fairly different > from its assembly counterpart, mostly because it is only concerned > with saving/restoring the GP registers, and nothing else. > > Signed-off-by: Marc Zyngier

Re: [PATCH v2 0/3] target-i386: Use C struct for xsave area layout, offsets & sizes

2015-12-01 Thread Eduardo Habkost
On Tue, Dec 01, 2015 at 04:09:44PM +0100, Paolo Bonzini wrote: > > > On 30/11/2015 18:34, Eduardo Habkost wrote: > > target-i386/cpu.c:ext_save_area uses magic numbers for the xsave > > area offets and sizes, and target-i386/kvm.c:kvm_{put,get}_xsave() > > uses offset macros and bit manipulation

Re: [PATCH v2 10/21] arm64: KVM: Add patchable function selector

2015-12-01 Thread Christoffer Dall
On Fri, Nov 27, 2015 at 06:50:04PM +, Marc Zyngier wrote: > KVM so far relies on code patching, and is likely to use it more > in the future. The main issue is that our alternative system works > at the instruction level, while we'd like to have alternatives at > the function level. > > In

Re: [PATCH v2 08/21] arm64: KVM: Implement debug save/restore

2015-12-01 Thread Christoffer Dall
On Tue, Dec 01, 2015 at 03:01:16PM +, Marc Zyngier wrote: > On 01/12/15 14:47, Christoffer Dall wrote: > > On Tue, Dec 01, 2015 at 01:06:31PM +, Marc Zyngier wrote: > >> On 01/12/15 12:56, Christoffer Dall wrote: > >>> On Fri, Nov 27, 2015 at 06:50:02PM +, Marc Zyngier wrote: >

Re: [PATCH v4 18/21] KVM: ARM64: Add PMU overflow interrupt routing

2015-12-01 Thread Marc Zyngier
On 01/12/15 15:13, Shannon Zhao wrote: > > > On 2015/12/1 22:50, Marc Zyngier wrote: >> On 01/12/15 14:35, Shannon Zhao wrote: >>> >>> >>> On 2015/12/1 2:22, Marc Zyngier wrote: On Fri, 30 Oct 2015 14:22:00 +0800 Shannon Zhao wrote: > From: Shannon

Re: [PATCH v2 07/21] arm64: KVM: Implement 32bit system register save/restore

2015-12-01 Thread Christoffer Dall
On Fri, Nov 27, 2015 at 06:50:01PM +, Marc Zyngier wrote: > Implement the 32bit system register save restore as a direct > translation of the assembly code version. > > Signed-off-by: Marc Zyngier > --- > arch/arm64/kvm/hyp/hyp.h | 2 ++ >

Re: [PATCH v2 06/21] arm64: KVM: Implement system register save/restore

2015-12-01 Thread Christoffer Dall
On Fri, Nov 27, 2015 at 06:50:00PM +, Marc Zyngier wrote: > Implement the system registe save restore as a direct translation of nit: s/registe/register/ > the assembly code version. > > Signed-off-by: Marc Zyngier > --- > arch/arm64/kvm/hyp/Makefile| 1 + >

Re: [PATCH v2 11/21] arm64: KVM: Implement the core world switch

2015-12-01 Thread Christoffer Dall
On Fri, Nov 27, 2015 at 06:50:05PM +, Marc Zyngier wrote: > Implement the core of the world switch in C. Not everything is there > yet, and there is nothing to re-enter the world switch either. > > But this already outlines the code structure well enough. > > Signed-of

Re: [PATCH v5 2/2] KVM: Make KVM_CAP_IRQFD dependent on KVM_CAP_IRQCHIP

2015-12-01 Thread Paolo Bonzini
On 30/11/2015 15:38, Cornelia Huck wrote: > It obviously > requires an irqchip; but if you need some configuration/enablement > beforehand, you'll get different values depending on when you retrieve > the cap. So does KVM_CAP_IRQFD mean "irqfds are available in principle" > or "everything has

Re: [PATCH v2 05/21] arm64: KVM: Implement timer save/restore

2015-12-01 Thread Marc Zyngier
On 30/11/15 19:59, Christoffer Dall wrote: > On Fri, Nov 27, 2015 at 06:49:59PM +, Marc Zyngier wrote: >> Implement the timer save restore as a direct translation of >> the assembly code version. >> >> Signed-off-by: Marc Zyngier >> --- >> arch/arm64/kvm/hyp/Makefile

Re: [PATCH v4 05/21] KVM: ARM64: Add reset and access handlers for PMSELR register

2015-12-01 Thread Shannon Zhao
On 2015/12/1 16:49, Marc Zyngier wrote: > On 01/12/15 01:51, Shannon Zhao wrote: >> Hi Marc, >> >> On 2015/12/1 1:56, Marc Zyngier wrote: >>> Same remark here as the one I made earlier. I'm pretty sure we don't >>> call any CP15 reset because they are all shared with their 64bit >>>

Re: [PATCH v2 03/21] arm64: KVM: Implement vgic-v2 save/restore

2015-12-01 Thread Marc Zyngier
On 30/11/15 20:00, Christoffer Dall wrote: > On Fri, Nov 27, 2015 at 06:49:57PM +, Marc Zyngier wrote: >> Implement the vgic-v2 save restore (mostly) as a direct translation >> of the assembly code version. >> >> Signed-off-by: Marc Zyngier >> --- >>

Re: [PATCH v2 04/21] arm64: KVM: Implement vgic-v3 save/restore

2015-12-01 Thread Christoffer Dall
On Tue, Dec 01, 2015 at 12:44:26PM +0100, Christoffer Dall wrote: > On Tue, Dec 01, 2015 at 11:32:20AM +, Marc Zyngier wrote: > > On 30/11/15 19:50, Christoffer Dall wrote: > > > On Fri, Nov 27, 2015 at 06:49:58PM +, Marc Zyngier wrote: > > >> Implement the vgic-v3 save restore as a direct

Re: [PATCH v2 04/21] arm64: KVM: Implement vgic-v3 save/restore

2015-12-01 Thread Marc Zyngier
On 01/12/15 11:50, Christoffer Dall wrote: > On Tue, Dec 01, 2015 at 12:44:26PM +0100, Christoffer Dall wrote: >> On Tue, Dec 01, 2015 at 11:32:20AM +, Marc Zyngier wrote: >>> On 30/11/15 19:50, Christoffer Dall wrote: On Fri, Nov 27, 2015 at 06:49:58PM +, Marc Zyngier wrote: >

Re: [PATCH v2 08/21] arm64: KVM: Implement debug save/restore

2015-12-01 Thread Marc Zyngier
On 01/12/15 12:56, Christoffer Dall wrote: > On Fri, Nov 27, 2015 at 06:50:02PM +, Marc Zyngier wrote: >> Implement the debug save restore as a direct translation of >> the assembly code version. >> >> Signed-off-by: Marc Zyngier >> --- >> arch/arm64/kvm/hyp/Makefile

Re: [PATCH v2 04/21] arm64: KVM: Implement vgic-v3 save/restore

2015-12-01 Thread Christoffer Dall
On Tue, Dec 01, 2015 at 11:32:20AM +, Marc Zyngier wrote: > On 30/11/15 19:50, Christoffer Dall wrote: > > On Fri, Nov 27, 2015 at 06:49:58PM +, Marc Zyngier wrote: > >> Implement the vgic-v3 save restore as a direct translation of > >> the assembly code version. > >> > >> Signed-off-by:

Re: [PATCH v2 04/21] arm64: KVM: Implement vgic-v3 save/restore

2015-12-01 Thread Marc Zyngier
On 01/12/15 12:24, Christoffer Dall wrote: > On Tue, Dec 01, 2015 at 11:57:16AM +, Marc Zyngier wrote: >> On 01/12/15 11:50, Christoffer Dall wrote: >>> On Tue, Dec 01, 2015 at 12:44:26PM +0100, Christoffer Dall wrote: On Tue, Dec 01, 2015 at 11:32:20AM +, Marc Zyngier wrote: > On

Re: [PATCH v2 08/21] arm64: KVM: Implement debug save/restore

2015-12-01 Thread Christoffer Dall
On Fri, Nov 27, 2015 at 06:50:02PM +, Marc Zyngier wrote: > Implement the debug save restore as a direct translation of > the assembly code version. > > Signed-off-by: Marc Zyngier > --- > arch/arm64/kvm/hyp/Makefile | 1 + > arch/arm64/kvm/hyp/debug-sr.c | 130 >

RE: [PATCH v5 2/2] KVM: Make KVM_CAP_IRQFD dependent on KVM_CAP_IRQCHIP

2015-12-01 Thread Pavel Fedin
'Marc Zyngier'; > 'Christoffer Dall'; > 'Gleb Natapov'; 'Paolo Bonzini' > Subject: Re: [PATCH v5 2/2] KVM: Make KVM_CAP_IRQFD dependent on > KVM_CAP_IRQCHIP > > On Mon, 30 Nov 2015 15:41:20 +0300 > Pavel Fedin <p.fe...@samsung.com> wrote: > > > Hello! > >

Re: [PATCH v2 00/21] arm64: KVM: world switch in C

2015-12-01 Thread Christoffer Dall
On Tue, Dec 01, 2015 at 09:58:23AM +, Marc Zyngier wrote: > On 30/11/15 20:33, Christoffer Dall wrote: > > On Fri, Nov 27, 2015 at 06:49:54PM +, Marc Zyngier wrote: > >> Once upon a time, the KVM/arm64 world switch was a nice, clean, lean > >> and mean piece of hand-crafted assembly code.

Re: [PATCH v2 04/21] arm64: KVM: Implement vgic-v3 save/restore

2015-12-01 Thread Christoffer Dall
On Tue, Dec 01, 2015 at 11:57:16AM +, Marc Zyngier wrote: > On 01/12/15 11:50, Christoffer Dall wrote: > > On Tue, Dec 01, 2015 at 12:44:26PM +0100, Christoffer Dall wrote: > >> On Tue, Dec 01, 2015 at 11:32:20AM +, Marc Zyngier wrote: > >>> On 30/11/15 19:50, Christoffer Dall wrote: >

Re: [PATCH v2 04/21] arm64: KVM: Implement vgic-v3 save/restore

2015-12-01 Thread Marc Zyngier
)], ICH_LR12_EL2); >> +case 11: >> +write_gicreg(cpu_if->vgic_lr[LR_OFFSET(11)], ICH_LR11_EL2); >> +case 10: >> +write_gicreg(cpu_if->vgic_lr[LR_OFFSET(10)], ICH_LR10_EL2); &

Re: [PATCH v2 02/21] arm64: KVM: Add a HYP-specific header file

2015-12-01 Thread Marc Zyngier
On 30/11/15 20:00, Christoffer Dall wrote: > On Fri, Nov 27, 2015 at 06:49:56PM +, Marc Zyngier wrote: >> In order to expose the various EL2 services that are private to >> the hypervisor, add a new hyp.h file. >> >> So far, it only contains mundane things such as section annotation >> and VA

Re: [PATCH v2 02/21] arm64: KVM: Add a HYP-specific header file

2015-12-01 Thread Christoffer Dall
On Tue, Dec 01, 2015 at 11:41:08AM +, Marc Zyngier wrote: > On 30/11/15 20:00, Christoffer Dall wrote: > > On Fri, Nov 27, 2015 at 06:49:56PM +, Marc Zyngier wrote: > >> In order to expose the various EL2 services that are private to > >> the hypervisor, add a new hyp.h file. > >> > >> So

Re: [PATCH v2 04/21] arm64: KVM: Implement vgic-v3 save/restore

2015-12-01 Thread Marc Zyngier
On 01/12/15 11:44, Christoffer Dall wrote: > On Tue, Dec 01, 2015 at 11:32:20AM +, Marc Zyngier wrote: >> On 30/11/15 19:50, Christoffer Dall wrote: >>> On Fri, Nov 27, 2015 at 06:49:58PM +, Marc Zyngier wrote: Implement the vgic-v3 save restore as a direct translation of the

RE: BUG ALERT: ARM32 KVM does not work in 4.4-rc3

2015-12-01 Thread Pavel Fedin
el'; christoffer.d...@linaro.org > Subject: RE: BUG ALERT: ARM32 KVM does not work in 4.4-rc3 > > Hello! > > > > My project involves ARM64, but from time to time i also test ARM32 > > > KVM. I have discovered that it stopped working in 4.4-rc3. The same > > > virtual ma

Re: [PATCH v2 08/21] arm64: KVM: Implement debug save/restore

2015-12-01 Thread Christoffer Dall
On Tue, Dec 01, 2015 at 01:06:31PM +, Marc Zyngier wrote: > On 01/12/15 12:56, Christoffer Dall wrote: > > On Fri, Nov 27, 2015 at 06:50:02PM +, Marc Zyngier wrote: > >> Implement the debug save restore as a direct translation of > >> the assembly code version. > >> > >> Signed-off-by:

Re: [PATCH v2 08/21] arm64: KVM: Implement debug save/restore

2015-12-01 Thread Christoffer Dall
On Tue, Dec 01, 2015 at 03:47:37PM +0100, Christoffer Dall wrote: > On Tue, Dec 01, 2015 at 01:06:31PM +, Marc Zyngier wrote: > > On 01/12/15 12:56, Christoffer Dall wrote: > > > On Fri, Nov 27, 2015 at 06:50:02PM +, Marc Zyngier wrote: > > >> Implement the debug save restore as a direct

Re: [PATCH 00/11] KVM: x86: track guest page access

2015-12-01 Thread Andrea Arcangeli
On Tue, Dec 01, 2015 at 11:17:30AM +0100, Paolo Bonzini wrote: > > > On 30/11/2015 19:26, Xiao Guangrong wrote: > > This patchset introduces the feature which allows us to track page > > access in guest. Currently, only write access tracking is implemented > > in this version. > > > > Four APIs

Re: [RFC PATCH V2 0/3] IXGBE/VFIO: Add live migration support for SRIOV NIC

2015-12-01 Thread Lan, Tianyu
On 12/1/2015 12:07 AM, Alexander Duyck wrote: They can only be corrected if the underlying assumptions are correct and they aren't. Your solution would have never worked correctly. The problem is you assume you can keep the device running when you are migrating and you simply cannot. At some

Re: [PATCH v4 18/21] KVM: ARM64: Add PMU overflow interrupt routing

2015-12-01 Thread Shannon Zhao
On 2015/12/1 2:22, Marc Zyngier wrote: > On Fri, 30 Oct 2015 14:22:00 +0800 > Shannon Zhao wrote: > >> From: Shannon Zhao >> >> When calling perf_event_create_kernel_counter to create perf_event, >> assign a overflow handler. Then when perf

Re: [PATCH net-next 3/3] vhost_net: basic polling support

2015-12-01 Thread Michael S. Tsirkin
On Tue, Dec 01, 2015 at 01:17:49PM +0800, Jason Wang wrote: > > > On 11/30/2015 06:44 PM, Michael S. Tsirkin wrote: > > On Wed, Nov 25, 2015 at 03:11:29PM +0800, Jason Wang wrote: > >> > This patch tries to poll for new added tx buffer or socket receive > >> > queue for a while at the end of

Re: [PATCH v4 18/21] KVM: ARM64: Add PMU overflow interrupt routing

2015-12-01 Thread Marc Zyngier
On 01/12/15 14:35, Shannon Zhao wrote: > > > On 2015/12/1 2:22, Marc Zyngier wrote: >> On Fri, 30 Oct 2015 14:22:00 +0800 >> Shannon Zhao wrote: >> >>> From: Shannon Zhao >>> >>> When calling perf_event_create_kernel_counter to create

Re: [RFC PATCH V2 00/10] Qemu: Add live migration support for SRIOV NIC

2015-12-01 Thread Michael S. Tsirkin
On Tue, Dec 01, 2015 at 02:26:57PM +0800, Lan, Tianyu wrote: > > > On 11/30/2015 4:01 PM, Michael S. Tsirkin wrote: > >It is still not very clear what it is you are trying to achieve, and > >whether your patchset achieves it. You merely say "adding live > >migration" but it seems pretty clear

Re: [PATCH v2 08/21] arm64: KVM: Implement debug save/restore

2015-12-01 Thread Marc Zyngier
On 01/12/15 14:47, Christoffer Dall wrote: > On Tue, Dec 01, 2015 at 01:06:31PM +, Marc Zyngier wrote: >> On 01/12/15 12:56, Christoffer Dall wrote: >>> On Fri, Nov 27, 2015 at 06:50:02PM +, Marc Zyngier wrote: Implement the debug save restore as a direct translation of the

Re: [PATCH 00/11] KVM: x86: track guest page access

2015-12-01 Thread Paolo Bonzini
On 01/12/2015 16:02, Andrea Arcangeli wrote: > > Applying your technique to non-leaf shadow pages actually makes this > > series quite interesting. :) Shadow paging is still in use for nested > > EPT, so it's always a good idea to speed it up. > > I don't have the full picture of how

Re: [PATCH v2 08/21] arm64: KVM: Implement debug save/restore

2015-12-01 Thread Alex Bennée
Marc Zyngier writes: > On 01/12/15 12:56, Christoffer Dall wrote: >> On Fri, Nov 27, 2015 at 06:50:02PM +, Marc Zyngier wrote: >>> Implement the debug save restore as a direct translation of >>> the assembly code version. >>> >>> Signed-off-by: Marc Zyngier

Re: [PATCH v2 08/21] arm64: KVM: Implement debug save/restore

2015-12-01 Thread Marc Zyngier
On 01/12/15 13:19, Alex Bennée wrote: > > Marc Zyngier writes: > >> On 01/12/15 12:56, Christoffer Dall wrote: >>> On Fri, Nov 27, 2015 at 06:50:02PM +, Marc Zyngier wrote: Implement the debug save restore as a direct translation of the assembly code version.

Re: [PATCH v4 18/21] KVM: ARM64: Add PMU overflow interrupt routing

2015-12-01 Thread Shannon Zhao
On 2015/12/1 23:41, Marc Zyngier wrote: The reason is that when guest clear the overflow register, it will trap >to kvm and call kvm_pmu_sync_hwstate() as you see above. At this moment, >the overflow register is still overflowed(that is some bit is still 1). >So We need to use some flag to

Re: [PATCH 2/2] KVM: Create debugfs dir and stat files for each VM

2015-11-30 Thread Janosch Frank
On 11/27/2015 09:42 PM, Tyler Baker wrote: On 27 November 2015 at 10:53, Tyler Baker wrote: On 27 November 2015 at 09:08, Tyler Baker wrote: On 27 November 2015 at 00:54, Christian Borntraeger wrote: On 11/26/2015

Re: [PATCH] vhost: replace % with & on data path

2015-11-30 Thread kbuild test robot
Hi Michael, [auto build test ERROR on: v4.4-rc3] [also build test ERROR on: next-20151127] url: https://github.com/0day-ci/linux/commits/Michael-S-Tsirkin/vhost-replace-with-on-data-path/20151130-163704 config: s390-performance_defconfig (attached as .config) reproduce: wget

Re: [PATCH] vhost: replace % with & on data path

2015-11-30 Thread kbuild test robot
Hi Michael, [auto build test ERROR on: v4.4-rc3] [also build test ERROR on: next-20151127] url: https://github.com/0day-ci/linux/commits/Michael-S-Tsirkin/vhost-replace-with-on-data-path/20151130-163704 config: i386-randconfig-s1-201548 (attached as .config) reproduce: # save the

Re: [PATCH] vhost: replace % with & on data path

2015-11-30 Thread Michael S. Tsirkin
On Mon, Nov 30, 2015 at 10:34:07AM +0200, Michael S. Tsirkin wrote: > We know vring num is a power of 2, so use & > to mask the high bits. > > Signed-off-by: Michael S. Tsirkin > --- > drivers/vhost/vhost.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > >

Re: [PATCH] vhost: replace % with & on data path

2015-11-30 Thread Michael S. Tsirkin
On Mon, Nov 30, 2015 at 12:42:49AM -0800, Joe Perches wrote: > On Mon, 2015-11-30 at 10:34 +0200, Michael S. Tsirkin wrote: > > We know vring num is a power of 2, so use & > > to mask the high bits. > [] > > diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c > [] > > @@ -1366,10 +1366,12

Re: [PATCH v2] vhost: replace % with & on data path

2015-11-30 Thread Christian Borntraeger
On 11/30/2015 10:15 AM, Michael S. Tsirkin wrote: > We know vring num is a power of 2, so use & > to mask the high bits. Makes a lot of sense and virtio_ring.c seems to use the same logic. Acked-by: Christian Borntraeger > > Signed-off-by: Michael S. Tsirkin

Re: [PATCH v2 04/21] arm64: KVM: Implement vgic-v3 save/restore

2015-11-30 Thread Alex Bennée
c_lr[LR_OFFSET(9)], ICH_LR9_EL2); > + case 8: > + write_gicreg(cpu_if->vgic_lr[LR_OFFSET(8)], ICH_LR8_EL2); > + case 7: > + write_gicreg(cpu_if->vgic_lr[LR_OFFSET(7)], ICH_LR7_EL2); > + case 6: > + write_gicreg(cpu_if->vg

Re: [PATCH v8 3/5] nvdimm acpi: build ACPI NFIT table

2015-11-30 Thread Michael S. Tsirkin
On Mon, Nov 16, 2015 at 06:51:01PM +0800, Xiao Guangrong wrote: > NFIT is defined in ACPI 6.0: 5.2.25 NVDIMM Firmware Interface Table (NFIT) > > Currently, we only support PMEM mode. Each device has 3 structures: > - SPA structure, defines the PMEM region info > > - MEM DEV structure, it has the

Re: [PATCH v8 4/5] nvdimm acpi: build ACPI nvdimm devices

2015-11-30 Thread Michael S. Tsirkin
On Mon, Nov 16, 2015 at 06:51:02PM +0800, Xiao Guangrong wrote: > NVDIMM devices is defined in ACPI 6.0 9.20 NVDIMM Devices > > There is a root device under \_SB and specified NVDIMM devices are under the > root device. Each NVDIMM device has _ADR which returns its handle used to > associate

Re: [PATCH 2/2] KVM: Create debugfs dir and stat files for each VM

2015-11-30 Thread Tyler Baker
On 30 November 2015 at 00:38, Christian Borntraeger wrote: > On 11/27/2015 09:42 PM, Tyler Baker wrote: >> On 27 November 2015 at 10:53, Tyler Baker wrote: >>> On 27 November 2015 at 09:08, Tyler Baker wrote: On 27

Re: [PATCH 2/2] KVM: Create debugfs dir and stat files for each VM

2015-11-30 Thread Alex Bennée
Janosch Frank writes: > On 11/27/2015 09:42 PM, Tyler Baker wrote: >> On 27 November 2015 at 10:53, Tyler Baker wrote: >>> On 27 November 2015 at 09:08, Tyler Baker wrote: On 27 November 2015 at 00:54, Christian

Re: [PATCH v2] vhost: replace % with & on data path

2015-11-30 Thread David Miller
From: "Michael S. Tsirkin" Date: Mon, 30 Nov 2015 11:15:23 +0200 > We know vring num is a power of 2, so use & > to mask the high bits. > > Signed-off-by: Michael S. Tsirkin Acked-by: David S. Miller -- To unsubscribe from this list:

RE: best way to create a snapshot of a running vm ?

2015-11-30 Thread Lentes, Bernd
Stefan wrote: > > Hi Bernd, > qemu-img cannot be used on the disk image when the VM is running. > Please use virsh, it communicates with the running QEMU process and > ensures that the snapshot is crash-consistent. > Hi Stefan, thanks for your answer. i read that virsh uses internally

Re: [RFC PATCH V2 0/3] IXGBE/VFIO: Add live migration support for SRIOV NIC

2015-11-30 Thread Alexander Duyck
On Sun, Nov 29, 2015 at 10:53 PM, Lan, Tianyu wrote: > On 11/26/2015 11:56 AM, Alexander Duyck wrote: >> >> > I am not saying you cannot modify the drivers, however what you are >> doing is far too invasive. Do you seriously plan on modifying all of >> the PCI device

Re: [PATCH] vhost: replace % with & on data path

2015-11-30 Thread David Miller
From: "Michael S. Tsirkin" Date: Mon, 30 Nov 2015 10:34:07 +0200 > We know vring num is a power of 2, so use & > to mask the high bits. > > Signed-off-by: Michael S. Tsirkin > --- > drivers/vhost/vhost.c | 8 +--- > 1 file changed, 5 insertions(+), 3

Re: [PATCH v4 05/21] KVM: ARM64: Add reset and access handlers for PMSELR register

2015-11-30 Thread Marc Zyngier
On Fri, 30 Oct 2015 14:21:47 +0800 Shannon Zhao wrote: > From: Shannon Zhao > > Since the reset value of PMSELR_EL0 is UNKNOWN, use reset_unknown for > its reset handler. As it doesn't need to deal with the acsessing action > specially, it

Re: [PATCH v4 04/21] KVM: ARM64: Add reset and access handlers for PMCR_EL0 register

2015-11-30 Thread Marc Zyngier
On Fri, 30 Oct 2015 14:21:46 +0800 Shannon Zhao wrote: > From: Shannon Zhao > > Add reset handler which gets host value of PMCR_EL0 and make writable > bits architecturally UNKNOWN except PMCR.E to zero. Add a common access > handler for PMU

Re: [PATCH v4 08/21] KVM: ARM64: Add reset and access handlers for PMXEVTYPER register

2015-11-30 Thread Marc Zyngier
On Fri, 30 Oct 2015 14:21:50 +0800 Shannon Zhao wrote: > From: Shannon Zhao > > Since the reset value of PMXEVTYPER is UNKNOWN, use reset_unknown or > reset_unknown_cp15 for its reset handler. Add access handler which > emulates writing and

Re: [PATCH v4 18/21] KVM: ARM64: Add PMU overflow interrupt routing

2015-11-30 Thread Marc Zyngier
On Fri, 30 Oct 2015 14:22:00 +0800 Shannon Zhao wrote: > From: Shannon Zhao > > When calling perf_event_create_kernel_counter to create perf_event, > assign a overflow handler. Then when perf event overflows, set > irq_pending and call

Re: [PATCH v4 21/21] KVM: ARM64: Add a new kvm ARM PMU device

2015-11-30 Thread Marc Zyngier
On Fri, 30 Oct 2015 14:22:03 +0800 Shannon Zhao wrote: > From: Shannon Zhao > > Add a new kvm device type KVM_DEV_TYPE_ARM_PMU_V3 for ARM PMU. Implement > the kvm_device_ops for it. > > Signed-off-by: Shannon Zhao >

Re: [PATCH v4 00/21] KVM: ARM64: Add guest PMU support

2015-11-30 Thread Marc Zyngier
On Fri, 30 Oct 2015 14:21:42 +0800 Shannon Zhao wrote: Hi Shannon, > From: Shannon Zhao > > This patchset adds guest PMU support for KVM on ARM64. It takes > trap-and-emulate approach. When guest wants to monitor one event, it > will be

Re: [PATCH v2 04/21] arm64: KVM: Implement vgic-v3 save/restore

2015-11-30 Thread Christoffer Dall
case 7: > + write_gicreg(cpu_if->vgic_lr[LR_OFFSET(7)], ICH_LR7_EL2); > + case 6: > + write_gicreg(cpu_if->vgic_lr[LR_OFFSET(6)], ICH_LR6_EL2); > + case 5:

Re: [PATCH v2 01/21] arm64: Add macros to read/write system registers

2015-11-30 Thread Christoffer Dall
On Fri, Nov 27, 2015 at 06:49:55PM +, Marc Zyngier wrote: > From: Mark Rutland > > Rather than crafting custom macros for reading/writing each system > register provide generics accessors, read_sysreg and write_sysreg, for > this purpose. > > Unlike read_cpuid, calls

Re: [PATCH v2 02/21] arm64: KVM: Add a HYP-specific header file

2015-11-30 Thread Christoffer Dall
On Fri, Nov 27, 2015 at 06:49:56PM +, Marc Zyngier wrote: > In order to expose the various EL2 services that are private to > the hypervisor, add a new hyp.h file. > > So far, it only contains mundane things such as section annotation > and VA manipulation. > > Signed-off-by: Marc Zyngier

Re: [PATCH v2 03/21] arm64: KVM: Implement vgic-v2 save/restore

2015-11-30 Thread Christoffer Dall
On Fri, Nov 27, 2015 at 06:49:57PM +, Marc Zyngier wrote: > Implement the vgic-v2 save restore (mostly) as a direct translation > of the assembly code version. > > Signed-off-by: Marc Zyngier > --- > arch/arm64/kvm/Makefile | 1 + > arch/arm64/kvm/hyp/Makefile

Re: [PATCH v2 05/21] arm64: KVM: Implement timer save/restore

2015-11-30 Thread Christoffer Dall
On Fri, Nov 27, 2015 at 06:49:59PM +, Marc Zyngier wrote: > Implement the timer save restore as a direct translation of > the assembly code version. > > Signed-off-by: Marc Zyngier > --- > arch/arm64/kvm/hyp/Makefile | 1 + > arch/arm64/kvm/hyp/hyp.h

Re: [PATCH v2 00/21] arm64: KVM: world switch in C

2015-11-30 Thread Christoffer Dall
On Fri, Nov 27, 2015 at 06:49:54PM +, Marc Zyngier wrote: > Once upon a time, the KVM/arm64 world switch was a nice, clean, lean > and mean piece of hand-crafted assembly code. Over time, features have > crept in, the code has become harder to maintain, and the smallest > change is a pain to

Re: [PATCH v2 00/21] arm64: KVM: world switch in C

2015-11-30 Thread Mario Smarduch
On 11/30/2015 12:33 PM, Christoffer Dall wrote: > On Fri, Nov 27, 2015 at 06:49:54PM +, Marc Zyngier wrote: >> Once upon a time, the KVM/arm64 world switch was a nice, clean, lean >> and mean piece of hand-crafted assembly code. Over time, features have >> crept in, the code has become

Re: [PATCH v4 08/21] KVM: ARM64: Add reset and access handlers for PMXEVTYPER register

2015-11-30 Thread Shannon Zhao
On 2015/12/1 2:12, Marc Zyngier wrote: > On Fri, 30 Oct 2015 14:21:50 +0800 > Shannon Zhao wrote: > >> > From: Shannon Zhao >> > >> > Since the reset value of PMXEVTYPER is UNKNOWN, use reset_unknown or >> > reset_unknown_cp15 for its reset

<    4   5   6   7   8   9   10   11   12   13   >