Re: [PATCH] acpi_piix4: remove bad save/restore of cpus_sts

On 04/18/2011 04:56 PM, Isaku Yamahata wrote: This patch would fix the segfaults. But I suppose the followings are necessary. - PIIX4PMState::gpe_cpu needs to be saved/loaded somewhere Yes. Juan? - gpe_writeb() needs to handle PROC_BASE ... PROC_BASE+31 like gpe_readb(). To be honest, I

Re: [PATCH] acpi_piix4: remove bad save/restore of cpus_sts

This patch would fix the segfaults. But I suppose the followings are necessary. - PIIX4PMState::gpe_cpu needs to be saved/loaded somewhere - gpe_writeb() needs to handle PROC_BASE ... PROC_BASE+31 like gpe_readb(). To be honest, I don't see why gpe_readb/writeb() are used for

Re: [PATCH] acpi_piix4: remove bad save/restore of cpus_sts

On Mon, Apr 18, 2011 at 10:56:58PM +0900, Isaku Yamahata wrote: - enable/disable_processor() manipulates gpe-sts pointer. it should be gpe-sts[0] |= PIIX4_CPU_HOTPLUG_STATUS The last one is wrong. enable/diable_processor() looks correct. -- yamahata -- To unsubscribe from this list: send