Re: [PATCH 5/6] KVM: x86: Add new dirty logging kvm_x86_ops for PML

2015-02-05 Thread Radim Krčmář
2015-02-05 14:29+0800, Kai Huang: > >>+ /* Still write protect RO slot */ > >>+ if (new->flags & KVM_MEM_READONLY) { > >>+ kvm_mmu_slot_remove_write_access(kvm, new); > >We didn't write protect RO slots before, does this patch depend on it? > No PML doesn't depend on it to work. It's

Re: [PATCH 5/6] KVM: x86: Add new dirty logging kvm_x86_ops for PML

2015-02-04 Thread Kai Huang
On 02/03/2015 11:53 PM, Radim Krčmář wrote: 2015-01-28 10:54+0800, Kai Huang: This patch adds new kvm_x86_ops dirty logging hooks to enable/disable dirty logging for particular memory slot, and to flush potentially logged dirty GPAs before reporting slot->dirty_bitmap to userspace. kvm x86 com

Re: [PATCH 5/6] KVM: x86: Add new dirty logging kvm_x86_ops for PML

2015-02-03 Thread Radim Krčmář
2015-01-28 10:54+0800, Kai Huang: > This patch adds new kvm_x86_ops dirty logging hooks to enable/disable dirty > logging for particular memory slot, and to flush potentially logged dirty GPAs > before reporting slot->dirty_bitmap to userspace. > > kvm x86 common code calls these hooks when they a