On Wed, Mar 17, 2010 at 03:49:19PM +0800, Xiao Guangrong wrote:
> Using bitmap_empty() to see whether memslot->dirty_bitmap is empty
>
> Changlog:
> cleanup x86 specific kvm_vm_ioctl_get_dirty_log() and fix a local
> parameter's type address Takuya Yoshikawa's suggestion
>
> Signed-off-by: Xiao
Takuya Yoshikawa wrote:
>
> Ah, probably checking the git log will explain you why it is like that!
> Marcelo's work? IIRC.
Oh, i find this commit:
commit 706831a7faec7ac0d3057d20df8234c45bbbc3c5
Author: Marcelo Tosatti
Date: Wed Dec 23 14:35:22 2009 -0200
KVM: use SRCU for dirty log
Xiao Guangrong wrote:
Takuya Yoshikawa wrote:
Oh, for such a tiny comment.
Your comment is valuable although it's tiny :-)
What I said was just you may be able to use bitmap_empty() instead of
-for (i = 0; !is_dirty && i < n/sizeof(long); i++)
-is_dirty = memslot->dirty_bitm
Takuya Yoshikawa wrote:
>
> Oh, for such a tiny comment.
Your comment is valuable although it's tiny :-)
>
>
> What I said was just you may be able to use bitmap_empty() instead of
>
>> -for (i = 0; !is_dirty && i < n/sizeof(long); i++)
>> -is_dirty = memslot->dirty_bitmap[i];
Xiao Guangrong wrote:
Using bitmap_empty() to see whether memslot->dirty_bitmap is empty
Changlog:
cleanup x86 specific kvm_vm_ioctl_get_dirty_log() and fix a local
parameter's type address Takuya Yoshikawa's suggestion
Oh, for such a tiny comment.
Signed-off-by: Xiao Guangrong
---
arch/