Re: [PATCH v4 4/6] KVM: MMU: prefetch ptes when intercepted guest #PF

2010-07-05 Thread Marcelo Tosatti
On Sat, Jul 03, 2010 at 04:08:42PM +0800, Xiao Guangrong wrote: Marcelo Tosatti wrote: + + if (is_rsvd_bits_set(vcpu, gpte, PT_PAGE_TABLE_LEVEL)) + break; BTW, doesnt sync_page also lack reserved bit checking? (unrelated to this patch). I think

Re: [PATCH v4 4/6] KVM: MMU: prefetch ptes when intercepted guest #PF

2010-07-05 Thread Xiao Guangrong
Marcelo Tosatti wrote: On Sat, Jul 03, 2010 at 04:08:42PM +0800, Xiao Guangrong wrote: Marcelo Tosatti wrote: + + if (is_rsvd_bits_set(vcpu, gpte, PT_PAGE_TABLE_LEVEL)) + break; BTW, doesnt sync_page also lack reserved bit checking? (unrelated to this patch).

Re: [PATCH v4 4/6] KVM: MMU: prefetch ptes when intercepted guest #PF

2010-07-03 Thread Xiao Guangrong
Marcelo Tosatti wrote: + +if (is_rsvd_bits_set(vcpu, gpte, PT_PAGE_TABLE_LEVEL)) +break; BTW, doesnt sync_page also lack reserved bit checking? (unrelated to this patch). I think it's not since if EPT is enabled, no unsync page exist, the sync page path

Re: [PATCH v4 4/6] KVM: MMU: prefetch ptes when intercepted guest #PF

2010-07-02 Thread Marcelo Tosatti
On Thu, Jul 01, 2010 at 09:55:17PM +0800, Xiao Guangrong wrote: Support prefetch ptes when intercept guest #PF, avoid to #PF by later access If we meet any failure in the prefetch path, we will exit it and not try other ptes to avoid become heavy path Note: this speculative will mark page