Re: [RFC] Bring in all the Linux headers we depend on in QEMU

2009-05-04 Thread Avi Kivity
Anthony Liguori wrote: Sorry this explanation is long winded, but this is a messy situation. In Linux, there isn't a very consistent policy about userspace kernel header inclusion. On a typical Linux system, you're likely to find kernel headers in three places. glibc headers

Re: [RFC] Bring in all the Linux headers we depend on in QEMU

2009-05-04 Thread Arnd Bergmann
On Sunday 03 May 2009, Anthony Liguori wrote: A classic example is linux/compiler.h and the broken usbdevice_fs.h header that depends on it. There are still distributions today that QEMU doesn't compile on because of this. Can you clarify this? I can't find any version of usbdevice_fs.h that

Re: [RFC] Bring in all the Linux headers we depend on in QEMU

2009-05-04 Thread Arnd Bergmann
On Monday 04 May 2009, Mark McLoughlin wrote: Right, but if you e.g. try to build a newer qemu-kvm on F10, you currently need newer kvm kernel headers - IMHO, we should use #ifdef to allow newer qemu-kvm build with older kvm headers. I think the kvm and virtio headers should just be shipped

Re: [RFC] Bring in all the Linux headers we depend on in QEMU

2009-05-04 Thread Anthony Liguori
Arnd Bergmann wrote: On Monday 04 May 2009, Mark McLoughlin wrote: Right, but if you e.g. try to build a newer qemu-kvm on F10, you currently need newer kvm kernel headers - IMHO, we should use #ifdef to allow newer qemu-kvm build with older kvm headers. I think the kvm and virtio

Re: [RFC] Bring in all the Linux headers we depend on in QEMU

2009-05-04 Thread Avi Kivity
Anthony Liguori wrote: I don't see the need to copy all the core headers. These should have been working for ages, and hardly ever see changes that are relevant to kvm. If we want to use virtio_*.h instead of duplicating the copies as we are now, then we need all of the core headers

Re: [Qemu-devel] Re: [RFC] Bring in all the Linux headers we depend on in QEMU

2009-05-04 Thread Christoph Hellwig
On Mon, May 04, 2009 at 04:38:12PM +0300, Avi Kivity wrote: qemu provides virtio, it doesn't consume it. We can merge the virtio headers and remove the linuxisms. Yeah. virtio is a one the (virtual) wire protocol, not a kernel ABI in the tradition sense. qemu should have it's own defintion.

Re: [RFC] Bring in all the Linux headers we depend on in QEMU

2009-05-04 Thread Avi Kivity
Anthony Liguori wrote: Thinking again about it, this is not really necessary. In general a distro provides kernel headers matched to the running kernel. For example F10 provides kernel-headers-2.6.27.21-170.2.56.fc10.x86_64 to go along with kernel-2.6.27.21-170.2.56.fc10.x86_64. So a user

Re: [RFC] Bring in all the Linux headers we depend on in QEMU

2009-05-04 Thread Anthony Liguori
Arnd Bergmann wrote: On Sunday 03 May 2009, Anthony Liguori wrote: A classic example is linux/compiler.h and the broken usbdevice_fs.h header that depends on it. There are still distributions today that QEMU doesn't compile on because of this. Can you clarify this? I can't find any

Re: [Qemu-devel] Re: [RFC] Bring in all the Linux headers we depend on in QEMU

2009-05-04 Thread Avi Kivity
Mark McLoughlin wrote: On Mon, 2009-05-04 at 12:08 +0300, Avi Kivity wrote: In general a distro provides kernel headers matched to the running kernel. For example F10 provides kernel-headers-2.6.27.21-170.2.56.fc10.x86_64 to go along with kernel-2.6.27.21-170.2.56.fc10.x86_64. So a user

Re: [RFC] Bring in all the Linux headers we depend on in QEMU

2009-05-04 Thread Anthony Liguori
Avi Kivity wrote: Anthony Liguori wrote: Comments? Thinking again about it, this is not really necessary. In general a distro provides kernel headers matched to the running kernel. For example F10 provides kernel-headers-2.6.27.21-170.2.56.fc10.x86_64 to go along with