Ubuntu Patches [was Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network]

2009-10-30 Thread Dustin Kirkland
On Thu, Oct 29, 2009 at 6:22 PM, Scott Tsai wrote: > What's the easiest way to see the patches to qemu that Canonical > carries for the different Ubuntu releases? > (I think http://patches.ubuntu.com/ only diffs against Debian for the > last stable Ubuntu release?) Correct. That site is sort of

Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-29 Thread Scott Tsai
Hi, Dustin, What's the easiest way to see the patches to qemu that Canonical carries for the different Ubuntu releases? (I think http://patches.ubuntu.com/ only diffs against Debian for the last stable Ubuntu release?) Also, is there a way for an outside developer to get email notifications when a

Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-29 Thread Mark McLoughlin
On Thu, 2009-10-29 at 10:13 -0500, Dustin Kirkland wrote: > On Thu, 2009-10-29 at 15:01 +, Mark McLoughlin wrote: > > Sorry, should be VIRTIO_NET_F_CSUM ... the rest is correct > > Brilliant! > > Works like a champ. I'll send a patch in a subsequent email. Would you > add a signed-off-by (o

Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-29 Thread Dustin Kirkland
On Thu, 2009-10-29 at 15:01 +, Mark McLoughlin wrote: > Sorry, should be VIRTIO_NET_F_CSUM ... the rest is correct Brilliant! Works like a champ. I'll send a patch in a subsequent email. Would you add a signed-off-by (or whatever), Mark? :-Dustin signature.asc Description: This is a digi

Re: qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-29 Thread Michael S. Tsirkin
On Thu, Oct 29, 2009 at 04:38:22PM +0200, Avi Kivity wrote: > On 10/29/2009 02:23 PM, Michael S. Tsirkin wrote: >> On Thu, Oct 29, 2009 at 09:16:43AM +, Mark McLoughlin wrote: >> >>> I agree we shouldn't exit in this scenario >>> >> virtio in qemu generally seems to handle guest error

Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-29 Thread Mark McLoughlin
On Thu, 2009-10-29 at 10:01 -0500, Dustin Kirkland wrote: > On Thu, 2009-10-29 at 14:48 +, Mark McLoughlin wrote: > > Ah, it all makes sense now. > > > > I was getting confused between HOST_* and GUEST_* > > > > this should have been: > > > > features |= (1 << VIRTIO_NET_F_MAC); > >

Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-29 Thread Dustin Kirkland
On Thu, 2009-10-29 at 14:48 +, Mark McLoughlin wrote: > Ah, it all makes sense now. > > I was getting confused between HOST_* and GUEST_* > > this should have been: > > features |= (1 << VIRTIO_NET_F_MAC); > features |= (1 << VIRTIO_NET_F_HOST_CSUM); > features |= (1 << VIRTIO_NE

Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-29 Thread Mark McLoughlin
On Thu, 2009-10-29 at 09:46 -0500, Dustin Kirkland wrote: > On Thu, 2009-10-29 at 09:34 -0500, Dustin Kirkland wrote: > > In the mean time, Hardy's kernel is in git here: > > > > http://kernel.ubuntu.com/git?p=ubuntu/ubuntu-hardy.git;a=summary > > I'll save you a few clicks... > > http://kernel.

Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-29 Thread Mark McLoughlin
On Thu, 2009-10-29 at 09:39 -0500, Anthony Liguori wrote: > Mark McLoughlin wrote: > > On Thu, 2009-10-29 at 09:11 -0500, Anthony Liguori wrote: > > > >> Mark McLoughlin wrote: > >> > tap_set_offload(csum: 1, tso4: 1, tso6: 1, ecn: 1) > being called and get an mtu of 1500 on virb

Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-29 Thread Dustin Kirkland
On Thu, 2009-10-29 at 09:34 -0500, Dustin Kirkland wrote: > In the mean time, Hardy's kernel is in git here: > > http://kernel.ubuntu.com/git?p=ubuntu/ubuntu-hardy.git;a=summary I'll save you a few clicks... http://kernel.ubuntu.com/git?p=ubuntu/ubuntu-hardy.git;a=blob;f=drivers/net/virtio_net.c

Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-29 Thread Dustin Kirkland
On Thu, 2009-10-29 at 09:16 +, Mark McLoughlin wrote: > Hi Dustin, > > On Wed, 2009-10-28 at 14:22 -0500, Dustin Kirkland wrote: > > I believe that we have identified a regression in qemu-kvm-0.11.0. > > Regression versus which previous version of qemu-kvm? Okay, sorry for the ambiguity. I

Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-29 Thread Dustin Kirkland
On Thu, 2009-10-29 at 20:00 +0800, Scott Tsai wrote: > Excerpts from Mark McLoughlin's message of Thu Oct 29 17:16:43 +0800 2009: > > Assuming this is something like the virtio-net in 2.6.26, there was no > > receivable buffers support so (as Scott points out) it must be that > > we've read a packe

Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-29 Thread Anthony Liguori
Mark McLoughlin wrote: On Thu, 2009-10-29 at 09:11 -0500, Anthony Liguori wrote: Mark McLoughlin wrote: tap_set_offload(csum: 1, tso4: 1, tso6: 1, ecn: 1) being called and get an mtu of 1500 on virbr0 using his birdge.sh script. virtio_net_receive2 was trying to transfer a 1534

Re: qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-29 Thread Avi Kivity
On 10/29/2009 02:23 PM, Michael S. Tsirkin wrote: On Thu, Oct 29, 2009 at 09:16:43AM +, Mark McLoughlin wrote: I agree we shouldn't exit in this scenario virtio in qemu generally seems to handle guest errors by calling exit(2). This probably makes it easier to notice the problems,

Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-29 Thread Dustin Kirkland
On Thu, 2009-10-29 at 14:25 +, Mark McLoughlin wrote: > On Thu, 2009-10-29 at 09:11 -0500, Anthony Liguori wrote: > > Mark McLoughlin wrote: > > > > > >> tap_set_offload(csum: 1, tso4: 1, tso6: 1, ecn: 1) > > >> being called and get an mtu of 1500 on virbr0 using his birdge.sh script. > > >> >

Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-29 Thread Mark McLoughlin
On Thu, 2009-10-29 at 09:11 -0500, Anthony Liguori wrote: > Mark McLoughlin wrote: > > > >>tap_set_offload(csum: 1, tso4: 1, tso6: 1, ecn: 1) > >> being called and get an mtu of 1500 on virbr0 using his birdge.sh script. > >> > >> virtio_net_receive2 was trying to transfer a 1534 byte packet (1

Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-29 Thread Anthony Liguori
Mark McLoughlin wrote: tap_set_offload(csum: 1, tso4: 1, tso6: 1, ecn: 1) being called and get an mtu of 1500 on virbr0 using his birdge.sh script. virtio_net_receive2 was trying to transfer a 1534 byte packet (1524 'size' + 10 'virtio_net_hdr') and the guest only had 1524 bytes of sp

Re: qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-29 Thread Michael S. Tsirkin
On Thu, Oct 29, 2009 at 09:16:43AM +, Mark McLoughlin wrote: > I agree we shouldn't exit in this scenario virtio in qemu generally seems to handle guest errors by calling exit(2). This probably makes it easier to notice the problems, but is likely not the right thing to do. A simple way to te

Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-29 Thread Scott Tsai
> Hmm - 0x930 doesn't seem right. Is that 930 decimal, 0x3a2 hex? yup. printf format string typo. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-29 Thread Mark McLoughlin
On Thu, 2009-10-29 at 20:00 +0800, Scott Tsai wrote: > Excerpts from Mark McLoughlin's message of Thu Oct 29 17:16:43 +0800 2009: > > Assuming this is something like the virtio-net in 2.6.26, there was no > > receivable buffers support so (as Scott points out) it must be that > > we've read a packe

Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-29 Thread Scott Tsai
Excerpts from Mark McLoughlin's message of Thu Oct 29 17:16:43 +0800 2009: > Assuming this is something like the virtio-net in 2.6.26, there was no > receivable buffers support so (as Scott points out) it must be that > we've read a packet from the tap device which is >1514 bytes (or >1524 > bytes

Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-29 Thread Mark McLoughlin
Hi Dustin, On Wed, 2009-10-28 at 14:22 -0500, Dustin Kirkland wrote: > I believe that we have identified a regression in qemu-kvm-0.11.0. Regression versus which previous version of qemu-kvm? > The kvm process crashes for older guests with virtio networking, when > the guest's incoming network c

Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-28 Thread Scott Tsai
Excerpts from Dustin Kirkland's message of Thu Oct 29 03:22:43 +0800 2009: > We're tracking this issue at: > * https://bugs.launchpad.net/ubuntu/+source/qemu-kvm/+bug/458521 > > I'll gladly review and test patches, or take pointers on where I might > look to solve this issue. Try the following p

Re: qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-28 Thread Dustin Kirkland
On Wed, Oct 28, 2009 at 2:22 PM, Dustin Kirkland wrote: > I have not reproduced the problem: >  a) by saturating the guest's outgoing network >  b) with newer guests ( >= 2.6.27 ) >  c) on kvm-84 on the host d) or by using e1000, or rtl8139 NIC models. :-Dustin -- To unsubscribe from this list:

qemu-kvm-0.11 regression, crashes on older guests with virtio network

2009-10-28 Thread Dustin Kirkland
I believe that we have identified a regression in qemu-kvm-0.11.0. The kvm process crashes for older guests with virtio networking, when the guest's incoming network connection is saturated. The subject guest is Ubuntu 8.04 Hardy, 2.6.24 kernel with virtio backports. For your convenience, I have