Re: virtio-blk performance and MSI

2009-08-11 Thread Eran Rom
Christoph Hellwig lst.de> writes: > Michael suggested to me a while ago to try MSI with virtio-blk and I > played with this small patch: > which gave about 5% speedups on 4k sized reads and writes, see the full > iozone output I attached. > > File size set to 131072 KB > Record Siz

Re: virtio-blk performance and MSI

2009-08-11 Thread Eran Rom
Christoph Hellwig lst.de> writes: > > > File size set to 131072 KB > Record Size 4 KB > O_DIRECT feature enabled > Command line used: iozone -s 128m -r 4k -I -f /dev/sdb is /dev/sdb a local disk, network drive attached via FC/IB, something else? What is the command line

Re: virtio-blk performance and MSI

2009-08-11 Thread Eran Rom
Christoph Hellwig lst.de> writes: > > File size set to 131072 KB > Record Size 4 KB > O_DIRECT feature enabled > Command line used: iozone -s 128m -r 4k -I -f /dev/sdb Apologies for multiple posts, might have a problem with my mail. Can you please elaborate more on the con

Re: virtio-blk performance and MSI

2009-08-09 Thread Michael S. Tsirkin
On Sun, Aug 09, 2009 at 01:01:35PM +0300, Avi Kivity wrote: > On 08/06/2009 07:35 PM, Christoph Hellwig wrote: >> Michael suggested to me a while ago to try MSI with virtio-blk and I >> played with this small patch: >> >> >> Index: qemu-kvm/hw/virtio-blk.c >> ===

Re: [Qemu-devel] Re: virtio-blk performance and MSI

2009-08-09 Thread Michael S. Tsirkin
On Sun, Aug 09, 2009 at 09:13:13PM +0200, Christoph Hellwig wrote: > On Sun, Aug 09, 2009 at 08:49:23PM +0300, Avi Kivity wrote: > > Sorry, confused. Upstream doesn't use kvm for msi (everything's done in > > userspace). What exactly blocks us here? > > Hmm, good question. Michael, do you know

Re: [Qemu-devel] Re: virtio-blk performance and MSI

2009-08-09 Thread Michael S. Tsirkin
On Sun, Aug 09, 2009 at 07:41:00PM +0200, Christoph Hellwig wrote: > On Sun, Aug 09, 2009 at 01:01:35PM +0300, Avi Kivity wrote: > > Looks good. Anthony, I think this applies upstream? > > This applies upstream, but as mentioned we can't just use it as-is. > We'll very recent kvm kernel support f

Re: [Qemu-devel] Re: virtio-blk performance and MSI

2009-08-09 Thread Christoph Hellwig
On Sun, Aug 09, 2009 at 08:49:23PM +0300, Avi Kivity wrote: > Sorry, confused. Upstream doesn't use kvm for msi (everything's done in > userspace). What exactly blocks us here? Hmm, good question. Michael, do you know if we can just enabled MSI unconditionally in upstream qemu, or are there gu

Re: [Qemu-devel] Re: virtio-blk performance and MSI

2009-08-09 Thread Avi Kivity
On 08/09/2009 08:41 PM, Christoph Hellwig wrote: On Sun, Aug 09, 2009 at 01:01:35PM +0300, Avi Kivity wrote: Looks good. Anthony, I think this applies upstream? This applies upstream, but as mentioned we can't just use it as-is. We'll very recent kvm kernel support for multiple MSI

Re: [Qemu-devel] Re: virtio-blk performance and MSI

2009-08-09 Thread Christoph Hellwig
On Sun, Aug 09, 2009 at 01:01:35PM +0300, Avi Kivity wrote: > Looks good. Anthony, I think this applies upstream? This applies upstream, but as mentioned we can't just use it as-is. We'll very recent kvm kernel support for multiple MSI vectors, and when the host doesn't have it even 2.6.30 crashe

Re: virtio-blk performance and MSI

2009-08-09 Thread Avi Kivity
On 08/06/2009 07:35 PM, Christoph Hellwig wrote: Michael suggested to me a while ago to try MSI with virtio-blk and I played with this small patch: Index: qemu-kvm/hw/virtio-blk.c === --- qemu-kvm.orig/hw/virtio-blk.c +++ qemu-kvm/

virtio-blk performance and MSI

2009-08-06 Thread Christoph Hellwig
Michael suggested to me a while ago to try MSI with virtio-blk and I played with this small patch: Index: qemu-kvm/hw/virtio-blk.c === --- qemu-kvm.orig/hw/virtio-blk.c +++ qemu-kvm/hw/virtio-blk.c @@ -416,6 +416,7 @@ VirtIODevice *v