Re: [ANNOUNCE] qemu-kvm-0.12.1.1

2009-12-23 Thread Thomas Treutner
On Tuesday 22 December 2009 13:50:03 you wrote: Changes from qemu-kvm-0.12.1 - fix build error due to missing kvm_save_mpstate() on some configurations - fix option rom loading (fixes boot=on) Doesn't compile for me with default settings (./configure make): CCx86_64-softmmu/i386-dis.o

[Autotest PATCH] KVM test: physical_resources_check subtest:Fixup `mem_chk_cmd' for rhel3.9

2009-12-23 Thread Yolkfull Chow
Signed-off-by: Yolkfull Chow yz...@redhat.com --- client/tests/kvm/tests_base.cfg.sample |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/client/tests/kvm/tests_base.cfg.sample b/client/tests/kvm/tests_base.cfg.sample index a403399..f5a55a0 100644 ---

Re: [ANNOUNCE] qemu-kvm-0.12.1.1

2009-12-23 Thread Avi Kivity
On 12/23/2009 10:16 AM, Thomas Treutner wrote: On Tuesday 22 December 2009 13:50:03 you wrote: Changes from qemu-kvm-0.12.1 - fix build error due to missing kvm_save_mpstate() on some configurations - fix option rom loading (fixes boot=on) Doesn't compile for me with default settings

Re: [PATCH] slow_map: minor improvements to ROM BAR handling

2009-12-23 Thread Avi Kivity
On 12/22/2009 06:00 PM, Alexander Graf wrote: Plus, you have a fixed length instruction length, likely more regular too. I imagine powerpc is load/store, so you don't have to emulate a zillion ALU instructions? Well, it's certainly doable (and easier than on x86). But I'm on the same

[PATCHv2] slow_map: minor improvements to ROM BAR handling

2009-12-23 Thread Michael S. Tsirkin
ROM BAR can be handled same as regular BAR: load_option_roms utility will take care of copying it to RAM as appropriate. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- Changes from v1: made ROM BAR read-only. hw/device-assignment.c | 23 +++ 1 files changed, 11

Re: [PATCH] slow_map: minor improvements to ROM BAR handling

2009-12-23 Thread Michael S. Tsirkin
On Tue, Dec 22, 2009 at 05:39:22PM +0200, Avi Kivity wrote: On 12/22/2009 05:36 PM, Alexander Graf wrote: Is there a way to trap this and fprintf something? I don't think so. KVM will just trap on execution outside of RAM and either fail badly or throw something bad into the guest.

Re: [PATCHv2] slow_map: minor improvements to ROM BAR handling

2009-12-23 Thread Avi Kivity
On 12/23/2009 11:12 AM, Michael S. Tsirkin wrote: ROM BAR can be handled same as regular BAR: load_option_roms utility will take care of copying it to RAM as appropriate. Signed-off-by: Michael S. Tsirkinm...@redhat.com --- Changes from v1: made ROM BAR read-only. hw/device-assignment.c |

Discordant results between UnixBench and nBench

2009-12-23 Thread Matthieu Olivier
All, I am performing a study about KVM. (Shame on me, I did not check the version of kvm module. All I know is that I was using the last Red Hat EL 5.4. Anyway). I used a DELL server 2950, with: - 1 processor Xeon L5240 (3 Ghz, 6 Mo cache) - 8 GB of RAM - 4 disks SAS 15k in RAID-1 I created a

Re: Discordant results between UnixBench and nBench

2009-12-23 Thread Avi Kivity
On 12/23/2009 11:43 AM, Matthieu Olivier wrote: All, I am performing a study about KVM. (Shame on me, I did not check the version of kvm module. All I know is that I was using the last Red Hat EL 5.4. Anyway). I used a DELL server 2950, with: - 1 processor Xeon L5240 (3 Ghz, 6 Mo cache) - 8

Re: buildbot failure in qemu-kvm on default_x86_64_debian_5_0

2009-12-23 Thread Avi Kivity
On 12/19/2009 04:03 AM, qemu-...@buildbot.b1-systems.de wrote: The Buildbot has detected a new failure of default_x86_64_debian_5_0 on qemu-kvm. Full details are available at: http://buildbot.b1-systems.de/qemu-kvm/builders/default_x86_64_debian_5_0/builds/208 Buildbot URL:

[PATCHv3] slow_map: minor improvements to ROM BAR handling

2009-12-23 Thread Michael S. Tsirkin
ROM BAR can be handled same as regular BAR: load_option_roms utility will take care of copying it to RAM as appropriate. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- Changes from v2: replace ?: with an if statement changes from v1: make ROM bar read only

Re: [GIT PULL] AlacrityVM guest drivers for 2.6.33

2009-12-23 Thread Andi Kleen
i.e. it has all the makings of a stupid, avoidable, permanent fork. The thing Nearly. There was no equivalent of a kernel based virtual driver host before. - Are a pure software concept and any compatibility mismatch is self-inflicted. The patches

Re: [ANNOUNCE] qemu-kvm-0.12.1.1

2009-12-23 Thread Thomas Treutner
On Wednesday 23 December 2009 09:52:47 you wrote: It looks like a problem in the Xen library? Or maybe we're including the library twice. There's no unlock_pages in qemu. Can you rerun with V=1 to see the full command line? Please see here: http://pastebin.com/f4d79c982 (make -j8 vs. just

Re: [GIT PULL] AlacrityVM guest drivers for 2.6.33

2009-12-23 Thread Avi Kivity
On 12/23/2009 12:13 PM, Andi Kleen wrote: i.e. it has all the makings of a stupid, avoidable, permanent fork. The thing Nearly. There was no equivalent of a kernel based virtual driver host before. These are guest drivers. We have virtio drivers, and Xen drivers (which are

Re: [ANNOUNCE] qemu-kvm-0.12.1.1

2009-12-23 Thread Avi Kivity
On 12/23/2009 12:15 PM, Thomas Treutner wrote: On Wednesday 23 December 2009 09:52:47 you wrote: It looks like a problem in the Xen library? Or maybe we're including the library twice. There's no unlock_pages in qemu. Can you rerun with V=1 to see the full command line? Please see

Re: buildbot failure in qemu-kvm on default_x86_64_debian_5_0

2009-12-23 Thread Daniel Gollub
On Wednesday 23 December 2009 11:00:12 am Avi Kivity wrote: On 12/19/2009 04:03 AM, qemu-...@buildbot.b1-systems.de wrote: The Buildbot has detected a new failure of default_x86_64_debian_5_0 on qemu-kvm. Full details are available at:

Re: Discordant results between UnixBench and nBench

2009-12-23 Thread Matthieu Olivier
On Wed, Dec 23, 2009 at 10:53 AM, Avi Kivity a...@redhat.com wrote: On 12/23/2009 11:43 AM, Matthieu Olivier wrote: All, I am performing a study about KVM. (Shame on me, I did not check the version of kvm module. All I know is that I was using the last Red Hat EL 5.4. Anyway).  I used a

Re: Discordant results between UnixBench and nBench

2009-12-23 Thread Avi Kivity
On 12/23/2009 12:35 PM, Matthieu Olivier wrote: To tell the truth, I had to test some others hypervisors, so now I don't have KVM installed anymore. I used top for following bench progress on 2 or 3 VM, but unfortunately I did not catch their output in a file, neither I used kvm_stat (by

Re: [ANNOUNCE] qemu-kvm-0.12.1.1

2009-12-23 Thread Thomas Treutner
On Wednesday 23 December 2009 11:24:04 Avi Kivity wrote: Please post a full log, after 'make clean'. http://pastebin.com/f404c8648 kr,t -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: buildbot failure in qemu-kvm on default_x86_64_debian_5_0

2009-12-23 Thread Daniel Gollub
On Wednesday 23 December 2009 11:00:12 am Avi Kivity wrote: On 12/19/2009 04:03 AM, qemu-...@buildbot.b1-systems.de wrote: The Buildbot has detected a new failure of default_x86_64_debian_5_0 on qemu-kvm. Full details are available at:

Re: [ANNOUNCE] qemu-kvm-0.12.1.1

2009-12-23 Thread Avi Kivity
On 12/23/2009 12:58 PM, Thomas Treutner wrote: On Wednesday 23 December 2009 11:24:04 Avi Kivity wrote: Please post a full log, after 'make clean'. http://pastebin.com/f404c8648 Oh, I missed it at first - looks like libxenguest and libxenctrl conflict. Copying Gerd for an

[patch 00/11] convert slotslock to SRCU

2009-12-23 Thread Marcelo Tosatti
Now that synchronize_srcu_expedited is in the tree, we can continue the convertion of slots_lock to SRCU. Results: up: srcu-memslot: cpuid 2157 vmcall 1992 mov_from_cr8 11 mov_to_cr8 17 inl_from_pmtimer 11226 ipi (skipped) ipi+halt (skipped) stock: cpuid 2272 vmcall 2114 mov_from_cr8 11

[patch 02/11] KVM: modify alias layout in x86s struct kvm_arch

2009-12-23 Thread Marcelo Tosatti
Have a pointer to an allocated region inside x86's kvm_arch. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Index: kvm/arch/x86/include/asm/kvm_host.h === --- kvm.orig/arch/x86/include/asm/kvm_host.h +++

[patch 10/11] KVM: switch vcpu context to use SRCU

2009-12-23 Thread Marcelo Tosatti
Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Index: kvm/arch/x86/kvm/x86.c === --- kvm.orig/arch/x86/kvm/x86.c +++ kvm/arch/x86/kvm/x86.c @@ -1307,15 +1307,15 @@ static int __msr_io(struct kvm_vcpu *vcp int

[patch 08/11] KVM: x86: switch kvm_set_memory_alias to SRCU update

2009-12-23 Thread Marcelo Tosatti
Using a similar two-step procedure as for memslots. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Index: kvm/arch/x86/include/asm/kvm_host.h === --- kvm.orig/arch/x86/include/asm/kvm_host.h +++

[patch 03/11] KVM: split kvm_arch_set_memory_region into prepare and commit

2009-12-23 Thread Marcelo Tosatti
Required for SRCU convertion later. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Index: kvm/arch/ia64/kvm/kvm-ia64.c === --- kvm.orig/arch/ia64/kvm/kvm-ia64.c +++ kvm/arch/ia64/kvm/kvm-ia64.c @@ -1576,15 +1576,14 @@ out:

[patch 05/11] KVM: use gfn_to_pfn_memslot in kvm_iommu_map_pages

2009-12-23 Thread Marcelo Tosatti
So its possible to iommu map a memslot before making it visible to kvm. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Index: kvm/include/linux/kvm_host.h === --- kvm.orig/include/linux/kvm_host.h +++

[patch 11/11] KVM: convert slots_lock to a mutex

2009-12-23 Thread Marcelo Tosatti
Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Index: kvm/arch/x86/kvm/vmx.c === --- kvm.orig/arch/x86/kvm/vmx.c +++ kvm/arch/x86/kvm/vmx.c @@ -2227,7 +2227,7 @@ static int alloc_apic_access_page(struct struct

[patch 01/11] KVM: modify memslots layout in struct kvm

2009-12-23 Thread Marcelo Tosatti
Have a pointer to an allocated region inside struct kvm. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Index: kvm/arch/x86/kvm/mmu.c === --- kvm.orig/arch/x86/kvm/mmu.c +++ kvm/arch/x86/kvm/mmu.c @@ -809,13 +809,14 @@ static

[patch 07/11] KVM: use SRCU for dirty log

2009-12-23 Thread Marcelo Tosatti
Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Index: kvm/arch/x86/kvm/x86.c === --- kvm.orig/arch/x86/kvm/x86.c +++ kvm/arch/x86/kvm/x86.c @@ -2416,27 +2416,60 @@ static int kvm_vm_ioctl_reinject(struct int

[patch 04/11] KVM: introduce gfn_to_pfn_memslot

2009-12-23 Thread Marcelo Tosatti
Which takes a memslot pointer instead of using kvm-memslots. To be used by SRCU convertion later. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Index: kvm/include/linux/kvm_host.h === --- kvm.orig/include/linux/kvm_host.h +++

Re: [patch 04/11] KVM: introduce gfn_to_pfn_memslot

2009-12-23 Thread Avi Kivity
On 12/23/2009 01:38 PM, Marcelo Tosatti wrote: Which takes a memslot pointer instead of using kvm-memslots. To be used by SRCU convertion later. Signed-off-by: Marcelo Tosattimtosa...@redhat.com @@ -835,21 +835,14 @@ unsigned long gfn_to_hva(struct kvm *kvm }

Re: [GIT PULL] AlacrityVM guest drivers for 2.6.33

2009-12-23 Thread Andi Kleen
http://www.redhat.com/f/pdf/summit/cwright_11_open_source_virt.pdf See slide 32. This is without vhost-net. Thanks. Do you also have latency numbers? It seems like there's definitely still potential for improvement with messages 4K. But for the large messages they indeed look rather good.

Re: [patch 06/11] KVM: introduce kvm-srcu and convert kvm_set_memory_region to SRCU update

2009-12-23 Thread Avi Kivity
On 12/23/2009 01:38 PM, Marcelo Tosatti wrote: Use two steps for memslot deletion: mark the slot invalid (which stops instantiation of new shadow pages for that slot, but allows destruction), then instantiate the new empty slot. Also simplifies kvm_handle_hva locking. r =

Re: Discordant results between UnixBench and nBench

2009-12-23 Thread Avi Kivity
On 12/23/2009 02:27 PM, Matthieu Olivier wrote: Ok, there is an excel file which contain some results. I'm not supposed to give so many informations, but I really need to understand what's the problem. This is strange. Is the machine hyperthreaded? Please supply full /proc/cpuinfo. --

Re: [GIT PULL] AlacrityVM guest drivers for 2.6.33

2009-12-23 Thread Avi Kivity
On 12/23/2009 02:14 PM, Andi Kleen wrote: http://www.redhat.com/f/pdf/summit/cwright_11_open_source_virt.pdf See slide 32. This is without vhost-net. Thanks. Do you also have latency numbers? No. Copying Chris. This was with the tx mitigation timer disabled, so you won't see

Re: Discordant results between UnixBench and nBench

2009-12-23 Thread Avi Kivity
On 12/23/2009 02:55 PM, Matthieu Olivier wrote: I can only see 4 cores in /proc/cpuinfo. According the caract page, there is no hyperthreading. - http://ark.intel.com/Product.aspx?id=35130 In this case the plateau at 4 guests is perfectly understandable. I also wonder why the host

Re: Discordant results between UnixBench and nBench

2009-12-23 Thread Matthieu Olivier
On Wed, Dec 23, 2009 at 1:59 PM, Avi Kivity a...@redhat.com wrote: On 12/23/2009 02:55 PM, Matthieu Olivier wrote: I can only see 4 cores in /proc/cpuinfo. According the caract page, there is no hyperthreading. -  http://ark.intel.com/Product.aspx?id=35130 In this case the plateau at 4

Re: [GIT PULL] AlacrityVM guest drivers for 2.6.33

2009-12-23 Thread Bartlomiej Zolnierkiewicz
On Wednesday 23 December 2009 07:51:29 am Ingo Molnar wrote: * Anthony Liguori anth...@codemonkey.ws wrote: On 12/22/2009 10:01 AM, Bartlomiej Zolnierkiewicz wrote: new e1000 driver is more superior in architecture and do the required work to make the new e1000 driver a full replacement

Re: [GIT PULL] AlacrityVM guest drivers for 2.6.33

2009-12-23 Thread Avi Kivity
On 12/23/2009 03:07 PM, Bartlomiej Zolnierkiewicz wrote: That is a very different situation from the AlacrityVM patches, which: - Are a pure software concept and any compatibility mismatch is self-inflicted. The patches are in fact breaking the ABI to KVM intentionally (for better

Re: [PATCH 0/6 v2] Add support for RDTSCP in VMX

2009-12-23 Thread Marcelo Tosatti
On Tue, Dec 22, 2009 at 08:26:25PM +0200, Avi Kivity wrote: On 12/22/2009 07:26 PM, Marcelo Tosatti wrote: On Sun, Dec 20, 2009 at 11:30:00AM +0200, Avi Kivity wrote: On 12/18/2009 10:48 AM, Sheng Yang wrote: Applied all, thanks. Need to save/restore MSR_TSC_AUX in qemu-kvm.

Re: [GIT PULL] AlacrityVM guest drivers for 2.6.33

2009-12-23 Thread Bartlomiej Zolnierkiewicz
On Wednesday 23 December 2009 02:31:11 pm Avi Kivity wrote: On 12/23/2009 03:07 PM, Bartlomiej Zolnierkiewicz wrote: That is a very different situation from the AlacrityVM patches, which: - Are a pure software concept and any compatibility mismatch is self-inflicted. The patches

Re: [GIT PULL] AlacrityVM guest drivers for 2.6.33

2009-12-23 Thread Avi Kivity
On 12/23/2009 04:08 PM, Bartlomiej Zolnierkiewicz wrote: The device model is exposed to the guest. If you change it, the guest breaks. Huh? Shouldn't non-vbus aware guests continue to work just fine? Sure. But we aren't merging this code in order not to use it. If we switch

Re: [patch 06/11] KVM: introduce kvm-srcu and convert kvm_set_memory_region to SRCU update

2009-12-23 Thread Avi Kivity
On 12/23/2009 04:19 PM, Marcelo Tosatti wrote: On Wed, Dec 23, 2009 at 02:32:55PM +0200, Avi Kivity wrote: On 12/23/2009 01:38 PM, Marcelo Tosatti wrote: Use two steps for memslot deletion: mark the slot invalid (which stops instantiation of new shadow pages for that slot, but allows

Re: qemu-kvm-0.12 bug?

2009-12-23 Thread Thomas Treutner
On Tuesday 22 December 2009 13:25:30 Thomas Treutner wrote: On Tuesday 22 December 2009 13:02:28 Thomas Treutner wrote: Hi, I've switched from -0.11.0 to -0.12 and from 2.6.31.6 to 2.6.32.2 to try the new virtio-memory-API introduced in latest libvirt from git. I can start VMs f.e. by

Re: [GIT PULL] AlacrityVM guest drivers for 2.6.33

2009-12-23 Thread Anthony Liguori
On 12/23/2009 12:15 AM, Kyle Moffett wrote: This is actually something that is of particular interest to me. I have a few prototype boards right now with programmable PCI-E host/device links on them; one of my long-term plans is to finagle vbus into providing multiple virtual devices across

Re: [GIT PULL] AlacrityVM guest drivers for 2.6.33

2009-12-23 Thread Anthony Liguori
On 12/22/2009 06:02 PM, Chris Wright wrote: * Anthony Liguori (anth...@codemonkey.ws) wrote: The virtio-net setup probably made extensive use of pinning and other tricks to make things faster than a normal user would see them. It ends up creating a perfect combination of batching which is

[PATCH 1/2] virtio-blk: add max sectors feature (qemu)

2009-12-23 Thread Avishay Traeger1
This is the accompanying qemu patch for the maximum number of total sectors in an I/O feature. Please CC me on replies, as I am not subscribed. Thanks, Avishay Signed-off-by: Avishay Traeger avis...@il.ibm.com --- diff --git a/block.c b/block.c index 3f3496e..9fa97b8 100644 --- a/block.c +++

[PATCH 1/2] virtio-blk: add max sectors feature (virtio_blk driver)

2009-12-23 Thread Avishay Traeger1
This is a revised patch that allows the guest and host to negotiate the maximum number of total sectors in an I/O. This feature has already been added by Rusty to the virtio spec. Please CC me on replies, as I am not subscribed. Thanks, Avishay Signed-off-by: Avishay Traeger

Re: [patch 06/11] KVM: introduce kvm-srcu and convert kvm_set_memory_region to SRCU update

2009-12-23 Thread Marcelo Tosatti
On Wed, Dec 23, 2009 at 04:33:06PM +0200, Avi Kivity wrote: On 12/23/2009 04:19 PM, Marcelo Tosatti wrote: On Wed, Dec 23, 2009 at 02:32:55PM +0200, Avi Kivity wrote: On 12/23/2009 01:38 PM, Marcelo Tosatti wrote: Use two steps for memslot deletion: mark the slot invalid (which

[PATCH] provide correct pci routing information in mptable

2009-12-23 Thread Gleb Natapov
OpenBSD uses irq routing from mptable, but doesn't create it correctly for PCI bus. This patch adds PCI routing info into mptable. Signed-off-by: Gleb Natapov g...@redhat.com diff --git a/src/mptable.c b/src/mptable.c index 1920dfe..545a41b 100644 --- a/src/mptable.c +++ b/src/mptable.c @@ -9,6

[KVM-AUTOTEST PATCH 1/2] KVM test: add proper prefixes to image, iso and step file paths

2009-12-23 Thread Michael Goldish
Since the control file cleanup, image, iso and step files are expected directly under the KVM test dir by default, but they should be in their respective subdirectories: images should be in kvm/images/, isos should be in kvm/isos/ and step files should be in kvm/steps/. This patch: 1. Makes

[KVM-AUTOTEST PATCH 2/2] KVM test: warn about corrupt PPM files after each test

2009-12-23 Thread Michael Goldish
Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/kvm_preprocessing.py |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/client/tests/kvm/kvm_preprocessing.py b/client/tests/kvm/kvm_preprocessing.py index 5bae2bd..4e45c76 100644 ---

[patch 04/11] KVM: introduce gfn_to_pfn_memslot

2009-12-23 Thread Marcelo Tosatti
Which takes a memslot pointer instead of using kvm-memslots. To be used by SRCU convertion later. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Index: kvm/include/linux/kvm_host.h === --- kvm.orig/include/linux/kvm_host.h +++

[patch 03/11] KVM: split kvm_arch_set_memory_region into prepare and commit

2009-12-23 Thread Marcelo Tosatti
Required for SRCU convertion later. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Index: kvm/arch/ia64/kvm/kvm-ia64.c === --- kvm.orig/arch/ia64/kvm/kvm-ia64.c +++ kvm/arch/ia64/kvm/kvm-ia64.c @@ -1576,15 +1576,14 @@ out:

[patch 08/11] KVM: x86: switch kvm_set_memory_alias to SRCU update

2009-12-23 Thread Marcelo Tosatti
Using a similar two-step procedure as for memslots. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Index: kvm/arch/x86/include/asm/kvm_host.h === --- kvm.orig/arch/x86/include/asm/kvm_host.h +++

[patch 06/11] KVM: introduce kvm-srcu and convert kvm_set_memory_region to SRCU update

2009-12-23 Thread Marcelo Tosatti
Use two steps for memslot deletion: mark the slot invalid (which stops instantiation of new shadow pages for that slot, but allows destruction), then instantiate the new empty slot. Also simplifies kvm_handle_hva locking. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Index:

[patch 02/11] KVM: modify alias layout in x86s struct kvm_arch

2009-12-23 Thread Marcelo Tosatti
Have a pointer to an allocated region inside x86's kvm_arch. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Index: kvm/arch/x86/include/asm/kvm_host.h === --- kvm.orig/arch/x86/include/asm/kvm_host.h +++

[patch 10/11] KVM: switch vcpu context to use SRCU

2009-12-23 Thread Marcelo Tosatti
Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Index: kvm/arch/x86/kvm/x86.c === --- kvm.orig/arch/x86/kvm/x86.c +++ kvm/arch/x86/kvm/x86.c @@ -1307,15 +1307,15 @@ static int __msr_io(struct kvm_vcpu *vcp int

[patch 09/11] KVM: convert io_bus to SRCU

2009-12-23 Thread Marcelo Tosatti
Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Index: kvm/arch/x86/kvm/i8254.c === --- kvm.orig/arch/x86/kvm/i8254.c +++ kvm/arch/x86/kvm/i8254.c @@ -642,13 +642,13 @@ struct kvm_pit *kvm_create_pit(struct kv

[patch 00/11] convert slotslock to SRCU v2

2009-12-23 Thread Marcelo Tosatti
Addressing comments. -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[patch 01/11] KVM: modify memslots layout in struct kvm

2009-12-23 Thread Marcelo Tosatti
Have a pointer to an allocated region inside struct kvm. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Index: kvm/arch/x86/kvm/mmu.c === --- kvm.orig/arch/x86/kvm/mmu.c +++ kvm/arch/x86/kvm/mmu.c @@ -809,13 +809,14 @@ static

Re: [GIT PULL] AlacrityVM guest drivers for 2.6.33

2009-12-23 Thread Gregory Haskins
On 12/23/09 1:51 AM, Ingo Molnar wrote: * Anthony Liguori anth...@codemonkey.ws wrote: On 12/22/2009 10:01 AM, Bartlomiej Zolnierkiewicz wrote: new e1000 driver is more superior in architecture and do the required work to make the new e1000 driver a full replacement for the old one.

Re: [GIT PULL] AlacrityVM guest drivers for 2.6.33

2009-12-23 Thread Chris Wright
* Avi Kivity (a...@redhat.com) wrote: On 12/23/2009 02:14 PM, Andi Kleen wrote: http://www.redhat.com/f/pdf/summit/cwright_11_open_source_virt.pdf See slide 32. This is without vhost-net. Thanks. Do you also have latency numbers? No. Copying Chris. This was with the tx mitigation timer

Re: [GIT PULL] AlacrityVM guest drivers for 2.6.33

2009-12-23 Thread Andi Kleen
And its moot, anyway, as I have already retracted my one outstanding pull request based on Linus' observation. So at this time, I am not advocating _anything_ for upstream inclusion. And I am contemplating _never_ doing so again. It's not worth _this_. That certainly sounds like the wrong

Re: [GIT PULL] AlacrityVM guest drivers for 2.6.33

2009-12-23 Thread Gregory Haskins
On 12/23/09 12:10 PM, Andi Kleen wrote: And its moot, anyway, as I have already retracted my one outstanding pull request based on Linus' observation. So at this time, I am not advocating _anything_ for upstream inclusion. And I am contemplating _never_ doing so again. It's not worth

Re: [GIT PULL] AlacrityVM guest drivers for 2.6.33

2009-12-23 Thread Andi Kleen
It seems like there's definitely still potential for improvement with messages4K. But for the large messages they indeed look rather good. You are misreading the graph. At 4K it is tracking bare metal (the green and yellow lines are bare metal, the red and blue bars are virtio). At 4k

Re: [GIT PULL] AlacrityVM guest drivers for 2.6.33

2009-12-23 Thread Linus Torvalds
On Wed, 23 Dec 2009, Gregory Haskins wrote: And upstream submission is not always like this! I would think the process would come to a grinding halt if it were ;) Well, in all honesty, if it had been non-virtualized drivers I would just have pulled. The pull request all looked sane,

Re: [GIT PULL] AlacrityVM guest drivers for 2.6.33

2009-12-23 Thread Gregory Haskins
On 12/23/09 1:15 AM, Kyle Moffett wrote: On Tue, Dec 22, 2009 at 12:36, Gregory Haskins gregory.hask...@gmail.com wrote: On 12/22/09 2:57 AM, Ingo Molnar wrote: * Gregory Haskins gregory.hask...@gmail.com wrote: Actually, these patches have nothing to do with the KVM folks. [...] That claim

Re: [PATCH] provide correct pci routing information in mptable

2009-12-23 Thread Kevin O'Connor
Thanks Gleb. On Wed, Dec 23, 2009 at 05:29:25PM +0200, Gleb Natapov wrote: - + sizeof(struct mpt_intsrc) * 18); + + sizeof(struct mpt_intsrc) * 34); [...] +foreachpci(bdf, max) { +int pin = pci_config_readb(bdf, PCI_INTERRUPT_PIN); +int

Re: [Alacrityvm-devel] [GIT PULL] AlacrityVM guest drivers for 2.6.33

2009-12-23 Thread Peter W. Morreale
On Wed, 2009-12-23 at 13:14 +0100, Andi Kleen wrote: http://www.redhat.com/f/pdf/summit/cwright_11_open_source_virt.pdf See slide 32. This is without vhost-net. Thanks. Do you also have latency numbers? It seems like there's definitely still potential for improvement with messages

Re: [Alacrityvm-devel] [GIT PULL] AlacrityVM guest drivers for 2.6.33

2009-12-23 Thread Gregory Haskins
On 12/23/09 5:22 AM, Avi Kivity wrote: There was no attempt by Gregory to improve virtio-net. If you truly do not understand why your statement is utterly wrong at this point in the discussion, I feel sorry for you. If you are trying to be purposely disingenuous, you should be ashamed of

Re: [Alacrityvm-devel] [GIT PULL] AlacrityVM guest drivers for 2.6.33

2009-12-23 Thread Gregory Haskins
On 12/23/09 12:52 PM, Peter W. Morreale wrote: On Wed, 2009-12-23 at 13:14 +0100, Andi Kleen wrote: http://www.redhat.com/f/pdf/summit/cwright_11_open_source_virt.pdf See slide 32. This is without vhost-net. Thanks. Do you also have latency numbers? It seems like there's definitely still

Re: [Alacrityvm-devel] [GIT PULL] AlacrityVM guest drivers for 2.6.33

2009-12-23 Thread Chris Wright
* Peter W. Morreale (pmorre...@novell.com) wrote: On Wed, 2009-12-23 at 13:14 +0100, Andi Kleen wrote: http://www.redhat.com/f/pdf/summit/cwright_11_open_source_virt.pdf See slide 32. This is without vhost-net. Thanks. Do you also have latency numbers? It seems like there's

Re: [GIT PULL] AlacrityVM guest drivers for 2.6.33

2009-12-23 Thread Chris Wright
* Anthony Liguori (anth...@codemonkey.ws) wrote: The poor packet latency of virtio-net is a result of the fact that we do software timer based TX mitigation. We do this such that we can decrease the number of exits per-packet and increase throughput. We set a timer for 250ms and

Re: [PATCH] provide correct pci routing information in mptable

2009-12-23 Thread Gleb Natapov
On Wed, Dec 23, 2009 at 01:11:43PM -0500, Kevin O'Connor wrote: Thanks Gleb. On Wed, Dec 23, 2009 at 05:29:25PM +0200, Gleb Natapov wrote: - + sizeof(struct mpt_intsrc) * 18); + + sizeof(struct mpt_intsrc) * 34); [...] +foreachpci(bdf, max) { +

Re: [GIT PULL] AlacrityVM guest drivers for 2.6.33

2009-12-23 Thread Ingo Molnar
* Andi Kleen a...@firstfloor.org wrote: - Are a pure software concept and any compatibility mismatch is self-inflicted. The patches are in fact breaking the ABI to KVM In practice, especially

Re: [PATCHv3] slow_map: minor improvements to ROM BAR handling

2009-12-23 Thread Marcelo Tosatti
On Wed, Dec 23, 2009 at 12:07:47PM +0200, Michael S. Tsirkin wrote: ROM BAR can be handled same as regular BAR: load_option_roms utility will take care of copying it to RAM as appropriate. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- Changes from v2: replace ?: with an if

Re: [GIT PULL] AlacrityVM guest drivers for 2.6.33

2009-12-23 Thread Andi Kleen
Ingo Molnar mi...@elte.hu writes: Yes, there's (obviously) compatibility requirements and artifacts and past mistakes (as with any software interface), but you need to admit it to Yes that's exactly what I meant. yourself that your virtualization is sloppy just like hardware claim is

Re: [GIT PULL] AlacrityVM guest drivers for 2.6.33

2009-12-23 Thread Ira W. Snyder
On Wed, Dec 23, 2009 at 12:34:44PM -0500, Gregory Haskins wrote: On 12/23/09 1:15 AM, Kyle Moffett wrote: On Tue, Dec 22, 2009 at 12:36, Gregory Haskins gregory.hask...@gmail.com wrote: On 12/22/09 2:57 AM, Ingo Molnar wrote: * Gregory Haskins gregory.hask...@gmail.com wrote: Actually,

Re: [PATCH] provide correct pci routing information in mptable

2009-12-23 Thread Kevin O'Connor
On Wed, Dec 23, 2009 at 08:45:07PM +0200, Gleb Natapov wrote: On Wed, Dec 23, 2009 at 01:11:43PM -0500, Kevin O'Connor wrote: Why only increase the allocated storage for intsrc by 16? The loop above seems like it could add a large number of entries. Unfortunately we have to allocate all

Re: [GIT PULL] AlacrityVM guest drivers for 2.6.33

2009-12-23 Thread Andi Kleen
Ira W. Snyder i...@ovro.caltech.edu writes: (You'll quickly find that you must use DMA to transfer data across PCI. AFAIK, CPU's cannot do burst accesses to the PCI bus. I get a 10+ times AFAIK that's what write-combining on x86 does. DMA has other advantages of course. -Andi --

Re: [Alacrityvm-devel] [GIT PULL] AlacrityVM guest drivers for 2.6.33

2009-12-23 Thread Ira W. Snyder
On Wed, Dec 23, 2009 at 09:09:21AM -0600, Anthony Liguori wrote: On 12/23/2009 12:15 AM, Kyle Moffett wrote: This is actually something that is of particular interest to me. I have a few prototype boards right now with programmable PCI-E host/device links on them; one of my long-term plans

Re: [PATCH] provide correct pci routing information in mptable

2009-12-23 Thread Gleb Natapov
On Wed, Dec 23, 2009 at 02:48:24PM -0500, Kevin O'Connor wrote: On Wed, Dec 23, 2009 at 08:45:07PM +0200, Gleb Natapov wrote: On Wed, Dec 23, 2009 at 01:11:43PM -0500, Kevin O'Connor wrote: Why only increase the allocated storage for intsrc by 16? The loop above seems like it could add a

Re: [Alacrityvm-devel] [GIT PULL] AlacrityVM guest drivers for 2.6.33

2009-12-23 Thread Avi Kivity
On 12/23/2009 08:15 PM, Gregory Haskins wrote: On 12/23/09 5:22 AM, Avi Kivity wrote: There was no attempt by Gregory to improve virtio-net. If you truly do not understand why your statement is utterly wrong at this point in the discussion, I feel sorry for you. If you are trying

Re: [PATCH] provide correct pci routing information in mptable

2009-12-23 Thread Kevin O'Connor
On Wed, Dec 23, 2009 at 09:56:23PM +0200, Gleb Natapov wrote: On Wed, Dec 23, 2009 at 02:48:24PM -0500, Kevin O'Connor wrote: On Wed, Dec 23, 2009 at 08:45:07PM +0200, Gleb Natapov wrote: On Wed, Dec 23, 2009 at 01:11:43PM -0500, Kevin O'Connor wrote: Why only increase the allocated

Re: [GIT PULL] AlacrityVM guest drivers for 2.6.33

2009-12-23 Thread Avi Kivity
On 12/23/2009 09:27 PM, Andi Kleen wrote: Ingo Molnarmi...@elte.hu writes: Yes, there's (obviously) compatibility requirements and artifacts and past mistakes (as with any software interface), but you need to admit it to Yes that's exactly what I meant. And we do make plenty

Re: [PATCH] provide correct pci routing information in mptable

2009-12-23 Thread Gleb Natapov
On Wed, Dec 23, 2009 at 03:26:55PM -0500, Kevin O'Connor wrote: On Wed, Dec 23, 2009 at 09:56:23PM +0200, Gleb Natapov wrote: On Wed, Dec 23, 2009 at 02:48:24PM -0500, Kevin O'Connor wrote: On Wed, Dec 23, 2009 at 08:45:07PM +0200, Gleb Natapov wrote: On Wed, Dec 23, 2009 at 01:11:43PM

Re: [GIT PULL] AlacrityVM guest drivers for 2.6.33

2009-12-23 Thread Avi Kivity
On 12/23/2009 06:44 PM, Gregory Haskins wrote: - Are a pure software concept By design. In fact, I would describe it as software to software optimized as opposed to trying to shoehorn into something that was designed as a software-to-hardware interface (and therefore has assumptions

Re: [PATCH] provide correct pci routing information in mptable

2009-12-23 Thread Kevin O'Connor
On Wed, Dec 23, 2009 at 10:35:55PM +0200, Gleb Natapov wrote: On Wed, Dec 23, 2009 at 03:26:55PM -0500, Kevin O'Connor wrote: BTW, this is only intended for PCI bus zero entries, right? (In theory, one could map a card with a bridge into kvm..) Mptable should have description for each

Re: [GIT PULL] AlacrityVM guest drivers for 2.6.33

2009-12-23 Thread Avi Kivity
On 12/23/2009 10:36 PM, Avi Kivity wrote: On 12/23/2009 06:44 PM, Gregory Haskins wrote: - Are a pure software concept By design. In fact, I would describe it as software to software optimized as opposed to trying to shoehorn into something that was designed as a software-to-hardware

Re: [Alacrityvm-devel] [GIT PULL] AlacrityVM guest drivers for 2.6.33

2009-12-23 Thread Gregory Haskins
(Sorry for top post...on a mobile) When someone repeatedly makes a claim you believe to be wrong and you correct them, you start to wonder if that person has a less than honorable agenda. In any case, I overreacted. For that, I apologize. That said, you are still incorrect. With what I

[PATCH qemu-kvm] device assignment: default requires IOMMU

2009-12-23 Thread Chris Wright
[ resend, fixing email header, sorry for duplicate ] The default mode for device assignment is to rely on an IOMMU for proper translations and a functioning device in the guest. The current logic makes this requirement advisory, and simply disables the request for IOMMU if one is not found on

Re: qemu-kvm-0.12 bug?

2009-12-23 Thread Bernhard Held
I've switched from -0.11.0 to -0.12 and from 2.6.31.6 to 2.6.32.2 to try the new virtio-memory-API introduced in latest libvirt from git. I can start VMs f.e. by kvm -cdrom $someiso --enable-kvm but my domain configs to not work anymore. Just found the other bug report about this

Re: [Alacrityvm-devel] [GIT PULL] AlacrityVM guest drivers for 2.6.33

2009-12-23 Thread Anthony Liguori
On 12/23/2009 01:54 PM, Ira W. Snyder wrote: On Wed, Dec 23, 2009 at 09:09:21AM -0600, Anthony Liguori wrote: I didn't know you were interested in this as well. See my later reply to Kyle for a lot of code that I've written with this in mind. BTW, in the future, please CC me or CC

Re: [GIT PULL] AlacrityVM guest drivers for 2.6.33

2009-12-23 Thread Anthony Liguori
On 12/23/2009 11:29 AM, Linus Torvalds wrote: On Wed, 23 Dec 2009, Gregory Haskins wrote: And upstream submission is not always like this! I would think the process would come to a grinding halt if it were ;) Well, in all honesty, if it had been non-virtualized drivers I would just have

Re: [Alacrityvm-devel] [GIT PULL] AlacrityVM guest drivers for 2.6.33

2009-12-23 Thread Ira W. Snyder
On Wed, Dec 23, 2009 at 04:58:37PM -0600, Anthony Liguori wrote: On 12/23/2009 01:54 PM, Ira W. Snyder wrote: On Wed, Dec 23, 2009 at 09:09:21AM -0600, Anthony Liguori wrote: I didn't know you were interested in this as well. See my later reply to Kyle for a lot of code that I've written

Re: [PATCH qemu-kvm] device assignment: default requires IOMMU

2009-12-23 Thread Alexander Graf
Am 23.12.2009 um 23:40 schrieb Chris Wright chr...@sous-sol.org: [ resend, fixing email header, sorry for duplicate ] The default mode for device assignment is to rely on an IOMMU for proper translations and a functioning device in the guest. The current logic makes this requirement

[PATCH] KVM: trivial document fixes

2009-12-23 Thread Wu Fengguang
Signed-off-by: Wu Fengguang fengguang...@intel.com --- Documentation/kvm/api.txt | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) --- linux.orig/Documentation/kvm/api.txt2009-12-12 09:54:19.0 +0800 +++ linux/Documentation/kvm/api.txt 2009-12-12

Re: [Alacrityvm-devel] [GIT PULL] AlacrityVM guest drivers for 2.6.33

2009-12-23 Thread Kyle Moffett
On Wed, Dec 23, 2009 at 17:58, Anthony Liguori anth...@codemonkey.ws wrote: On 12/23/2009 01:54 PM, Ira W. Snyder wrote: On Wed, Dec 23, 2009 at 09:09:21AM -0600, Anthony Liguori wrote: But both virtio-lguest and virtio-s390 use in-band enumeration and discovery since they do not have support

  1   2   >