Re: [PATCH] kvm:s390:Fix assumption that kvm_set_irq_routing is always run successfully

Am 06.08.2015 um 19:05 schrieb Nicholas Krause: This fixes the assumption that kvm_set_irq_routing is always run successfully by instead making it equal to the variable r which we use for returning in the function kvm_arch_vm_ioctl instead of making r equal to zero when calling this particular

[GIT PULL 0/2] KVM: s390: fix and feature for kvm/next (4.3)

Paolo, the following changes since commit c92ea7b9f7d256cabf7ee08a7627a5227e356dec: KVM: s390: log capability enablement and vm attribute changes (2015-07-29 11:02:36 +0200) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kvms390/linux.git

[GIT PULL 1/2] KVM: s390: host STP toleration for VMs

preemption). Signed-off-by: Fan Zhang zhang...@linux.vnet.ibm.com Reviewed-by: David Hildenbrand d...@linux.vnet.ibm.com Reviewed-by: Christian Borntraeger borntrae...@de.ibm.com Acked-by: Martin Schwidefsky schwidef...@de.ibm.com Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com --- arch

[GIT PULL 2/2] KVM: s390: Fix assumption that kvm_set_irq_routing is always run successfully

and incorrectly making the caller of kvm_arch_vm_ioctl think the function has run successfully. Signed-off-by: Nicholas Krause xerofo...@gmail.com Message-Id: 1438880754-27149-1-git-send-email-xerofo...@gmail.com Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com --- arch/s390/kvm/kvm

Re: [PATCH v2 1/5] KVM: add kvm_has_request wrapper

Am 05.08.2015 um 18:32 schrieb Radim Krčmář: We want to have requests abstracted from bit operations. Signed-off-by: Radim Krčmář rkrc...@redhat.com --- kvm_check_request is now somewhat a misnomer (what is the difference between test and check?) but still Acked-by: Christian Borntraeger

Re: [PATCH v2 5/5] KVM: refactor asynchronous vcpu ioctl dispatch

Am 05.08.2015 um 18:33 schrieb Radim Krčmář: I find the switch easier to read and modify. yes. Signed-off-by: Radim Krčmář rkrc...@redhat.com --- v2: new virt/kvm/kvm_main.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/virt/kvm/kvm_main.c

Re: [PATCH v2] virt: IRQ bypass manager

Am 16.07.2015 um 23:26 schrieb Alex Williamson: When a physical I/O device is assigned to a virtual machine through facilities like VFIO and KVM, the interrupt for the device generally bounces through the host system before being injected into the VM. However, hardware technologies exist that

[GIT PULL 0/3] KVM: s390: Bugfix and cleanups for kvm/next (4.4)

ins two cleanups. ---- Christian Borntraeger (2): KVM: s390: drop useless newline in debugging data KVM: s390: use simple switch statement as multiplexer David Hildenbrand (1): KVM: s390: SCA must not cross page boundar

[GIT PULL 3/3] KVM: s390: use simple switch statement as multiplexer

--368 Right now my gcc does conditional branches instead of jump tables. The inlining seems to give us enough cycles as some micro-benchmarking shows minimal improvements, but still in noise. Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> Reviewed-by: Cornelia Huck <c

[GIT PULL 2/3] KVM: s390: drop useless newline in debugging data

the s390 debug feature does not need newlines. In fact it will result in empty lines. Get rid of 4 leftovers. Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> Acked-by: Cornelia Huck <cornelia.h...@de.ibm.com> --- arch/s390/kvm/kvm-s390.c | 8 1 file changed,

[GIT PULL 1/3] KVM: s390: SCA must not cross page boundaries

lls via SIGP IF. Especially the 2. happens regularly. So this could produce two problems: 1. The guest losing/getting external calls. 2. Random memory overwrites in the host. So this problem happens on every 127 + 128 created VM with 64 VCPUs. Cc: sta...@vger.kernel.org # v3.15+ Acked-by: Chr

[PATCH 1/4] Provide simple noop dma ops

We are going to require dma_ops for several common drivers, even for systems that do have an identity mapping. Lets provide some minimal no-op dma_ops that can be used for that purpose. Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> --- include/linux/dma-mapping.h | 2 +

[PATCH 2/4] alpha: use common noop dma ops

Some of the alpha pci noop dma ops are identical to the common ones. Use them. Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> --- arch/alpha/kernel/pci-noop.c | 46 1 file changed, 4 insertions(+), 42 deletions(-) diff --git

[PATCH 3/4] s390/dma: Allow per device dma ops

As virtio-ccw now has dma ops, we can no longer default to the PCI ones. Make use of dev_archdata to keep the dma_ops per device. Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> --- arch/s390/include/asm/device.h | 6 +- arch/s390/include/asm/dma-mapping.h | 2 +-

[PATCH/RFC 0/4] dma ops and virtio

with the dummy ones - patch3: allow per device dma ops for s390 - patch4: wire up virtio dma ops TODOs - test (s390 virtio-ccw with Andis changes, s390 pci) and review - check i386 nommu dma ops for potential improvements in the noop handlers - make dma-noop only compile when necessary Christian

[PATCH 4/4] s390/virtio: use noop dma ops

With all infrastructure in place, lets provide dma_ops for virtio devices on s390. Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> --- drivers/s390/virtio/kvm_virtio.c | 2 ++ drivers/s390/virtio/virtio_ccw.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/driver

Re: [PATCH 2/3] virtio_ring: Support DMA APIs

Am 28.10.2015 um 10:17 schrieb Andy Lutomirski: @@ -423,27 +522,42 @@ EXPORT_SYMBOL_GPL(virtqueue_kick); > > static void detach_buf(struct vring_virtqueue *vq, unsigned int head) > { > - unsigned int i; > + unsigned int i, j; > + u16 nextflag = cpu_to_virtio16(vq->vq.vdev,

Re: [PATCH v2 2/3] virtio_ring: Support DMA APIs

Am 28.10.2015 um 15:04 schrieb David Woodhouse: > On Wed, 2015-10-28 at 14:52 +0900, Christian Borntraeger wrote: >>0059b25a: e3201024 lg %r2,32(%r1) >> #0059b260: e310b0a4 lg %r1,160(%r11) >> >00

Re: [PATCH v3 0/3] virtio DMA API core stuff

Am 28.10.2015 um 16:17 schrieb Michael S. Tsirkin: > On Tue, Oct 27, 2015 at 11:38:57PM -0700, Andy Lutomirski wrote: >> This switches virtio to use the DMA API unconditionally. I'm sure >> it breaks things, but it seems to work on x86 using virtio-pci, with >> and without Xen, and using both the

Re: [PATCH v2 2/3] virtio_ring: Support DMA APIs

Am 28.10.2015 um 14:30 schrieb Andy Lutomirski: > +static void vring_unmap_one(const struct vring_virtqueue *vq, > + struct vring_desc *desc) > +{ > + u16 flags = virtio16_to_cpu(vq->vq.vdev, desc->flags); > + > + if (flags & VRING_DESC_F_INDIRECT) { > +

Re: [PATCH/RFC 0/4] dma ops and virtio

Am 29.10.2015 um 07:22 schrieb Andy Lutomirski: > On Tue, Oct 27, 2015 at 3:48 PM, Christian Borntraeger > <borntrae...@de.ibm.com> wrote: >> This is an RFC to check if I am on the right track. There >> are some attempts to unify the dma ops (Christoph) as well >> a

Re: [PATCH] mm: Loosen MADV_NOHUGEPAGE to enable Qemu postcopy on s390

(something); == EINVAL; seems strange. So I think changing the kernel is the better approach. > > Glad to hear KVM postcopy live migration is already running on s390 too. > > Thanks, > Andrea > >> >> Signed-off-by: Jason J. Herne <jjhe...@linux.vnet.ibm.com> Acke

Re: [PATCH] mm: Loosen MADV_NOHUGEPAGE to enable Qemu postcopy on s390

Am 11.11.2015 um 18:30 schrieb Andrea Arcangeli: > Hi Jason, > > On Wed, Nov 11, 2015 at 10:35:16AM -0500, Jason J. Herne wrote: >> MADV_NOHUGEPAGE processing is too restrictive. kvm already disables >> hugepage but hugepage_madvise() takes the error path when we ask to turn >> on the

Re: [PATCH 1/3] Provide simple noop dma ops

Am 02.11.2015 um 16:16 schrieb Joerg Roedel: > On Fri, Oct 30, 2015 at 02:20:35PM +0100, Christian Borntraeger wrote: >> +static void *dma_noop_alloc(struct device *dev, size_t size, >> +dma_addr_t *dma_handle, gfp_t gfp, >> +st

Re: [PATCH/RFC 0/4] dma ops and virtio

Am 02.11.2015 um 21:23 schrieb Andy Lutomirski: > On Mon, Nov 2, 2015 at 3:16 AM, Cornelia Huck > wrote: >> On Fri, 30 Oct 2015 13:33:07 -0700 >> Andy Lutomirski wrote: >> >>> On Fri, Oct 30, 2015 at 1:25 AM, Cornelia Huck

[PATCH 1/3] dma: Provide simple noop dma ops

We are going to require dma_ops for several common drivers, even for systems that do have an identity mapping. Lets provide some minimal no-op dma_ops that can be used for that purpose. Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> --- include/linux/dma-mapping.h | 2 +

[PATCH 2/3] alpha/dma: use common noop dma ops

Some of the alpha pci noop dma ops are identical to the common ones. Use them. Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> Reviewed-by: Joerg Roedel <jroe...@suse.de> --- arch/alpha/kernel/pci-noop.c | 46 1 fil

[PATCHv3 0/3] dma ops and virtio

loc - prefix patches with *dma* v1->v2: - initial testing - always use dma_noop_ops if device has no private dma_ops - get rid of setup in virtio_ccw,kvm_virtio - set CONFIG_HAS_DMA(ATTRS) for virtio (fixes compile for !PCI) - rename s390_dma_ops to s390_pci_dma_ops Christian Borntraeger (3): dma: P

[PATCH 3/3] s390/dma: Allow per device dma ops

also have to enable the DMA api with virtio. Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> Reviewed-by: Joerg Roedel <jroe...@suse.de> Acked-by: Sebastian Ott <seb...@linux.vnet.ibm.com> --- arch/s390/Kconfig | 3 ++- arch/s390/include/asm

Re: [PATCH v4 2/6] virtio_ring: Support DMA APIs

Am 30.10.2015 um 13:01 schrieb Cornelia Huck: > On Thu, 29 Oct 2015 18:09:47 -0700 > Andy Lutomirski wrote: > >> virtio_ring currently sends the device (usually a hypervisor) >> physical addresses of its I/O buffers. This is okay when DMA >> addresses and physical addresses are

[PATCHv2 0/3] dma ops and virtio

tio (fixes compile for !PCI) - rename s390_dma_ops to s390_pci_dma_ops Christian Borntraeger (3): Provide simple noop dma ops alpha: use common noop dma ops s390/dma: Allow per device dma ops arch/alpha/kernel/pci-noop.c| 46 ++ arch/s390/Kcon

Re: [PATCH v4 1/6] virtio-net: Stop doing DMA from the stack

Am 30.10.2015 um 02:09 schrieb Andy Lutomirski: > From: "Michael S. Tsirkin" > > Once virtio starts using the DMA API, we won't be able to safely DMA > from the stack. virtio-net does a couple of config DMA requests > from small stack buffers -- switch to using

Re: [PATCH 4/4] s390/virtio: use noop dma ops

Am 30.10.2015 um 13:17 schrieb Cornelia Huck: > On Tue, 27 Oct 2015 23:48:51 +0100 > Christian Borntraeger <borntrae...@de.ibm.com> wrote: > >> With all infrastructure in place, lets provide dma_ops for virtio >> devices on s390. >> >> Signed-off-by: Christ

Re: [PATCH 1/4] Provide simple noop dma ops

Am 28.10.2015 um 01:41 schrieb Joerg Roedel: > Hi Christian, > > On Tue, Oct 27, 2015 at 11:48:48PM +0100, Christian Borntraeger wrote: >> +static dma_addr_t dma_noop_map_page(struct device *dev, struct page *page, >> + unsigned lon

Re: [PATCH 4/4] s390/virtio: use noop dma ops

Am 28.10.2015 um 01:43 schrieb Joerg Roedel: > On Tue, Oct 27, 2015 at 11:48:51PM +0100, Christian Borntraeger wrote: >> @@ -1093,6 +1094,7 @@ static void virtio_ccw_auto_online(void *data, >> async_cookie_t cookie) >> struct ccw_device *cdev = data; >>

[PATCH 1/3] Provide simple noop dma ops

We are going to require dma_ops for several common drivers, even for systems that do have an identity mapping. Lets provide some minimal no-op dma_ops that can be used for that purpose. Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> --- include/linux/dma-mapping.h | 2 +

[PATCH 2/3] alpha: use common noop dma ops

Some of the alpha pci noop dma ops are identical to the common ones. Use them. Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> --- arch/alpha/kernel/pci-noop.c | 46 1 file changed, 4 insertions(+), 42 deletions(-) diff --git

[PATCH 3/3] s390/dma: Allow per device dma ops

also have to enable the DMA api with virtio. Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> --- arch/s390/Kconfig | 3 ++- arch/s390/include/asm/device.h | 6 +- arch/s390/include/asm/dma-mapping.h | 6 -- arch/s390/pci/pci.c | 1 +

Re: [PATCH v3 2/3] target-i386: calculate vcpu's TSC rate to be migrated

Am 02.11.2015 um 10:40 schrieb James Hogan: > On Mon, Nov 02, 2015 at 05:26:42PM +0800, Haozhong Zhang wrote: >> The value of the migrated vcpu's TSC rate is determined as below. >> 1. If a TSC rate is specified by the cpu option 'tsc-freq', then this >> user-specified value will be used. >>

Re: [PATCH 3/3] s390/dma: Allow per device dma ops

Am 03.11.2015 um 13:26 schrieb Cornelia Huck: > On Tue, 3 Nov 2015 12:54:39 +0100 > Christian Borntraeger <borntrae...@de.ibm.com> wrote: > >> As virtio-ccw now has dma ops, we can no longer default to the PCI ones. >> Make use of dev_archdata to keep the dma_ops

[GIT PULL v4 2/3] alpha/dma: use common noop dma ops

Some of the alpha pci noop dma ops are identical to the common ones. Use them. Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> Reviewed-by: Joerg Roedel <jroe...@suse.de> --- arch/alpha/kernel/pci-noop.c | 46 1 fil

[GIT PULL v4 0/3] dma and virtio prep patches

/linux.git dma for you to fetch changes up to fc7f9754db6ce0c12281da4055281f731d36bdee: s390/dma: Allow per device dma ops (2015-11-05 21:02:40 +0100) Christian Borntraeger (3): dma: Provide simple noop dma ops alpha/dma

[GIT PULL v4 1/3] dma: Provide simple noop dma ops

We are going to require dma_ops for several common drivers, even for systems that do have an identity mapping. Lets provide some minimal no-op dma_ops that can be used for that purpose. Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> Reviewed-by: Joerg Roedel <jroe..

[GIT PULL v4 3/3] s390/dma: Allow per device dma ops

. To compile without PCI support we will enable HAS_DMA all the time, via the default config in lib/Kconfig. Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> Reviewed-by: Joerg Roedel <jroe...@suse.de> Acked-by: Sebastian Ott <seb...@linux.vnet.ibm.com> ---

Re: [PATCH v4 0/6] virtio core DMA API conversion

Am 30.10.2015 um 02:09 schrieb Andy Lutomirski: > This switches virtio to use the DMA API unconditionally. I'm sure > it breaks things, but it seems to work on x86 using virtio-pci, with > and without Xen, and using both the modern 1.0 variant and the > legacy variant. > > This appears to work

[GIT PULL 03/10] KVM: s390: set interception requests for all floating irqs

From: David Hildenbrand <d...@linux.vnet.ibm.com> No need to separate pending and floating irqs when setting interception requests. Let's do it for all equally. Reviewed-by: Christian Borntraeger <borntrae...@de.ibm.com> Signed-off-by: David Hildenbrand <d...@linux.vnet.ibm.

[GIT PULL 01/10] KVM: s390: remove unused variable in __inject_vm

the float int structure is no longer used in __inject_vm. Acked-by: Cornelia Huck <cornelia.h...@de.ibm.com> Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> --- arch/s390/kvm/interrupt.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/arch/s390/kvm/interrupt.c b/a

[GIT PULL 09/10] KVM: s390: factor out and fix setting of guest TOD clock

fering VCPUs with different TODs. Acked-by: Christian Borntraeger <borntrae...@de.ibm.com> Signed-off-by: David Hildenbrand <d...@linux.vnet.ibm.com> Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> --- arch/s390/kvm/kvm-s390.c | 28 +--- arch/

[GIT PULL 05/10] KVM: s390: drop out early in kvm_s390_has_irq()

From: David Hildenbrand <d...@linux.vnet.ibm.com> Let's get rid of the local variable and exit directly if we found any pending interrupt. This is not only faster, but also better readable. Reviewed-by: Christian Borntraeger <borntrae...@de.ibm.com> Signed-off-by: David Hi

[GIT PULL 00/10] KVM: s390: Fixes for 4.4

is important enough to qualify for 4.3 or stable. Christian Borntraeger (1): KVM: s390: remove unused variable in __inject_vm David Hildenbrand (9): KVM: s390: disabled wait cares about machine checks, not PER KVM: s390

[GIT PULL 04/10] KVM: s390: kvm_arch_vcpu_runnable already cares about timer interrupts

From: David Hildenbrand <d...@linux.vnet.ibm.com> We can remove that double check. Reviewed-by: Christian Borntraeger <borntrae...@de.ibm.com> Signed-off-by: David Hildenbrand <d...@linux.vnet.ibm.com> Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> --- a

[GIT PULL 10/10] KVM: s390: factor out reading of the guest TOD clock

P sync (using preempt_disable() logic). Reviewed-by: Christian Borntraeger <borntrae...@de.ibm.com> Signed-off-by: David Hildenbrand <d...@linux.vnet.ibm.com> Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> --- arch/s390/kvm/interrupt.c | 15 +++ arch/s

[GIT PULL 02/10] KVM: s390: disabled wait cares about machine checks, not PER

esting once again for magic bits. Reviewed-by: Christian Borntraeger <borntrae...@de.ibm.com> Signed-off-by: David Hildenbrand <d...@linux.vnet.ibm.com> Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> --- arch/s390/kvm/interrupt.c | 8 +++- 1 file changed, 3 in

[GIT PULL 08/10] KVM: s390: switch to get_tod_clock() and fix STP sync races

an now also easily move the get_tod_clock() call into the preempt_disable() section. This is in fact necessary to make the STP sync work as expected. Otherwise the host TOD could change and we would end up with a wrong epoch calculation. Reviewed-by: Christian Borntraeger <borntrae...@de.ibm.com>

[GIT PULL 07/10] KVM: s390: correctly handle injection of pgm irqs and per events

viewed-by: Christian Borntraeger <borntrae...@de.ibm.com> Signed-off-by: David Hildenbrand <d...@linux.vnet.ibm.com> Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> --- arch/s390/kvm/interrupt.c | 21 - 1 file changed, 20 insertions(+), 1 deleti

[GIT PULL 06/10] KVM: s390: simplify in-kernel program irq injection

e dropped as they are implicitely given by kvm_s390_inject_vcpu(), to avoid ugly long function prototypes. Reviewed-by: Jens Freimann <jf...@linux.vnet.ibm.com> Acked-by: Cornelia Huck <cornelia.h...@de.ibm.com> Reviewed-by: Christian Borntraeger <borntrae...@de.ibm.com> Signed-o

Re: KVM memory slots limit on powerpc

Am 04.09.2015 um 11:35 schrieb Thomas Huth: > > Hi all, > > now that we get memory hotplugging for the spapr machine on qemu-ppc, > too, it seems like we easily can hit the amount of KVM-internal memory > slots now ("#define KVM_USER_MEM_SLOTS 32" in > arch/powerpc/include/asm/kvm_host.h). For

Re: [Qemu-ppc] KVM memory slots limit on powerpc

Am 04.09.2015 um 12:04 schrieb Alexander Graf: > > > On 04.09.15 11:59, Christian Borntraeger wrote: >> Am 04.09.2015 um 11:35 schrieb Thomas Huth: >>> >>> Hi all, >>> >>> now that we get memory hotplugging for the spapr machine on qemu-ppc,

Re: [Qemu-ppc] KVM memory slots limit on powerpc

Am 08.09.2015 um 08:05 schrieb Thomas Huth: > On 07/09/15 16:31, Igor Mammedov wrote: >> On Fri, 4 Sep 2015 12:04:41 +0200 >> Alexander Graf <ag...@suse.de> wrote: >> >>> >>> >>> On 04.09.15 11:59, Christian Borntraeger wrote: >>>&g

Re: [PATCH v3 0/5] KVM: optimize userspace exits with a new ioctl

Am 14.08.2015 um 12:08 schrieb Radim Krčmář: > v3: > * acked by Christian [1/5] > * use ioctl argument directly (unsigned long as flags) [4/5] > * precisely #ifdef arch-specific ioctls [5/5] > v2: > * move request_exits debug counter patch right after introduction of >KVM_REQ_EXIT [3/5] >

Re: [PATCH v7 0/3] KVM: Dynamic Halt-Polling

Am 10.09.2015 um 03:55 schrieb Wanpeng Li: > On 9/9/15 9:39 PM, Christian Borntraeger wrote: >> Am 03.09.2015 um 16:07 schrieb Wanpeng Li: >>> v6 -> v7: >>> * explicit signal (set a bool) >>> * fix the tracepoint >>> >>> v5 -> v6: &

Re: linux-next: Tree for Sep 10

Am 10.09.2015 um 06:02 schrieb Stephen Rothwell: > Hi all, > > Please do not add material for v4.4 until after v4.3-rc1 is out. > [...] > The kvm tree still had its build failure for which I reverted a commit. [..] > Merging kvm/linux-next (2cbd78244fb2 KVM: trace kvm_halt_poll_ns grow/shrink) >

Re: [PATCH v7 0/3] KVM: Dynamic Halt-Polling

Am 03.09.2015 um 16:07 schrieb Wanpeng Li: > v6 -> v7: > * explicit signal (set a bool) > * fix the tracepoint > > v5 -> v6: > * fix wait_ns and poll_ns > > v4 -> v5: > * set base case 10us and max poll time 500us > * handle short/long halt, idea from David, many thanks David > > v3 ->

Re: [4.2] commit d59cfc09c32 (sched, cgroup: replace signal_struct->group_rwsem with a global percpu_rwsem) causes regression for libvirt/kvm

Am 16.09.2015 um 10:32 schrieb Paolo Bonzini: > > > On 15/09/2015 19:38, Paul E. McKenney wrote: >> Excellent points! >> >> Other options in such situations include the following: >> >> oRework so that the code uses call_rcu*() instead of *_expedited(). >> >> oMaintain a per-task or

Re: [4.2] commit d59cfc09c32 (sched, cgroup: replace signal_struct->group_rwsem with a global percpu_rwsem) causes regression for libvirt/kvm

Am 16.09.2015 um 03:24 schrieb Tejun Heo: > Hello, Paul. > > On Tue, Sep 15, 2015 at 04:38:18PM -0700, Paul E. McKenney wrote: >> Well, the decision as to what is too big for -stable is owned by the >> -stable maintainers, not by me. > > Is it tho? Usually the subsystem maintainer knows the

Re: [4.2] commit d59cfc09c32 (sched, cgroup: replace signal_struct->group_rwsem with a global percpu_rwsem) causes regression for libvirt/kvm

Am 16.09.2015 um 13:03 schrieb Tejun Heo: > Hello, > > On Wed, Sep 16, 2015 at 12:58:00PM +0200, Christian Borntraeger wrote: >> FWIW, I added a printk to percpu_down_write. With KVM and uprobes disabled, >> just booting up a fedora20 gives me __6749__ percpu_down_write cal

Re: [PATCH] KVM: add halt_attempted_poll to VCPU stats

gt; attempted polling compared to the successful polls. > > Cc: Christian Borntraeger <borntrae...@de.ibm.com< > Cc: David Matlack <dmatl...@google.com> > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> Acked-by: Christian Borntraeger <borntrae...@de.ibm.com&g

Re: [4.2] commit d59cfc09c32 (sched, cgroup: replace signal_struct->group_rwsem with a global percpu_rwsem) causes regression for libvirt/kvm

Am 16.09.2015 um 09:44 schrieb Christian Borntraeger: > Am 16.09.2015 um 03:24 schrieb Tejun Heo: >> Hello, Paul. >> >> On Tue, Sep 15, 2015 at 04:38:18PM -0700, Paul E. McKenney wrote: >>> Well, the decision as to what is too big for -stable is owned by the >

Re: [4.2] commit d59cfc09c32 (sched, cgroup: replace signal_struct->group_rwsem with a global percpu_rwsem) causes regression for libvirt/kvm

Am 16.09.2015 um 14:22 schrieb Oleg Nesterov: >> The issue is that rcu_sync doesn't eliminate synchronize_sched, > > Yes, but it eliminates _expedited(). This is good, but otoh this means > that (say) individual __cgroup_procs_write() can take much more time. > However, it won't block the

Re: [PATCH] Fixes: 805de8f43c20 (atomic: Replace atomic_{set,clear}_mask() usage)

he incorrect atomic_or with atomic_andnot > > Signed-off-by: Jason J. Herne <jjhe...@linux.vnet.ibm.com> Acked-by: Christian Borntraeger <borntrae...@de.ibm.com> Paolo, can you take this via kvm tree for 4.3? Maybe move the subject line into the mail body an rephrase the subject li

Re: [PATCH] KVM: fix polling for guest halt continued even if disable it

This patch fix it by reset vcpu->halt_poll_ns in order to stop polling > when polling is disabled. > > Reported-by: Christian Borntraeger <borntrae...@de.ibm.com> > Signed-off-by: Wanpeng Li <wanpeng...@hotmail.com> > --- > virt/kvm/kvm_main.c | 3 ++- > 1 file chan

[4.2] commit d59cfc09c32 (sched, cgroup: replace signal_struct->group_rwsem with a global percpu_rwsem) causes regression for libvirt/kvm

Tejun, commit d59cfc09c32a2ae31f1c3bc2983a0cd79afb3f14 (sched, cgroup: replace signal_struct->group_rwsem with a global percpu_rwsem) causes some noticably hickups when starting several kvm guests (which libvirt will move into cgroups - each vcpu thread and each i/o thread) When you now start

Re: [4.2] commit d59cfc09c32 (sched, cgroup: replace signal_struct->group_rwsem with a global percpu_rwsem) causes regression for libvirt/kvm

Am 15.09.2015 um 18:42 schrieb Paolo Bonzini: > > > On 15/09/2015 15:36, Christian Borntraeger wrote: >> I am wondering why the old code behaved in such fatal ways. Is there >> some interaction between waiting for a reschedule in the >> synchronize_sched writer

Re: [PATCH cgroup/for-4.3-fixes 1/2] Revert "cgroup: simplify threadgroup locking"

Both patches in combination Tested-by: Christian Borntraeger <borntrae...@de.ibm.com> # on top of 4.3-rc1 As a side note, patch 2 does not apply cleanly on 4.2, so we probably need to provide a separate backport. Christian -- To unsubscribe from this list: send the line "unsu

Re: [4.2] commit d59cfc09c32 (sched, cgroup: replace signal_struct->group_rwsem with a global percpu_rwsem) causes regression for libvirt/kvm

Am 15.09.2015 um 15:05 schrieb Peter Zijlstra: > On Tue, Sep 15, 2015 at 02:05:14PM +0200, Christian Borntraeger wrote: >> Tejun, >> >> >> commit d59cfc09c32a2ae31f1c3bc2983a0cd79afb3f14 (sched, cgroup: replace >> signal_struct->group_rwsem with a global

[PATCH 0/1] macvtap regression since 3.18

than sorry as we dont want to rely on the implementation of macros. Opinions? Christian Borntraeger (1): macvtap: Fix regression for macvtap ioctls drivers/net/macvtap.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) -- 2.3.0 -- To unsubscribe from this list: send the line "

[PATCH 1/1] macvtap: Fix regression for macvtap ioctls

net> Reported-by: Mark A. Peloquin Bisected-by: Matthew Rosato <mjros...@linux.vnet.ibm.com> Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> Fixes: 39ec7de7092b ("macvtap: fix uninitialized access on TUNSETIFF") Cc: sta...@vger.kernel.org --- drivers/net/macvtap.c

Re: [PATCH] KVM: disable halt_poll_ns as default for s390x

Am 18.09.2015 um 13:29 schrieb Paolo Bonzini: > > > On 18/09/2015 12:54, Christian Borntraeger wrote: >>> -/* halt polling only reduces halt latency by 5-7 us, 500us is enough */ >>> -static unsigned int halt_poll_ns = 50; >>> +/* Architectures shou

Re: [PATCH] KVM: disable halt_poll_ns as default for s390x

> latency */ > +static unsigned int halt_poll_ns = KVM_HALT_POLL_NS_DEFAULT; Yes, I prefer this over disabling it via Kconfig. There are benchmarks which benefit from polling on s390. Furthermore it seems that the latency strongly depends on timing of the architecture so making it per arch

Re: [PATCH] KVM: disable halt_poll_ns as default for s390x

Am 18.09.2015 um 13:29 schrieb Paolo Bonzini: > > > On 18/09/2015 12:54, Christian Borntraeger wrote: >>> -/* halt polling only reduces halt latency by 5-7 us, 500us is enough */ >>> -static unsigned int halt_poll_ns = 50; >>> +/* Architectures shou

[GIT PULL 02/23] KVM: use heuristic for fast VCPU lookup by id

From: David Hildenbrand <d...@linux.vnet.ibm.com> Usually, VCPU ids match the array index. So let's try a fast lookup first before falling back to the slow iteration. Suggested-by: Christian Borntraeger <borntrae...@de.ibm.com> Reviewed-by: Dominik Dingel <din...@linux.vnet.ib

[GIT PULL 14/23] KVM: s390: we always have a SCA

ff-by: David Hildenbrand <d...@linux.vnet.ibm.com> Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> --- arch/s390/kvm/kvm-s390.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c index 16c19fb..5c58127 100644

[GIT PULL 01/23] KVM: Use common function for VCPU lookup by id

From: David Hildenbrand <d...@linux.vnet.ibm.com> Let's reuse the new common function for VPCU lookup by id. Reviewed-by: Christian Borntraeger <borntrae...@de.ibm.com> Reviewed-by: Dominik Dingel <din...@linux.vnet.ibm.com> Signed-off-by: David Hildenbrand <d...@linux.vne

[GIT PULL 10/23] KVM: s390: Make provisions for ESCA utilization

ESCA cases. Also the kvm.arch.use_esca flag is provided. The actual functionality is kept the same. Signed-off-by: Eugene (jno) Dvurechenski <j...@linux.vnet.ibm.com> Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> --- arch/s390/include/asm/kvm_host.h | 3 +- arch/s390

[GIT PULL 17/23] KVM: s390: cleanup sca_add_vcpu

From: David Hildenbrand <d...@linux.vnet.ibm.com> Now that we already have kvm and the VCPU id set for the VCPU, we can convert sda_add_vcpu to look much more like sda_del_vcpu. Signed-off-by: David Hildenbrand <d...@linux.vnet.ibm.com> Signed-off-by: Christian Borntraeg

[GIT PULL 19/23] s390/sclp: introduce check for SIE

..@linux.vnet.ibm.com> Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> --- arch/s390/include/asm/sclp.h | 6 +- drivers/s390/char/sclp_early.c | 1 + 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/arch/s390/include/asm/sclp.h b/arch/s390/include/asm/sclp.h

[GIT PULL 23/23] KVM: s390: remove redudant assigment of error code

rc already contains -ENOMEM, no need to assign it twice. Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> Acked-by: Cornelia Huck <cornelia.h...@de.ibm.com> Reviewed-by: David Hildenbrand <d...@linux.vnet.ibm.com> --- arch/s390/kvm/kvm-s390.c | 4 +--- 1 file ch

[GIT PULL 08/23] KVM: s390: Provide SCA-aware helpers for VCPU add/del

: David Hildenbrand <d...@linux.vnet.ibm.com> Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> --- arch/s390/kvm/kvm-s390.c | 44 +++- 1 file changed, 31 insertions(+), 13 deletions(-) diff --git a/arch/s390/kvm/kvm-s390.c b/arch

[GIT PULL 05/23] s390/sclp: introduce checks for ESCA and HVS

gt; Reviewed-by: David Hildenbrand <d...@linux.vnet.ibm.com> Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> --- arch/s390/include/asm/sclp.h | 2 ++ drivers/s390/char/sclp_early.c | 7 ++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/arch/s390/incl

[GIT PULL 11/23] KVM: s390: Introduce switching code

@linux.vnet.ibm.com> Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> --- arch/s390/include/asm/kvm_host.h | 1 + arch/s390/kvm/gaccess.c | 30 arch/s390/kvm/interrupt.c| 6 arch/s390/kvm/kvm-s390.c | 75 +

[GIT PULL 15/23] KVM: s390: fix SCA related races and double use

y been registered at the VM. We also have to make sure to update ECB at that point. Signed-off-by: David Hildenbrand <d...@linux.vnet.ibm.com> Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> --- arch/s390/kvm/kvm-s390.c | 11 +-- 1 file changed, 5 insertions(+), 6 deleti

[GIT PULL 21/23] KVM: s390: don't load kvm without virtualization support

vid Hildenbrand <d...@linux.vnet.ibm.com> Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> --- arch/s390/kvm/kvm-s390.c | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c index 539d385..49d3319 100644 --- a/arch/s390/kvm/kvm-s390.c

[GIT PULL 12/23] KVM: s390: Enable up to 248 VCPUs per VM

@linux.vnet.ibm.com> Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> --- arch/s390/include/asm/kvm_host.h | 2 +- arch/s390/kvm/kvm-s390.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/s390/include/asm/kvm_host.h b/arch/s390/include/asm/kvm_h

[GIT PULL 03/23] KVM: Remove unnecessary debugfs dentry references

remove them by using debugfs_remove_recursive(kvm_debugfs_dir). Therefore we don't need the extra tracking in the kvm_stats_debugfs_item anymore. Signed-off-by: Janosch Frank <fran...@linux.vnet.ibm.com> Reviewed-By: Sascha Silbe <si...@linux.vnet.ibm.com> Acked-by: Christian Bor

[GIT PULL 06/23] KVM: s390: Generalize access to IPTE controls

ibm.com> Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> --- arch/s390/kvm/gaccess.c | 10 +- arch/s390/kvm/kvm-s390.h | 5 + 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/arch/s390/kvm/gaccess.c b/arch/s390/kvm/gaccess.c index a7559f7..06f7edb 100644 -

[GIT PULL 16/23] KVM: s390: always set/clear the SCA sda field

and <d...@linux.vnet.ibm.com> Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> --- arch/s390/kvm/kvm-s390.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c index 2ba5978..7e0092b 100644 -

[GIT PULL 09/23] KVM: s390: Introduce new structures

rols were turned into bitfields instead of hardcoded bitmasks. Signed-off-by: Eugene (jno) Dvurechenski <j...@linux.vnet.ibm.com> Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> --- arch/s390/include/asm/kvm_host.h | 47 +++- arch/s390

[GIT PULL 18/23] KVM: s390: don't switch to ESCA for ucontrol

tructures are safe as well. Signed-off-by: David Hildenbrand <d...@linux.vnet.ibm.com> Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> --- arch/s390/kvm/kvm-s390.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390

[GIT PULL 04/23] KVM: s390: rewrite vcpu_post_run and drop out early

rcepts to the place where it belongs and convert it to -EREMOTE. Reviewed-by: Dominik Dingel <din...@linux.vnet.ibm.com> Reviewed-by: Cornelia Huck <cornelia.h...@de.ibm.com> Signed-off-by: David Hildenbrand <d...@linux.vnet.ibm.com> Signed-off-by: Christian Borntraeger <borntrae...

[GIT PULL 07/23] KVM: s390: Generalize access to SIGP controls

ibm.com> Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> --- arch/s390/kvm/interrupt.c | 72 +-- 1 file changed, 45 insertions(+), 27 deletions(-) diff --git a/arch/s390/kvm/interrupt.c b/arch/s390/kvm/interrupt.c index 6a75352..2a4718

<    5   6   7   8   9   10   11   >