On Mon, Feb 28, 2011 at 07:20:38PM +0800, Amos Kong wrote:
Communicate between two vms, and try to capture packages from another vm in
the same lan.
This test used tcpdump, so we need limit it with Linux guests.
Signed-off-by: Amos Kong ak...@redhat.com
I don't think there's any such
On Mon, Feb 28, 2011 at 11:40:43AM +0100, Jean-Philippe Menil wrote:
Le 28/02/2011 11:11, Michael S. Tsirkin a écrit :
On Mon, Feb 28, 2011 at 09:56:46AM +0100, Jean-Philippe Menil wrote:
Le 27/02/2011 18:00, Michael S. Tsirkin a écrit :
On Fri, Feb 25, 2011 at 10:07:22AM +0100, Jean-Philippe
On Mon, Feb 28, 2011 at 11:34:16PM +0100, Jean-Philippe Menil wrote:
Hi,
here is another trace with kvm.ko compiled with debug flags.
the bug:
[12099.503414] BUG: unable to handle kernel paging request at
0b6635e9
[12099.503462] IP: [a03ee877] kvm_set_irq+0x37/0x140 [kvm]
On Tue, Mar 01, 2011 at 02:10:37PM +0800, Sheng Yang wrote:
On Monday 28 February 2011 19:27:29 Michael S. Tsirkin wrote:
On Mon, Feb 28, 2011 at 03:20:04PM +0800, Sheng Yang wrote:
Then we can support mask bit operation of assigned devices now.
Signed-off-by: Sheng Yang sh
On Tue, Mar 01, 2011 at 05:18:58PM -0300, Marcelo Tosatti wrote:
On Fri, Feb 25, 2011 at 10:29:38AM +0200, Michael S. Tsirkin wrote:
On Fri, Feb 25, 2011 at 02:28:02PM +0800, Sheng Yang wrote:
On Thursday 24 February 2011 18:45:08 Michael S. Tsirkin wrote:
On Thu, Feb 24, 2011 at 05:51
On Wed, Mar 02, 2011 at 03:26:53PM +0800, Sheng Yang wrote:
Change from v10:
1. Update according to the comments of Michael.
2. Use mmio_needed to exit to userspace according to Marcelo's comments.
PCI-wise, I don't see anything to complain about.
So ack the PCI bits.
You guys decide on the
On Tue, Mar 01, 2011 at 09:32:56PM +0530, Krishna Kumar2 wrote:
Michael S. Tsirkin m...@redhat.com wrote on 02/28/2011 03:13:20 PM:
Thank you once again for your feedback on both these patches.
I will send the qemu patch tomorrow. I will also send the next
version incorporating
On Tue, Mar 01, 2011 at 09:34:35PM +0530, Krishna Kumar2 wrote:
Michael S. Tsirkin m...@redhat.com wrote on 02/28/2011 03:34:23 PM:
The number of vhost threads is = #txqs. Threads handle more
than one txq when #txqs is more than MAX_VHOST_THREADS (4).
It is this sharing that prevents
On Wed, Mar 02, 2011 at 03:51:20PM -0300, Marcelo Tosatti wrote:
On Wed, Mar 02, 2011 at 11:23:14AM +0200, Michael S. Tsirkin wrote:
On Wed, Mar 02, 2011 at 03:26:53PM +0800, Sheng Yang wrote:
Change from v10:
1. Update according to the comments of Michael.
2. Use mmio_needed to exit
Clarify a comment in kvm/eventfd.c: we do
rcu_assign_pointer without explicit synchronize_rcu
afterwards, and the reason this works is because we
use a spinlock to synch against another place
which does call synchronize_rcu.
Signed-off-by: Michael S. Tsirkin m...@redhat.com
---
diff --git
On Tue, Mar 01, 2011 at 03:39:12PM +0100, Jean-Philippe Menil wrote:
so this time the bug is:
[17882.612303] BUG: unable to handle kernel paging request at
2458
[17882.612342] IP: [a03898a0] kvm_set_irq+0x30/0x140 [kvm]
markup_oops give me this:
root@ayrshire:~# cat
On Thu, Mar 03, 2011 at 04:26:11PM +0100, Jean-Philippe Menil wrote:
Le 03/03/2011 15:47, Michael S. Tsirkin a écrit :
On Tue, Mar 01, 2011 at 03:39:12PM +0100, Jean-Philippe Menil wrote:
so this time the bug is:
[17882.612303] BUG: unable to handle kernel paging request at
2458
On Fri, Mar 04, 2011 at 10:22:03AM +0100, Jean-Philippe Menil wrote:
Le 03/03/2011 16:55, Michael S. Tsirkin a écrit :
On Thu, Mar 03, 2011 at 04:26:11PM +0100, Jean-Philippe Menil wrote:
Le 03/03/2011 15:47, Michael S. Tsirkin a écrit :
On Tue, Mar 01, 2011 at 03:39:12PM +0100, Jean-Philippe
The RCU use in kvm_irqfd_deassign is tricky: we have rcu_assign_pointer
but no synchronize_rcu: synchronize_rcu is done by kvm_irq_routing_update
which we share a spinlock with.
Fix up a comment in an attempt to make this clearer.
Signed-off-by: Michael S. Tsirkin m...@redhat.com
---
virt/kvm
copy_from_user is pretty high on perf top profile,
replacing it with __copy_from_user helps.
It's also safe because we do access_ok checks during setup.
Signed-off-by: Michael S. Tsirkin m...@redhat.com
---
drivers/vhost/vhost.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff
On Sun, Mar 06, 2011 at 06:03:39PM -0800, David Miller wrote:
From: Michael S. Tsirkin m...@redhat.com
Date: Sun, 6 Mar 2011 13:33:49 +0200
copy_from_user is pretty high on perf top profile,
replacing it with __copy_from_user helps.
It's also safe because we do access_ok checks during
On Fri, Mar 04, 2011 at 10:39:05AM +0100, Jean-Philippe Menil wrote:
Yes, it's a 2.6.37.2 kernel.
OK, here's a debugging patch.
Please run with slab debugging as previously until you see
'eventfd bug detected!' in dmesg or until there is a crash.
It might be also useful to enable timestampts on
On Tue, Mar 08, 2011 at 09:02:38PM +0530, Krishna Kumar2 wrote:
Michael S. Tsirkin m...@redhat.com wrote on 03/02/2011 03:36:00 PM:
Sorry for the delayed response, I have been sick the last few days.
I am responding to both your posts here.
Both virtio-net and vhost need some check
for transmit: with indirect,
just a single one is enough. Without indirect we'll
need more possibly, but just for testing this should
be enough.
Signed-off-by: Michael S. Tsirkin m...@redhat.com
---
Note: untested.
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index 82dba5a
On Mon, Mar 07, 2011 at 04:31:41PM -0600, Tom Lendacky wrote:
I used the uperf tool to do this after verifying the results against netperf.
Uperf allows the specification of the number of connections as a parameter in
an XML file as opposed to launching, in this case, 100 separate
On Wed, Mar 09, 2011 at 01:28:43PM +0100, Jean-Philippe Menil wrote:
Le 08/03/2011 12:13, Michael S. Tsirkin a écrit :
On Fri, Mar 04, 2011 at 10:39:05AM +0100, Jean-Philippe Menil wrote:
Yes, it's a 2.6.37.2 kernel.
OK, here's a debugging patch.
Please run with slab debugging as previously
On Wed, Mar 09, 2011 at 02:12:58PM +0100, Jean-Philippe Menil wrote:
Le 09/03/2011 14:00, Michael S. Tsirkin a écrit :
On Wed, Mar 09, 2011 at 01:28:43PM +0100, Jean-Philippe Menil wrote:
Le 08/03/2011 12:13, Michael S. Tsirkin a écrit :
On Fri, Mar 04, 2011 at 10:39:05AM +0100, Jean-Philippe
On Wed, Mar 09, 2011 at 07:45:43AM -0800, Shirley Ma wrote:
On Wed, 2011-03-09 at 09:15 +0200, Michael S. Tsirkin wrote:
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index 82dba5a..ebe3337 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
On Wed, Mar 09, 2011 at 10:09:26AM -0600, Tom Lendacky wrote:
On Wednesday, March 09, 2011 01:15:58 am Michael S. Tsirkin wrote:
On Mon, Mar 07, 2011 at 04:31:41PM -0600, Tom Lendacky wrote:
We've been doing some more experimenting with the small packet network
performance problem in KVM
On Wed, Mar 09, 2011 at 08:25:34AM -0800, Shirley Ma wrote:
On Wed, 2011-03-09 at 18:10 +0200, Michael S. Tsirkin wrote:
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index 82dba5a..4477b9a 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
On Wed, Mar 09, 2011 at 08:51:33AM -0800, Shirley Ma wrote:
On Wed, 2011-03-09 at 10:09 -0600, Tom Lendacky wrote:
Vhost is receiving a lot of notifications for packets that are to
be
transmitted (over 60% of the packets generate a kick_notify).
This is guest TX send notification
On Wed, Mar 09, 2011 at 02:11:07PM -0600, Tom Lendacky wrote:
Here are the results again with the addition of the interrupt rate that
occurred on the guest virtio_net device:
Here is the KVM baseline (average of six runs):
Txn Rate: 87,070.34 Txn/Sec, Pkt Rate: 172,992 Pkts/Sec
Exits:
On Wed, Mar 09, 2011 at 05:25:11PM -0600, Tom Lendacky wrote:
As for which CPU the interrupt gets pinned to, that doesn't matter - see
below.
So what hurts us the most is that the IRQ jumps between the VCPUs?
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a
On Thu, Mar 10, 2011 at 09:23:42AM -0600, Tom Lendacky wrote:
On Thursday, March 10, 2011 12:54:58 am Michael S. Tsirkin wrote:
On Wed, Mar 09, 2011 at 05:25:11PM -0600, Tom Lendacky wrote:
As for which CPU the interrupt gets pinned to, that doesn't matter - see
below.
So what hurts
need is to handle the case where the skb is
pulled from the receive queue after skb_peek. However this is not the
right lock to use for that, sk_receive_queue.lock is.
So I expect the following is the right way to handle this.
Comments?
Signed-off-by: Michael S. Tsirkin m...@redhat.com
diff
On Sun, Mar 13, 2011 at 04:52:50PM +0100, Eric Dumazet wrote:
Le dimanche 13 mars 2011 à 17:06 +0200, Michael S. Tsirkin a écrit :
On Mon, Jan 17, 2011 at 04:11:17PM +0800, Jason Wang wrote:
We can use lock_sock_fast() instead of lock_sock() in order to get
speedup in peek_head_len
On Sun, Mar 13, 2011 at 05:32:07PM +0100, Eric Dumazet wrote:
Le dimanche 13 mars 2011 à 18:19 +0200, Michael S. Tsirkin a écrit :
Other side is in drivers/net/tun.c and net/packet/af_packet.c
At least wrt tun it seems clear socket is not locked.
Yes (assuming you refer to tun_net_xmit
On Sun, Mar 13, 2011 at 06:41:32PM +0100, Eric Dumazet wrote:
Le dimanche 13 mars 2011 à 18:43 +0200, Michael S. Tsirkin a écrit :
On Sun, Mar 13, 2011 at 05:32:07PM +0100, Eric Dumazet wrote:
Le dimanche 13 mars 2011 à 18:19 +0200, Michael S. Tsirkin a écrit :
Other side
On Mon, Mar 14, 2011 at 10:35:08PM +0530, rukhsana ansari wrote:
Seeking clarification to the original question I posted:
This maybe a novice question - Would appreciate it if you can you provide a
pointer to documentation or relevant code that explains what is the
limitation in
but please review.
Warning: compiled only, completely untested, I intend to add the bits
that use the last available index in guest to reduce exits, test it all
together.
Would appreciate review and/or testing.
Michael S. Tsirkin (2):
virtio: put last seen used index into ring itself
vhost
.
This imporves bandwidth by 30% under some workflows.
Signed-off-by: Michael S. Tsirkin m...@redhat.com
---
drivers/vhost/vhost.c | 58 +++-
drivers/vhost/vhost.h |9 +++
2 files changed, 61 insertions(+), 6 deletions(-)
diff --git a/drivers/vhost
...@rustcorp.com.au
Signed-off-by: Michael S. Tsirkin m...@redhat.com
---
drivers/virtio/virtio_ring.c | 25 -
include/linux/virtio_ring.h | 11 +++
2 files changed, 27 insertions(+), 9 deletions(-)
diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
index
On Wed, Mar 16, 2011 at 05:12:55PM -0700, Shirley Ma wrote:
Signed-off-by: Shirley Ma x...@us.ibm.com
---
drivers/net/virtio_net.c | 39 ---
1 files changed, 20 insertions(+), 19 deletions(-)
diff --git a/drivers/net/virtio_net.c
On Thu, Mar 17, 2011 at 09:00:30AM +0100, Jean-Philippe Menil wrote:
Are you running a preemptible kernel?
Does the following help at all?
diff --git a/virt/kvm/eventfd.c b/virt/kvm/eventfd.c
index 2ca4535..cdf51c9 100644
--- a/virt/kvm/eventfd.c
+++ b/virt/kvm/eventfd.c
@@ -90,7 +90,7 @@
irqfd in kvm used flush_work incorrectly:
it assumed that work scheduled previously can't run
after flush_work, but since kvm uses a non-reentrant
workqueue (by means of schedule_work)
we need flush_work_sync to get that guarantee.
Signed-off-by: Michael S. Tsirkin m...@redhat.com
Reported
The following is needed on top: still compiled only, post
here in case Tom is willing to test this meanwhile.
--
virtio: fix vring_last_used
Reported-by: Shirley Ma mashi...@us.ibm.com
Signed-off-by: Michael S. Tsirkin m...@redhat.com
---
diff --git a/drivers/virtio/virtio_ring.c b
and net.c
Michael S. Tsirkin (2):
vhost: copy_from_user - __copy_from_user
vhost-net: remove unlocked use of receive_queue
drivers/vhost/net.c | 159 -
drivers/vhost/vhost.c | 55 -
2 files changed, 64 insertions
On Thu, Mar 17, 2011 at 08:28:47PM -0700, Shirley Ma wrote:
On Thu, 2011-03-17 at 08:18 -0700, Shirley Ma wrote:
On Thu, 2011-03-17 at 07:02 +0200, Michael S. Tsirkin wrote:
So, this just tries to make sure there's enough space for
max packet in the ring, if not - drop and return OK
On Mon, Mar 21, 2011 at 11:03:07AM -0700, Shirley Ma wrote:
On Fri, 2011-03-18 at 18:41 -0700, Shirley Ma wrote:
+ /* Drop packet instead of stop queue for better
performance
*/
I would like to see some justification as to why this is the right
way to go and not just
On Tue, Mar 22, 2011 at 02:37:27PM +0200, Avi Kivity wrote:
On 03/17/2011 10:53 AM, Michael S. Tsirkin wrote:
irqfd in kvm used flush_work incorrectly:
it assumed that work scheduled previously can't run
after flush_work, but since kvm uses a non-reentrant
workqueue (by means of schedule_work
On Thu, Mar 24, 2011 at 10:46:49AM +1030, Rusty Russell wrote:
On Tue, 22 Mar 2011 13:36:50 +0200, Michael S. Tsirkin m...@redhat.com
wrote:
On Mon, Mar 21, 2011 at 11:03:07AM -0700, Shirley Ma wrote:
On Fri, 2011-03-18 at 18:41 -0700, Shirley Ma wrote:
+ /* Drop packet instead
On Thu, Mar 24, 2011 at 11:00:53AM +1030, Rusty Russell wrote:
With simply removing the notify here, it does help the case when TX
overrun hits too often, for example for 1K message size, the single
TCP_STREAM performance improved from 2.xGb/s to 4.xGb/s.
OK, we'll be getting rid of the
On Thu, Mar 24, 2011 at 10:46:49AM -0700, Shirley Ma wrote:
On Thu, 2011-03-24 at 16:28 +0200, Michael S. Tsirkin wrote:
On Thu, Mar 24, 2011 at 11:00:53AM +1030, Rusty Russell wrote:
With simply removing the notify here, it does help the case when TX
overrun hits too often, for example
On Fri, Mar 25, 2011 at 03:20:46PM +1030, Rusty Russell wrote:
3. For TX sometimes we free a single buffer, sometimes
a ton of them, which might make the transmit latency
vary. It's probably a good idea to limit this,
maybe free the minimal number possible to keep the device
On Thu, Mar 10, 2011 at 12:19:42PM +1030, Rusty Russell wrote:
Here's an old patch where I played with implementing this:
...
virtio: put last_used and last_avail index into ring itself.
Generally, the other end of the virtio ring doesn't need to see where
you're up to in consuming the
On Thu, Apr 14, 2011 at 08:58:41PM +0930, Rusty Russell wrote:
On Tue, 12 Apr 2011 23:01:12 +0300, Michael S. Tsirkin m...@redhat.com
wrote:
On Thu, Mar 10, 2011 at 12:19:42PM +1030, Rusty Russell wrote:
Here's an old patch where I played with implementing this:
...
virtio
On Mon, Apr 18, 2011 at 02:01:14PM +0200, Ingo Molnar wrote:
- the kvm tool wants to be stateless - i.e. it does not want to allocate or
manage host side devices - it just wants to provide the kind of TCP/IP
connectivity host unprivileged user-space has, to the guest. The tool
wants
On Mon, Jun 07, 2010 at 12:01:04PM -0700, Tom Lyon wrote:
On Sunday 06 June 2010 02:54:51 am Michael S. Tsirkin wrote:
On Thu, Jun 03, 2010 at 02:41:38PM -0700, Tom Lyon wrote:
OK, in the interest of making progress, I am about to embark on the
following:
1. Create a user-iommu
drivers/uio/uio_pci_generic.c:
+ * Copyright (C) 2009 Red Hat, Inc.
+ * Author: Michael S. Tsirkin m...@redhat.com
+ */
+
+#include linux/module.h
+#include linux/device.h
+#include linux/mm.h
+#include linux/idr.h
+#include linux/string.h
+#include linux/interrupt.h
+#include linux/fs.h
On Tue, Jun 08, 2010 at 04:54:43PM -0700, Tom Lyon wrote:
On Tuesday 08 June 2010 03:38:44 pm Michael S. Tsirkin wrote:
On Tue, Jun 08, 2010 at 02:21:52PM -0700, Tom Lyon wrote:
The VFIO driver is used to allow privileged AND non-privileged
processes to
implement user-level device
On Tue, Jun 08, 2010 at 02:21:52PM -0700, Tom Lyon wrote:
+ case VFIO_DOMAIN_UNSET:
+ vfio_domain_unset(vdev);
+ ret = 0;
+ break;
+
What if I do:
SET
mmap
UNSET
Now I have access to device which is not behind an iommu.
Simplest solution is to remove
On Fri, Jun 04, 2010 at 02:03:16PM -0300, Marcelo Tosatti wrote:
On Wed, Jun 02, 2010 at 09:01:52PM +0300, Michael S. Tsirkin wrote:
vhost net currently keeps running after vmstop,
which causes trouble as qemy does not check
for dirty pages anymore.
The fix is to simply keep vm and vhost
On Fri, Jun 11, 2010 at 03:15:53PM -0700, Tom Lyon wrote:
[ bunch of stuff about MSI-X checking and IOMMUs and config registers...]
OK, here's the thing. The IOMMU API today does not do squat about
dealing with interrupts. Interrupts are special because the APIC
addresses are not each in
On Thu, Jun 17, 2010 at 02:14:00PM -0700, Tom Lyon wrote:
On Sunday 13 June 2010 03:23:39 am Michael S. Tsirkin wrote:
On Fri, Jun 11, 2010 at 03:15:53PM -0700, Tom Lyon wrote:
[ bunch of stuff about MSI-X checking and IOMMUs and config registers...]
OK, here's the thing. The IOMMU
On Sun, Jun 20, 2010 at 08:32:35PM +1000, Herbert Xu wrote:
On Sun, Jun 20, 2010 at 01:06:32PM +0300, Michael S. Tsirkin wrote:
Changing the guest virtio to match the backend is a problem,
this breaks migration etc.
As long as it's done in a backwards compatible way it should be
fine
On Sun, Jun 20, 2010 at 09:02:54PM +1000, Herbert Xu wrote:
On Sun, Jun 20, 2010 at 01:39:09PM +0300, Michael S. Tsirkin wrote:
It's just like migrating from a backend that supports TSO
to one that doesn't.
Exactly. We don't support such migration.
Well that's something that has
On Sun, Jun 20, 2010 at 09:59:26PM +1000, Herbert Xu wrote:
On Sun, Jun 20, 2010 at 02:47:19PM +0300, Michael S. Tsirkin wrote:
Let's do this then. So far the virtio spec avoided making layout
assumptions, leaving guests lay out data as they see fit.
Isn't it possible to keep supporting
On Sun, May 30, 2010 at 10:25:01PM +0200, Tejun Heo wrote:
Apply the cpumask and cgroup of the initializing task to the created
vhost poller.
Based on Sridhar Samudrala's patch.
Cc: Michael S. Tsirkin m...@redhat.com
Cc: Sridhar Samudrala samudrala.srid...@gmail.com
I wanted to apply
On Thu, Jun 24, 2010 at 02:22:19PM +0200, Joerg Roedel wrote:
On Thu, Jun 17, 2010 at 02:14:00PM -0700, Tom Lyon wrote:
On Sunday 13 June 2010 03:23:39 am Michael S. Tsirkin wrote:
OK, after more investigation, I realize you are right.
We definitely need the IOMMU protection
-by: Michael S. Tsirkin m...@redhat.com
---
Eduardo, you might want to pick this one up too.
kvm/scripts/make-release |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kvm/scripts/make-release b/kvm/scripts/make-release
index e8051f4..cd28275 100755
--- a/kvm/scripts/make
On Thu, Jun 24, 2010 at 01:12:04PM -0300, Eduardo Habkost wrote:
On Thu, Jun 24, 2010 at 06:48:52PM +0300, Michael S. Tsirkin wrote:
With recent git versions (like one in rhel6 beta),
git prints out tag info in addition to
requested format, if passed a tag name.
This breaks make-release
this.
Signed-off-by: Michael S. Tsirkin m...@redhat.com
---
Changes from v1: use ^{commit} for clarity.
kvm/scripts/make-release |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kvm/scripts/make-release b/kvm/scripts/make-release
index e8051f4..64e77f9 100755
--- a/kvm/scripts/make
On Thu, Jun 24, 2010 at 03:45:51PM -0700, Sridhar Samudrala wrote:
On Thu, 2010-06-24 at 11:11 +0300, Michael S. Tsirkin wrote:
On Sun, May 30, 2010 at 10:25:01PM +0200, Tejun Heo wrote:
Apply the cpumask and cgroup of the initializing task to the created
vhost poller.
Based
On Thu, Jun 24, 2010 at 05:43:15PM -0600, Cam Macdonell wrote:
Hi Michael,
I'm trying to write a uio driver for my shared memory device for KVM
and I'm running into a situation where several interrupts in quick
succession are not all triggering the callback function in my kernel
UIO driver,
On Fri, Jun 25, 2010 at 12:39:21PM +0930, Rusty Russell wrote:
On Thu, 24 Jun 2010 03:00:30 pm Stefan Hajnoczi wrote:
On Wed, Jun 23, 2010 at 11:12 PM, Anthony Liguori anth...@codemonkey.ws
wrote:
Shouldn't it be possible to just drop the lock before invoking
virtqueue_kick() and
On Fri, Jun 25, 2010 at 09:03:46AM +0800, Dong, Eddie wrote:
Herbert Xu wrote:
On Wed, Jun 23, 2010 at 06:05:41PM +0800, Dong, Eddie wrote:
I mean once the frontend side driver post the buffers to the backend
driver, the backend driver will immediately use that buffers to
compose skb
On Fri, Jun 25, 2010 at 04:31:44PM +0100, Stefan Hajnoczi wrote:
On Fri, Jun 25, 2010 at 01:43:17PM +0300, Michael S. Tsirkin wrote:
On Fri, Jun 25, 2010 at 12:39:21PM +0930, Rusty Russell wrote:
On Thu, 24 Jun 2010 03:00:30 pm Stefan Hajnoczi wrote:
On Wed, Jun 23, 2010 at 11:12 PM
When ring parsing fails, we currently handle this
as ring empty condition. This means that we enable
kicks and recheck ring empty: if this not empty,
we re-start polling which of course will fail again.
Instead, let's return a negative error code and stop polling.
Signed-off-by: Michael S
-by: Michael S. Tsirkin m...@redhat.com
---
So here's what I came up with: I basically copied
the work-around from userspace virtio.
As suggested by Dave (assuming I understood the suggestion
correctly) this implements the workaround in vhost-net, so
other tun users don't start relying
On Mon, Jun 28, 2010 at 05:56:07PM +0800, Xin, Xiaohui wrote:
-Original Message-
From: Herbert Xu [mailto:herb...@gondor.apana.org.au]
Sent: Sunday, June 27, 2010 2:15 PM
To: Dong, Eddie
Cc: Xin, Xiaohui; Stephen Hemminger; net...@vger.kernel.org;
kvm@vger.kernel.org;
bother applying the hack to IPv6 as userspace virtio does not
have a work-around for that - let's hope guests will do the right
thing wrt IPv6.
Signed-off-by: Michael S. Tsirkin m...@redhat.com
---
Dave, I'm going to put this patch on the vhost tree,
no need for you to bother merging it - you'll get
On Mon, Jun 28, 2010 at 01:08:07PM +0300, Michael S. Tsirkin wrote:
Userspace virtio server has the following hack
so guests rely on it, and we have to replicate it, too:
Use port number to detect incoming IPv4 DHCP response packets,
and fill in the checksum for these.
The issue we
On Mon, Jun 28, 2010 at 10:11:43AM -0700, Sridhar Samudrala wrote:
On Sun, 2010-06-27 at 11:59 +0300, Michael S. Tsirkin wrote:
When ring parsing fails, we currently handle this
as ring empty condition. This means that we enable
kicks and recheck ring empty: if this not empty,
we re-start
On Tue, Jun 29, 2010 at 12:36:47AM -0700, David Miller wrote:
From: Michael S. Tsirkin m...@redhat.com
Date: Mon, 28 Jun 2010 13:08:07 +0300
Userspace virtio server has the following hack
so guests rely on it, and we have to replicate it, too:
Use port number to detect incoming IPv4
On Wed, Jun 30, 2010 at 12:14:12AM -0600, Alex Williamson wrote:
On Tue, 2010-06-08 at 14:21 -0700, Tom Lyon wrote:
The VFIO driver is used to allow privileged AND non-privileged processes
to
implement user-level device drivers for any well-behaved PCI, PCI-X, and
PCIe
devices.
Hi
On Wed, Jun 30, 2010 at 05:08:11PM -0500, Anthony Liguori wrote:
On 06/29/2010 08:04 AM, Michael S. Tsirkin wrote:
On Tue, Jun 29, 2010 at 12:36:47AM -0700, David Miller wrote:
From: Michael S. Tsirkinm...@redhat.com
Date: Mon, 28 Jun 2010 13:08:07 +0300
Userspace virtio server has
On Wed, Jun 30, 2010 at 03:17:55PM -0700, Tom Lyon wrote:
Thanks, Alex!
Am incorporating...
I get it there's no chance you'll drop the virtualization
from the driver then?
--
MST
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to
Samudrala s...@us.ibm.com
Signed-off-by: Michael S. Tsirkin m...@redhat.com
---
I'm not sure the previous time made it clear what exactly is the
proposed change, so reposting. Info, Peter, could you ack merging the
following through the net-next tree please?
diff --git a/kernel/sched.c b/kernel
On Thu, Jul 01, 2010 at 02:55:07PM +0300, Michael S. Tsirkin wrote:
On Thu, Jul 01, 2010 at 01:43:23PM +0200, Peter Zijlstra wrote:
On Thu, 2010-07-01 at 13:19 +0200, Peter Zijlstra wrote:
On Thu, 2010-07-01 at 14:07 +0300, Michael S. Tsirkin wrote:
Author: Sridhar Samudrala s
On Thu, Jul 01, 2010 at 02:32:43PM +0200, Peter Zijlstra wrote:
On Thu, 2010-07-01 at 14:55 +0300, Michael S. Tsirkin wrote:
- why can't it set the kernel thread's affinity too?
It can. However: the threads are started internally by the driver
when qemu does an ioctl. What we want
On Thu, Jul 01, 2010 at 02:46:35PM +0200, Peter Zijlstra wrote:
On Thu, 2010-07-01 at 14:34 +0200, Peter Zijlstra wrote:
On Thu, 2010-07-01 at 15:23 +0300, Michael S. Tsirkin wrote:
The patch using this is here:
http://www.mail-archive.com/kvm@vger.kernel.org/msg35411.html
On Thu, Jul 01, 2010 at 03:07:26PM +0200, Peter Zijlstra wrote:
On Thu, 2010-07-01 at 15:50 +0300, Michael S. Tsirkin wrote:
On Thu, Jul 01, 2010 at 02:32:43PM +0200, Peter Zijlstra wrote:
On Thu, 2010-07-01 at 14:55 +0300, Michael S. Tsirkin wrote:
- why can't it set the kernel
On Thu, Jul 01, 2010 at 03:30:24PM +0200, Peter Zijlstra wrote:
On Thu, 2010-07-01 at 16:08 +0300, Michael S. Tsirkin wrote:
On Thu, Jul 01, 2010 at 02:46:35PM +0200, Peter Zijlstra wrote:
On Thu, 2010-07-01 at 14:34 +0200, Peter Zijlstra wrote:
On Thu, 2010-07-01 at 15:23 +0300, Michael
On Thu, Jul 01, 2010 at 09:29:04AM -0600, Alex Williamson wrote:
On Tue, 2010-06-08 at 14:21 -0700, Tom Lyon wrote:
+The VFIO_DMA_MASK ioctl is used to set the maximum permissible DMA address
+(device dependent). It takes a single unsigned 64 bit integer as an
argument.
+This call also
On Thu, Jul 01, 2010 at 09:48:41AM -0600, Alex Williamson wrote:
On Thu, 2010-07-01 at 18:31 +0300, Michael S. Tsirkin wrote:
On Thu, Jul 01, 2010 at 09:29:04AM -0600, Alex Williamson wrote:
On Tue, 2010-06-08 at 14:21 -0700, Tom Lyon wrote:
+The VFIO_DMA_MASK ioctl is used to set
)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost-net
Michael S. Tsirkin (2):
vhost: break out of polling loop on error
vhost: add unlikely annotations to error path
drivers/vhost/net.c | 12 ++-
drivers/vhost/vhost.c
On Fri, Jul 02, 2010 at 11:06:37PM +0200, Oleg Nesterov wrote:
On 07/02, Peter Zijlstra wrote:
On Fri, 2010-07-02 at 11:01 -0700, Sridhar Samudrala wrote:
Does it (Tejun's kthread_clone() patch) also inherit the
cgroup of the caller?
Of course, its a simple do_fork() which
in a VM):
iptables -A POSTROUTING -t mangle -p udp --dport 68 -j CHECKSUM
--checksum-fill
Signed-off-by: Michael S. Tsirkin m...@redhat.com
---
Lightly tested. Please review for 2.6.36. Thanks!
include/linux/netfilter_ipv4/ipt_CHECKSUM.h | 18 +++
net/ipv4/netfilter/Kconfig
with checksum offloads, but don't want to disable
checksum offload in your device.
The problem happens in the field with virtualized applications.
For reference, see Red Hat bz 60, as well as
http://www.spinics.net/lists/kvm/msg37660.html
Signed-off-by: Michael S. Tsirkin m...@redhat.com
On Fri, Jul 09, 2010 at 03:18:14PM +0800, Herbert Xu wrote:
On Fri, Jul 09, 2010 at 01:29:13AM +0300, Michael S. Tsirkin wrote:
This adds a `CHECKSUM' target, which can be used in the iptables mangle
table.
You can use this target to compute and fill in the checksum in
an IP packet
On Fri, Jul 09, 2010 at 05:17:36PM +0200, Patrick McHardy wrote:
Am 09.07.2010 00:29, schrieb Michael S. Tsirkin:
This adds a `CHECKSUM' target, which can be used in the iptables mangle
table.
You can use this target to compute and fill in the checksum in
an IP packet that lacks
On Fri, Jul 09, 2010 at 11:56:26AM +0200, Jan Engelhardt wrote:
On Friday 2010-07-09 00:29, Michael S. Tsirkin wrote:
include/linux/netfilter_ipv4/ipt_CHECKSUM.h | 18 +++
net/ipv4/netfilter/Kconfig | 16 ++
net/ipv4/netfilter/Makefile |1
On Sun, Jul 11, 2010 at 02:45:49PM +0200, Jan Engelhardt wrote:
On Sunday 2010-07-11 14:27, Michael S. Tsirkin wrote:
include/linux/netfilter_ipv4/ipt_CHECKSUM.h | 18 +++
net/ipv4/netfilter/Kconfig | 16 ++
net/ipv4/netfilter/Makefile
On Sun, Jul 11, 2010 at 08:45:01PM +0800, Changli Gao wrote:
On Sun, Jul 11, 2010 at 8:27 PM, Michael S. Tsirkin m...@redhat.com wrote:
On Fri, Jul 09, 2010 at 11:56:26AM +0200, Jan Engelhardt wrote:
On Friday 2010-07-09 00:29, Michael S. Tsirkin wrote:
include/linux/netfilter_ipv4
in a VM):
iptables -A POSTROUTING -t mangle -p udp --dport bootpc \
-j CHECKSUM --checksum-fill
Signed-off-by: Michael S. Tsirkin m...@redhat.com
---
Changes from v1:
moved from ipt to xt
get rid of any ipv4 dependencies
coding style tweaks
include/linux/netfilter
501 - 600 of 4680 matches
Mail list logo
