Re: Performance test result between virtio_pci MSI-X disable and enable

2010-12-02 Thread Michael S. Tsirkin
On Thu, Dec 02, 2010 at 07:52:00PM +0800, Sheng Yang wrote: On Thu, Dec 2, 2010 at 5:49 PM, Michael S. Tsirkin m...@redhat.com wrote: On Thu, Dec 02, 2010 at 09:13:28AM +0800, Yang, Sheng wrote: On Wednesday 01 December 2010 22:03:58 Michael S. Tsirkin wrote: On Wed, Dec 01, 2010 at 04:41

Re: Mask bit support's API

2010-12-02 Thread Michael S. Tsirkin
On Thu, Dec 02, 2010 at 03:09:43PM +0200, Avi Kivity wrote: On 12/01/2010 04:36 AM, Yang, Sheng wrote: On Tuesday 30 November 2010 22:15:29 Avi Kivity wrote: On 11/26/2010 04:35 AM, Yang, Sheng wrote: Shouldn't kvm also service reads from the pending bitmask? Of

Re: Mask bit support's API

2010-12-02 Thread Michael S. Tsirkin
On Thu, Dec 02, 2010 at 03:56:52PM +0200, Avi Kivity wrote: On 12/02/2010 03:47 PM, Michael S. Tsirkin wrote: Which case? the readl() doesn't need access to the routing table, just the entry. One thing that read should do is flush in the outstanding interrupts and flush out the mask

Re: Mask bit support's API

2010-12-02 Thread Michael S. Tsirkin
On Thu, Dec 02, 2010 at 10:54:24PM +0800, Sheng Yang wrote: On Thu, Dec 2, 2010 at 10:26 PM, Michael S. Tsirkin m...@redhat.com wrote: On Thu, Dec 02, 2010 at 03:56:52PM +0200, Avi Kivity wrote: On 12/02/2010 03:47 PM, Michael S. Tsirkin wrote:  Which case?  the readl() doesn't need

Re: [PATCH 1/2] vhost test module

2010-12-02 Thread Michael S. Tsirkin
On Thu, Dec 02, 2010 at 11:00:37AM -0800, Paul E. McKenney wrote: On Mon, Nov 29, 2010 at 07:09:01PM +0200, Michael S. Tsirkin wrote: This adds a test module for vhost infrastructure. Intentionally not tied to kbuild to prevent people from installing and loading it accidentally. Signed

Re: [PATCH 1/2] vhost test module

2010-12-02 Thread Michael S. Tsirkin
On Thu, Dec 02, 2010 at 11:26:16AM -0800, Paul E. McKenney wrote: On Thu, Dec 02, 2010 at 09:11:30PM +0200, Michael S. Tsirkin wrote: On Thu, Dec 02, 2010 at 11:00:37AM -0800, Paul E. McKenney wrote: On Mon, Nov 29, 2010 at 07:09:01PM +0200, Michael S. Tsirkin wrote: This adds a test

Re: [PATCH 1/2] vhost test module

2010-12-02 Thread Michael S. Tsirkin
On Thu, Dec 02, 2010 at 03:13:03PM -0800, Paul E. McKenney wrote: On Thu, Dec 02, 2010 at 09:47:09PM +0200, Michael S. Tsirkin wrote: On Thu, Dec 02, 2010 at 11:26:16AM -0800, Paul E. McKenney wrote: On Thu, Dec 02, 2010 at 09:11:30PM +0200, Michael S. Tsirkin wrote: On Thu, Dec 02, 2010

Re: virtio_net sometimes didn't work

2010-12-09 Thread Michael S. Tsirkin
baloon is moved, there's still the message in guest, only this time things keep going afterwards? and i found someone else also meet this problem. https://bugs.launchpad.net/ubuntu/+source/linux/+bug/584675 2010/11/25 Michael S. Tsirkin m...@redhat.com: On Thu, Nov 25, 2010 at 10:21:24PM

Re: Performance test result between per-vhost kthread disable and enable

2010-12-09 Thread Michael S. Tsirkin
On Tue, Nov 23, 2010 at 10:13:43AM +0800, lidong chen wrote: I test the performance between per-vhost kthread disable and enable. Test method: Send the same traffic load between per-vhost kthread disable and enable, and compare the cpu rate of host os. I run five vm on kvm, each of them

Re: Performance test result between per-vhost kthread disable and enable

2010-12-09 Thread Michael S. Tsirkin
On Thu, Dec 09, 2010 at 03:31:08PM +0200, Michael S. Tsirkin wrote: On Tue, Nov 23, 2010 at 10:13:43AM +0800, lidong chen wrote: I test the performance between per-vhost kthread disable and enable. Test method: Send the same traffic load between per-vhost kthread disable and enable

[GIT PULL net-2.6] vhost-net: logging fixup

2010-12-12 Thread Michael S. Tsirkin
/scm/linux/kernel/git/mst/vhost.git vhost-net Michael S. Tsirkin (1): vhost: correctly set bits of dirty pages drivers/vhost/vhost.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord

[PATCH conditional] qemu-kvm: ioeventfd fixup

2010-12-12 Thread Michael S. Tsirkin
Make ioeventfd patchset apply to qemu-kvm. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- This patch will need to be applied when ioeventfd is merged in qemu.git. kvm-all.c |2 +- kvm.h |1 + qemu-kvm.c |2 ++ qemu-kvm.h |1 + 4 files changed, 5 insertions(+), 1

Re: [PATCH v2 0/4] KVM genirq: Enable adaptive IRQ sharing for passed-through devices

2010-12-13 Thread Michael S. Tsirkin
hurt, and yes, they all seem to be handled correctly. FWIW Reviewed-by: Michael S. Tsirkin m...@redhat.com -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[GIT PULL net-next-2.6] vhost-net: tools, cleanups, optimizations

2010-12-13 Thread Michael S. Tsirkin
/mst/vhost.git vhost-net-next Jason Wang (1): vhost: fix typos in comment Julia Lawall (1): drivers/vhost/vhost.c: delete double assignment Michael S. Tsirkin (9): vhost: put mm after thread stop vhost-net: batch use/unuse mm vhost: copy_to_user - __copy_to_user

Re: [PATCH 2/2] tools/virtio: virtio_test tool

2010-12-13 Thread Michael S. Tsirkin
On Mon, Dec 06, 2010 at 02:37:05PM -0200, Thiago Farina wrote: On Mon, Nov 29, 2010 at 3:16 PM, Michael S. Tsirkin m...@redhat.com wrote: +#define container_of(ptr, type, member) ({                     \ +       const typeof( ((type *)0)-member ) *__mptr = (ptr);    \ +       (type

Re: [PATCH 2/2] tools/virtio: virtio_test tool

2010-12-13 Thread Michael S. Tsirkin
On Mon, Dec 06, 2010 at 03:23:02PM +1030, Rusty Russell wrote: On Tue, 30 Nov 2010 03:46:37 am Michael S. Tsirkin wrote: This is the userspace part of the tool: it includes a bunch of stubs for linux APIs, somewhat simular to linuxsched. This makes it possible to recompile the ring code

Re: [GIT PULL net-next-2.6] vhost-net: tools, cleanups, optimizations

2010-12-13 Thread Michael S. Tsirkin
On Mon, Dec 13, 2010 at 12:44:13PM +0200, Michael S. Tsirkin wrote: Please merge the following tree for 2.6.38. Thanks! Um, I sent this out before I noticed the mail from Rusty with some questions on the test code. I missed that and assumed no comments - no issues, perhaps wrongly. Rusty - I

[GIT PULL net-next-2.6] vhost-net: tools, cleanups, optimizations

2010-12-14 Thread Michael S. Tsirkin
On Mon, Dec 13, 2010 at 12:44:13PM +0200, Michael S. Tsirkin wrote: Please merge the following tree for 2.6.38. Thanks! Rusty Acked it as is, so please pull the below. Thanks very much! The following changes since commit ad1184c6cf067a13e8cb2a4e7ccc407f947027d0: net: au1000_eth: remove

Re: [PATCH 4/5] pci-assign: Convert need_emulate_cmd into a bitmask

2010-12-15 Thread Michael S. Tsirkin
On Mon, Dec 13, 2010 at 04:56:29PM -0700, Alex Williamson wrote: On Tue, 2010-12-14 at 00:25 +0100, Jan Kiszka wrote: From: Jan Kiszka jan.kis...@siemens.com Define a mask of PCI command register bits that need to be emulated, i.e. read back from their shadow state. We will need this for

Re: [PATCH 11/21] ioport: insert event_tap_ioport() to ioport_write().

2010-12-16 Thread Michael S. Tsirkin
On Thu, Dec 16, 2010 at 04:37:41PM +0900, Yoshiaki Tamura wrote: 2010/11/28 Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp: 2010/11/28 Michael S. Tsirkin m...@redhat.com: On Thu, Nov 25, 2010 at 03:06:50PM +0900, Yoshiaki Tamura wrote: Record ioport event to replay it upon failover

Re: [PATCH 05/21] virtio: modify save/load handler to handle inuse varialble.

2010-12-16 Thread Michael S. Tsirkin
On Thu, Dec 16, 2010 at 04:36:16PM +0900, Yoshiaki Tamura wrote: 2010/12/3 Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp: 2010/12/2 Michael S. Tsirkin m...@redhat.com: On Wed, Dec 01, 2010 at 05:03:43PM +0900, Yoshiaki Tamura wrote: 2010/11/28 Michael S. Tsirkin m...@redhat.com: On Sun

Re: [PATCH 11/21] ioport: insert event_tap_ioport() to ioport_write().

2010-12-16 Thread Michael S. Tsirkin
On Thu, Dec 16, 2010 at 06:50:04PM +0900, Yoshiaki Tamura wrote: 2010/12/16 Michael S. Tsirkin m...@redhat.com: On Thu, Dec 16, 2010 at 04:37:41PM +0900, Yoshiaki Tamura wrote: 2010/11/28 Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp: 2010/11/28 Michael S. Tsirkin m...@redhat.com

Re: [PATCH 05/21] virtio: modify save/load handler to handle inuse varialble.

2010-12-16 Thread Michael S. Tsirkin
On Thu, Dec 16, 2010 at 11:28:46PM +0900, Yoshiaki Tamura wrote: 2010/12/16 Michael S. Tsirkin m...@redhat.com: On Thu, Dec 16, 2010 at 04:36:16PM +0900, Yoshiaki Tamura wrote: 2010/12/3 Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp: 2010/12/2 Michael S. Tsirkin m...@redhat.com: On Wed

Re: [PATCH v3 2/4] genirq: Inform handler about line sharing state

2010-12-18 Thread Michael S. Tsirkin
On Fri, Dec 17, 2010 at 05:32:46PM +0100, Thomas Gleixner wrote: On Fri, 17 Dec 2010, Jan Kiszka wrote: Am 17.12.2010 16:25, Thomas Gleixner wrote: Your aproach with disable_irq_nosync() is completely flawed, simply because you try to pretend that your interrupt handler is done, while

Re: [PATCH 05/21] virtio: modify save/load handler to handle inuse varialble.

2010-12-24 Thread Michael S. Tsirkin
On Fri, Dec 17, 2010 at 12:59:58AM +0900, Yoshiaki Tamura wrote: 2010/12/16 Michael S. Tsirkin m...@redhat.com: On Thu, Dec 16, 2010 at 11:28:46PM +0900, Yoshiaki Tamura wrote: 2010/12/16 Michael S. Tsirkin m...@redhat.com: On Thu, Dec 16, 2010 at 04:36:16PM +0900, Yoshiaki Tamura wrote

Re: [PATCH 06/19] virtio: update last_avail_idx when inuse is decreased.

2010-12-24 Thread Michael S. Tsirkin
On Fri, Dec 24, 2010 at 12:18:15PM +0900, Yoshiaki Tamura wrote: virtio save/load is currently sending last_avail_idx, but inuse isn't. This causes inconsistent state when using Kemari which replays outstanding requests on the secondary. By letting last_avail_idx to be updated after inuse is

Re: [PATCH 06/19] virtio: update last_avail_idx when inuse is decreased.

2010-12-24 Thread Michael S. Tsirkin
On Fri, Dec 24, 2010 at 08:22:00PM +0900, Yoshiaki Tamura wrote: 2010/12/24 Michael S. Tsirkin m...@redhat.com: On Fri, Dec 24, 2010 at 12:18:15PM +0900, Yoshiaki Tamura wrote: virtio save/load is currently sending last_avail_idx, but inuse isn't. This causes inconsistent state when using

Re: [PATCH 05/21] virtio: modify save/load handler to handle inuse varialble.

2010-12-24 Thread Michael S. Tsirkin
On Fri, Dec 24, 2010 at 08:42:19PM +0900, Yoshiaki Tamura wrote: 2010/12/24 Michael S. Tsirkin m...@redhat.com: On Fri, Dec 17, 2010 at 12:59:58AM +0900, Yoshiaki Tamura wrote: 2010/12/16 Michael S. Tsirkin m...@redhat.com: On Thu, Dec 16, 2010 at 11:28:46PM +0900, Yoshiaki Tamura wrote

Re: [PATCH 06/19] virtio: update last_avail_idx when inuse is decreased.

2010-12-24 Thread Michael S. Tsirkin
On Fri, Dec 24, 2010 at 10:14:50PM +0900, Yoshiaki Tamura wrote: 2010/12/24 Michael S. Tsirkin m...@redhat.com: On Fri, Dec 24, 2010 at 08:22:00PM +0900, Yoshiaki Tamura wrote: 2010/12/24 Michael S. Tsirkin m...@redhat.com: On Fri, Dec 24, 2010 at 12:18:15PM +0900, Yoshiaki Tamura wrote

Re: [PATCH 05/21] virtio: modify save/load handler to handle inuse varialble.

2010-12-26 Thread Michael S. Tsirkin
On Fri, Dec 24, 2010 at 08:42:19PM +0900, Yoshiaki Tamura wrote: If qemu_aio_flush() is responsible for flushing the outstanding virtio-net requests, I'm wondering why it's a problem for Kemari. As I described in the previous message, Kemari queues the requests first.  So in you example

Re: [Qemu-devel] Re: [PATCH 05/21] virtio: modify save/load handler to handle inuse varialble.

2010-12-26 Thread Michael S. Tsirkin
On Sun, Dec 26, 2010 at 07:14:44PM +0900, Yoshiaki Tamura wrote: 2010/12/26 Michael S. Tsirkin m...@redhat.com: On Fri, Dec 24, 2010 at 08:42:19PM +0900, Yoshiaki Tamura wrote: If qemu_aio_flush() is responsible for flushing the outstanding virtio-net requests, I'm wondering why it's

Re: [PATCH 05/21] virtio: modify save/load handler to handle inuse varialble.

2010-12-26 Thread Michael S. Tsirkin
On Fri, Dec 24, 2010 at 08:42:19PM +0900, Yoshiaki Tamura wrote: 2010/12/24 Michael S. Tsirkin m...@redhat.com: On Fri, Dec 17, 2010 at 12:59:58AM +0900, Yoshiaki Tamura wrote: 2010/12/16 Michael S. Tsirkin m...@redhat.com: On Thu, Dec 16, 2010 at 11:28:46PM +0900, Yoshiaki Tamura wrote

Re: [PATCH 05/21] virtio: modify save/load handler to handle inuse varialble.

2010-12-26 Thread Michael S. Tsirkin
On Sun, Dec 26, 2010 at 07:57:52PM +0900, Yoshiaki Tamura wrote: 2010/12/26 Michael S. Tsirkin m...@redhat.com: On Fri, Dec 24, 2010 at 08:42:19PM +0900, Yoshiaki Tamura wrote: 2010/12/24 Michael S. Tsirkin m...@redhat.com: On Fri, Dec 17, 2010 at 12:59:58AM +0900, Yoshiaki Tamura wrote

Re: [Qemu-devel] Re: [PATCH 05/21] virtio: modify save/load handler to handle inuse varialble.

2010-12-26 Thread Michael S. Tsirkin
On Sun, Dec 26, 2010 at 09:16:28PM +0900, Yoshiaki Tamura wrote: 2010/12/26 Michael S. Tsirkin m...@redhat.com: On Sun, Dec 26, 2010 at 07:57:52PM +0900, Yoshiaki Tamura wrote: 2010/12/26 Michael S. Tsirkin m...@redhat.com: On Fri, Dec 24, 2010 at 08:42:19PM +0900, Yoshiaki Tamura wrote

Re: [PATCH 18/19] Introduce -k option to enable FT migration mode (Kemari).

2010-12-27 Thread Michael S. Tsirkin
On Mon, Dec 27, 2010 at 05:25:36PM +0900, Yoshiaki Tamura wrote: When -k option is set to migrate command, it will turn on ft_mode to start FT migration mode (Kemari). Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- hmp-commands.hx |7 --- migration.c |3

Re: [PATCH 18/19] Introduce -k option to enable FT migration mode (Kemari).

2010-12-27 Thread Michael S. Tsirkin
On Mon, Dec 27, 2010 at 06:11:27PM +0900, Yoshiaki Tamura wrote: 2010/12/27 Michael S. Tsirkin m...@redhat.com: On Mon, Dec 27, 2010 at 05:25:36PM +0900, Yoshiaki Tamura wrote: When -k option is set to migrate command, it will turn on ft_mode to start FT migration mode (Kemari). Signed

[PATCH] lfp: fix AF_INET checksum with csum offloading

2010-12-27 Thread Michael S. Tsirkin
When an AF_INET socket is used, linux would sometimes return a packet without the checksum. This happens when a packet originates on the same machine, which is most common with virtual machines but might be possible even without with a software-based dhcp server such as dnsmasq. This appears to

Re: [Qemu-devel] Re: [PATCH 18/19] Introduce -k option to enable FT migration mode (Kemari).

2010-12-27 Thread Michael S. Tsirkin
On Tue, Dec 28, 2010 at 08:34:12AM +0900, Yoshiaki Tamura wrote: 2010/12/28 Avi Kivity a...@redhat.com: On 12/27/2010 01:07 PM, Yoshiaki Tamura wrote:    Not sure whether we need to mention the codename here: is it likely to    help the users?  Ah:-)  Just didn't know what

Re: [PATCH 2/2][RFC] KVM: Emulate MSI-X table and PBA in kernel

2010-12-29 Thread Michael S. Tsirkin
On Wed, Dec 29, 2010 at 03:18:13PM +0800, Sheng Yang wrote: On Tuesday 28 December 2010 20:26:13 Avi Kivity wrote: On 12/22/2010 10:44 AM, Sheng Yang wrote: Then we can support mask bit operation of assigned devices now. @@ -3817,14 +3819,16 @@ static int

Re: [PATCH 2/2][RFC] KVM: Emulate MSI-X table and PBA in kernel

2010-12-29 Thread Michael S. Tsirkin
On Thu, Dec 30, 2010 at 03:32:42PM +0800, Sheng Yang wrote: On Wednesday 29 December 2010 17:28:24 Michael S. Tsirkin wrote: On Wed, Dec 29, 2010 at 04:55:19PM +0800, Sheng Yang wrote: On Wednesday 29 December 2010 16:31:35 Michael S. Tsirkin wrote: On Wed, Dec 29, 2010 at 03:18:13PM

Re: [PATCH 2/2][RFC] KVM: Emulate MSI-X table and PBA in kernel

2010-12-30 Thread Michael S. Tsirkin
On Thu, Dec 30, 2010 at 03:55:10PM +0800, Sheng Yang wrote: On Thursday 30 December 2010 15:47:48 Michael S. Tsirkin wrote: On Thu, Dec 30, 2010 at 03:32:42PM +0800, Sheng Yang wrote: On Wednesday 29 December 2010 17:28:24 Michael S. Tsirkin wrote: On Wed, Dec 29, 2010 at 04:55:19PM

Re: [PATCH 2/2][RFC] KVM: Emulate MSI-X table and PBA in kernel

2010-12-30 Thread Michael S. Tsirkin
On Thu, Dec 30, 2010 at 04:24:10PM +0800, Sheng Yang wrote: On Thursday 30 December 2010 16:15:32 Michael S. Tsirkin wrote: On Thu, Dec 30, 2010 at 03:55:10PM +0800, Sheng Yang wrote: On Thursday 30 December 2010 15:47:48 Michael S. Tsirkin wrote: On Thu, Dec 30, 2010 at 03:32:42PM +0800

Re: [PATCH 2/2][RFC] KVM: Emulate MSI-X table and PBA in kernel

2010-12-30 Thread Michael S. Tsirkin
On Thu, Dec 30, 2010 at 11:28:20AM +0200, Avi Kivity wrote: On 12/30/2010 09:32 AM, Sheng Yang wrote: I don't think it's going to work: we are not in the context of the right process. Further I think we should keep the option of reading the PBA status from the device or host kernel

Re: [PATCH 2/2][RFC] KVM: Emulate MSI-X table and PBA in kernel

2010-12-30 Thread Michael S. Tsirkin
On Thu, Dec 30, 2010 at 11:30:12AM +0200, Avi Kivity wrote: On 12/30/2010 09:47 AM, Michael S. Tsirkin wrote: I am not really suggesting this. What I say is PBA is unimplemented let us not commit to an interface yet. What happens to a guest that tries to use PBA? It's a mandatory part

Re: [PATCH 2/2][RFC] KVM: Emulate MSI-X table and PBA in kernel

2010-12-30 Thread Michael S. Tsirkin
On Thu, Dec 30, 2010 at 12:37:18PM +0200, Avi Kivity wrote: On 12/30/2010 12:32 PM, Michael S. Tsirkin wrote: On Thu, Dec 30, 2010 at 11:30:12AM +0200, Avi Kivity wrote: On 12/30/2010 09:47 AM, Michael S. Tsirkin wrote: I am not really suggesting this. What I say is PBA is unimplemented

Re: [PATCH 2/2][RFC] KVM: Emulate MSI-X table and PBA in kernel

2010-12-30 Thread Michael S. Tsirkin
On Thu, Dec 30, 2010 at 01:27:15PM +0200, Avi Kivity wrote: On 12/30/2010 01:07 PM, Michael S. Tsirkin wrote: On Thu, Dec 30, 2010 at 12:37:18PM +0200, Avi Kivity wrote: On 12/30/2010 12:32 PM, Michael S. Tsirkin wrote: On Thu, Dec 30, 2010 at 11:30:12AM +0200, Avi Kivity wrote

Re: [PATCH 2/2][RFC] KVM: Emulate MSI-X table and PBA in kernel

2011-01-02 Thread Michael S. Tsirkin
On Sun, Jan 02, 2011 at 12:58:50PM +0200, Avi Kivity wrote: On 01/02/2011 12:39 PM, Michael S. Tsirkin wrote: I agree. At least it's not a regression. And in fact we haven't seen any device driver use this. I've checked Linux kernel code, found no one used PCI_MSIX_PBA

Re: [PATCH 2/2][RFC] KVM: Emulate MSI-X table and PBA in kernel

2011-01-02 Thread Michael S. Tsirkin
On Sun, Jan 02, 2011 at 03:34:21PM +0200, Avi Kivity wrote: On 01/02/2011 01:51 PM, Michael S. Tsirkin wrote: I don't see how userspace can send interrupts with this interface unfortunately. We also need irqfd support ... Sure we'll need additions to that interface. What I

Re: [PATCH 09/21] Introduce event-tap.

2011-01-04 Thread Michael S. Tsirkin
On Tue, Jan 04, 2011 at 08:02:54PM +0900, Yoshiaki Tamura wrote: 2010/11/29 Stefan Hajnoczi stefa...@gmail.com: On Thu, Nov 25, 2010 at 6:06 AM, Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp wrote: event-tap controls when to start FT transaction, and provides proxy functions to called

Re: [Qemu-devel] Re: [PATCH 09/21] Introduce event-tap.

2011-01-04 Thread Michael S. Tsirkin
On Tue, Jan 04, 2011 at 09:20:53PM +0900, Yoshiaki Tamura wrote: 2011/1/4 Michael S. Tsirkin m...@redhat.com: On Tue, Jan 04, 2011 at 08:02:54PM +0900, Yoshiaki Tamura wrote: 2010/11/29 Stefan Hajnoczi stefa...@gmail.com: On Thu, Nov 25, 2010 at 6:06 AM, Yoshiaki Tamura tamura.yoshi

Re: [Qemu-devel] Re: [PATCH 09/21] Introduce event-tap.

2011-01-04 Thread Michael S. Tsirkin
On Tue, Jan 04, 2011 at 10:45:13PM +0900, Yoshiaki Tamura wrote: 2011/1/4 Michael S. Tsirkin m...@redhat.com: On Tue, Jan 04, 2011 at 09:20:53PM +0900, Yoshiaki Tamura wrote: 2011/1/4 Michael S. Tsirkin m...@redhat.com: On Tue, Jan 04, 2011 at 08:02:54PM +0900, Yoshiaki Tamura wrote

[PATCH] virtio-pci: add softlinks between virtio and pci

2011-01-05 Thread Michael S. Tsirkin
-by: Michael S. Tsirkin m...@redhat.com --- Gleb, could you please ack that this patch below will be enough to fix the installer issue that you see? drivers/virtio/virtio_pci.c | 18 +- 1 files changed, 17 insertions(+), 1 deletions(-) diff --git a/drivers/virtio/virtio_pci.c b

Re: [Qemu-devel] Re: [PATCH 09/21] Introduce event-tap.

2011-01-06 Thread Michael S. Tsirkin
On Thu, Jan 06, 2011 at 05:47:27PM +0900, Yoshiaki Tamura wrote: 2011/1/4 Michael S. Tsirkin m...@redhat.com: On Tue, Jan 04, 2011 at 10:45:13PM +0900, Yoshiaki Tamura wrote: 2011/1/4 Michael S. Tsirkin m...@redhat.com: On Tue, Jan 04, 2011 at 09:20:53PM +0900, Yoshiaki Tamura wrote

Re: Flow Control and Port Mirroring Revisited

2011-01-06 Thread Michael S. Tsirkin
On Thu, Jan 06, 2011 at 06:33:12PM +0900, Simon Horman wrote: Hi, Back in October I reported that I noticed a problem whereby flow control breaks down when openvswitch is configured to mirror a port[1]. Apropos the UDP flow control. See this

Re: Flow Control and Port Mirroring Revisited

2011-01-06 Thread Michael S. Tsirkin
On Thu, Jan 06, 2011 at 08:30:52PM +0900, Simon Horman wrote: On Thu, Jan 06, 2011 at 12:27:55PM +0200, Michael S. Tsirkin wrote: On Thu, Jan 06, 2011 at 06:33:12PM +0900, Simon Horman wrote: Hi, Back in October I reported that I noticed a problem whereby flow control breaks down

Re: Flow Control and Port Mirroring Revisited

2011-01-06 Thread Michael S. Tsirkin
On Thu, Jan 06, 2011 at 09:29:02PM +0900, Simon Horman wrote: On Thu, Jan 06, 2011 at 02:07:22PM +0200, Michael S. Tsirkin wrote: On Thu, Jan 06, 2011 at 08:30:52PM +0900, Simon Horman wrote: On Thu, Jan 06, 2011 at 12:27:55PM +0200, Michael S. Tsirkin wrote: On Thu, Jan 06, 2011 at 06

Re: [PATCH] pci-assign: Fix transition MSI-INTx

2011-01-06 Thread Michael S. Tsirkin
On Tue, Jan 04, 2011 at 10:04:30PM +0100, Jan Kiszka wrote: From: Jan Kiszka jan.kis...@siemens.com Make sure to re-register the IRQ of an assigned device as INTx when the guest disables MSI[X] mode again. Signed-off-by: Jan Kiszka jan.kis...@siemens.com Acked-by: Michael S. Tsirkin m

[PATCH] vhost: fix signed/unsigned comparison

2011-01-10 Thread Michael S. Tsirkin
-by: Michael S. Tsirkin m...@redhat.com --- I've put this on my vhost.git tree. drivers/vhost/vhost.c | 18 +++--- 1 files changed, 11 insertions(+), 7 deletions(-) diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c index 159c77a..522b8fc 100644 --- a/drivers/vhost/vhost.c +++ b

Re: [PATCH][RFC] qemu:virtio-net: Use TUNSETTXFILTER for MAC filteringlogin register about

2011-01-12 Thread Michael S. Tsirkin
this discussion for suggestions: Date: Tue, 9 Mar 2010 15:15:44 +0200 From: Michael S. Tsirkin m...@redhat.com To: qemu-de...@nongnu.org

Re: [PATCH][RFC] qemu:virtio-net: Use TUNSETTXFILTER for MAC filteringlogin register about

2011-01-12 Thread Michael S. Tsirkin
. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- diff --git a/hw/virtio-net.c b/hw/virtio-net.c index 1d61f19..7892ca9 100644 --- a/hw/virtio-net.c +++ b/hw/virtio-net.c @@ -343,6 +343,15 @@ static int virtio_net_handle_mac(VirtIONet *n, uint8_t cmd, n-mac_table.multi_overflow = 1

Re: Flow Control and Port Mirroring Revisited

2011-01-13 Thread Michael S. Tsirkin
On Fri, Jan 14, 2011 at 08:41:36AM +0900, Simon Horman wrote: On Thu, Jan 13, 2011 at 10:45:38AM -0500, Jesse Gross wrote: On Thu, Jan 13, 2011 at 1:47 AM, Simon Horman ho...@verge.net.au wrote: On Mon, Jan 10, 2011 at 06:31:55PM +0900, Simon Horman wrote: On Fri, Jan 07, 2011 at

Re: Flow Control and Port Mirroring Revisited

2011-01-13 Thread Michael S. Tsirkin
On Fri, Jan 14, 2011 at 03:35:28PM +0900, Simon Horman wrote: On Fri, Jan 14, 2011 at 06:58:18AM +0200, Michael S. Tsirkin wrote: On Fri, Jan 14, 2011 at 08:41:36AM +0900, Simon Horman wrote: On Thu, Jan 13, 2011 at 10:45:38AM -0500, Jesse Gross wrote: On Thu, Jan 13, 2011 at 1:47 AM

[PULL] vhost-net: 2.6.38 fix

2011-01-14 Thread Michael S. Tsirkin
://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost-net Michael S. Tsirkin (1): vhost: fix signed/unsigned comparison drivers/vhost/vhost.c | 18 +++--- 1 files changed, 11 insertions(+), 7 deletions(-) -- To unsubscribe from this list: send the line unsubscribe kvm

Re: [PATCH 2/3] vhost-net: Unify the code of mergeable and big buffer handling

2011-01-17 Thread Michael S. Tsirkin
On Mon, Jan 17, 2011 at 04:11:08PM +0800, Jason Wang wrote: Codes duplication were found between the handling of mergeable and big buffers, so this patch tries to unify them. This could be easily done by adding a quota to the get_rx_bufs() which is used to limit the number of buffers it

Re: [PATCH 1/3] vhost-net: check the support of mergeable buffer outside the receive loop

2011-01-17 Thread Michael S. Tsirkin
On Mon, Jan 17, 2011 at 04:10:59PM +0800, Jason Wang wrote: No need to check the support of mergeable buffer inside the recevie loop as the whole handle_rx()_xx is in the read critical region. So this patch move it ahead of the receiving loop. Signed-off-by: Jason Wang jasow...@redhat.com

Re: [PATCH 3/3] vhost-net: use lock_sock_fast() in peek_head_len()

2011-01-17 Thread Michael S. Tsirkin
On Mon, Jan 17, 2011 at 04:11:17PM +0800, Jason Wang wrote: We can use lock_sock_fast() instead of lock_sock() in order to get speedup in peek_head_len(). Signed-off-by: Jason Wang jasow...@redhat.com Queued for 2.6.39, thanks everyone. --- drivers/vhost/net.c |4 ++-- 1 files

Re: Flow Control and Port Mirroring Revisited

2011-01-17 Thread Michael S. Tsirkin
On Mon, Jan 17, 2011 at 07:37:30AM +0900, Simon Horman wrote: On Fri, Jan 14, 2011 at 08:54:15AM +0200, Michael S. Tsirkin wrote: On Fri, Jan 14, 2011 at 03:35:28PM +0900, Simon Horman wrote: On Fri, Jan 14, 2011 at 06:58:18AM +0200, Michael S. Tsirkin wrote: On Fri, Jan 14, 2011 at 08

Re: Flow Control and Port Mirroring Revisited

2011-01-17 Thread Michael S. Tsirkin
On Mon, Jan 17, 2011 at 10:26:25AM +1030, Rusty Russell wrote: On Mon, 17 Jan 2011 09:07:30 am Simon Horman wrote: [snip] I've been away, but what concerns me is that socket buffer limits are bypassed in various configurations, due to skb cloning. We should probably drop such limits

Re: [PATCH 2/3] KVM: Emulate MSI-X table in kernel

2011-01-17 Thread Michael S. Tsirkin
On Mon, Jan 17, 2011 at 02:29:44PM +0200, Avi Kivity wrote: On 01/06/2011 12:19 PM, Sheng Yang wrote: Then we can support mask bit operation of assigned devices now. +int kvm_assigned_device_update_msix_mask_bit(struct kvm *kvm, +int assigned_dev_id, int

Re: [PATCH 1/3] vhost-net: check the support of mergeable buffer outside the receive loop

2011-01-17 Thread Michael S. Tsirkin
On Tue, Jan 18, 2011 at 12:26:17PM +0800, Jason Wang wrote: Michael S. Tsirkin writes: On Mon, Jan 17, 2011 at 04:10:59PM +0800, Jason Wang wrote: No need to check the support of mergeable buffer inside the recevie loop as the whole handle_rx()_xx is in the read critical region. So

Re: [PATCH 2/3] vhost-net: Unify the code of mergeable and big buffer handling

2011-01-17 Thread Michael S. Tsirkin
On Tue, Jan 18, 2011 at 11:05:33AM +0800, Jason Wang wrote: Michael S. Tsirkin writes: On Mon, Jan 17, 2011 at 04:11:08PM +0800, Jason Wang wrote: Codes duplication were found between the handling of mergeable and big buffers, so this patch tries to unify them. This could be easily

[PATCH] vhost: rcu annotation fixup

2011-01-18 Thread Michael S. Tsirkin
-by: Michael S. Tsirkin m...@redhat.com --- drivers/vhost/vhost.h |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/vhost/vhost.h b/drivers/vhost/vhost.h index 2af44b7..2d03a31 100644 --- a/drivers/vhost/vhost.h +++ b/drivers/vhost/vhost.h @@ -173,9 +173,7 @@ static

[PATCH] virtio-pci: mask notifier error handling fixups

2011-01-18 Thread Michael S. Tsirkin
Fix virtio-pci error handling in the mask notifiers: be careful to undo exactly what we did so far. Reported-by: Alex Williamson alex.william...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- This is for qemu-kvm only. hw/virtio-pci.c | 12 1 files changed, 12

Re: [RFC PATCH 00/17] virtual-bus

2009-04-02 Thread Michael S. Tsirkin
On Thu, Apr 02, 2009 at 10:43:19PM +1030, Rusty Russell wrote: On Thursday 02 April 2009 21:36:07 Gregory Haskins wrote: You do not need to know when the packet is copied (which I currently do). You only need it for zero-copy (of which I would like to support, but as I understand it there

[PATCH] qemu-kvm: configure script fixups after qemu-kvm reorg

2009-04-26 Thread Michael S. Tsirkin
Make kvm configure script and Makefile work again after things have been moved around, so that you can do 'cd kvm ./configure' to get a kvm-enabled qemu. Also, guard against infinite recursion in case of 'cd' commands failing. Signed-off-by: Michael S. Tsirkin m...@redhat.com -- On Thu, Apr

Re: [PATCH] qemu-kvm: configure script fixups after qemu-kvm reorg

2009-04-26 Thread Michael S. Tsirkin
On Sun, Apr 26, 2009 at 10:48:20AM +0300, Gleb Natapov wrote: On Sun, Apr 26, 2009 at 10:38:39AM +0300, Michael S. Tsirkin wrote: Make kvm configure script and Makefile work again after things have been moved around, so that you can do 'cd kvm ./configure' to get a kvm-enabled qemu

Re: [PATCH] qemu-kvm: configure script fixups after qemu-kvm reorg

2009-04-26 Thread Michael S. Tsirkin
Also for me running ./configure --kerneldir=/path/to/kernel at top dir works. (/path/to/kernel should be absolute though, otherwise kernel include path is incorrect). Ah, I didn't realise kvm/cofigure is obsolete. -- To unsubscribe from this list: send the line unsubscribe kvm in the body

[PATCH] thinko fix: move memset to after mmap failure check

2009-04-26 Thread Michael S. Tsirkin
By the time we've done a memset, it's too late to check the pointer for MAP_FAILED value. Let's compare to MAP_FAILED first. Signed-off-by: Michael S. Tsikirn m...@redhat.com --- Noticed this when reading the code. Makes sense, does it not? hw/device-assignment.c |2 +- 1 files changed, 1

[PATCH] qemu-kvm: make clean should propagate into libkvm directory

2009-04-27 Thread Michael S. Tsirkin
make 'clean' target propage into libkvm if it's enabled Signed-off-by: Michael S. Tsirkin m...@redhat.com --- Makefile.target |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/Makefile.target b/Makefile.target index d890220..28dce60 100644 --- a/Makefile.target +++ b

[PATCH] qemu-kvm: fix compiler warning

2009-04-27 Thread Michael S. Tsirkin
kvm-common.h:25:7: warning: __ia64__ is not defined Signed-off-by: Michael S. Tsirkin m...@redhat.com --- kvm/libkvm/kvm-common.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/kvm/libkvm/kvm-common.h b/kvm/libkvm/kvm-common.h index 96361e8..591fb53 100644 --- a/kvm

[PATCH] qemu-kvm: make kvm_create_pit static

2009-04-27 Thread Michael S. Tsirkin
libkvm-x86.c:55: warning: no previous prototype for ‘kvm_create_pit’ Signed-off-by: Michael S. Tsirkin m...@redhat.com --- kvm/libkvm/libkvm-x86.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/kvm/libkvm/libkvm-x86.c b/kvm/libkvm/libkvm-x86.c index 2fc4fce..df8cc81

[PATCH RFC 0/8] virtio: add guest MSI-X support

2009-04-27 Thread Michael S. Tsirkin
. Tsirkin m...@redhat.com --- Here's a draft set of patches for MSI-X support in the guest. It still needs to be tested properly, and performance impact measured, but I thought I'd share it here in the hope of getting some very early feedback/flames. Michael S. Tsirkin (8): virtio: add request_vqs

[PATCH 1/8] virtio: add request_vqs/free_vqs operations

2009-04-27 Thread Michael S. Tsirkin
This adds 2 new optional virtio operations: request_vqs/free_vqs. They will be used for MSI support, because MSI needs to know the total number of vectors upfront. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/linux/virtio_config.h | 35 +++ 1

[PATCH 2/8] virtio_blk: add request_vqs/free_vqs calls

2009-04-27 Thread Michael S. Tsirkin
Add request_vqs/free_vqs calls to virtio_blk. These will be required for MSI support. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- drivers/block/virtio_blk.c |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/drivers/block/virtio_blk.c b/drivers/block

[PATCH 3/8] virtio-rng: add request_vqs/free_vqs calls

2009-04-27 Thread Michael S. Tsirkin
Add request_vqs/free_vqs calls to virtio-rng. These will be required for MSI support. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- drivers/char/hw_random/virtio-rng.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/drivers/char/hw_random/virtio-rng.c b

[PATCH 7/8] virtio_pci: split up vp_interrupt

2009-04-27 Thread Michael S. Tsirkin
This reorganizes virtio-pci code in vp_interrupt slightly, so that it's easier to add per-vq MSI support on top. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- drivers/virtio/virtio_pci.c | 45 +- 1 files changed, 35 insertions(+), 10 deletions

[PATCH 8/8] virtio_pci: optional MSI-X support

2009-04-27 Thread Michael S. Tsirkin
This implements optional MSI-X support in virtio_pci. MSI-X is used whenever the host supports at least 2 MSI-X vectors: 1 for configuration changes and 1 for virtqueues. Per-virtqueue vectors are allocated if enough vectors available. Signed-off-by: Michael S. Tsirkin m...@redhat.com

[PATCH 5/8] virtio_net: add request_vqs/free_vqs calls

2009-04-27 Thread Michael S. Tsirkin
Add request_vqs/free_vqs calls to virtio_net. These will be required for MSI support. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- drivers/net/virtio_net.c | 16 +--- 1 files changed, 13 insertions(+), 3 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net

qemu/hw/device-assignment: questions about msix_table_page

2009-04-27 Thread Michael S. Tsirkin
Sheng, Marcelo, I've been reading code in qemu/hw/device-assignment.c, and I have a couple of questions about msi-x implementation: 1. What is the reason that msix_table_page is allocated with mmap and not with e.g. malloc? 2. msix_table_page has the guest view of the msix table for the device.

Re: qemu/hw/device-assignment: questions about msix_table_page

2009-04-27 Thread Michael S. Tsirkin
On Mon, Apr 27, 2009 at 09:16:14PM +0800, Sheng Yang wrote: On Monday 27 April 2009 18:41:17 Michael S. Tsirkin wrote: Sheng, Marcelo, I've been reading code in qemu/hw/device-assignment.c, and I have a couple of questions about msi-x implementation: Hi Michael 1. What is the reason

Re: qemu/hw/device-assignment: questions about msix_table_page

2009-04-27 Thread Michael S. Tsirkin
On Mon, Apr 27, 2009 at 10:03:59PM +0800, Sheng Yang wrote: On Monday 27 April 2009 21:51:34 Michael S. Tsirkin wrote: On Mon, Apr 27, 2009 at 09:16:14PM +0800, Sheng Yang wrote: On Monday 27 April 2009 18:41:17 Michael S. Tsirkin wrote: Sheng, Marcelo, I've been reading code in qemu

Re: [PATCH RFC 0/8] virtio: add guest MSI-X support

2009-04-27 Thread Michael S. Tsirkin
On Mon, Apr 27, 2009 at 04:00:30PM +0200, Christian Borntraeger wrote: Am Monday 27 April 2009 14:31:36 schrieb Michael S. Tsirkin: Add optional MSI-X support: use a vector per virtqueue with fallback to a common vector and finally to regular interrupt. Teach all drivers to use it. I

Re: qemu/hw/device-assignment: questions about msix_table_page

2009-04-27 Thread Michael S. Tsirkin
On Mon, Apr 27, 2009 at 10:30:17PM +0800, Sheng Yang wrote: My suggestion is get mask bit support first, then consider optimization. Yea. Thanks for the explanations! -- MST -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org

Re: [PATCH RFC 0/8] virtio: add guest MSI-X support

2009-04-27 Thread Michael S. Tsirkin
On Mon, Apr 27, 2009 at 06:06:48PM +0300, Avi Kivity wrote: Christian Borntraeger wrote: Am Monday 27 April 2009 14:31:36 schrieb Michael S. Tsirkin: Add optional MSI-X support: use a vector per virtqueue with fallback to a common vector and finally to regular interrupt. Teach all drivers

Re: [PATCH RFC 0/8] virtio: add guest MSI-X support

2009-04-27 Thread Michael S. Tsirkin
On Mon, Apr 27, 2009 at 05:37:25PM +0200, Christian Borntraeger wrote: As number of virtqueues = number of vectors, we could pre-allocate all vectors that host supports, but this seems a bit drastic as an MSI-X device could support up to 2K vectors. In fact, the transport has to have

Re: [PATCH RFC 0/8] virtio: add guest MSI-X support

2009-04-27 Thread Michael S. Tsirkin
On Mon, Apr 27, 2009 at 06:59:52PM +0200, Christian Borntraeger wrote: Am Monday 27 April 2009 17:39:36 schrieb Michael S. Tsirkin: So we'll probably need to rename request_vqs to request_vectors, but we probably still need the driver to pass the number of vectors it wants to the transport

Re: [PATCH RFC 0/8] virtio: add guest MSI-X support

2009-04-27 Thread Michael S. Tsirkin
On Mon, Apr 27, 2009 at 09:39:06AM -0500, Anthony Liguori wrote: Michael S. Tsirkin wrote: Add optional MSI-X support: use a vector per virtqueue with fallback to a common vector and finally to regular interrupt. Teach all drivers to use it. I added 2 new virtio operations: request_vqs

[no subject]

2009-04-28 Thread Michael S. Tsirkin
From 5858c329a426dc1450bad038e7506b17faa4910c Mon Sep 17 00:00:00 2001 From: Michael S. Tsirkin m...@redhat.com Date: Tue, 28 Apr 2009 12:07:35 +0300 Subject: [PATCH] kvm-kmod: create include directory include directory is not in git, so configure must create it before creating include/asm link

Re: kvm-kmod.git

2009-04-28 Thread Michael S. Tsirkin
On Mon, Apr 27, 2009 at 03:32:29PM +0300, Avi Kivity wrote: This is a small git repository for the kvm external module kit. So, I am building on a host with CONFIG_KVM_TRACE set in its kernel, but I run configure without enabling kvm trace. As a result the module fails to link: WARNING:

[PATCH] kvm-kmod: create include directory

2009-04-28 Thread Michael S. Tsirkin
include directory is not in git, so configure must create it before creating include/asm link Signed-off-by: Michael S. Tsirkin m...@redhat.com --- resending with a sane subject, sorry about multiple messages. configure |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git

<    5   6   7   8   9   10   11   12   13   14   >