Re: [Qemu-devel] How to reserve guest physical region for ACPI

On Tue, 5 Jan 2016 18:43:02 +0200 "Michael S. Tsirkin" <m...@redhat.com> wrote: > On Tue, Jan 05, 2016 at 05:30:25PM +0100, Igor Mammedov wrote: > > > > bios-linker-loader is a great interface for initializing some > > > > guest owned data

Re: [PATCH 5/6] nvdimm acpi: let qemu handle _DSM method

On Tue, 5 Jan 2016 02:52:07 +0800 Xiao Guangrong wrote: > If dsm memory is successfully patched, we let qemu fully emulate > the dsm method > > This patch saves _DSM input parameters into dsm memory, tell dsm > memory address to QEMU, then fetch the result from

Re: How to reserve guest physical region for ACPI

2015 at 04:55:54PM +0100, Igor Mammedov wrote: > >> On Mon, 28 Dec 2015 14:50:15 +0200 > >> "Michael S. Tsirkin" <m...@redhat.com> wrote: > >> > >>> On Mon, Dec 28, 2015 at 10:39:04AM +0800, Xiao Guangrong wrote: > >>>>

Re: [Qemu-devel] [PATCH 0/6] NVDIMM ACPI: introduce the framework of QEMU emulated DSM

cted-aml.sh to make it 5. if make check by some miracle passes with these patches, dump NVDIMM table in guest and try to decompile and then compile it back with IASL, it will show you what needs to be fixed. PS: under NVDIMM table I mean SSDT NVMDIM table. > Igor Mammedov (1): > pc:

Re: How to reserve guest physical region for ACPI

On Tue, 5 Jan 2016 18:22:33 +0100 Laszlo Ersek <ler...@redhat.com> wrote: > On 01/05/16 18:08, Igor Mammedov wrote: > > On Mon, 4 Jan 2016 21:17:31 +0100 > > Laszlo Ersek <ler...@redhat.com> wrote: > > > >> Michael CC'd me on the grandparent of the ema

Re: [PATCH 3/6] nvdimm acpi: introduce patched dsm memory

On Tue, 5 Jan 2016 02:52:05 +0800 Xiao Guangrong wrote: > The dsm memory is used to save the input parameters and store > the dsm result which is filled by QEMU. > > The address of dsm memory is decided by bios and patched into > int64 object returned by "MEMA"

Re: How to reserve guest physical region for ACPI

On Wed, 30 Dec 2015 21:52:32 +0200 "Michael S. Tsirkin" <m...@redhat.com> wrote: > On Wed, Dec 30, 2015 at 04:55:54PM +0100, Igor Mammedov wrote: > > On Mon, 28 Dec 2015 14:50:15 +0200 > > "Michael S. Tsirkin" <m...@redhat.com> wrote: > >

Re: How to reserve guest physical region for ACPI

2015 at 04:55:54PM +0100, Igor Mammedov wrote: > >> On Mon, 28 Dec 2015 14:50:15 +0200 > >> "Michael S. Tsirkin" <m...@redhat.com> wrote: > >> > >>> On Mon, Dec 28, 2015 at 10:39:04AM +0800, Xiao Guangrong wrote: > >>>>

Re: How to reserve guest physical region for ACPI

On Mon, 28 Dec 2015 14:50:15 +0200 "Michael S. Tsirkin" wrote: > On Mon, Dec 28, 2015 at 10:39:04AM +0800, Xiao Guangrong wrote: > > > > Hi Michael, Paolo, > > > > Now it is the time to return to the challenge that how to reserve guest > > physical region internally used by

Re: [PATCH v6 05/33] acpi: add aml_object_type

On Mon, 9 Nov 2015 13:35:51 +0200 "Michael S. Tsirkin" wrote: > On Fri, Oct 30, 2015 at 01:55:59PM +0800, Xiao Guangrong wrote: > > Implement ObjectType which is used by NVDIMM _DSM method in > > later patch > > > > Signed-off-by: Xiao Guangrong

Re: [Qemu-devel] [PATCH v7 25/35] nvdimm acpi: init the resource used by NVDIMM ACPI

On Fri, 6 Nov 2015 16:31:43 +0800 Xiao Guangrong <guangrong.x...@linux.intel.com> wrote: > > > On 11/05/2015 10:49 PM, Igor Mammedov wrote: > > On Thu, 5 Nov 2015 21:33:39 +0800 > > Xiao Guangrong <guangrong.x...@linux.intel.com> wrote: > > > >>

Re: [PATCH v7 25/35] nvdimm acpi: init the resource used by NVDIMM ACPI

On Mon, 2 Nov 2015 17:13:27 +0800 Xiao Guangrong wrote: > A page staring from 0xFF0 and IO port 0x0a18 - 0xa1b in guest are ^^ missing one 0??? > reserved for NVDIMM ACPI emulation, refer to docs/specs/acpi_nvdimm.txt > for

Re: [PATCH v7 25/35] nvdimm acpi: init the resource used by NVDIMM ACPI

On Thu, 5 Nov 2015 18:15:31 +0800 Xiao Guangrong <guangrong.x...@linux.intel.com> wrote: > > > On 11/05/2015 05:58 PM, Igor Mammedov wrote: > > On Mon, 2 Nov 2015 17:13:27 +0800 > > Xiao Guangrong <guangrong.x...@linux.intel.com> wrote: > > > >>

Re: [PATCH v7 25/35] nvdimm acpi: init the resource used by NVDIMM ACPI

On Thu, 5 Nov 2015 21:33:39 +0800 Xiao Guangrong <guangrong.x...@linux.intel.com> wrote: > > > On 11/05/2015 09:03 PM, Igor Mammedov wrote: > > On Thu, 5 Nov 2015 18:15:31 +0800 > > Xiao Guangrong <guangrong.x...@linux.intel.com> wrote: > > > >>

Re: [PATCH v7 27/35] nvdimm acpi: build ACPI nvdimm devices

On Tue, 3 Nov 2015 22:22:40 +0800 Xiao Guangrong <guangrong.x...@linux.intel.com> wrote: > > > On 11/03/2015 09:13 PM, Igor Mammedov wrote: > > On Mon, 2 Nov 2015 17:13:29 +0800 > > Xiao Guangrong <guangrong.x...@linux.intel.com> wrote: > > > >

Re: [PATCH v7 27/35] nvdimm acpi: build ACPI nvdimm devices

On Mon, 2 Nov 2015 17:13:29 +0800 Xiao Guangrong wrote: > NVDIMM devices is defined in ACPI 6.0 9.20 NVDIMM Devices > > There is a root device under \_SB and specified NVDIMM devices are under the > root device. Each NVDIMM device has _ADR which returns its

Re: [PATCH v7 09/35] exec: allow file_ram_alloc to work on file

On Mon, 2 Nov 2015 17:13:11 +0800 Xiao Guangrong wrote: > Currently, file_ram_alloc() only works on directory - it creates a file > under @path and do mmap on it > > This patch tries to allow it to work on file directly, if @path is a > directory it works as

Re: [Qemu-devel] [PATCH v7 06/35] acpi: add aml_method_serialized

On Mon, 2 Nov 2015 17:13:08 +0800 Xiao Guangrong wrote: > It avoid explicit Mutex and will be used by NVDIMM ACPI > > Signed-off-by: Xiao Guangrong > --- > hw/acpi/aml-build.c | 26 -- >

Re: [PATCH v4 28/33] nvdimm acpi: support DSM_FUN_IMPLEMENTED function

On Wed, 21 Oct 2015 21:32:38 +0800 Xiao Guangrong wrote: > > > On 10/21/2015 06:49 PM, Stefan Hajnoczi wrote: > > On Wed, Oct 21, 2015 at 12:26:35AM +0800, Xiao Guangrong wrote: > >> > >> > >> On 10/20/2015 11:51 PM, Stefan Hajnoczi wrote: > >>> On Mon, Oct 19,

Re: [PATCH v3 22/32] nvdimm: init the address region used by NVDIMM ACPI

On Mon, 19 Oct 2015 09:56:12 +0300 "Michael S. Tsirkin" wrote: > On Sun, Oct 11, 2015 at 11:52:54AM +0800, Xiao Guangrong wrote: [...] > > diff --git a/include/hw/mem/nvdimm.h b/include/hw/mem/nvdimm.h > > index f6bd2c4..aa95961 100644 > > --- a/include/hw/mem/nvdimm.h > > +++

Re: [PATCH v3 22/32] nvdimm: init the address region used by NVDIMM ACPI

On Mon, 19 Oct 2015 12:17:22 +0300 "Michael S. Tsirkin" wrote: > On Mon, Oct 19, 2015 at 03:44:13PM +0800, Xiao Guangrong wrote: > > > > > > On 10/19/2015 03:39 PM, Michael S. Tsirkin wrote: > > >On Mon, Oct 19, 2015 at 03:27:21PM +0800, Xiao Guangrong wrote: > > +

Re: [Qemu-devel] [PATCH v3 22/32] nvdimm: init the address region used by NVDIMM ACPI

On Mon, 19 Oct 2015 18:01:17 +0800 Xiao Guangrong <guangrong.x...@linux.intel.com> wrote: > > > On 10/19/2015 05:46 PM, Igor Mammedov wrote: > > On Mon, 19 Oct 2015 12:17:22 +0300 > > "Michael S. Tsirkin" <m...@redhat.com> wrote: > > > >>

Re: [Qemu-devel] [RESEND PATCH] kvm: Allow the Hyper-V vendor ID to be specified

On Fri, 16 Oct 2015 08:26:14 -0600 Alex Williamson wrote: > On Fri, 2015-10-16 at 09:30 +0200, Paolo Bonzini wrote: > > > > On 16/10/2015 00:16, Alex Williamson wrote: > > > According to Microsoft documentation, the signature in the standard > > > hypervisor CPUID

Re: [PATCH v3 04/32] acpi: add aml_mutex, aml_acquire, aml_release

On Sun, 11 Oct 2015 11:52:36 +0800 Xiao Guangrong wrote: > Implement Mutex, Acquire and Release terms which are used by NVDIMM _DSM > method > in later patch > > Signed-off-by: Xiao Guangrong > --- > hw/acpi/aml-build.c

Re: [PATCH v3 02/32] acpi: add aml_sizeof

On Sun, 11 Oct 2015 11:52:34 +0800 Xiao Guangrong <guangrong.x...@linux.intel.com> wrote: > Implement SizeOf term which is used by NVDIMM _DSM method in later patch > > Signed-off-by: Xiao Guangrong <guangrong.x...@linux.intel.com> Reviewed-by: Igor Mammedov <imamm...@

Re: [PATCH v3 03/32] acpi: add aml_create_field

On Sun, 11 Oct 2015 11:52:35 +0800 Xiao Guangrong wrote: > Implement CreateField term which is used by NVDIMM _DSM method in later patch > > Signed-off-by: Xiao Guangrong > --- > hw/acpi/aml-build.c | 13 + >

Re: [PATCH v3 01/32] acpi: add aml_derefof

On Sun, 11 Oct 2015 11:52:33 +0800 Xiao Guangrong <guangrong.x...@linux.intel.com> wrote: > Implement DeRefOf term which is used by NVDIMM _DSM method in later patch > > Signed-off-by: Xiao Guangrong <guangrong.x...@linux.intel.com> Reviewed-by: Igor Mammedov <imamm...@

Re: [Qemu-devel] [PATCH v3 25/32] nvdimm: build ACPI nvdimm devices

On Sun, 11 Oct 2015 11:52:57 +0800 Xiao Guangrong wrote: > NVDIMM devices is defined in ACPI 6.0 9.20 NVDIMM Devices > > There is a root device under \_SB and specified NVDIMM devices are under the > root device. Each NVDIMM device has _ADR which returns its

Re: [PATCH v3 00/32] implement vNVDIMM

On Mon, 12 Oct 2015 11:06:20 +0800 Xiao Guangrong wrote: > > > On 10/12/2015 10:59 AM, Bharata B Rao wrote: > > Xiao, > > > > Are these patches present in any git tree so that they can be easily tried > > out. > > > > Sorry, currently no git tree out of my

[PATCH] kvm: svm: reset mmu on VCPU reset

b() time. -- * AMD64 Architecture Programmer’s Manual, Volume 2: System Programming, rev: 3.25 15.19 Paged Real Mode ** Opteron 1216 Signed-off-by: Igor Mammedov <imamm...@redhat.com> --- arch/x86/kvm/svm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/kvm/svm.c b/arch/x86

Re: [PATCH v2 08/18] nvdimm: init backend memory mapping and config data area

On Thu, 17 Sep 2015 16:39:12 +0800 Xiao Guangrong wrote: > > > On 09/16/2015 12:10 AM, Paolo Bonzini wrote: > > > > > > On 01/09/2015 11:14, Stefan Hajnoczi wrote: > > When I was digging into live migration code, i noticed that the same MR > name

Re: [PATCH v2 09/18] nvdimm: build ACPI NFIT table

On Tue, 15 Sep 2015 18:12:43 +0200 Paolo Bonzini wrote: > > > On 14/08/2015 16:52, Xiao Guangrong wrote: > > NFIT is defined in ACPI 6.0: 5.2.25 NVDIMM Firmware Interface Table (NFIT) > > > > Currently, we only support PMEM mode. Each device has 3 tables: > > - SPA table,

Re: [Qemu-devel] [PATCH v2 08/18] nvdimm: init backend memory mapping and config data area

On Tue, 8 Sep 2015 21:38:17 +0800 Xiao Guangrong <guangrong.x...@linux.intel.com> wrote: > > > On 09/07/2015 10:11 PM, Igor Mammedov wrote: > > On Fri, 14 Aug 2015 22:52:01 +0800 > > Xiao Guangrong <guangrong.x...@linux.intel.com> wrote: > > > >&

Re: [Qemu-devel] [PATCH v2 06/18] pc: implement NVDIMM device abstract

On Tue, 8 Sep 2015 22:03:01 +0800 Xiao Guangrong <guangrong.x...@linux.intel.com> wrote: > > > On 09/07/2015 09:40 PM, Igor Mammedov wrote: > > On Sun, 6 Sep 2015 14:07:21 +0800 > > Xiao Guangrong <guangrong.x...@linux.intel.com> wrote: > > > >>

Re: [Qemu-devel] [PATCH v2 06/18] pc: implement NVDIMM device abstract

On Sun, 6 Sep 2015 14:07:21 +0800 Xiao Guangrong <guangrong.x...@linux.intel.com> wrote: > > > On 09/02/2015 07:31 PM, Igor Mammedov wrote: > > On Wed, 2 Sep 2015 18:36:43 +0800 > > Xiao Guangrong <guangrong.x...@linux.intel.com> wrote: > > > >>

Re: [Qemu-ppc] KVM memory slots limit on powerpc

On Fri, 4 Sep 2015 12:04:41 +0200 Alexander Graf wrote: > > > On 04.09.15 11:59, Christian Borntraeger wrote: > > Am 04.09.2015 um 11:35 schrieb Thomas Huth: > >> > >> Hi all, > >> > >> now that we get memory hotplugging for the spapr machine on qemu-ppc, > >> too, it seems

Re: [Qemu-devel] [PATCH v2 08/18] nvdimm: init backend memory mapping and config data area

On Fri, 14 Aug 2015 22:52:01 +0800 Xiao Guangrong wrote: > The parameter @file is used as backed memory for NVDIMM which is > divided into two parts if @dataconfig is true: > - first parts is (0, size - 128K], which is used as PMEM (Persistent > Memory) > - 128K

Re: [Qemu-devel] [PATCH v2 07/18] nvdimm: reserve address range for NVDIMM

On Fri, 14 Aug 2015 22:52:00 +0800 Xiao Guangrong wrote: > NVDIMM reserves all the free range above 4G to do: > - Persistent Memory (PMEM) mapping > - implement NVDIMM ACPI device _DSM method > > Signed-off-by: Xiao Guangrong >

Re: [PATCH v2 01/18] acpi: allow aml_operation_region() working on 64 bit offset

.x...@linux.intel.com> Reviewed-by: Igor Mammedov <imamm...@redhat.com> > --- > hw/acpi/aml-build.c | 2 +- > include/hw/acpi/aml-build.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c >

Re: [Qemu-devel] [PATCH v2 06/18] pc: implement NVDIMM device abstract

On Wed, 2 Sep 2015 18:36:43 +0800 Xiao Guangrong <guangrong.x...@linux.intel.com> wrote: > > > On 09/02/2015 05:58 PM, Igor Mammedov wrote: > > On Fri, 14 Aug 2015 22:51:59 +0800 > > Xiao Guangrong <guangrong.x...@linux.intel.com> wrote: > > > >

Re: [PATCH v2 05/18] acpi: add aml_create_field

On Fri, 14 Aug 2015 22:51:58 +0800 Xiao Guangrong wrote: > Implement CreateField term which are used by NVDIMM _DSM method in later patch > > Signed-off-by: Xiao Guangrong > --- > hw/acpi/aml-build.c | 14 ++ >

Re: [Qemu-devel] [PATCH v2 02/18] i386/acpi-build: allow SSDT to operate on 64 bit

On Wed, 2 Sep 2015 18:43:41 +0800 Xiao Guangrong <guangrong.x...@linux.intel.com> wrote: > > > On 09/02/2015 06:06 PM, Igor Mammedov wrote: > > On Fri, 14 Aug 2015 22:51:55 +0800 > > Xiao Guangrong <guangrong.x...@linux.intel.com> wrote: > > &

Re: [PATCH v2 02/18] i386/acpi-build: allow SSDT to operate on 64 bit

On Fri, 14 Aug 2015 22:51:55 +0800 Xiao Guangrong wrote: > Only 512M is left for MMIO below 4G and that are used by PCI, BIOS etc. > Other components also reserve regions from their internal usage, e.g, > [0xFED0, 0xFED0 + 0x400) is reserved for HPET > >

Re: [PATCH v2 03/18] acpi: add aml_derefof

On Fri, 14 Aug 2015 22:51:56 +0800 Xiao Guangrong wrote: > Implement DeRefOf term which is used by NVDIMM _DSM method in later patch > > Signed-off-by: Xiao Guangrong > --- > hw/acpi/aml-build.c | 8 >

Re: [Qemu-devel] [PATCH v2 06/18] pc: implement NVDIMM device abstract

On Fri, 14 Aug 2015 22:51:59 +0800 Xiao Guangrong wrote: > Introduce "pc-nvdimm" device and it has two parameters: Why do you use prefix "pc-", I suppose we potentially could use this device not only with x86 targets but with other targets as well. I'd just drop

Re: [PATCH v2 04/18] acpi: add aml_sizeof

On Fri, 14 Aug 2015 22:51:57 +0800 Xiao Guangrong wrote: > Implement SizeOf term which is used by NVDIMM _DSM method in later patch > > Signed-off-by: Xiao Guangrong > --- > hw/acpi/aml-build.c | 8 >

Re: [PATCH 2/2] vhost: increase default limit of nregions from 64 to 509

On Thu, 30 Jul 2015 09:33:57 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Thu, Jul 30, 2015 at 08:26:03AM +0200, Igor Mammedov wrote: On Wed, 29 Jul 2015 18:28:26 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Wed, Jul 29, 2015 at 04:29:23PM +0200, Igor Mammedov wrote

Re: [PATCH 2/2] vhost: increase default limit of nregions from 64 to 509

On Thu, 30 Jul 2015 09:33:57 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Thu, Jul 30, 2015 at 08:26:03AM +0200, Igor Mammedov wrote: On Wed, 29 Jul 2015 18:28:26 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Wed, Jul 29, 2015 at 04:29:23PM +0200, Igor Mammedov wrote

Re: [PATCH 2/2] vhost: increase default limit of nregions from 64 to 509

On Wed, 29 Jul 2015 18:28:26 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Wed, Jul 29, 2015 at 04:29:23PM +0200, Igor Mammedov wrote: although now there is vhost module max_mem_regions option to set custom limit it doesn't help for default setups, since it requires administrator

Re: [PATCH 1/2] vhost: add ioctl to query nregions upper limit

On Wed, 29 Jul 2015 17:43:17 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Wed, Jul 29, 2015 at 04:29:22PM +0200, Igor Mammedov wrote: From: Michael S. Tsirkin m...@redhat.com Userspace currently simply tries to give vhost as many regions as it happens to have, but you only have

[PATCH 0/2] vhost: add ioctl to query nregions limit and rise default limit

Igor Mammedov (1): vhost: increase default limit of nregions from 64 to 509 Michael S. Tsirkin (1): vhost: add ioctl to query nregions upper limit drivers/vhost/vhost.c | 7 ++- include/uapi/linux/vhost.h | 17 - 2 files changed, 22 insertions(+), 2 deletions

[PATCH 1/2] vhost: add ioctl to query nregions upper limit

left unused, let's make that mean that the current userspace behaviour (trial and error) is required, just in case we want it back. Signed-off-by: Michael S. Tsirkin m...@redhat.com Signed-off-by: Igor Mammedov imamm...@redhat.com --- drivers/vhost/vhost.c | 7 ++- include/uapi/linux

[PATCH 2/2] vhost: increase default limit of nregions from 64 to 509

), so that default deployments would work out of box. Signed-off-by: Igor Mammedov imamm...@redhat.com --- PS: Users that would want to lock down vhost could still use max_mem_regions option to set lower limit, but I expect it would be minority. --- include/uapi/linux/vhost.h | 2 +- 1 file changed

Re: [PATCH v4 2/2] vhost: add max_mem_regions module parameter

On Thu, 2 Jul 2015 15:08:11 +0200 Igor Mammedov imamm...@redhat.com wrote: it became possible to use a bigger amount of memory slots, which is used by memory hotplug for registering hotplugged memory. However QEMU crashes if it's used with more than ~60 pc-dimm devices and vhost-net enabled

[PATCH] fixup! vhost: extend memory regions allocation to vmalloc

-by: Dan Carpenter dan.carpen...@oracle.com Suggested-by: Julia Lawall julia.law...@lip6.fr Signed-off-by: Igor Mammedov imamm...@redhat.com --- drivers/vhost/vhost.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c index a9fe859

Re: [Qemu-devel] [PATCH] target-i386: Sanity check host processor physical address width

On Thu, 09 Jul 2015 09:02:38 +0200 Laszlo Ersek ler...@redhat.com wrote: On 07/09/15 00:42, Bandan Das wrote: If a Linux guest is assigned more memory than is supported by the host processor, the guest is unable to boot. That is expected, however, there's no message indicating the user

Re: [Qemu-devel] [PATCH] target-i386: Sanity check host processor physical address width

On Wed, 08 Jul 2015 18:42:01 -0400 Bandan Das b...@redhat.com wrote: If a Linux guest is assigned more memory than is supported by the host processor, the guest is unable to boot. That is expected, however, there's no message indicating the user what went wrong. This change prints a message

Re: [PATCH v4 0/2] vhost: support more than 64 memory regions

On Thu, 2 Jul 2015 15:08:09 +0200 Igor Mammedov imamm...@redhat.com wrote: changes since v3: * rebased on top of vhost-next branch changes since v2: * drop cache patches for now as suggested * add max_mem_regions module parameter instead of unconditionally increasing limit

Re: [Qemu-devel] [BUG/RFC] Two cpus are not brought up normally in SLES11 sp3 VM after reboot

On Tue, 7 Jul 2015 19:43:35 +0800 zhanghailiang zhang.zhanghaili...@huawei.com wrote: On 2015/7/7 19:23, Igor Mammedov wrote: On Mon, 6 Jul 2015 17:59:10 +0800 zhanghailiang zhang.zhanghaili...@huawei.com wrote: On 2015/7/6 16:45, Paolo Bonzini wrote: On 06/07/2015 09:54

Re: [BUG/RFC] Two cpus are not brought up normally in SLES11 sp3 VM after reboot

On Mon, 6 Jul 2015 17:59:10 +0800 zhanghailiang zhang.zhanghaili...@huawei.com wrote: On 2015/7/6 16:45, Paolo Bonzini wrote: On 06/07/2015 09:54, zhanghailiang wrote: From host, we found that QEMU vcpu1 thread and vcpu7 thread were not consuming any cpu (Should be in idle state),

[PATCH v4 2/2] vhost: add max_mem_regions module parameter

regions. Allow to tweak limit via max_mem_regions module paramemter with default value set to 64 slots. Signed-off-by: Igor Mammedov imamm...@redhat.com --- drivers/vhost/vhost.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c

[PATCH v4 1/2] vhost: extend memory regions allocation to vmalloc

could use large amount of memory regions. Signed-off-by: Igor Mammedov imamm...@redhat.com --- drivers/vhost/vhost.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c index 71bb468..6488011 100644 --- a/drivers

[PATCH v4 0/2] vhost: support more than 64 memory regions

in default QEMU configuration. Igor Mammedov (2): vhost: extend memory regions allocation to vmalloc vhost: add max_mem_regions module parameter drivers/vhost/vhost.c | 28 ++-- 1 file changed, 22 insertions(+), 6 deletions(-) -- 1.8.3.1 -- To unsubscribe from this list

[PATCH v3 1/2] vhost: extend memory regions allocation to vmalloc

could use large amount of memory regions. Signed-off-by: Igor Mammedov imamm...@redhat.com --- drivers/vhost/vhost.c | 22 +- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c index f1e07b8..99931a0 100644

[PATCH v3 2/2] vhost: add max_mem_regions module parameter

regions. Allow to tweak limit via max_mem_regions module paramemter with default value set to 64 slots. Signed-off-by: Igor Mammedov imamm...@redhat.com --- drivers/vhost/vhost.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c

[PATCH v3 0/2] vhost: support more than 64 memory regions

://www.spinics.net/lists/kvm/msg117654.html Series allows to tweak vhost's memory regions count limit. It fixes VM crashing on memory hotplug due to vhost refusing accepting more than 64 memory regions with max_mem_regions set to more than 262 slots in default QEMU configuration. Igor Mammedov (2): vhost

Re: [PATCH RFC] vhost: add ioctl to query nregions upper limit

On Wed, 24 Jun 2015 17:08:56 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Wed, Jun 24, 2015 at 04:52:29PM +0200, Igor Mammedov wrote: On Wed, 24 Jun 2015 16:17:46 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Wed, Jun 24, 2015 at 04:07:27PM +0200, Igor Mammedov wrote

Re: [PATCH RFC] vhost: add ioctl to query nregions upper limit

and you can assume at least 64 slots. Since 0 value's left unused, let's make that mean that the current userspace behaviour (trial and error) is required, just in case we want it back. Signed-off-by: Michael S. Tsirkin m...@redhat.com Cc: Igor Mammedov imamm...@redhat.com Cc: Paolo Bonzini pbonz

Re: [PATCH RFC] vhost: add ioctl to query nregions upper limit

On Wed, 24 Jun 2015 16:17:46 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Wed, Jun 24, 2015 at 04:07:27PM +0200, Igor Mammedov wrote: On Wed, 24 Jun 2015 15:49:27 +0200 Michael S. Tsirkin m...@redhat.com wrote: Userspace currently simply tries to give vhost as many regions

Re: [PATCH 3/5] vhost: support upto 509 memory regions

On Fri, 19 Jun 2015 18:33:39 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Fri, Jun 19, 2015 at 06:26:27PM +0200, Paolo Bonzini wrote: On 19/06/2015 18:20, Michael S. Tsirkin wrote: We could, but I/O is just an example. It can be I/O, a network ring, whatever. We cannot

Re: [PATCH 3/5] vhost: support upto 509 memory regions

On Thu, 18 Jun 2015 13:41:22 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Thu, Jun 18, 2015 at 01:39:12PM +0200, Igor Mammedov wrote: Lets leave decision upto users instead of making them live with crashing guests. Come on, let's fix it in userspace. I'm not abandoning userspace

Re: [PATCH 3/5] vhost: support upto 509 memory regions

On Thu, 18 Jun 2015 11:50:22 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Thu, Jun 18, 2015 at 11:12:24AM +0200, Igor Mammedov wrote: On Wed, 17 Jun 2015 18:30:02 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Wed, Jun 17, 2015 at 06:09:21PM +0200, Igor Mammedov wrote

Re: [PATCH 3/5] vhost: support upto 509 memory regions

, Michael S. Tsirkin wrote: On Thu, Jun 18, 2015 at 01:39:12PM +0200, Igor Mammedov wrote: Lets leave decision upto users instead of making them live with crashing guests. Come on, let's fix it in userspace. It's not trivial to fix it in userspace. Since QEMU uses RCU there isn't

Re: [PATCH 3/5] vhost: support upto 509 memory regions

On Wed, 17 Jun 2015 18:30:02 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Wed, Jun 17, 2015 at 06:09:21PM +0200, Igor Mammedov wrote: On Wed, 17 Jun 2015 17:38:40 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Wed, Jun 17, 2015 at 05:12:57PM +0200, Igor Mammedov wrote

Re: [PATCH 3/5] vhost: support upto 509 memory regions

On Wed, 17 Jun 2015 18:30:02 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Wed, Jun 17, 2015 at 06:09:21PM +0200, Igor Mammedov wrote: On Wed, 17 Jun 2015 17:38:40 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Wed, Jun 17, 2015 at 05:12:57PM +0200, Igor Mammedov wrote

Re: [PATCH 3/5] vhost: support upto 509 memory regions

On Wed, 17 Jun 2015 18:47:18 +0200 Paolo Bonzini pbonz...@redhat.com wrote: On 17/06/2015 18:41, Michael S. Tsirkin wrote: On Wed, Jun 17, 2015 at 06:38:25PM +0200, Paolo Bonzini wrote: On 17/06/2015 18:34, Michael S. Tsirkin wrote: On Wed, Jun 17, 2015 at 06:31:32PM +0200, Paolo

Re: [PATCH 3/5] vhost: support upto 509 memory regions

On Wed, 17 Jun 2015 12:46:09 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Wed, Jun 17, 2015 at 12:37:42PM +0200, Igor Mammedov wrote: On Wed, 17 Jun 2015 12:11:09 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Wed, Jun 17, 2015 at 10:54:21AM +0200, Igor Mammedov wrote

Re: [PATCH 0/5] vhost: support upto 509 memory regions

On Wed, 17 Jun 2015 08:31:23 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Wed, Jun 17, 2015 at 12:19:15AM +0200, Igor Mammedov wrote: On Tue, 16 Jun 2015 23:16:07 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Tue, Jun 16, 2015 at 06:33:34PM +0200, Igor Mammedov wrote

Re: [PATCH 3/5] vhost: support upto 509 memory regions

On Wed, 17 Jun 2015 13:51:56 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Wed, Jun 17, 2015 at 01:48:03PM +0200, Igor Mammedov wrote: So far it's kernel limitation and this patch fixes crashes that users see now, with the rest of patches enabling performance not to regress

Re: [PATCH 3/5] vhost: support upto 509 memory regions

On Wed, 17 Jun 2015 08:34:26 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Wed, Jun 17, 2015 at 12:00:56AM +0200, Igor Mammedov wrote: On Tue, 16 Jun 2015 23:14:20 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Tue, Jun 16, 2015 at 06:33:37PM +0200, Igor Mammedov wrote

Re: [PATCH 3/5] vhost: support upto 509 memory regions

On Wed, 17 Jun 2015 12:11:09 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Wed, Jun 17, 2015 at 10:54:21AM +0200, Igor Mammedov wrote: On Wed, 17 Jun 2015 09:39:06 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Wed, Jun 17, 2015 at 09:28:02AM +0200, Igor Mammedov wrote

Re: [PATCH 3/5] vhost: support upto 509 memory regions

On Wed, 17 Jun 2015 09:39:06 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Wed, Jun 17, 2015 at 09:28:02AM +0200, Igor Mammedov wrote: On Wed, 17 Jun 2015 08:34:26 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Wed, Jun 17, 2015 at 12:00:56AM +0200, Igor Mammedov wrote

[PATCH v2 0/6] vhost: support upto 509 memory regions

% this series | 0.2% | 0.5% | 0.7% where non cached column reflects trashing wokload with constant cache miss. More details on timing in respective patches. Igor Mammedov (6): vhost: use binary search instead of linear in find_region() vhost: extend memory regions allocation to vmalloc vhost: add

[PATCH v2 2/6] vhost: extend memory regions allocation to vmalloc

could use large amount of memory regions. Signed-off-by: Igor Mammedov imamm...@redhat.com --- drivers/vhost/vhost.c | 22 +- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c index f1e07b8..99931a0 100644

[PATCH v2 3/6] vhost: add per VQ memory region caching

that brings down translate_desc() cost to around 210ns if accessed descriptors are from the same memory region. Signed-off-by: Igor Mammedov imamm...@redhat.com --- that's what netperf/iperf workloads were during testing. --- drivers/vhost/vhost.c | 16 +--- drivers/vhost/vhost.h

[PATCH v2 5/6] vhost: add 'translation_cache' module parameter

with cashing enabled for sequential workload doesn't seem to be affected much vs version without static key switch, i.e. still the same 0.2% of total time with key(NOPs) consuming 5ms on 5min workload. Signed-off-by: Igor Mammedov imamm...@redhat.com --- I don't have a test case for trashing workload

[PATCH v2 1/6] vhost: use binary search instead of linear in find_region()

allowed number of slots is increased to 509 like it has been done in KVM. Signed-off-by: Igor Mammedov imamm...@redhat.com --- v2: move kvfree() to 2/2 where it belongs --- drivers/vhost/vhost.c | 36 +++- 1 file changed, 27 insertions(+), 9 deletions(-) diff --git

[PATCH v2 4/6] vhost: translate_desc: optimization for desc.len region size

with a single remaining length check and execute next iov steps only when it needed. It saves a tiny 2% of translate_desc() execution time. Signed-off-by: Igor Mammedov imamm...@redhat.com --- PS: I'm not sure if iov_size 0 is always true, if it's not then better to drop this patch. --- drivers/vhost

[PATCH v2 6/6] vhost: support upto 509 memory regions

in module vhost-net refuses to accept more than 64 memory regions. Increase VHOST_MEMORY_MAX_NREGIONS limit from 64 to 509 to match KVM_USER_MEM_SLOTS to fix issue for vhost-net and current QEMU versions. Signed-off-by: Igor Mammedov imamm...@redhat.com --- drivers/vhost/vhost.c | 2 +- 1 file

Re: [PATCH 3/5] vhost: support upto 509 memory regions

On Wed, 17 Jun 2015 16:32:02 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Wed, Jun 17, 2015 at 03:20:44PM +0200, Paolo Bonzini wrote: On 17/06/2015 15:13, Michael S. Tsirkin wrote: Considering userspace can be malicious, I guess yes. I don't think it's a valid concern in

Re: [PATCH 3/5] vhost: support upto 509 memory regions

On Wed, 17 Jun 2015 17:38:40 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Wed, Jun 17, 2015 at 05:12:57PM +0200, Igor Mammedov wrote: On Wed, 17 Jun 2015 16:32:02 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Wed, Jun 17, 2015 at 03:20:44PM +0200, Paolo Bonzini wrote

[PATCH 1/5] vhost: use binary search instead of linear in find_region()

allowed number of slots is increased to 509 like it has been done in kvm. Signed-off-by: Igor Mammedov imamm...@redhat.com --- drivers/vhost/vhost.c | 38 -- 1 file changed, 28 insertions(+), 10 deletions(-) diff --git a/drivers/vhost/vhost.c b/drivers/vhost

[PATCH 5/5] vhost: translate_desc: optimization for desc.len region size

with a single remaining length check and execute next iov steps only when it needed. It saves tiny 2% of translate_desc() execution time. Signed-off-by: Igor Mammedov imamm...@redhat.com --- PS: I'm not sure if iov_size 0 is always true, if it's not then better to drop this patch. --- drivers/vhost

[PATCH 0/5] vhost: support upto 509 memory regions

trashing wokload with constant cache miss. More details on timing in respective patches. Igor Mammedov (5): vhost: use binary search instead of linear in find_region() vhost: extend memory regions allocation to vmalloc vhost: support upto 509 memory regions vhost: add per VQ memory region caching

[PATCH 3/5] vhost: support upto 509 memory regions

in module vhost-net refuses to accept more than 65 memory regions. Increase VHOST_MEMORY_MAX_NREGIONS from 65 to 509 to match KVM_USER_MEM_SLOTS fixes issue for vhost-net. Signed-off-by: Igor Mammedov imamm...@redhat.com --- drivers/vhost/vhost.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH 2/5] vhost: extend memory regions allocation to vmalloc

could use large amount of memory regions. Signed-off-by: Igor Mammedov imamm...@redhat.com --- --- drivers/vhost/vhost.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c index a22f8c3..99931a0 100644

[PATCH 4/5] vhost: add per VQ memory region caching

that brings down translate_desc() cost to around 210ns if accessed descriptors are from the same memory region. Signed-off-by: Igor Mammedov imamm...@redhat.com --- that's what netperf/iperf workloads were during testing. --- drivers/vhost/vhost.c | 16 +--- drivers/vhost/vhost.h

Re: [PATCH 1/5] vhost: use binary search instead of linear in find_region()

On Tue, 16 Jun 2015 23:07:24 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Tue, Jun 16, 2015 at 06:33:35PM +0200, Igor Mammedov wrote: For default region layouts performance stays the same as linear search i.e. it takes around 210ns average for translate_desc() that inlines

Re: [PATCH 3/5] vhost: support upto 509 memory regions

On Tue, 16 Jun 2015 23:14:20 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Tue, Jun 16, 2015 at 06:33:37PM +0200, Igor Mammedov wrote: since commit 1d4e7e3 kvm: x86: increase user memory slots to 509 it became possible to use a bigger amount of memory slots, which is used

Re: [PATCH 0/5] vhost: support upto 509 memory regions

On Tue, 16 Jun 2015 23:16:07 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Tue, Jun 16, 2015 at 06:33:34PM +0200, Igor Mammedov wrote: Series extends vhost to support upto 509 memory regions, and adds some vhost:translate_desc() performance improvemnts so it won't regress when

  1   2   3   >