Re: [PATCH 2/2] KVM: Use pci_store/load_saved_state() around VM device usage

2011-04-20 Thread Avi Kivity
On 04/18/2011 10:43 PM, Alex Williamson wrote: On Sun, 2011-04-17 at 12:25 +0300, Avi Kivity wrote: On 04/15/2011 10:54 PM, Alex Williamson wrote: Store the device saved state so that we can reload the device back to the original state when it's unassigned. This has the benefit

Re: [PATCH 2/2] KVM: Use pci_store/load_saved_state() around VM device usage

2011-04-20 Thread Alex Williamson
On Wed, 2011-04-20 at 10:19 +0300, Avi Kivity wrote: On 04/18/2011 10:43 PM, Alex Williamson wrote: On Sun, 2011-04-17 at 12:25 +0300, Avi Kivity wrote: On 04/15/2011 10:54 PM, Alex Williamson wrote: Store the device saved state so that we can reload the device back to the

Re: [PATCH 2/2] KVM: Use pci_store/load_saved_state() around VM device usage

2011-04-20 Thread Avi Kivity
On 04/20/2011 06:13 PM, Alex Williamson wrote: This is also why I changed the __pci_reset_function() back to a normal pci_reset_function(), so we're never left with an uninitialized device like we are now. We could be more verbose or return an error here, but we've gone

Re: [PATCH 2/2] KVM: Use pci_store/load_saved_state() around VM device usage

2011-04-18 Thread Alex Williamson
On Sun, 2011-04-17 at 12:25 +0300, Avi Kivity wrote: On 04/15/2011 10:54 PM, Alex Williamson wrote: Store the device saved state so that we can reload the device back to the original state when it's unassigned. This has the benefit that the state survives across pci_reset_function() calls

Re: [PATCH 2/2] KVM: Use pci_store/load_saved_state() around VM device usage

2011-04-17 Thread Avi Kivity
On 04/15/2011 10:54 PM, Alex Williamson wrote: Store the device saved state so that we can reload the device back to the original state when it's unassigned. This has the benefit that the state survives across pci_reset_function() calls via the PCI sysfs reset interface while the VM is using

[PATCH 2/2] KVM: Use pci_store/load_saved_state() around VM device usage

2011-04-15 Thread Alex Williamson
Store the device saved state so that we can reload the device back to the original state when it's unassigned. This has the benefit that the state survives across pci_reset_function() calls via the PCI sysfs reset interface while the VM is using the device. Signed-off-by: Alex Williamson

Re: [PATCH 2/2] KVM: Use pci_store/load_saved_state() around VM device usage

2011-04-15 Thread Jan Kiszka
On 2011-04-15 21:54, Alex Williamson wrote: Store the device saved state so that we can reload the device back to the original state when it's unassigned. This has the benefit that the state survives across pci_reset_function() calls via the PCI sysfs reset interface while the VM is using the

Re: [PATCH 2/2] KVM: Use pci_store/load_saved_state() around VM device usage

2011-04-15 Thread Alex Williamson
On Fri, 2011-04-15 at 22:03 +0200, Jan Kiszka wrote: On 2011-04-15 21:54, Alex Williamson wrote: Store the device saved state so that we can reload the device back to the original state when it's unassigned. This has the benefit that the state survives across pci_reset_function() calls via

Re: [PATCH 2/2] KVM: Use pci_store/load_saved_state() around VM device usage

2011-04-15 Thread Jan Kiszka
On 2011-04-15 22:13, Alex Williamson wrote: On Fri, 2011-04-15 at 22:03 +0200, Jan Kiszka wrote: On 2011-04-15 21:54, Alex Williamson wrote: Store the device saved state so that we can reload the device back to the original state when it's unassigned. This has the benefit that the state