Re: [PATCH v3 11/11] KVM: MMU: improve write flooding detected

2011-09-14 Thread Avi Kivity
On 09/13/2011 10:19 PM, Xiao Guangrong wrote: The spte may not be accessed, but other sptes in the same page can be accessed. An example is the fixmap area for kmap_atomic(), there will be a lot of pte writes but other sptes will be accessed without going through soft-mmu at all. I think

Re: [PATCH v3 11/11] KVM: MMU: improve write flooding detected

2011-09-13 Thread Avi Kivity
On 08/30/2011 05:38 AM, Xiao Guangrong wrote: Detecting write-flooding does not work well, when we handle page written, if the last speculative spte is not accessed, we treat the page is write-flooding, however, we can speculative spte on many path, such as pte prefetch, page synced, that means

Re: [PATCH v3 11/11] KVM: MMU: improve write flooding detected

2011-09-13 Thread Xiao Guangrong
On 09/13/2011 07:07 PM, Avi Kivity wrote: On 08/30/2011 05:38 AM, Xiao Guangrong wrote: Detecting write-flooding does not work well, when we handle page written, if the last speculative spte is not accessed, we treat the page is write-flooding, however, we can speculative spte on many path,

[PATCH v3 11/11] KVM: MMU: improve write flooding detected

2011-08-29 Thread Xiao Guangrong
Detecting write-flooding does not work well, when we handle page written, if the last speculative spte is not accessed, we treat the page is write-flooding, however, we can speculative spte on many path, such as pte prefetch, page synced, that means the last speculative spte may be not point to