Re: [Qemu-devel] [PATCH v3 1/9] net: introduce tcp_server_start()

2012-03-16 Thread Amos Kong
On 14/03/12 22:58, Michael Roth wrote: On Wed, Mar 14, 2012 at 04:33:14PM +0800, Amos Kong wrote: On 14/03/12 00:39, Michael Roth wrote: On Wed, Mar 07, 2012 at 06:47:45AM +0800, Amos Kong wrote: Introduce tcp_server_start() by moving original code in tcp_start_incoming_migration().

Re: [Qemu-devel] [PATCH v3 1/9] net: introduce tcp_server_start()

2012-03-14 Thread Orit Wasserman
On 03/07/2012 12:47 AM, Amos Kong wrote: Introduce tcp_server_start() by moving original code in tcp_start_incoming_migration(). Signed-off-by: Amos Kong ak...@redhat.com --- net.c | 28 qemu_socket.h |2 ++ 2 files changed, 30 insertions(+), 0

Re: [Qemu-devel] [PATCH v3 1/9] net: introduce tcp_server_start()

2012-03-14 Thread Paolo Bonzini
Il 14/03/2012 08:14, Orit Wasserman ha scritto: if (bind(*fd, (struct sockaddr *)saddr, sizeof(saddr)) 0) { closesocket(*fd); return -socket_error(); } return 0; and than you will not need ret But closesocket could clobber socket_error(), no? Paolo -- To unsubscribe from

Re: [Qemu-devel] [PATCH v3 1/9] net: introduce tcp_server_start()

2012-03-14 Thread Amos Kong
On 14/03/12 15:27, Paolo Bonzini wrote: Hi Paolo, Il 14/03/2012 08:14, Orit Wasserman ha scritto: if (bind(*fd, (struct sockaddr *)saddr, sizeof(saddr)) 0) { closesocket(*fd); return -socket_error(); } return 0; and than you will not need ret But closesocket could

Re: [Qemu-devel] [PATCH v3 1/9] net: introduce tcp_server_start()

2012-03-14 Thread Paolo Bonzini
Il 14/03/2012 08:51, Amos Kong ha scritto: ret = bind(*fd, (struct sockaddr *)saddr, sizeof(saddr)); if (ret 0) { ret = -socket_error(); closesocket(*fd); } return ret; } Looks good. Paolo -- To unsubscribe from this list: send the line unsubscribe kvm

Re: [Qemu-devel] [PATCH v3 1/9] net: introduce tcp_server_start()

2012-03-14 Thread Amos Kong
On 14/03/12 00:39, Michael Roth wrote: On Wed, Mar 07, 2012 at 06:47:45AM +0800, Amos Kong wrote: Introduce tcp_server_start() by moving original code in tcp_start_incoming_migration(). Signed-off-by: Amos Kongak...@redhat.com --- net.c | 28

Re: [Qemu-devel] [PATCH v3 1/9] net: introduce tcp_server_start()

2012-03-14 Thread Orit Wasserman
On 03/14/2012 09:51 AM, Amos Kong wrote: On 14/03/12 15:27, Paolo Bonzini wrote: Hi Paolo, Il 14/03/2012 08:14, Orit Wasserman ha scritto: if (bind(*fd, (struct sockaddr *)saddr, sizeof(saddr)) 0) { closesocket(*fd); return -socket_error(); } return 0; and than you

Re: [Qemu-devel] [PATCH v3 1/9] net: introduce tcp_server_start()

2012-03-14 Thread Kevin Wolf
Am 14.03.2012 08:51, schrieb Amos Kong: On 14/03/12 15:27, Paolo Bonzini wrote: Hi Paolo, Il 14/03/2012 08:14, Orit Wasserman ha scritto: if (bind(*fd, (struct sockaddr *)saddr, sizeof(saddr)) 0) { closesocket(*fd); return -socket_error(); } return 0; and than you

Re: [Qemu-devel] [PATCH v3 1/9] net: introduce tcp_server_start()

2012-03-14 Thread Michael Roth
On Wed, Mar 14, 2012 at 04:33:14PM +0800, Amos Kong wrote: On 14/03/12 00:39, Michael Roth wrote: On Wed, Mar 07, 2012 at 06:47:45AM +0800, Amos Kong wrote: Introduce tcp_server_start() by moving original code in tcp_start_incoming_migration(). Signed-off-by: Amos Kongak...@redhat.com ---

Re: [Qemu-devel] [PATCH v3 1/9] net: introduce tcp_server_start()

2012-03-13 Thread Michael Roth
On Wed, Mar 07, 2012 at 06:47:45AM +0800, Amos Kong wrote: Introduce tcp_server_start() by moving original code in tcp_start_incoming_migration(). Signed-off-by: Amos Kong ak...@redhat.com --- net.c | 28 qemu_socket.h |2 ++ 2 files changed, 30