Re: seabios 0.6.1 regression

2010-11-20 Thread Avi Kivity
On 11/16/2010 03:19 PM, Alexander Graf wrote: Rewriting it to use inb / stos works (jecxz ; insb; loop doesn't) so it looks like a kernel bug in insb emulation. Turns out is was a subtle bug in the tpr optimization we do for Windows XP. The problem happens when we load the vapic

Re: seabios 0.6.1 regression

2010-11-19 Thread Avi Kivity
On 11/16/2010 04:17 PM, Alexander Graf wrote: On 16.11.2010, at 15:15, Avi Kivity wrote: On 11/16/2010 03:19 PM, Alexander Graf wrote: Rewriting it to use inb / stos works (jecxz ; insb; loop doesn't) so it looks like a kernel bug in insb emulation. Turns out is was a

Re: seabios 0.6.1 regression

2010-11-16 Thread Avi Kivity
On 11/16/2010 02:18 AM, Kevin O'Connor wrote: Rewriting it to use inb / stos works (jecxz ; insb; loop doesn't) so it looks like a kernel bug in insb emulation. Ughh. I can revert that change on stable-0.6.1 if needed. kernel bug - kernel fix. SeaBIOS should feel free to use any

Re: seabios 0.6.1 regression

2010-11-16 Thread Avi Kivity
On 11/15/2010 06:09 PM, Avi Kivity wrote: On 11/15/2010 05:49 PM, Avi Kivity wrote: On 11/15/2010 05:41 PM, Avi Kivity wrote: I think it's a miscompile. out/code16.o: 1a4: 3e ds 1a5: 6c insb (%dx),%es:(%edi) Note no 66 prefix. It isn't,

Re: seabios 0.6.1 regression

2010-11-16 Thread Alexander Graf
On 16.11.2010, at 11:47, Avi Kivity wrote: On 11/15/2010 06:09 PM, Avi Kivity wrote: On 11/15/2010 05:49 PM, Avi Kivity wrote: On 11/15/2010 05:41 PM, Avi Kivity wrote: I think it's a miscompile. out/code16.o: 1a4: 3e ds 1a5: 6c insb

Re: seabios 0.6.1 regression

2010-11-16 Thread Alexander Graf
On 16.11.2010, at 15:15, Avi Kivity wrote: On 11/16/2010 03:19 PM, Alexander Graf wrote: Rewriting it to use inb / stos works (jecxz ; insb; loop doesn't) so it looks like a kernel bug in insb emulation. Turns out is was a subtle bug in the tpr optimization we do for Windows

seabios 0.6.1 regression

2010-11-15 Thread Avi Kivity
Installing Windows XP with seabios 0.6.1, immediately after the first reboot, Windows hangs in protected mode instead of proceeding with installation. I'm bisecting this, but if anyone can point to a likely culprit, I can try it first. -- error compiling committee.c: too many arguments to

Re: seabios 0.6.1 regression

2010-11-15 Thread Avi Kivity
On 11/15/2010 03:39 PM, Avi Kivity wrote: Installing Windows XP with seabios 0.6.1, immediately after the first reboot, Windows hangs in protected mode instead of proceeding with installation. I'm bisecting this, but if anyone can point to a likely culprit, I can try it first. Bisect

Re: seabios 0.6.1 regression

2010-11-15 Thread Avi Kivity
On 11/15/2010 05:04 PM, Avi Kivity wrote: On 11/15/2010 03:39 PM, Avi Kivity wrote: Installing Windows XP with seabios 0.6.1, immediately after the first reboot, Windows hangs in protected mode instead of proceeding with installation. I'm bisecting this, but if anyone can point to a likely

Re: seabios 0.6.1 regression

2010-11-15 Thread Avi Kivity
On 11/15/2010 05:12 PM, Avi Kivity wrote: That was premature, the real culprit (if I didn't mess up the bisect) is: commit 6039fc55274deb7202060d08e0f23b9f3dcface4 Author: Kevin O'Connor ke...@koconnor.net Date: Wed Aug 25 21:43:19 2010 -0400 Update qemu_cfg_read to use rep insb.

Re: seabios 0.6.1 regression

2010-11-15 Thread Avi Kivity
On 11/15/2010 05:34 PM, Avi Kivity wrote: On 11/15/2010 05:12 PM, Avi Kivity wrote: That was premature, the real culprit (if I didn't mess up the bisect) is: commit 6039fc55274deb7202060d08e0f23b9f3dcface4 Author: Kevin O'Connor ke...@koconnor.net Date: Wed Aug 25 21:43:19 2010 -0400

Re: seabios 0.6.1 regression

2010-11-15 Thread Avi Kivity
On 11/15/2010 05:41 PM, Avi Kivity wrote: I think it's a miscompile. out/code16.o: 1a4: 3e ds 1a5: 6c insb (%dx),%es:(%edi) Note no 66 prefix. It isn't, that was random crap. All the insb() code is 32-bit. -- error compiling committee.c:

Re: seabios 0.6.1 regression

2010-11-15 Thread Avi Kivity
On 11/15/2010 05:49 PM, Avi Kivity wrote: On 11/15/2010 05:41 PM, Avi Kivity wrote: I think it's a miscompile. out/code16.o: 1a4: 3e ds 1a5: 6c insb (%dx),%es:(%edi) Note no 66 prefix. It isn't, that was random crap. All the insb() code

Re: seabios 0.6.1 regression

2010-11-15 Thread Kevin O'Connor
On Mon, Nov 15, 2010 at 06:09:45PM +0200, Avi Kivity wrote: On 11/15/2010 05:49 PM, Avi Kivity wrote: On 11/15/2010 05:41 PM, Avi Kivity wrote: I think it's a miscompile. out/code16.o: 1a4: 3e ds 1a5: 6c insb (%dx),%es:(%edi) Note no