On Monday 06 November 2006 14:15, you wrote:
> On bootup, the rdx register contains information about the processor. The
> function which calculates this value has the bugs:
>
> - missing 'cpuid' to get the value from the processor
> - missing register clobber caused a miscompilation in some cir
On bootup, the rdx register contains information about the processor. The
function which calculates this value has the bugs:
- missing 'cpuid' to get the value from the processor
- missing register clobber caused a miscompilation in some circumstances
- we shouldn't return a value that depends
Arjan van de Ven wrote:
>> \> as a general rule, it's a lot better to sort structures big-to-small, to
>>
>>> make sure alignments inside the struct are minimized and don't suck too
>>> much. This is especially important to get right for 32/64 bit
>>> compatibility. This comment is true for mo
> \> as a general rule, it's a lot better to sort structures big-to-small, to
> > make sure alignments inside the struct are minimized and don't suck too
> > much. This is especially important to get right for 32/64 bit
> > compatibility. This comment is true for most structures in this header
> >
Arjan van de Ven wrote:
> Hi,
>
> some nitpicks about the ioctl interfaces while it still can be done ;)
>
>
There are some changes still planned (to streamline smp support).
>
>> Signed-off-by: Yaniv Kamay <[EMAIL PROTECTED]>
>> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]>
>>
>> --- /dev/
Hi,
some nitpicks about the ioctl interfaces while it still can be done ;)
> Signed-off-by: Yaniv Kamay <[EMAIL PROTECTED]>
> Signed-off-by: Avi Kivity <[EMAIL PROTECTED]>
>
> --- /dev/null 2006-10-25 17:42:42.376631750 +0200
> +++ linux-2.6/include/linux/kvm.h 2006-10-26 15:22:01.0
