Re: [kvm-devel] [PATCH 1/2] KVM: Remove arch specific components from the general code

2007-07-29 Thread Avi Kivity
Gregory Haskins wrote: > Signed-off-by: Gregory Haskins <[EMAIL PROTECTED]> > Applied, thanks. -- error compiling committee.c: too many arguments to function - This SF.net email is sponsored by: Splunk Inc. Still greppin

Re: [kvm-devel] [PATCH 2/2] KVM: Clean up VMCLEAR/VMPTRLD code on VMX

2007-07-29 Thread Avi Kivity
Gregory Haskins wrote: > Signed-off-by: Gregory Haskins <[EMAIL PROTECTED]> > --- > > Dropped - I don't see a problem with the current code. -- error compiling committee.c: too many arguments to function - This SF.net

Re: [kvm-devel] [PATCH 2/2] Dynamically allocate vcpus

2007-07-29 Thread Avi Kivity
Rusty Russell wrote: > Dynamically allocate vcpus > > This patch converts the vcpus array in "struct kvm" to a pointer > array, and changes the "vcpu_create" and "vcpu_setup" hooks into one > "vcpu_create" call which does the allocation and initialization of the > vcpu (calling back into the kvm_vc

Re: [kvm-devel] 2.6.23-rc1, KVM-AMD problem

2007-07-29 Thread Avi Kivity
Alistair John Strachan wrote: Hi, I'm getting periodic oopses running KVM-33 on 2.6.23-rc1. Here is a digital photo of the oops. Alarmingly, a lot of the time it triple faults the machine and I don't get a chance to grab it. This time I was lucky, though. http://devzero.co.uk/~alistair/kvm-2

Re: [kvm-devel] [PATCH] Improve the method of writing vmcs control

2007-07-29 Thread Avi Kivity
Yang, Sheng wrote: > Put cpu feature detecting part in hardware_setup, and stored the vmcs > condition in global variable for further check. > > Applied, thanks. -- error compiling committee.c: too many arguments to function --

Re: [kvm-devel] qcow2 image growing without reason ?

2007-07-29 Thread Avi Kivity
Ben Budts wrote: > Hi, > > I've been running kvm21 for a long time (just upgraded to kvm-33 with > 2.6.22.1) > > I have a 60GB qcow2 image, I noticed the image was growing without me > installing software on the guest os...(WIN XP) > > When I select all my files and take properties (in win xp tha

Re: [kvm-devel] 2.6.23-rc1, KVM-AMD problem

2007-07-29 Thread Alistair John Strachan
On Sunday 29 July 2007 09:16:43 Avi Kivity wrote: > Alistair John Strachan wrote: > > Hi, > > > > I'm getting periodic oopses running KVM-33 on 2.6.23-rc1. Here is a > > digital photo of the oops. Alarmingly, a lot of the time it triple faults > > the machine and I don't get a chance to grab it. Th

Re: [kvm-devel] 2.6.23-rc1, KVM-AMD problem

2007-07-29 Thread Avi Kivity
Alistair John Strachan wrote: > On Sunday 29 July 2007 09:16:43 Avi Kivity wrote: > >> Alistair John Strachan wrote: >> >>> Hi, >>> >>> I'm getting periodic oopses running KVM-33 on 2.6.23-rc1. Here is a >>> digital photo of the oops. Alarmingly, a lot of the time it triple faults >>> the m

Re: [kvm-devel] qcow2 image growing without reason ?

2007-07-29 Thread Luca
On 7/26/07, Ben Budts <[EMAIL PROTECTED]> wrote: > When I select all my files and take properties (in win xp that is), it says > 3.7GB, as expected... > > The image is allmost the double though (6.4GB) when i look at the qcow2 image, > when taking the properties of the HD in win xp it also indicta

Re: [kvm-devel] 2.6.23-rc1, KVM-AMD problem

2007-07-29 Thread Avi Kivity
Alistair John Strachan wrote: > On Sunday 29 July 2007 12:34:28 you wrote: > [snip] > >>> Doesn't help, I still get the same crashes. I tried 2.6.22 again and it's >>> rock solid by comparison. >>> >> Do you mean, kvm-33 on top of 2.6.22, or the kvm modules from 2.6.22? >> Please describe

Re: [kvm-devel] 2.6.23-rc1, KVM-AMD problem

2007-07-29 Thread Alistair John Strachan
On Sunday 29 July 2007 12:34:28 you wrote: [snip] > > Doesn't help, I still get the same crashes. I tried 2.6.22 again and it's > > rock solid by comparison. > > Do you mean, kvm-33 on top of 2.6.22, or the kvm modules from 2.6.22? > Please describe your configuration *exactly*. I'm using the kvm-

Re: [kvm-devel] 2.6.23-rc1, KVM-AMD problem

2007-07-29 Thread Alistair John Strachan
On Sunday 29 July 2007 14:47:57 you wrote: > Alistair John Strachan wrote: > > On Sunday 29 July 2007 12:34:28 you wrote: > > [snip] > > > >>> Doesn't help, I still get the same crashes. I tried 2.6.22 again and > >>> it's rock solid by comparison. > >> > >> Do you mean, kvm-33 on top of 2.6.22, or

[kvm-devel] [PATCH] Add cpu consistence check in vmx.

2007-07-29 Thread Yang, Sheng
All the physical CPUs on the board should support the same VMX feature set. The hardware_enable() do the per-cpu check now. In case of vmx/svm enabling failure, transfer a variable in hardware_enable() for error report. Signed-off-by: Sheng Yang <[EMAIL PROTECTED]> --- drivers/kvm/kvm_main.c |

[kvm-devel] Storing command line options in qcow2 images

2007-07-29 Thread Jorge Lucángeli Obes
Hi Avi, hi all, I've started some (very minor) groundwork for this task. My idea was to add an extra "annotation" field in qcow2 snapshots. In this way, a snapshot can hold abitrary information; for example, command line arguments. Before going any further, I wanted to validate the general idea w

[kvm-devel] [PATCH] fx_init() needs preemption disabled while it plays with the FPU state

2007-07-29 Thread Rusty Russell
fx_init() needs preemption disabled while it plays with the FPU state Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> diff -r 66566cf6b576 drivers/kvm/kvm_main.c --- a/drivers/kvm/kvm_main.cFri Jul 27 16:27:11 2007 +1000 +++ b/drivers/kvm/kvm_main.cMon Jul 30 11:22:44 2007 +1000 @@ -651,

[kvm-devel] [PATCH 1/4] vmx: pass vcpu_vmx internally

2007-07-29 Thread Rusty Russell
container_of is wonderful, but not casting at all is better. This patch changes vmx.c's internal functions to pass "struct vcpu_vmx" instead of "struct kvm_vcpu" and using container_of. Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> diff -r 45a921ab14a2 drivers/kvm/vmx.c --- a/drivers/kvm/vmx.

[kvm-devel] [PATCH 2/4] svm: pass vcpu_svm internally

2007-07-29 Thread Rusty Russell
container_of is wonderful, but not casting at all is better. This patch changes svm.c's internal functions to pass "struct vcpu_svm" instead of "struct kvm_vcpu" and using container_of. It also changes some internal function names: 1) io_adress -> io_address (de-germanify the spelling) 2) kvm_re

[kvm-devel] [PATCH 3/4] House svm.c's pop_irq and push_irq helpers into generic header

2007-07-29 Thread Rusty Russell
Everyone can use push_irq() and pop_irq(), so move them to common code. Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> diff -r a26d2ddb1eee drivers/kvm/kvm.h --- a/drivers/kvm/kvm.h Fri Jul 27 18:08:57 2007 +1000 +++ b/drivers/kvm/kvm.h Fri Jul 27 18:09:38 2007 +1000 @@ -725,6 +725,24 @@ static

[kvm-devel] [PATCH 4/4] Use kmem cache for allocating vcpus, simplify FPU ops

2007-07-29 Thread Rusty Russell
If we use a kmem cache for allocating vcpus, we can get the 16-byte alignment required by fxsave & fxrstor instructions, and avoid manually aligning the buffer. Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> diff -r 39421cbc0486 drivers/kvm/kvm.h --- a/drivers/kvm/kvm.h Mon Jul 30 15:01:44 2007

Re: [kvm-devel] [PATCH 3/4] House svm.c's pop_irq and push_irq helpers into generic header

2007-07-29 Thread Rusty Russell
s/House/Hoist/ More coffee needed maybe, Rusty. - This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browse

[kvm-devel] [PATCH] Remove three magic numbers

2007-07-29 Thread Rusty Russell
There are several places where hardcoded numbers are used in place of the easily-available constant, which is poor form. Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> diff -r 8bb74738cd07 drivers/kvm/kvm_main.c --- a/drivers/kvm/kvm_main.cMon Jul 30 15:54:02 2007 +1000 +++ b/drivers/kvm/kv