[kvm-devel] [PATCH] KVM: VMX: Enabling MSR Bitmap feature

2008-03-27 Thread Yang, Sheng
From 560146a8f93fa61aa6e6a6cc78087e24da8b9693 Mon Sep 17 00:00:00 2001 From: Sheng Yang <[EMAIL PROTECTED]> Date: Fri, 28 Mar 2008 13:18:56 +0800 Subject: [PATCH] KVM: VMX: Enabling MSR Bitmap feature MSR Bitmap can control if the accessing of MSR causing VM Exit. Signed-off-by: Sheng Yang <[EMAI

[kvm-devel] [patch 2/2] QEMU/KVM: add function to handle signals

2008-03-27 Thread Marcelo Tosatti
SIGUSR1 has no handler, and the SIGUSR2 one does nothing useful anymore (thats also true for SIGIO on tap fd, which runs host_alarm_handler unnecessarily). Index: kvm-userspace.io/qemu/qemu-kvm.c === --- kvm-userspace.io.orig/qemu/q

[kvm-devel] [patch 1/2] QEMU/KVM: separate thread for IO handling

2008-03-27 Thread Marcelo Tosatti
Move IO processing from vcpu0 to a dedicated thread. This removes load on vcpu0 by allowing better cache locality and also improves latency. We can now block signal handling for IO events, so sigtimedwait won't race with handlers: - Currently the SIGALRM handler fails to set CPU_INTERRUPT_EXIT b

[kvm-devel] [patch 0/2] separate thread for IO handling V2

2008-03-27 Thread Marcelo Tosatti
- Fix reset, powerdown and shutdown. - Fix kvmctl. -- - Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239

Re: [kvm-devel] [Qemu-devel] [PATCH] ignore reads to the EOI register.

2008-03-27 Thread Aurelien Jarno
On Wed, Mar 26, 2008 at 09:57:16PM -0300, Glauber Costa wrote: > They seem legal in real hardware, even though the EOI > is a write-only register. By "legal" I mean they are completely > ignored, but at least, don't cause any bits to be set at ESR. > > Without this patch, some (very recent) linux

[kvm-devel] 7-11 апреля, гостиница

2008-03-27 Thread Курс для участников Гостиничного бизнеса
Пpиглашаем Bаc пpинять yчаcтиве в тематичеckoм kypcе: Г o c т и н и ч н ы й б и з н е c: метoды эффеkтивнoгo yпpавления и метoды пpивлечения kлиентoв 07 - II апpеля, Cанkт-Петеpбypг B пpoгpамме: 1. Упpавленчеckая cтpykтypа coвpеменнoгo oтеля. 2. Ценoва

[kvm-devel] [PATCH 5/5] qemu: ARRAY_SIZE redefined

2008-03-27 Thread Carlo Marcelo Arenas Belon
qemu/qemu-kvm-x86.c:23:1: warning: "ARRAY_SIZE" redefined In file included from ../cpu-defs.h:30, from /var/tmp/portage/app-emulation/kvm-64/work/kvm-64/qemu/target-i386/cpu.h:45, from ../qemu-common.h:62, from /var/tmp/portage/app-emulation/kvm-

[kvm-devel] [PATCH 4/5] qemu: PCI_COMMAND_SERR redefined from linux headers

2008-03-27 Thread Carlo Marcelo Arenas Belon
qemu/hw/cirrus_vga.c:193:1: warning: "PCI_COMMAND_SERR" redefined In file included from /usr/include/linux/pci.h:21, from /var/tmp/portage/app-emulation/kvm-64/work/kvm-64/qemu/hw/pci.h:6, from /var/tmp/portage/app-emulation/kvm-64/work/kvm-64/qemu/hw/cirrus_vga.

Re: [kvm-devel] [PATCH] virtio-blk: allow more than one in-flight request

2008-03-27 Thread Rusty Russell
On Friday 28 March 2008 03:29:48 Marcelo Tosatti wrote: > Allow more than one in-flight request in the virtio ring. This allows > the host driver to submit requests in parallel. > > Signed-off-by: Marcelo Tosatti <[EMAIL PROTECTED]> For a moment, I thought this was true and felt very stupid :) Fo

[kvm-devel] [PATCH 3/5] qemu: model in NICInfo is a pointer to a constant string

2008-03-27 Thread Carlo Marcelo Arenas Belon
qemu/vl.c: In function `net_client_uninit': qemu/vl.c:4951: warning: passing arg 1 of `free' discards qualifiers from pointer target type Signed-off-by: Carlo Marcelo Arenas Belon <[EMAIL PROTECTED]> --- qemu/vl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qemu/vl.

[kvm-devel] [PATCH 2/5] qemu: cpu_model is a pointer to a constant string

2008-03-27 Thread Carlo Marcelo Arenas Belon
qemu/hw/pc.c: In function `pc_init1': qemu/hw/pc.c:1029: warning: passing arg 1 of `qemu_system_hot_add_init' discards qualifiers from pointer target type Signed-off-by: Carlo Marcelo Arenas Belon <[EMAIL PROTECTED]> --- qemu/hw/acpi.c |5 ++--- qemu/sysemu.h |2 +- 2 files changed, 3 i

[kvm-devel] [PATCH 1/5] libkvm: export kvm_disable_pit_creation to support -no-kvm-pit

2008-03-27 Thread Carlo Marcelo Arenas Belon
qemu/qemu-kvm.c: In function `kvm_qemu_create_context': qemu/qemu-kvm.c:549: warning: implicit declaration of function `kvm_disable_pit_creation' Signed-off-by: Carlo Marcelo Arenas Belon <[EMAIL PROTECTED]> --- libkvm/libkvm.h | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-)

[kvm-devel] [PATCH 0/5] trivial fixes to silence compilation warnings

2008-03-27 Thread Carlo Marcelo Arenas Belon
The following series contains unrelated patches with fixes to compilation warnings added since kvm-63; because of redefined macros, undefined functions or mismatched pointer types. PATCH 1/5 : libkvm: missing declaration for kvm_disable_pit_creation PATCH 2/5 : qemu: cpu_model is a constant st

[kvm-devel] [PATCH] KVM: MMU: fix large page breakage

2008-03-27 Thread Marcelo Tosatti
commit 15aaa819e20cb183f26392ed8ea16020630ef142 broke large page handling. With large pages it is valid to enter mmu_set_spte() with a gfn different than what current shadow pte contains, when overwritting a PTE page pointer. Signed-off-by: Marcelo Tosatti <[EMAIL PROTECTED]> diff --git a/arch

Re: [kvm-devel] hugetlbfs not working

2008-03-27 Thread Marcelo Tosatti
On Thu, Mar 27, 2008 at 06:09:56PM +0200, Avi Kivity wrote: > Anthony Liguori wrote: > > > > If you don't bail when ftruncate fails, does it work as expected for > > you? Perhaps older versions of hugetlbfs didn't support truncate. > > If you don't truncate, how can you change the file size? h

[kvm-devel] occludent

2008-03-27 Thread Giesen Zebell
Hello, Hohe hoholulu He can't help it it's second nature to him. Charles climb, kermana view of the kerman plain from the honest over batteries though i don't understand the reason that i loved the vicious devil of a the lower exit of which we had seen from below. time, under

Re: [kvm-devel] [PATCH] virtio-blk: allow more than one in-flight request

2008-03-27 Thread Marcelo Tosatti
On Thu, Mar 27, 2008 at 06:45:14PM +0100, Christian Borntraeger wrote: > Am Donnerstag, 27. März 2008 schrieb Marcelo Tosatti: > > > > Allow more than one in-flight request in the virtio ring. This allows > > the host driver to submit requests in parallel. > [...] > > diff --git a/drivers/block/vi

Re: [kvm-devel] [patch 0/3] QEMU dedicated IO thread

2008-03-27 Thread Marcelo Tosatti
On Thu, Mar 27, 2008 at 09:06:58PM +0200, Avi Kivity wrote: > Avi Kivity wrote: > >Marcelo Tosatti wrote: > > > > > >Applied all, thanks. > > > > > And backed out, as the regression tests indicate a bazillion failures. > I haven't investigated , but I think things are just slow so the tests >

Re: [kvm-devel] [patch 0/3] QEMU dedicated IO thread

2008-03-27 Thread Avi Kivity
Avi Kivity wrote: > Marcelo Tosatti wrote: > > > Applied all, thanks. > > And backed out, as the regression tests indicate a bazillion failures. I haven't investigated , but I think things are just slow so the tests time out. -- Any sufficiently difficult bug is indistinguishable from a fea

[kvm-devel] Долевое строительство домов

2008-03-27 Thread Ладимир
Бухгалтeрский учeт и налогообложeниe при осущeствлeнии капитальных вложeний и жилищного строитeльства Однoднeвный сeминар / 7 апрeля 2008 г. / Мoсква Прoграмма сeминара: 1. Понятиe инвeстиций в капитальныe вложeния. Субъeкты капитальных вложeний. Инвeстор, пользоватeль, заказчик, подрядчик.

Re: [kvm-devel] [PATCH] virtio-blk: allow more than one in-flight request

2008-03-27 Thread Christian Borntraeger
Am Donnerstag, 27. März 2008 schrieb Marcelo Tosatti: > > Allow more than one in-flight request in the virtio ring. This allows > the host driver to submit requests in parallel. [...] > diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c > index 3b1a68d..5bb041f 100644 > --- a/dri

Re: [kvm-devel] [patch 2/3] QEMU/KVM: add function to handle signals

2008-03-27 Thread Avi Kivity
Marcelo Tosatti wrote: > SIGUSR1 has no handler, and the SIGUSR2 one does nothing useful anymore > (thats also true for SIGIO on tap fd, which runs host_alarm_handler > unnecessarily). > > This one prevents alt+F4 from closing the sdl window (X over ssh), so I'm backing it out. I'm getting

Re: [kvm-devel] hugetlbfs not working

2008-03-27 Thread Marcelo Tosatti
On Thu, Mar 27, 2008 at 06:09:56PM +0200, Avi Kivity wrote: > Anthony Liguori wrote: > > > > If you don't bail when ftruncate fails, does it work as expected for > > you? Perhaps older versions of hugetlbfs didn't support truncate. > > If you don't truncate, how can you change the file size? h

Re: [kvm-devel] QEMU/KVM: virtio-blk asynchronous IO

2008-03-27 Thread Anthony Liguori
Marcelo Tosatti wrote: > Use asynchronous IO in the virtio block QEMU driver. > > virtio_blk_handle_output should not block for long periods, since it > holds the mutex lock prohibiting other vcpu's from doing IO to QEMU > devices. Without AIO write intensive benchmarks make guests hang for > sever

Re: [kvm-devel] kvm causing memory corruption? ~2.6.25-rc6

2008-03-27 Thread Dave Hansen
On Thu, 2008-03-27 at 16:59 +0200, Avi Kivity wrote: > Dave Hansen wrote: > > On Thu, 2008-03-27 at 12:10 +0200, Avi Kivity wrote: > >> btw, is this with >= 4GB RAM on the host? > >> > > Well, are you asking whether I have PAE on or not? :) > > No, I'm asking whether there is a possibility of

Re: [kvm-devel] kvm causing memory corruption? ~2.6.25-rc6

2008-03-27 Thread Dave Hansen
On Thu, 2008-03-27 at 17:53 +0200, Avi Kivity wrote: > Dave Hansen wrote: > > On Thu, 2008-03-27 at 11:36 +0200, Avi Kivity wrote: > > > >> I dug out my i386 install and tried it. Doesn't reproduce for me on > >> either kvm.git or -rc7. > >> > >> Do you have a working setup that we can bisect?

[kvm-devel] [PATCH] virtio-blk: allow more than one in-flight request

2008-03-27 Thread Marcelo Tosatti
Allow more than one in-flight request in the virtio ring. This allows the host driver to submit requests in parallel. Signed-off-by: Marcelo Tosatti <[EMAIL PROTECTED]> diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c index 3b1a68d..5bb041f 100644 --- a/drivers/block/virtio_

[kvm-devel] QEMU/KVM: virtio-blk asynchronous IO

2008-03-27 Thread Marcelo Tosatti
Use asynchronous IO in the virtio block QEMU driver. virtio_blk_handle_output should not block for long periods, since it holds the mutex lock prohibiting other vcpu's from doing IO to QEMU devices. Without AIO write intensive benchmarks make guests hang for several seconds. Write performance als

Re: [kvm-devel] hugetlbfs not working

2008-03-27 Thread Avi Kivity
Anthony Liguori wrote: > > If you don't bail when ftruncate fails, does it work as expected for > you? Perhaps older versions of hugetlbfs didn't support truncate. If you don't truncate, how can you change the file size? hugetlbfs doesn't support write(). I vaugely recall using ftruncate() o

Re: [kvm-devel] hugetlbfs not working

2008-03-27 Thread Anthony Liguori
Alexander Graf wrote: > On Mar 27, 2008, at 4:19 PM, Avi Kivity wrote: > > >> Alexander Graf wrote: >> >>> Hi, >>> >>> I'm currently trying to get hugetlbfs working on the current git >>> version and am quite puzzled to see it not working. It appears as >>> if the ftruncate call fails

Re: [kvm-devel] [patch 2/3] QEMU/KVM: add function to handle signals

2008-03-27 Thread Avi Kivity
Marcelo Tosatti wrote: > On Thu, Mar 27, 2008 at 05:25:20PM +0200, Avi Kivity wrote: > >> Marcelo Tosatti wrote: >> >>> SIGUSR1 has no handler, and the SIGUSR2 one does nothing useful anymore >>> (thats also true for SIGIO on tap fd, which runs host_alarm_handler >>> unnecessarily). >>>

Re: [kvm-devel] [patch 3/3] QEMU/libkvm: dont create vcpu0 thread

2008-03-27 Thread Avi Kivity
Marcelo Tosatti wrote: > Since the vcpu0 thread is not special anymore and created by qemu-kvm.c. > > Index: kvm-userspace.io/libkvm/libkvm.c > === > --- kvm-userspace.io.orig/libkvm/libkvm.c > +++ kvm-userspace.io/libkvm/libkvm.c > @@

Re: [kvm-devel] [patch 0/3] QEMU dedicated IO thread

2008-03-27 Thread Avi Kivity
Marcelo Tosatti wrote: Applied all, thanks. -- error compiling committee.c: too many arguments to function - Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anythi

Re: [kvm-devel] [patch 2/3] QEMU/KVM: add function to handle signals

2008-03-27 Thread Marcelo Tosatti
On Thu, Mar 27, 2008 at 05:25:20PM +0200, Avi Kivity wrote: > Marcelo Tosatti wrote: > >SIGUSR1 has no handler, and the SIGUSR2 one does nothing useful anymore > >(thats also true for SIGIO on tap fd, which runs host_alarm_handler > >unnecessarily). > > > > The sigaction(); sa.sa_handler() stu

Re: [kvm-devel] kvm causing memory corruption? ~2.6.25-rc6

2008-03-27 Thread Avi Kivity
Dave Hansen wrote: > On Thu, 2008-03-27 at 11:36 +0200, Avi Kivity wrote: > >> I dug out my i386 install and tried it. Doesn't reproduce for me on >> either kvm.git or -rc7. >> >> Do you have a working setup that we can bisect? >> > > I don't really have a working revision to bisect again

Re: [kvm-devel] kvm causing memory corruption? ~2.6.25-rc6

2008-03-27 Thread Dave Hansen
On Thu, 2008-03-27 at 11:36 +0200, Avi Kivity wrote: > I dug out my i386 install and tried it. Doesn't reproduce for me on > either kvm.git or -rc7. > > Do you have a working setup that we can bisect? I don't really have a working revision to bisect against. I'm not sure that it ever worked.

Re: [kvm-devel] [patch 1/3] QEMU/KVM: separate thread for IO handling

2008-03-27 Thread Avi Kivity
Marcelo Tosatti wrote: >>> >>> >> I still don't understand this. Timer expiration ought to be processed >> in the iothread, when SIGALRM is dequeued, and be completely unrelated >> to whatever vcpu 0 is doing. >> > > Yes, now it is unrelated. But before the patch it wasnt. So "curr

Re: [kvm-devel] [patch 1/3] QEMU/KVM: separate thread for IO handling

2008-03-27 Thread Marcelo Tosatti
On Thu, Mar 27, 2008 at 05:23:38PM +0200, Avi Kivity wrote: > Marcelo Tosatti wrote: > >Move IO processing from vcpu0 to a dedicated thread. > > > >This removes load on vcpu0 by allowing better cache locality and also > >improves latency. > > > > > > Does live migration (and stop/cont) still wor

Re: [kvm-devel] hugetlbfs not working

2008-03-27 Thread Alexander Graf
On Mar 27, 2008, at 4:19 PM, Avi Kivity wrote: > Alexander Graf wrote: >> Hi, >> >> I'm currently trying to get hugetlbfs working on the current git >> version and am quite puzzled to see it not working. It appears as >> if the ftruncate call fails: >> >> open("/dev/hugetlbfs//kvm.vI3G8z",

Re: [kvm-devel] [PATCH] KVM: MMU: Fix rmap_remove() race

2008-03-27 Thread Andi Kleen
Avi Kivity <[EMAIL PROTECTED]> writes: (thought i sent a reply before, but i don't see it now. sorry if you see it twice) > Andrea notes that freeing the page before flushing the tlb is a race, as the > guest can sneak in one last write before the tlb is flushed, writing to a > page that may belo

Re: [kvm-devel] [patch 2/3] QEMU/KVM: add function to handle signals

2008-03-27 Thread Avi Kivity
Marcelo Tosatti wrote: > SIGUSR1 has no handler, and the SIGUSR2 one does nothing useful anymore > (thats also true for SIGIO on tap fd, which runs host_alarm_handler > unnecessarily). > The sigaction(); sa.sa_handler() stuff was added as a stopgap; do we actually need to run _any_ signal ha

Re: [kvm-devel] [patch 1/3] QEMU/KVM: separate thread for IO handling

2008-03-27 Thread Avi Kivity
Marcelo Tosatti wrote: > Move IO processing from vcpu0 to a dedicated thread. > > This removes load on vcpu0 by allowing better cache locality and also > improves latency. > > Does live migration (and stop/cont) still work with this? > We can now block signal handling for IO events, so sigtime

Re: [kvm-devel] hugetlbfs not working

2008-03-27 Thread Avi Kivity
Alexander Graf wrote: > Hi, > > I'm currently trying to get hugetlbfs working on the current git > version and am quite puzzled to see it not working. It appears as if > the ftruncate call fails: > > open("/dev/hugetlbfs//kvm.vI3G8z", O_RDWR|O_CREAT|O_EXCL, 0600) = 7 > unlink("/dev/hugetlbfs//k

[kvm-devel] [patch 2/3] QEMU/KVM: add function to handle signals

2008-03-27 Thread Marcelo Tosatti
SIGUSR1 has no handler, and the SIGUSR2 one does nothing useful anymore (thats also true for SIGIO on tap fd, which runs host_alarm_handler unnecessarily). Index: kvm-userspace.io/qemu/qemu-kvm.c === --- kvm-userspace.io.orig/qemu/q

[kvm-devel] [patch 1/3] QEMU/KVM: separate thread for IO handling

2008-03-27 Thread Marcelo Tosatti
Move IO processing from vcpu0 to a dedicated thread. This removes load on vcpu0 by allowing better cache locality and also improves latency. We can now block signal handling for IO events, so sigtimedwait won't race with handlers: - Currently the SIGALRM handler fails to set CPU_INTERRUPT_EXIT b

[kvm-devel] [patch 3/3] QEMU/libkvm: dont create vcpu0 thread

2008-03-27 Thread Marcelo Tosatti
Since the vcpu0 thread is not special anymore and created by qemu-kvm.c. Index: kvm-userspace.io/libkvm/libkvm.c === --- kvm-userspace.io.orig/libkvm/libkvm.c +++ kvm-userspace.io/libkvm/libkvm.c @@ -388,9 +388,6 @@ int kvm_create(kvm

[kvm-devel] [patch 0/3] QEMU dedicated IO thread

2008-03-27 Thread Marcelo Tosatti
-- - Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace __

[kvm-devel] hugetlbfs not working

2008-03-27 Thread Alexander Graf
Hi, I'm currently trying to get hugetlbfs working on the current git version and am quite puzzled to see it not working. It appears as if the ftruncate call fails: open("/dev/hugetlbfs//kvm.vI3G8z", O_RDWR|O_CREAT|O_EXCL, 0600) = 7 unlink("/dev/hugetlbfs//kvm.vI3G8z")= 0 ftruncate(7, 1572

Re: [kvm-devel] crash booting Windows with current -git

2008-03-27 Thread Dave Hansen
On Thu, 2008-03-27 at 15:02 +0200, Dor Laor wrote: > On Tue, 2008-03-25 at 12:38 -0700, Dave Hansen wrote: > > I'm getting the following crash with current -git userspace. I'm > > running a stock 2.6.22-14-generic ubuntu kernels with modules from the > > kvm-userspace tree. I believe my BIOS ima

Re: [kvm-devel] kvm causing memory corruption? ~2.6.25-rc6

2008-03-27 Thread Avi Kivity
Dave Hansen wrote: > On Thu, 2008-03-27 at 12:10 +0200, Avi Kivity wrote: > >> btw, is this with >= 4GB RAM on the host? >> > > Well, are you asking whether I have PAE on or not? :) > > No, I'm asking whether there is a possibility of address truncation :) PAE by itself doesn't affect

Re: [kvm-devel] [PATCH] KVM: MMU: Fix rmap_remove() race

2008-03-27 Thread Avi Kivity
Andrea Arcangeli wrote: > On Thu, Mar 27, 2008 at 04:35:55PM +0200, Avi Kivity wrote: > >> We can put it under a Kconfig option. >> > > Yes, I thought the MMU_NOTIFIER knob would be enough but we can of > course add more finegrined options if we think it worth to allow > unprivileged users

Re: [kvm-devel] kvm causing memory corruption? ~2.6.25-rc6

2008-03-27 Thread Dave Hansen
On Thu, 2008-03-27 at 12:10 +0200, Avi Kivity wrote: > btw, is this with >= 4GB RAM on the host? Well, are you asking whether I have PAE on or not? :) The host has 4GB of RAM exactly, but there are some serious BIOS holes, so I needed PAE because about a gig of it is mapped >4GB. [0.00]

Re: [kvm-devel] [PATCH] KVM: MMU: Fix rmap_remove() race

2008-03-27 Thread Andrea Arcangeli
On Thu, Mar 27, 2008 at 04:35:55PM +0200, Avi Kivity wrote: > We can put it under a Kconfig option. Yes, I thought the MMU_NOTIFIER knob would be enough but we can of course add more finegrined options if we think it worth to allow unprivileged users to own /dev/kvm. -

Re: [kvm-devel] [PATCH] KVM: MMU: Fix rmap_remove() race

2008-03-27 Thread Avi Kivity
Andrea Arcangeli wrote: > On Thu, Mar 27, 2008 at 03:56:56PM +0200, Avi Kivity wrote: > >> That's not good. We need to support the older userspace, for a while yet. >> >> Why is there a problem? IIRC it's just anonymous memory. >> > > Problem is that for it to be unmapped __do_fault must c

[kvm-devel] [ANNOUNCE] kvm-64 release

2008-03-27 Thread Avi Kivity
Major changes: PCI hotplug; improved PIT accuracy; paravirt mmu. Changes from kvm-63: - kvm clock fixes (Glauber Costa) - kvm clock enable/disable bit (Glauber Costa) - in kernel pit model (Sheng Yang) - improves timing accuracy for certain guests - fix bad tss handling causing ioperm() to fail

Re: [kvm-devel] [PATCH] KVM: MMU: Fix rmap_remove() race

2008-03-27 Thread Andrea Arcangeli
On Thu, Mar 27, 2008 at 03:56:56PM +0200, Avi Kivity wrote: > That's not good. We need to support the older userspace, for a while yet. > > Why is there a problem? IIRC it's just anonymous memory. Problem is that for it to be unmapped __do_fault must call page_add_new_anon_rmap on it. Even anon w

Re: [kvm-devel] [PATCH] KVM: MMU: Fix rmap_remove() race

2008-03-27 Thread Avi Kivity
Andrea Arcangeli wrote: > On Thu, Mar 27, 2008 at 10:11:42AM +0200, Avi Kivity wrote: > >> Erm I don't think this means what you think it means. This is the >> kernel/user communication area, used to pass exit data to userspace. It's >> not the memslot vma. >> > > Yep... only the kvm_vm

Re: [kvm-devel] manage number of VCPU and memory

2008-03-27 Thread Avi Kivity
Břeťa Vomočil wrote: > Thanks, it worked... > But I have one more question, is there also some command for changing actual > memory like cpu_set for setting number of VCPUs? > > There's the balloon driver, but that is not yet merged. -- error compiling committee.c: too many arguments to fu

Re: [kvm-devel] [PATCH] KVM: MMU: Fix rmap_remove() race

2008-03-27 Thread Andrea Arcangeli
On Thu, Mar 27, 2008 at 10:11:42AM +0200, Avi Kivity wrote: > Erm I don't think this means what you think it means. This is the > kernel/user communication area, used to pass exit data to userspace. It's > not the memslot vma. Yep... only the kvm_vm_vm_ops can run gfn_to_page, and I assume tha

Re: [kvm-devel] [PATCH] ignore reads to the EOI register.

2008-03-27 Thread Maciej W. Rozycki
On Thu, 27 Mar 2008, Andi Kleen wrote: > It would be quite possible to make the cycle conditional on a > cpufeatures.h quirk flag that is only set on P5. Just would need to > out of line a few functions to avoid code bloat. Exactly what I suggested at the LKML -- you could even go down to a list

Re: [kvm-devel] crash booting Windows with current -git

2008-03-27 Thread Dor Laor
On Tue, 2008-03-25 at 12:38 -0700, Dave Hansen wrote: > I'm getting the following crash with current -git userspace. I'm > running a stock 2.6.22-14-generic ubuntu kernels with modules from the > kvm-userspace tree. I believe my BIOS images are also from current > -git. I didn't understand if t

Re: [kvm-devel] [PATCH] ignore reads to the EOI register.

2008-03-27 Thread Avi Kivity
Andi Kleen wrote: > "Maciej W. Rozycki" <[EMAIL PROTECTED]> writes: > >> Linux performs reads to all registers written including this one >> deliberately using an RMW cycle to avoid triggering an erratum in some >> early Pentium integrated APICs. Obviously it does not matter for most of >>

Re: [kvm-devel] KVM: register the kvm mmu cache with the shrinker.

2008-03-27 Thread Avi Kivity
Izik Eidus wrote: > void kvm_mmu_module_exit(void) > { > if (pte_chain_cache) > @@ -1980,6 +2026,7 @@ void kvm_mmu_module_exit(void) > kmem_cache_destroy(rmap_desc_cache); > if (mmu_page_header_cache) > kmem_cache_destroy(mmu_page_header_cache); > + unr

Re: [kvm-devel] manage number of VCPU and memory

2008-03-27 Thread Břeťa Vomočil
Thanks, it worked... But I have one more question, is there also some command for changing actual memory like cpu_set for setting number of VCPUs? Thanks in advance b. __ > Od: [EMAIL PROTECTED] > Komu: břeťa <[EMAIL PROTECTED]> > CC:

[kvm-devel] crash booting Windows with current -git

2008-03-27 Thread Dave Hansen
I'm getting the following crash with current -git userspace. I'm running a stock 2.6.22-14-generic ubuntu kernels with modules from the kvm-userspace tree. I believe my BIOS images are also from current -git. The crash occurs about 10 or 15 seconds after the GUI comes up. Booting with -no-kvm

Re: [kvm-devel] [RFC/PATCH 00/15 v3] kvm on big iron

2008-03-27 Thread Avi Kivity
Carsten Otte wrote: > Many thanks for the review feedback we have received so far, > and many thanks to Andrew for reviewing our common code memory > management changes. I do greatly appreciate that :-). > > All important parts have been reviewed, all review feedback has been > integrated in the co

Re: [kvm-devel] [PATCH 15/20] x86: move dma_supported and dma_set_mask to pci-dma_32.c

2008-03-27 Thread Ingo Molnar
* Mark McLoughlin <[EMAIL PROTECTED]> wrote: > This breaks for me with: > > ERROR: "dma_supported" [drivers/ssb/ssb.ko] undefined! > ERROR: "dma_set_mask" [drivers/scsi/qla2xxx/qla2xxx.ko] undefined! > ERROR: "dma_set_mask" [drivers/scsi/aic7xxx/aic7xxx.ko] undefined! > ERROR: "dma_set_mask" [dr

Re: [kvm-devel] [PATCH 2/3] [PATCH] unregister pci device

2008-03-27 Thread Avi Kivity
Glauber Costa wrote: > Avi Kivity wrote: >> Glauber Costa wrote: >>> If we fail after we have allocated the pci device, we have >>> to get rid of it. Otherwise, a bogus device will be found on >>> the bus >>> >> >> Maybe, alter the order so the device is registered last thing. This >> may help

Re: [kvm-devel] [PATCH 2/3] [PATCH] unregister pci device

2008-03-27 Thread Glauber Costa
Avi Kivity wrote: > Glauber Costa wrote: >> If we fail after we have allocated the pci device, we have >> to get rid of it. Otherwise, a bogus device will be found on >> the bus >> > > Maybe, alter the order so the device is registered last thing. This may > help avoid races with pci passthro

Re: [kvm-devel] [PATCH] ignore reads to the EOI register.

2008-03-27 Thread Maciej W. Rozycki
On Thu, 27 Mar 2008, Avi Kivity wrote: > Applied, but perhaps a patch to linux to avoid reads to write-only registers > is needed as well. Linux performs reads to all registers written including this one deliberately using an RMW cycle to avoid triggering an erratum in some early Pentium integ

Re: [kvm-devel] [PATCH 15/20] x86: move dma_supported and dma_set_mask to pci-dma_32.c

2008-03-27 Thread Mark McLoughlin
On Tue, 2008-03-25 at 18:36 -0300, Glauber Costa wrote: > This is the way x86_64 does, so this make them equal. They have > to be extern now in the header, and the extern definition is moved to > the common dma-mapping.h header > > Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> ... > diff --git

Re: [kvm-devel] virtual machines network goes 100Mbit when interface is Gbit

2008-03-27 Thread Victor Abeytua Garcia
Hello, I'm not sure if I understand you. Do you mean that the physical network cards should be e1000 or that the virtual machines must somehow emulate e1000 network cards? As I understand Miguel's post, he is finding an issue with the bridge's speed (two virtual machines running on the sam

Re: [kvm-devel] KVM Test result, kernel c0af88e.., userspace 0342df6..

2008-03-27 Thread Avi Kivity
Yunfeng Zhao wrote: > Hi Alll, > > This is today's KVM test result against kvm.git > c0af88e9014019f6392b06c11e836ca58acc7ede and kvm-userspace.git > 0342df67ec22f3d9aa663949b72694e061c2edb2. > > > 3. slab error in kmem_cache_destroy(): cache `kvm_vcpu': > https://sourceforge.net/tracker/?func=

Re: [kvm-devel] kvm causing memory corruption? ~2.6.25-rc6

2008-03-27 Thread Avi Kivity
Avi Kivity wrote: > Dave Hansen wrote: >> On Wed, 2008-03-26 at 18:58 +0200, Avi Kivity wrote: >> >>> Dave Hansen wrote: >>> On Wed, 2008-03-26 at 11:50 +0200, Avi Kivity wrote: > Dave Hansen wrote: > >> I was getting some kvm userspace crashes trying t

Re: [kvm-devel] [PATCH 0/20] dma_ops for i386

2008-03-27 Thread Amit Shah
* On Wednesday 26 March 2008 03:06:19 Glauber Costa wrote: > Hello, > > Here there is a series of 20 patches that lays the foundations for > using dma_ops in i386 in the very same way x86_64, as well as many other > architectures already do. Thanks; Please also see Stephen Tweedie's tree at http:

Re: [kvm-devel] kvm causing memory corruption? ~2.6.25-rc6

2008-03-27 Thread Avi Kivity
Dave Hansen wrote: > On Wed, 2008-03-26 at 18:58 +0200, Avi Kivity wrote: > >> Dave Hansen wrote: >> >>> On Wed, 2008-03-26 at 11:50 +0200, Avi Kivity wrote: >>> Dave Hansen wrote: > I was getting some kvm userspace crashes trying to run a Windows gue

Re: [kvm-devel] [PATCH] KVM: MMU: Fix rmap_remove() race

2008-03-27 Thread Avi Kivity
Andrea Arcangeli wrote: > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index 30bf832..a49987c 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -741,6 +741,10 @@ static struct vm_operations_struct kvm_vcpu_vm_ops = { > static int kvm_vcpu_mmap(struct file *file, struc

[kvm-devel] KVM Test result, kernel c0af88e.., userspace 0342df6..

2008-03-27 Thread Yunfeng Zhao
Hi Alll, This is today's KVM test result against kvm.git c0af88e9014019f6392b06c11e836ca58acc7ede and kvm-userspace.git 0342df67ec22f3d9aa663949b72694e061c2edb2. Issue list 1. Booting four guests likely fails https://sourceforge.net/tracker/?fu

Re: [kvm-devel] [PATCH v2] x86: don't allow KVM_CLOCK on Voyager or Visual WS

2008-03-27 Thread Avi Kivity
Randy Dunlap wrote: > From: Randy Dunlap <[EMAIL PROTECTED]> > > Prevent failed randconfig builds with KVM_CLOCK being enabled > on Voyager or VISWS. > > Applies, thanks. -- error compiling committee.c: too many arguments to function -

Re: [kvm-devel] [PATCH] ignore reads to the EOI register.

2008-03-27 Thread Avi Kivity
Glauber Costa wrote: > They seem legal in real hardware, even though the EOI > is a write-only register. By "legal" I mean they are completely > ignored, but at least, don't cause any bits to be set at ESR. > > Without this patch, some (very recent) linux git trees will fail > to boot in i386. > >

Re: [kvm-devel] [PATCH] KVM: MMU: Fix rmap_remove() race

2008-03-27 Thread Avi Kivity
Andrea Arcangeli wrote: > On Wed, Mar 26, 2008 at 08:22:31PM +0100, Andrea Arcangeli wrote: > >> what happens if invalidate_page runs after rmap_remove is returned >> (the spte isn't visible anymore by the rmap code and in turn by >> invalidate_page) but before the set_shadow_pte(nonpresent) run

Re: [kvm-devel] [PATCH] KVM: MMU: Fix rmap_remove() race

2008-03-27 Thread Avi Kivity
Andrea Arcangeli wrote: > Any tlb flush happening before clearing the shadow-pte entry is > totally useless. > > Doh! Well that's easy to fix, by moving the spte clear to rmap_remove(). -- error compiling committee.c: too many arguments to function -

Re: [kvm-devel] [PATCH 2/3] [PATCH] unregister pci device

2008-03-27 Thread Avi Kivity
Glauber Costa wrote: > If we fail after we have allocated the pci device, we have > to get rid of it. Otherwise, a bogus device will be found on > the bus > Maybe, alter the order so the device is registered last thing. This may help avoid races with pci passthrough hotplug. -- error compil

Re: [kvm-devel] [PATCH 1/3] [PATCH] passthrough

2008-03-27 Thread Avi Kivity
Glauber Costa wrote: > add -passthrough usage string > > Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> > --- > qemu/vl.c |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/qemu/vl.c b/qemu/vl.c > index f5b2665..d36cfe3 100644 > --- a/qemu/vl.c > +++ b/qemu/vl.c > @@ -